Author Topic: Additional Tagging & Reporting Tools  (Read 1154994 times)

boroda

  • Hero Member
  • *****
  • Posts: 5171
Version 9.2 Update 1 (9.2.9122)

* Huge code refactoring. Many UI/UX bug fixes related to ASR/MSR and Change Case

https://www.mediafire.com/file/h2t08o9562efboi/mb_TagTools_latest.zip/file

Full plugin package:

https://www.mediafire.com/file/dm3rhfze89n3qwi/Additional-Tagging-Tools-Plugin.zip/file

-------------------------

@all, please try the updated version, then report bugs again if any remained

Babydoll32

  • Full Member
  • ***
  • Posts: 180
Version 9.2 Update 1 (9.2.9122)
@all, please try the updated version, then report bugs again if any remained

Thanks for updating. But now, that's what I get, if I try to install asr presets

Code
MusicBee v3.6.9108.26223D  (Win10.0), 22 Dez 2024 10:01:

System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei MusicBeePlugin.AdvancedSearchAndReplace.checkFilters(Preset preset, String searchText)
   bei MusicBeePlugin.AdvancedSearchAndReplace.refreshPresetList(Guid selectedPresetGuid, Boolean resetFilters, Boolean fillOnlyChainedPresets)
   bei MusicBeePlugin.AdvancedSearchAndReplace.install(Boolean installAll)
   bei MusicBeePlugin.AdvancedSearchAndReplace.buttonInstallAll_Click(Object sender, EventArgs e)
   bei System.Windows.Forms.Control.OnClick(EventArgs e)
   bei System.Windows.Forms.Button.OnClick(EventArgs e)
   bei System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   bei System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   bei System.Windows.Forms.Control.WndProc(Message& m)
   bei System.Windows.Forms.ButtonBase.WndProc(Message& m)
   bei System.Windows.Forms.Button.WndProc(Message& m)
   bei System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   bei System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   bei System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

boroda

  • Hero Member
  • *****
  • Posts: 5171

Dizza17

  • Full Member
  • ***
  • Posts: 186
@ boroda,
Using the latest version of the plugin, when selecting a saved MSR preset this error occurs.

MusicBee v3.6.9121.23098P  (Win10.0), 23 Dec 2024 0:03:

System.InvalidCastException: Unable to cast object of type 'System.String' to type 'Preset'.
   at MusicBeePlugin.MultipleSearchAndReplace.loadComboBox_SelectedIndexChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ComboBox.OnSelectedIndexChanged(EventArgs e)
   at System.Windows.Forms.ComboBox.WmReflectCommand(Message& m)
   at System.Windows.Forms.ComboBox.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
When the rich wage war, it’s the poor who suffer.

Babydoll32

  • Full Member
  • ***
  • Posts: 180
thanks for critical bug report. actually, there were much more bugs of this kind.

--------------------

Version 9.2 Update 2 (9.2.9122)

https://www.mediafire.com/file/h2t08o9562efboi/mb_TagTools_latest.zip/file

Full plugin package:

https://www.mediafire.com/file/dm3rhfze89n3qwi/Additional-Tagging-Tools-Plugin.zip/file

We have to thank you for the development. Installing the presets works up to the point of saving. Then the following error message appears:
Code
MusicBee v3.6.9108.26223D  (Win10.0), 22 Dez 2024 17:23:

System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei MusicBeePlugin.AdvancedSearchAndReplace.saveSettings()
   bei MusicBeePlugin.AdvancedSearchAndReplace.buttonSaveClose_Click(Object sender, EventArgs e)
   bei System.Windows.Forms.Control.OnClick(EventArgs e)
   bei System.Windows.Forms.Button.OnClick(EventArgs e)
   bei System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   bei System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   bei System.Windows.Forms.Control.WndProc(Message& m)
   bei System.Windows.Forms.ButtonBase.WndProc(Message& m)
   bei System.Windows.Forms.Button.WndProc(Message& m)
   bei System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   bei System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   bei System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

If it's interesting, I'm using WIN 11.



Babydoll32

  • Full Member
  • ***
  • Posts: 180

boroda

  • Hero Member
  • *****
  • Posts: 5171
it can't be the same error and i'm not able to reproduce any exceptions on saving ASR presets, though now i've made the correct fix instead of workaround:

Version 9.2 Update 4 (9.2.9126)

https://www.mediafire.com/file/h2t08o9562efboi/mb_TagTools_latest.zip/file

Full plugin package:

https://www.mediafire.com/file/dm3rhfze89n3qwi/Additional-Tagging-Tools-Plugin.zip/file

Babydoll32

  • Full Member
  • ***
  • Posts: 180
it can't be the same error and i'm not able to reproduce any exceptions on saving ASR presets, though now i've made the correct fix instead of workaround:

Version 9.2 Update 4 (9.2.9126)

https://www.mediafire.com/file/h2t08o9562efboi/mb_TagTools_latest.zip/file

Full plugin package:

https://www.mediafire.com/file/dm3rhfze89n3qwi/Additional-Tagging-Tools-Plugin.zip/file

The good news. Installing of presets work fine again, but it still has a problem with the error message of auto execution and still counts to negative, everytime the message pops up. The box before preset showed a check, first time I select, later it‘s showed unchecked.
And when opening „Advanced search & replace“, message below pops up and every action (e.g. typing in filter, selecting preset) message pops up again.


boroda

  • Hero Member
  • *****
  • Posts: 5171

Babydoll32

  • Full Member
  • ***
  • Posts: 180
very stupid bug. maybe i have been drunk when i wrote these 2 lines of code to check real preset chain  ;D

Version 9.2 Update 5 (9.2.9126)

https://www.mediafire.com/file/h2t08o9562efboi/mb_TagTools_latest.zip/file

Full plugin package:

https://www.mediafire.com/file/dm3rhfze89n3qwi/Additional-Tagging-Tools-Plugin.zip/file

First of all, I can say with a fair amount of certainty that you code better drunk than I do sober. 😂
And bad times are the best times to be drunk. 🤷🏻‍♂️
Unfortunately, the error message still appears.

Dizza17

  • Full Member
  • ***
  • Posts: 186
@Boroda

When selecting a saved preset in MSR, the error messege in the screnshot appears and it takes 5-6 clicks for it to be resolved and load the presets functions. using the latest version of the plugin & Musicbee.

cheer's Aaron
https://imgur.com/a/EHd0Jfg
When the rich wage war, it’s the poor who suffer.

boroda

  • Hero Member
  • *****
  • Posts: 5171
@Dizza, i can't reproduce this exception. i've suppressed this error message, but only suppressing it may be insufficient. try the new version and report if it's working now as expected.

https://www.mediafire.com/file/h2t08o9562efboi/mb_TagTools_latest.zip/file

Dizza17

  • Full Member
  • ***
  • Posts: 186
@boroda,
just a small but easily fixed bug, ASR preset " add up to one zero to a group of digits in <tag 1>" currently adds "${text}" before the zero when using this preset. it works as expected if you remove this from the replace parameter's. Just something you might want to tidy up for the next update release. see attached screenshots for reference.

https://imgur.com/a/BzWVX3E

kind regards
Diz
When the rich wage war, it’s the poor who suffer.