LyricsReloaded (Latest)

[phred]

Thanks for the explanations on both of my comments.

[sveakul]

Thanks Mayibongwe for LR 1.2.2!  I'm glad my "detective work" helped in locating the source of the hangs.

FYI:  while cycling through lyric sources during a playing stream, I noticed a hit come up with no source label at the top despite the option to display this enabled and all the other retrievals obeying it.  A right-click on the panel showed the lyrics source as "LYRICSOVH.COM"--yes similar name to your own "Lyrics.ovh" (Lyrics_ovh.yml) and probably the same source, but with no YML file.  I can only surmise that its existence comes from Steven baking it into the code as he did with a few others in the past.  Just thought I'd mention it in case people who saw it come up would think the LR option was at fault.

BTW, if it IS the same source as your Lyrics_ovh.yml, it found lyrics that the latter did not!  E.g., song Diamond Jigsaw by Underworld.  When I checked the log, it showed that Lyrics_ovh.yml failed to load its config, which would explain the no results;  here is what the log shows:

07/07/2024 12:11:11 [DEBUG] Loading config from file: C:\MusicBee\AppData\mb_LyricsReloaded\providers\Lyrics_ovh.yml
07/07/2024 12:11:11 [ERROR] Failed to load a configuration:
07/07/2024 12:11:11 [ERROR] (Lin: 8, Col: 0, Chr: 122) - (Lin: 8, Col: 0, Chr: 122): While scanning a simple key, could not find expected ':'.
07/07/2024 12:11:11 [ERROR] YamlDotNet.Core.SyntaxErrorException: (Lin: 8, Col: 0, Chr: 122) - (Lin: 8, Col: 0, Chr: 122): While scanning a simple key, could not find expected ':'.
   at YamlDotNet.Core.Scanner.StaleSimpleKeys()
   at YamlDotNet.Core.Scanner.FetchMoreTokens()
   at YamlDotNet.Core.Scanner.InternalMoveNext()
   at YamlDotNet.Core.Parser.GetCurrentToken()
   at YamlDotNet.Core.Parser.ParseBlockMappingValue()
   at YamlDotNet.Core.Parser.StateMachine()
   at YamlDotNet.Core.Parser.MoveNext()
   at YamlDotNet.Core.EventReader.Allow[T]()
   at YamlDotNet.Core.EventReader.Expect[T]()
   at YamlDotNet.RepresentationModel.YamlScalarNode..ctor(EventReader events, DocumentLoadingState state)
   at YamlDotNet.RepresentationModel.YamlNode.ParseNode(EventReader events, DocumentLoadingState state)
   at YamlDotNet.RepresentationModel.YamlMappingNode..ctor(EventReader events, DocumentLoadingState state)
   at YamlDotNet.RepresentationModel.YamlNode.ParseNode(EventReader events, DocumentLoadingState state)
   at YamlDotNet.RepresentationModel.YamlDocument..ctor(EventReader events)
   at YamlDotNet.RepresentationModel.YamlStream.Load(TextReader input)
   at CubeIsland.LyricsReloaded.Provider.ProviderManager.loadProvider(TextReader configReader)

[Mayibongwe]

When I checked the log, it showed that Lyrics_ovh.yml failed to load its config, which would explain the no results;  here is what the log shows:

I probably messed up something when adding it to the providers.zip
I posted the yml for it a while back (which I only remembered to copy and dump on to the zip today).
So can you check if it works when you load it yourself from here: https://getmusicbee.com/forum/index.php?topic=36952.msg224134#msg224134

[sveakul]

Lyrics_ovh.yml from the latest Providers.zip and the YML posted a while back you linked to have exacty the same code.

I just deleted it and checked on the list the hard-coded one that does work, "lyricsovh.com" (has no YML file).  Has to be the same source.

[phred]

A right-click on the panel showed the lyrics source as "LYRICSOVH.COM"--yes similar name to your own "Lyrics.ovh" (Lyrics_ovh.yml) and probably the same source, but with no YML filw.

I right-click on the lyrics panel and it does not show the source, but it shows "Lyrics Source: Embedded in Music File". Shouldn't it be showing the source?

[sveakul]

A right-click on the panel showed the lyrics source as "LYRICSOVH.COM"--yes similar name to your own "Lyrics.ovh" (Lyrics_ovh.yml) and probably the same source, but with no YML filw.

I right-click on the lyrics panel and it does not show the source, but it shows "Lyrics Source: Embedded in Music File". Shouldn't it be showing the source?

If the lyrics are embedded in the file, that IS the source of their display--the file itself.  From where they were obtained when originally entered into the file tag is not kept.

[sveakul]

After looking inside MusicBee.exe with Notepad++, amid the binary jumble was able to find text confirmation of two hard-coded lyrics sources that are still selectable on the list:  "Chartlyrics" and "Lyricsovh," both of which still work but return hits that do not have the source on top, although if you right-click the panel you will see it indicated on the first line of the context menu.  Also hard coded but removed as functioning sources are Gracenote and Minilyrics.

The Chartlyrics occasionally returns wildly inaccurate lyrics, no doubt due to an ages-old search strategy;  I did see Lyricsovh make a correct return today, but never noticed it was active until now.

Anyway, for people who like to "know things."

[phred]

If the lyrics are embedded in the file, that IS the source of their display--the file itself.  From where they were obtained when originally entered into the file tag is not kept.

Ahhh ... I was mistaken as to what it should be showing. But the -original- source -is- displayed at the top of the retrieved lyrics. Which is what I expected to see when right-clicking lyrics that -didn't- have a source displayed.

Thanks.

[sveakul]

If the lyrics are embedded in the file, that IS the source of their display--the file itself.  From where they were obtained when originally entered into the file tag is not kept.

Ahhh ... I was mistaken as to what it should be showing. But the -original- source -is- displayed at the top of the retrieved lyrics. Which is what I expected to see when right-clicking lyrics that -didn't- have a source displayed.

Thanks.

The "-original- source -is- displayed at the top of the retrieved lyrics" is only in the case when you do the original retrieval via the plugin for a file that never HAD any lyrics.  Once the lyrics are embedded (if you've chosen that), they are considered "added and tagged", and then the source of display IS the file tag.  This all makes sense to me, but we all have our own perspective.

As far as encountering "un-titled" retrievals from the two "hidden" MB sources, Chartlyrics and lyricsovh, right clicking the results WILL show those as "Lyrics source" at the top of the context results.  This is assuming you already have the show source options activated in the "normal" LyriscReloaded and slonopot plugins, which will show the source without needing to right-click anything.  If you actually embed the retrieval from those two sources into your files, the panel source will change to "Embedded in music file" like all the rest.

[phred]

Thanks for the clarification, sveakul.

[sveakul]

Mayibongwe:  please see this thread (bug in MBLR since 1.2.1.0):
https://getmusicbee.com/forum/index.php?topic=41448.0

[sveakul]

Mayibongwe:  while you're doing the re-write to fix the _source.log issue, could you take a look at the built-in "Deezer" source script?  I think it hasn't been functioning for a while.  Thanks.

[phred]

... could you take a look at the built-in "Deezer" source script?  I think it hasn't been functioning for a while.  Thanks.

Yes, I agree. Deezer used to be the provider that returned the most lyrics, but looking back over the past couple of weeks, I see that it hasn't retrieved any.

Thanks.

[Mayibongwe]

I acknowledge the current disfunctional status of the deezer.yml.
They look to have changed the structure of their website where it's now, for the most-part, dynamically generated.
I cannot see the lyrics in plain text (i.e. viewing the static source, where in Chrome, that's through CTRL + U)
I can only see the lyrics when I 'inspect the source' in real time (but for now, i can't see how I'd do that with the plugin).

So i thought to remove Deezer and reintroduce the google.yml which would serve as a direct replacement (since they both retrieve their content from LyricsFind).
But I now realise the google.yml may not have been working for some time either.

I will take a closer look at fixing google.

_______

The latest version up for download has the _sourceLog data file removed.

[sveakul]

Good luck with the Google repair;  sounds like Deezer shut its doors pretty tight this time.

BTW,  the version number of LR should be updated to 1.2.3 on the Plugins download page.