my mind is made up on this point. Just to be clear it only applies to the text search. Using middle mouse button click or Ctrl-F custom query opens the search results in a new tab
You sound like you're done with improving this feature. Then I leave the following responses just for the record.
Current implementation of searching within a pinned tab is anything but consistency and user-friendliness. Here's why.
- Whether to open in the same tab or in a new tab should depend on whether the content is confined in the same node or not. That's why clicking on another node within a pinned tab opens a new tab and moves focus to there.
- Then the same should be applied to search actions too. Middle mouse click search is working globally, so it's consistent to open the search results in a new tab. What about custom search? If that's local then in the same tab, If global then in a new tab. But currently local custom search results show in a new tab whereas local text search results (consistently) display in the same tab. Why?
- Doing a global search (both text and custom) in a pinned tab is a real pain since it's disabled. You need to open a new tab and search there, but that tab is set to local search (because you're opening a new tab from a local search set tab) so you have to first change the setting to global search. After done, close the tab and return to the original tab. Now I'm not sure it's worth it to pin tabs as I'm doing global search a lot.