Author Topic: Looking for Element(s)  (Read 9336 times)

phred

  • Global Moderator
  • Sr. Member
  • *****
  • Posts: 9366
Is it possible to change the highlight fg in these two areas of the Tag Editor?  And if so, what element controls it?  I can't seem to track it down.  Thanks.
EDIT:  I found Controls.TabHeader.Highlight for the tabs.  Now I just need the element for the highlight in the line above it (menu bar?)

Last Edit: January 04, 2016, 09:54:13 PM by phred
Download the latest MusicBee v3.5 or 3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Posting screenshots is here
Searching the forum with Google is  here

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
the highlight is controlled by
<element id="Menu.CommandButton.Selected" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
MusicBee and my library - Making bee-utiful music together

phred

  • Global Moderator
  • Sr. Member
  • *****
  • Posts: 9366
the highlight is controlled by
<element id="Menu.CommandButton.Selected" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
Thanks very much Bee-liever, but it doesn't work.  The selected bg and bdr change, but not the fg. 
Download the latest MusicBee v3.5 or 3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Posting screenshots is here
Searching the forum with Google is  here

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
If just the ordinary text - not highlight - you can use
<element id="Menu.CommandButton.Default" fg="xxx,xxx,xxx" />

or the override
<element id="Toolbar.MenuTextOverride" fg="xxx,xxx,xxx" />
MusicBee and my library - Making bee-utiful music together

phred

  • Global Moderator
  • Sr. Member
  • *****
  • Posts: 9366
If just the ordinary text - not highlight - you can use
<element id="Menu.CommandButton.Default" fg="xxx,xxx,xxx" />

or the override
<element id="Toolbar.MenuTextOverride" fg="xxx,xxx,xxx" />
Again, thanks, but neither helps me accomplish what I'm trying to do.  Which is to have the selected menu item show the text (fg) in white.  I can do it in the main window's menu bar. I can get the tabs in the tag editor to do it.  But I can't get it to happen in the Tag Editor's menu bar.

@Steven - are we looking in the wrong place or is this system controlled?  Bee-liever's suggestion to use Toolbar.MenuTextOverride only overrides the default fg.  I'm looking for the highlight (selected) fg.
Download the latest MusicBee v3.5 or 3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Posting screenshots is here
Searching the forum with Google is  here

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
Again, thanks, but neither helps me accomplish what I'm trying to do.  Which is to have the selected menu item show the text (fg) in white.

are using both
<element id="Menu.CommandButton.Default" fg="xxx,xxx,xxx" />
<element id="Menu.CommandButton.Selected" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />

'cause they don't work properly unless paired.
MusicBee and my library - Making bee-utiful music together

phred

  • Global Moderator
  • Sr. Member
  • *****
  • Posts: 9366
Again, thanks, but neither helps me accomplish what I'm trying to do.  Which is to have the selected menu item show the text (fg) in white.

are using both
<element id="Menu.CommandButton.Default" fg="xxx,xxx,xxx" />
<element id="Menu.CommandButton.Selected" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />

'cause they don't work properly unless paired.
This is what I'm using:
<element id="Menu.CommandButton.Default" fg="30,57,91" />
<element id="Menu.CommandButton.Selected" bg="106,150,228" fg="255,255,255" />
Download the latest MusicBee v3.5 or 3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Posting screenshots is here
Searching the forum with Google is  here

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
substituted into "Bleached Bone" skin and works pefectly.

Do you have those elements after all the id="Controls. elements?
MusicBee and my library - Making bee-utiful music together

phred

  • Global Moderator
  • Sr. Member
  • *****
  • Posts: 9366
substituted into "Bleached Bone" skin and works pefectly.

Do you have those elements after all the id="Controls. elements?
No, I don't.  All the id=Controls. elements are in lines 105-167 and my two lines are 24 and 25.
Do you think moving them to the Controls section would help?
If you'd like to look at the full xml, it's here:
http://www.mediafire.com/download/h8uvvosdhn5himf/Phred+on+the+Lookout.xml

I'll work on this a little more tomorrow, which if I remember correctly, is already today for you. 

Thanks.
Download the latest MusicBee v3.5 or 3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Posting screenshots is here
Searching the forum with Google is  here

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
You can't put the .xml in semi-alphabetical sequence as it causes problems like you're experiencing, where overrides don't work and you get colour aberrations in your skin.

The sequence is basically
Menu Bar
Main Panel Headers (including tabs)
Left Panel
Right Panel
Library Panels
Players
Preferences/Pop-Up Panels
Overrides

Check out some of the earlier skins, especially lnminente's work, or psychoadept's Mellon Remix skin for good examples of the xml broken into sections.
MusicBee and my library - Making bee-utiful music together

hiccup

  • Sr. Member
  • ****
  • Posts: 7908
The skin.xml that was used as a basis came from me, and I can pretty much vouch that the order of all elements is functioning correctly.

Hopefully I am not adding to any confusion, but if from the skin you uploaded, all you change is to disable (or remove) "Toolbar.MenuTextOverride", isn't that what you are trying to achieve?

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
disable (or remove) "Toolbar.MenuTextOverride"

Yep. That's all that was needed.

I do still stand by my statement of keeping the skin xml in that sequence.
psychoadept and I had quite a bit of trouble with the Mellon Remix /Scamelon skins when I deviated from that pattern with the original base skin.
MusicBee and my library - Making bee-utiful music together

hiccup

  • Sr. Member
  • ****
  • Posts: 7908
disable (or remove) "Toolbar.MenuTextOverride"
Yep. That's all that was needed.

I do still stand by my statement of keeping the skin xml in that sequence.
psychoadept and I had quite a bit of trouble with the Mellon Remix /Scamelon skins when I deviated from that pattern with the original base skin.

I wasn't arguing that the order of the elements is unimportant.
On the contrary, I also spend tons of times in the past figuring out why some elements sometimes wouldn't work.
I was just saying that in my skins the order of elements is checked and working. (not betting arms and legs on it though)

I don't believe there is such thing as an official base skin.
Several skinners found an order and structure they liked and that worked for them, and then build up from there.

But it's very good that you mentioned this matter.
This probably might stay relevant when adding new elements to existing xml's.
It could probably have consequences if if you insert them in a 'wrong' position in the xml.

Bee-liever

  • Member
  • Sr. Member
  • *****
  • Posts: 3840
  • MB Version: 3.6.8878 P
I don't believe there is such thing as an official base skin.

I don't think there is one anymore either, but when I was having troubles with that Scamelon skin,  I found a MusicBee Default.xml from 2010 that was laid out with that basic structure.

I think you're right in that other skinners have since tried to standardise the base skin with headings and line numbers.

But enough of this off-topic chatter,  "we doth digress to much" :)
MusicBee and my library - Making bee-utiful music together

hiccup

  • Sr. Member
  • ****
  • Posts: 7908
But enough of this off-topic chatter,  "we doth digress to much" :)

I don't think it's off-topic. (much)
You raised good points which will give other new-to-the-game skinners finding this topic some insights I wished I had in the beginning.