Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 329830 times)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Meanwhile, is it intended that the Now Playing List (and Column Browser) overrides no longer work?
Also the "search" placeholder text in the search box no longer uses the skin color.
the column browser should apply the filter panel override for the next update. The last update should have correctly set the "search" text which should have only not applied the override when in the caption bar.
However i am not sure for the Now Playing list what override you are refering to, Can you give me an example of a skin where this override is being used and do you know the element name? (I have looked in the code and cant find anything but it might be done in a non-obvious way for me to find easily)
edit:
found the Now Playing list. I will include it in the next update
Last Edit: December 02, 2015, 07:54:22 PM by Steven

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Thank you. now working even when using the pop-up volume.
But, can you tell me where the volume indicator is drawing its colour from?
It shows in some skins, but not others.
PlayerMini.Control.Default
but if that or the PlayerMini.Background element is not defined, then the colors are retrieved from the sidebar player

Thanks for that, but when I said it was working, I got it a little bit wrong.  :o

When the mini player is small enough to have to use the pop-up volume, everything now shows on top of the player - except the volume slider button.

Oh, and were you aware that you can't re-size the mini player from the LH side?
MusicBee and my library - Making bee-utiful music together

phred

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10279
Meanwhile, is it intended that the Now Playing List (and Column Browser) overrides no longer work?
Also the "search" placeholder text in the search box no longer uses the skin color.
the column browser should apply the filter panel override for the next update. The last update should have correctly set the "search" text which should have only not applied the override when in the caption bar.
However i am not sure for the Now Playing list what override you are refering to, Can you give me an example of a skin where this override is being used and do you know the element name? (I have looked in the code and cant find anything but it might be done in a non-obvious way for me to find easily)
edit:
found the Now Playing list. I will include it in the next update
I'm not sure if this relates to psychoadept's comment and Steven's fix.  And understand that my comment is coming from the standpoint of I really don't know what I'm doing when working with skins.  If ever there was a trial and error guy, that's me.  I've taken hiccup's Jistme on the Outlook skin (xml) and have been trying to add alternating bars of color in the Track Details view of the Main Panel.  For whatever reason, the bars are extending to the Column Browser.  And what I'd like in the Column browser is just a background color without the bars. 

I'm getting close, but I'm finding that v3 exhibits different results than v2.5.
This is 2.5:


And this is 3.x:


In the 2.5 version note the blank space under "2014" and under "A-Z."  And in the 3.x version there are bars in those spaces.  This is the same skin that shows differently in the two versions of MB.

So as an aside, what element do I need to change in order to have a plain solid background in the Column Browser? At this point I'd be very content to have it working as I want in 2.5.
Download the latest MusicBee v3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Custom Forum Search
Posting screenshots is here

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
the change was intentional so rows are rendered in a consistent manner with the main panel. I dont have a strong opinion about that so if people dont like it then it should be easy to change

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
I'd like to be able to put a border here, connected to the tab border (in other words, I'd like to have one both above and below panel.childheader.default):


thats done for the next update as:
TabsBar.TabInCaptionBar.BorderLine bdr="xxx"

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
thats done for the next update as:
TabsBar.TabInCaptionBar.BorderLine bdr="xxx"

Is it just me or does the border line look strange that it doesn't run under the inactive tabs?
MusicBee and my library - Making bee-utiful music together

Sofocl

  • Sr. Member
  • ****
  • Posts: 305
Steven will be Back the opportunity highlight?:
V 2.5


Request.
To make the highlight color is dependent on Skin:
Aimp 4
Sorry for my bad English.

phred

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10279
changes as described above:
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe
This update has fixed the erroneous left-hand close button I reported.  Thanks.
Last Edit: December 03, 2015, 01:57:34 PM by phred
Download the latest MusicBee v3.6 patch from here.
Unzip into your MusicBee directory and overwrite existing files.

----------
The FAQ
The Wiki
Custom Forum Search
Posting screenshots is here

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Steven will be Back the opportunity highlight?:
V 2.5

i dont understand what you want or how the picture relates to the question

for the 2nd part, skin developers already have control over the colours for file selection
Last Edit: December 03, 2015, 06:32:51 PM by Steven

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Is it just me or does the border line look strange that it doesn't run under the inactive tabs?
i have changed it so the line is drawn under inactive tabs as well so its consistent with when tabs are not docked in the caption bar

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Is it just me or does the border line look strange that it doesn't run under the inactive tabs?
i have changed it so the line is drawn under inactive tabs as well so its consistent with when tabs are not docked in the caption bar

Thanks for doing that.  I think it will look better that way.
MusicBee and my library - Making bee-utiful music together

Sofocl

  • Sr. Member
  • ****
  • Posts: 305
i dont understand what you want or how the picture relates to the question

for the 2nd part, skin developers already have control over the colours for file selection
Sorry. I meant the selection frame:


In version 3 there is no selection frame:


This has already been reported:
I am unable to make a selection of tracks in any panel by dragging a rectangle over them with my mouse.

To clarify what I mean, selecting like this,



for the 2nd part, skin developers already have control over the colours for file selection
I meant the control over the colours for "selection frame".
Sorry for my bad English.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
yes i did implement that in v3 and was enabled in the early builds. But i really hated that feature and its mostly disabled, except it is still possible in the track details layout by selecting using the very left status column

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
While re-sizing compact player:

do you still get the visual artifacts? the resized area should stay entirly black while resizing is being done

edit:
no need to answer - i can sort of reproduce this still
Last Edit: December 03, 2015, 10:23:18 PM by Steven