Skin- and visual errors related to, and skinning requests for MusicBee v3

[hiccup]

EDIT:
also, if you don't want the top border to match the panel border, you can override it with:
<element id="MainPanelTopBorderColour" bdr="54,62,69" />

I believe that is this line, but that is not related to the issue I am raising? Or am I missing something?

[Bee-liever]

That entry is present and enabled.
(Otherwise it also wouldn't show up in 2.5 would it?)

Just had a look at your updated skin in 3.0 and there is a faint divider line (colour:2,13,12) between the column browser columns.

EDIT:
also, if you don't want the top border to match the panel border, you can override it with:
<element id="MainPanelTopBorderColour" bdr="54,62,69" />

I believe that is this line, but that is not related to the issue I am raising? Or am I missing something?

so if you wanted that red line under the tabs but wanted the divider border to stay "2,13,12", you would need:

<element id="MainPanelTopBorder">true</element>
<element id="Panel.Body.Default" bg="16,19,16" fg="127,132,133" bdr="2,13,12"/>
<element id="MainPanelTopBorderColour" bdr="255,0,0" />

otherwise the red border would also be "2,13,12"

[hiccup]

Just had a look at your updated skin in 3.0 and there is a faint divider line (colour:2,13,12) between the column browser columns.

You have the eyes of a hawk ;-)

So v3 draws the color for that element from a different entry than 2.x did.
Some investigating to do....

[Bee-liever]

You have the eyes of a hawk ;-)

no, just a good colour-picker app that has a magnifying viewer 

also see my edited post above.

[hiccup]

so if you wanted that red line under the tabs but wanted the divider border to stay "2,13,12", you would need:
<element id="MainPanelTopBorder">true</element>
<element id="Panel.Body.Default" bg="16,19,16" fg="127,132,133" bdr="2,13,12"/>
<element id="MainPanelTopBorderColour" bdr="255,0,0" />
otherwise the red border would also be "2,13,12"

I believe the horizontal line you are bringing up is not really related to this issue.
The exact same xml is acting differently in v2 vs v3 for these vertical dividers.

The issue is that in v2 these dividers in the column browser draw their color from:
<element id="Content[TrackDetail].Body.Default"  bdr=  />

but in v3 it now draws its color from:
<element id="Panel.Body.Default"   bdr=  />

If I change that value to the color I want for the vertical dividers for v3, as it looks in v2, all panel borders change to that color, which looks bad for this skin.
(and for most skins I presume)
All body panels then get 'compartmentalized'.

[Steven]

i recommend you dont go changing things until i have had a chance to investigate. There will be some things which are not intentional that i wont have noticed because of the skin i predominately use

[Steven]

"TabsBar.Background" is an existing element thats the one used for the tabs background. I had made a change in v3 to use the border component to draw a line across the tabs bar. However testing this against a number of skins has poor results eg. red border line for some skins

So instead a i will add a new element in case you already made use of this - it will be: "TabsBar.BorderLine" bdr=XXXX

@hiccup, i have corrected the column browser and also a few other items such as the section headers in the left navigator, expander icon colours in the same panel and the thumbnail browser color override used by other skins.
I will post an updated version later

[Bee-liever]

I have corrected the column browser and also a few other items...

would that include making v3 follow the existing protocol of
<element id="MainPanelTopBorder">true/false</element>
turns the "bdr" attribute of
<element id="Panel.Body.Default" bg="xxxx" fg="xxxx" bdr="xxxx"/>
on/off?

my mistake  -  it doesn't.  wrong info in the colourfinder dummy skin

[Steven]

fixes for the above

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe

[hiccup]

fixes for the above

Thnx, looking good. The new element is also very nice.

A question: With v2 I could have vertical separators (A). But now with this v3 also some horizontal lines B and C show up with that color.
Is that avoidable in some manner?
Also thinking about other skins, it certainly would be good to have the option for a new dedicated element for C.

[hiccup]

I am editing a bitmapped skin with not much fancy stuff going on. The player control buttons are to be drawn by MusicBee itself.
In v2 they are nicely in place, but with exactly the same skin xmlc, in v3 the previous and next buttons don't line up horizontally.

Is it me doing something wrong, or is it MB v3?

Code

<element id="PrevTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-122" />
  <top relativeTo="Panel.VerticalCenter" offset="5" />
  <!-- musicbee draws the |<< icon in the centre of this image. The colours for the musicbee drawn icon are determined from the skin file -->
  <images drawPlayButton="true"
    default="Images\ButtonSmall.png"
    highlight="Images\ButtonSmallHighlight.png"
  />
</element>


<element id="NextTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-49" />
  <top relativeTo="Panel.VerticalCenter" offset="5" />
  <!-- musicbee draws the >>| icon in the centre of this image if drawPlayButton="True" -->
  <images drawPlayButton="true"
    default="Images\ButtonSmall.png"
    highlight="Images\ButtonSmallHighlight.png"
  />
</element>

[Sofocl]

A couple of versions ago, MB can be closed simply by moving the cursor to the upper right corner, now need to aim at the close button (This is very uncomfortable). This new behavior, or it can be changed at the level of the skin?

[Alumni]

A couple of versions ago, MB can be closed simply by moving the cursor to the upper right corner, now need to aim at the close button (This is very uncomfortable). This new behavior, or it can be changed at the level of the skin?

Not sure what you mean - I've always been able to click those buttons easily, even without carefully aiming.

[Sofocl]

Not sure what you mean - I've always been able to click those buttons easily, even without carefully aiming.

The latest versions of Steven obviously added a few pixels above the buttons (such behavior has already been to the menu button in v3, is also inconvenient).

V3                                                                               V2.5
               

[Alumni]

This might not be worth mentioning, but on my Windows 7 PC I noticed when the right sidebar is disabled, the main panel header bar extends all the way to the outermost border, which creates a gap in the bitmap window border.