Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 329870 times)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
while testing some of the older skins, i realised MB3 is setting an override by default that it shouldnt - you would see it on the browse back/forward buttons if you are using the default buttons). I have corrected that but there is a small chance it affects your skin if you used the defaults (I checked a number of the new skins and they were all fine)

use these elements if your skin is affected:
<element id="Panel.HeaderButtonOverride.Default" fg="225,5,5" />
<element id="Panel.HeaderButtonOverride.Disabled" fg="190,10,10" />

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10940
This is pretty minor, but I noticed that the window buttons for minimize, restore, and close are all stationary on highlight, but the maximize button shifts up very slightly.  I double checked that there wasn't anything different about my images except the background color.




Also, this button loses its color once you move your mouse over the menu:



One more thing, maybe not directly skin related but I noticed it because you can see the edge of the icons on this skin.  The edge is cut off when you tick or untick a track in the "tickmark" column.  (I had unticked the ones with the egde cut off here - all the rest were already unticked.)


Last Edit: April 04, 2016, 09:12:05 PM by psychoadept
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest patches
(Unzip and overwrite existing program files)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
This is pretty minor, but I noticed that the window buttons for minimize, restore, and close are all stationary on highlight, but the maximize button shifts up very slightly.  I double checked that there wasn't anything different about my images except the background color.
are they all 15px high and 96 dpi?

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10940
This is pretty minor, but I noticed that the window buttons for minimize, restore, and close are all stationary on highlight, but the maximize button shifts up very slightly.  I double checked that there wasn't anything different about my images except the background color.
are they all 15px high and 96 dpi?

I thought so, but it turns out GIMP was resetting them to 72 dpi on export.  I've fixed that now, and it seems to be fine.  Thanks.
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest patches
(Unzip and overwrite existing program files)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
for the 2nd issue, you need to set:
Menu.ParentItem.Pressed
for the 3rd, i have fixed that for the next update

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10940
Awesome, thanks.  :) 

meanwhile, I've discovered that if you put playing tracks in the main panel, it keeps its skin settings at first, but as soon as you restart mb, it takes the main panel settings instead.

And artists view is getting it's scroll bar colors from somewhere different than track detail.  In Mellon remix, they turn green & purple like column browser and some sidebar panels.

Maybe for a future version, could we have the window button highlight cover the whole height of the caption bar, like native Windows 10?
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest patches
(Unzip and overwrite existing program files)

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10940
And artists view is getting it's scroll bar colors from somewhere different than track detail.  In Mellon remix, they turn green & purple like column browser and some sidebar panels.
I finally had a chance to test it out: this is caused by the Panel.ChildBody.ScrollBar... elements, and affects both Artists and Album Covers views.


for the 2nd issue, you need to set:
Menu.ParentItem.Pressed
Actually, I have this set:

  <element id="Menu.ParentItem.Pressed" bg="82,83,176" fg="255,255,255" bdr="27,160,225" />

I tried moving it to the top, but that didn't help.
Last Edit: April 05, 2016, 04:26:32 AM by psychoadept
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest patches
(Unzip and overwrite existing program files)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990

endeavour1934

  • Full Member
  • ***
  • Posts: 207
Is <element id="MiniPlayerLastFmNotLove"> not working or have I missed an override?

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?

endeavour1934

  • Full Member
  • ***
  • Posts: 207
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
No, the problem is it's using the default shape icon for Not Loved, and my custom shape & color icon for Loved.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
No, the problem is it's using the default shape icon for Not Loved, and my custom shape & color icon for Loved.
could you PM me a link to the skin so i can check what is going on

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
meanwhile, I've discovered that if you put playing tracks in the main panel, it keeps its skin settings at first, but as soon as you restart mb, it takes the main panel settings instead.
that was intentional that the override colours didnt apply when docked in the main panel (if poorly implemented) but i have changed it so the override colours are always used

And artists view is getting it's scroll bar colors from somewhere different than track detail.  In Mellon remix, they turn green & purple like column browser and some sidebar panels.
i have changed the default to come from the Panel rather than ChildPanel so it should work as you expect without adjustment. Keep in mind there are also overrides available:
Content[Artwork].ScrollBarThumb
Content[Artwork].ScrollBarBackground
Content[Artwork].ScrollBar
Content[Artwork].ScrollBar.Lowlight


for the menu pressed element, its working fine for me using your WIP skin

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
@endeavour1934, dont worry - i found the issue and it will be fixed for the next update

endeavour1934

  • Full Member
  • ***
  • Posts: 207
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
No, the problem is it's using the default shape icon for Not Loved, and my custom shape & color icon for Loved.
could you PM me a link to the skin so i can check what is going on
Sent. Right now I have...

LastFmLove (Panels. Uses shape and color)
LastFmLoveSelected
LastFmLoveBright
LastFmNotLove

PlayerLastFmLove (Player, Compact Player. Uses shape and color)
PlayerLastFmLoveBright
PlayerLastFmNotLove

MiniPlayerLastFmLove (Miniplayer. Uses shape and color)
MiniPlayerLastFmNotLove
MiniPlayerLastFmLoveBright

that's a lot of icons and I know some of them are not used. And some are only used for the shape, not the color. Anyone knows exactly which ones are used and where?
Last Edit: April 05, 2016, 06:39:31 PM by endeavour1934