Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 329968 times)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Can anyone confirm that the column/filter browser does not currently support alternating row colors?
Edit: I found an old post saying it was intentionally not supported, but it also mentioned an override might be added at a later date.
the thumb browser definitely (intentionally) doesnt support alternating rows but i could put it in the override now.
the column browser should support alternating rows. I wouldnt be surprised if the filter panels override doesnt. Are you also saying the column browser overiddes dont as well?
it might be best if you explicitly state the elements you are using so there is no confusion

redwing

  • Guest
i will check this out on my win10 machine tomorrow. The borders are (should be) controlled by windows, except the top border as described. So i dont know why your active preferences screen would show the wrong border colours

Here's a full screenshot. Preferences panel active (left) and main window active (right) with Windows' "auto pick accent color from background" option turned on.

http://i.imgur.com/ZP3mWn8.png

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
the thumb browser definitely (intentionally) doesnt support alternating rows but i could put it in the override now.
the column browser should support alternating rows. I wouldnt be surprised if the filter panels override doesnt. Are you also saying the column browser overiddes dont as well?
it might be best if you explicitly state the elements you are using so there is no confusion

Sorry for the confusion, the column browser does support alternating rows, it's just the filter/thumb browser that doesn't.
An override would be much appreciated.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Here's a full screenshot. Preferences panel active (left) and main window active (right) with Windows' "auto pick accent color from background" option turned on.

http://i.imgur.com/ZP3mWn8.png
so its what i said then - the inactive top border is a guessed value. It is not working well because (a) the guessed value is quite different from the real value in your windows setup and (b) the skin itself highlights the inconsistency. I will see if it can be improved or if there is some way to get the correct value. And if thats not possible i will think about what can be done

redwing

  • Guest
so its what i said then - the inactive top border is a guessed value. It is not working well because (a) the guessed value is quite different from the real value in your windows setup and (b) the skin itself highlights the inconsistency. I will see if it can be improved or if there is some way to get the correct value. And if thats not possible i will think about what can be done

What about the surrounding border line of an active window? That's what makes a skin look broken whereas v2.5 works perfect on Windows 10 without showing that line both for active and inactive windows.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
What about the surrounding border line of an active window? That's what makes a skin look broken whereas v2.5 works perfect on Windows 10 without showing that line both for active and inactive windows.
those lines are drawn by windows. Are you saying that other application windows use a different single px colour?

redwing

  • Guest
What about the surrounding border line of an active window? That's what makes a skin look broken whereas v2.5 works perfect on Windows 10 without showing that line both for active and inactive windows.
those lines are drawn by windows. Are you saying that other application windows use a different single px colour?

Of course other apps use the same accent color for that border except one app which doesn't show the border at all. Guess what that app is, reading what I said above again.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Of course other apps use the same accent color for that border except one app which doesn't show the border at all. Guess what that app is, reading what I said above again.
no need for the snark - i need to be very clear on what people are saying before i spend valuable time investigating. I wont commit to the no borders until i know whats involved and it certainly isnt trivial as you might think or simply a case of doing it the same as v2.5 without other consequences.
I do have an idea for the inactive border colours which i will try later

redwing

  • Guest
Sorry, no offense meant.
Regarding Windows' accent color border for an active window, I don't really get their intention. Whatever color the user may pick it always won't match many apps. Also auto-pick background color option only makes sense when main window is not maximized. I think either the border itself should be able to be disabled or an app should be able to override the color. Hopefully you find some way to do that, but if not, don't worry too much. I will just accept the way Windows is designed.

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
@Steven
Not to rush you, but I'm finishing up a new skin and was hoping to get the code ready regarding the thumb browser override.
Last Edit: February 04, 2016, 02:23:42 PM by Alumni

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
with a monochromatic skin like Arsenic, a bit more contrast between the auto generated colours for the check mark and the box infill is needed, please.



or an override, if that's the easier of the two.
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
@Steven
Not to rush you, but I'm finishing up a new skin and was hoping to get the code ready regarding the thumb browser override.
i have activated the alternating row colours if the FilterPanel override colours are set.
If it turns out its causing issues with some of the other skins, i will add a new setting so its activated

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
with a monochromatic skin like Arsenic, a bit more contrast between the auto generated colours for the check mark and the box infill is needed, please.
i dont think i can adjust the colours to suit so i have added this override:
Controls.LargeTickBoxFill bg=XXXX


Alumni

  • Sr. Member
  • ****
  • Posts: 1007
i have activated the alternating row colours if the FilterPanel override colours are set.
If it turns out its causing issues with some of the other skins, i will add a new setting so its activated

Great, thanks - can confirm its working.