Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 330280 times)

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
if those images are not supplied then MB gets the colours from:
Panel.HeaderButtonOverride.Disabled

or CaptionBar.HeaderControl.Disabled
when in the caption bar :)
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
With version 3, when a track is started, a small gap is created in the left side of the progress bar fill element:



I tried a lot of things, and I can get rid of the gap when I make the progress button less wide, but that will affect, and cuts-off some pixels from the left side of the progress bar element, and this:



becomes this:




Maybe it's something in the xml file, but I tried lots of things and can't figure this out by myself.
(pm send with all relevant skin files in case you could look into this)
i am looking at this now. If you want the left and right arrows preserved then you should use dedicated left and right of progress bar images for that. See the bee-tunes skin for an example of implenting that if you are not familar with what i am saying.
With the arrangement you have, the left and right progress bar images will get overwritten when playback starts. I will fix the bug where its not doing that correctly

edit:
the reported bug is fixed for the next update
Last Edit: January 30, 2016, 12:32:38 PM by Steven

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
with the analyse volume panel, i know you can't change the blue pointer on the slider, but can the graduations on the scale be changed?


they're 196,196,196 in all skins.
could that be blended with the panel fg text colour so we don't have to have another override?
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
with the analyse volume panel, i know you can't change the blue pointer on the slider, but can the graduations on the scale be changed?
no - these are all controlled by windows. I would need to create my own control for this purpose which i dont think is a priority for the time i have available

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
no - these are all controlled by windows. I would need to create my own control for this purpose which i dont think is a priority for the time i have available

That's OK.  Now I also know it's a windows issue I agree.  It only impacts a few paler skins, but the numbers popping-up on moving the slider compensate in those cases.
MusicBee and my library - Making bee-utiful music together

hiccup

  • Hero Member
  • *****
  • Posts: 9149
If you want the left and right arrows preserved then you should use dedicated left and right of progress bar images for that. See the bee-tunes skin for an example of implenting that if you are not familar with what i am saying.

Maybe I misunderstand what you mean exactly, but I don't think there are dedicated left and right progress bar images? Both bee-tunes and my example skin have:

- 'progressbar'
- 'progressbarfill'
- 'progressbarbutton'

I haven't got the opportunity now to investigate why they behave differently between bee-tunes and my sample skin, but I suspect it has to do with the width of these three images somehow influencing each other.

I'll patiently await what you come up with, and see if I then can get an exact grasp of their behavior.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
what i said wasnt quitre right and the change made negatively affects other skins, so i will need to do some more on this. I will make it so the left and right sections of the progress bar image are always preserved (as was the original intention when i first did this years ago).
edit:
nope, its not going to work well with some of the skins such as beetunes. I will have to make a compromise where once playback starts the left section image for the progress bar narrows to not exceed the button width
Last Edit: January 30, 2016, 01:34:34 PM by Steven

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
@hiccup, the way MB works with bitmap skins for the progress bar is MB uses the left side of the image provided as the left side of the progress bar, the middle section of the provided image as the fill colour, and the right side as the right side of the progress bar. Thats fine with your skin.
When playback starts MB uses the "Filler" image. In your case you have set it to a different size to the first image. It needs to be the same size and has the same behavior as the first image, except it only displays when playback has started and only applies to the left side of the progress bar.
I suggest you just copy ProgressBar.png to ProgressBarFill.png and put the green fill colour in the middle. Or if you want the arrows wiped out on playback then fill the entire image with green.
I have made one improvement for the next update for handling the progress bar width being smaller than the left/right side of the progress bar image. So until that update is made available it still wont work optimally for you


hiccup

  • Hero Member
  • *****
  • Posts: 9149
@hiccup, the way MB works with bitmap skins for the progress bar is MB uses the left side of the image provided as the left side of the progress bar, the middle section of the provided image as the fill colour, and the right side as the right side of the progress bar. Thats fine with your skin.
When playback starts MB uses the "Filler" image. In your case you have set it to a different size to the first image. It needs to be the same size and has the same behavior as the first image, except it only displays when playback has started and only applies to the left side of the progress bar.
I suggest you just copy ProgressBar.png to ProgressBarFill.png and put the green fill colour in the middle. Or if you want the arrows wiped out on playback then fill the entire image with green.
I have made one improvement for the next update for handling the progress bar width being smaller than the left/right side of the progress bar image. So until that update is made available it still wont work optimally for you

Perfect. Thank you for addressing this so quickly, and explaining the exact workings.
It's working very well and predictable now. Thnx!

redwing

  • Guest
It seems that if I use transparent background for FormRestoreButton & FormRestoreHighlightButton, they overlap with FormMaximiseButton (but not FormMaximiseHighlightButton when highlighted). Can you confirm and fix this if that's the case? (All other buttons work properly)
Last Edit: January 31, 2016, 07:53:58 PM by redwing

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
It seems that if I use transparent background for FormRestoreButton & FormRestoreHighlightButton, they overlap with FormMaximiseButton (but not FormMaximiseHighlightButton when highlighted). Can you confirm and fix this if that's the case? (All other buttons work properly)
yes that does appear to be the case. I will make the change untested and if it still has problems after the next update can you send me the skin you are working on



Alumni

  • Sr. Member
  • ****
  • Posts: 1007
A possible bug;
With the native button theme the forward and back buttons are not centered properly (relative to each other) in the tag edit popup window.