Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 329760 times)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
thanks - i can reproduce the flashing as you describe using your settings so i should be able to fix it

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
the NotificationIcon and DownloadIndicatorIcon are out of alignment with the other panel icons.

NotificationIcon is 1px up
DownloadIndicatorIcon is 1px down

(I'm not really nit-picking, I can't help it, my OCD is showing) :)
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
i will try and look at the skinning issues raised before the end of the weekend

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
However, there is no Controls.SearchBoxPTop.NotActivated (bg, bdr) element. BTW, after using the searchbox and clearing it, it never returns to the NotActivated state. I don't remember if this happened on previous versions. You can see in DarkRED why I'm asking for both these things: https://dl.dropboxusercontent.com/u/10773406/DarkREDFlat3.xml
(I chose to use a "highlight" bg for the activated searchbox because in some panels search is activated by default, and without the highlight sometimes I don't notice it, but I'd prefer if it returns to NotActivated when it loses the focus.)
Of course if this implies too much work I can go back to use a uniform background (but I will still need Controls.SearchBoxPTop.NotActivated bg, bdr).
for the next v3 update:
Controls.SearchBoxPTop.NotActivated bg=XXX bdr=XXX

i have also changed the search box behavior so that when its empty and loses focus it reverts to the not activated state

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Therefor this is a request for an image overrule element for that.
for the next v3 updated i have removed:
Controls.WebLink
and added:
Controls.WebLinkIcon (16x16px)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
This is a bit weird, and before I dive into this further, maybe somebody can confirm this. (I checked this with a few skins)

I have set <element id="Panel.HeaderButtonOverride.Highlight" bg="2,254,6" />
But this doesn't have any effect at all when I click, or hoover over a self-created toolbar button (text button, no icon).
that should be fixed for the next v3 update


Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
@ Steven
Have been trying the new icon overrides, but I can't work out where PlayingIcon.Highlight & PausedIcon.Highlight appear.
Default ones show up fine in all the right places, but highlight ones don't show on mouse-over or anywhere I can see.
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Highlight was probably not the best name. Its when the row the playing track icon displays is selected

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
its working fine here so i wont be able to help you with that
<element id="MenuIcon" fg="250,10,70" />

Figured it out - I was confused because the element doesn't give you a 'true color', maybe because of the gradient effect.

i probably wont do a bitmap override because there is special handling for aligning to the fonts used and for dpi scaling that needs special treatment

Oh ok, fair enough. I was hoping to give the menu icon a sharper appearance to match the rest of my layout, like this:



PS: Can this missing element be added? It's a lowlight override for the preferences scrollbar.

Code
<element id="Controls.ScrollBar.Lowlight" />
Last Edit: January 23, 2016, 02:18:02 PM by Alumni

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i have added:
  <element id="MenuButtonSharp">true</element>
  the colour override will also be a true colour with this setting
and
Controls.ScrollBar.Lowlight (not tested)

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i have added:
  <element id="MenuButtonSharp">true</element>
  the colour override will also be a true colour with this setting
and
Controls.ScrollBar.Lowlight (not tested)

Thanks! Really happy with the way those look.

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Highlight was probably not the best name. Its when the row the playing track icon displays is selected

It only changes in Track Detail view. 
Bug or by design?
MusicBee and my library - Making bee-utiful music together

hiccup

  • Hero Member
  • *****
  • Posts: 9149
As soon as I click that button, suddenly for the other 'text' toolbar button the above highlight element coloring is activated.

To illustrate,
When I press the toolbar button (1) for 'show thumbnail browser', then toolbar button (2) gets the highlight color. (But the other button (3) doesn't)


edit:

And after the MB window loses focus after that, the button gets to look like this:


The first issue seems to be fixed.
The second is still present:

To replicate:
Have a toolbar command button for "show artwork", and press it without having any files selected:







Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Therefor this is a request for an image overrule element for that.
for the next v3 updated i have removed:
Controls.WebLink
and added:
Controls.WebLinkIcon (16x16px)
Thanks for this one.  Looks much better :)
MusicBee and my library - Making bee-utiful music together