Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 329813 times)

hiccup

  • Hero Member
  • *****
  • Posts: 9149
As EffenBlue established here:

http://getmusicbee.com/forum/index.php?topic=6793.msg102427#msg102427
http://getmusicbee.com/forum/index.php?topic=10884.msg102428#msg102428

There is a graphical issue with 'disabled' entries in the Playing Tracks panel.
I checked with a few skins (DarkRed xml, Dem Ol Kozmic Blues, and my own Crimson Creme) and they all display this issue.

The default MusicBee3 skin doesn't have this problem, nor a few other skins I checked, but which have substantial less elements then the ones I just mentioned.

Removing or disabling the <element id="NowPlayingList[TrackDetail].Disabled" fg="1,250,7" /> doesn't solve it, so there probably is a dependency on other elements too.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
<!-- 55-->  <element id="Content[TrackDetail].ListAlternating.Disabled" bg="225,225,225" fg="160,160,160" />
<element id="Content[TrackDetail].Body.Disabled" fg="160,160,160" />
the playing track overrides (NowPlayingList[TrackDetail].*) are only used if NowPlayingList[TrackDetail].Default bg is included

This setting is nothing new but i guess its possible in v2.5, if it wasnt provided then .Default is used so i will probably change that

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Also I just noticed this:


thats controlled by the .NET library but if you provide a bdr override then MB wiill handle the borders consistently
  <element id="Menu.DropDown.Highlight" bg="Highlight" bdr="0,255,0" />

hiccup

  • Hero Member
  • *****
  • Posts: 9149
<!-- 55-->  <element id="Content[TrackDetail].ListAlternating.Disabled" bg="225,225,225" fg="160,160,160" />
<element id="Content[TrackDetail].Body.Disabled" fg="160,160,160" />
the playing track overrides (NowPlayingList[TrackDetail].*) are only used if NowPlayingList[TrackDetail].Default bg is included

This setting is nothing new but i guess its possible in v2.5, if it wasnt provided then .Default is used so i will probably change that

The corruption is indeed gone when I remove the bg value from NowPlayingList[TrackDetail].Default
But it probably needs a fix from your side, since not all existing skins that have this bg value will be maintained by their creators.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
@endeavour1934 and Alumni
i have added the following, but wont do the volume slider or selector button arrow changes for this iteration of MB3


left menu button:
MenuIcon fg=XXX

player on top overrides:
TabsBarPTop.InactiveTabIconMask bg=XXX
Controls.SearchBoxPTop.Default bg=XXX fg=XXX

icon overrides:
SearchMenuButton  (26x20px)
PlayingIcon.Default  (16x16px)
PausedIcon.Default  (16x16px)
PlayingIcon.Highlight  (16x16px)
PausedIcon.Highlight  (16x16px)
AddTabIcon  (16x16px)
AddTabIconInCaptionBar  (16x16px)
Last Edit: January 21, 2016, 07:50:08 PM by Steven


endeavour1934

  • Full Member
  • ***
  • Posts: 207
@endeavour1934 and Alumni
i have added the following
Thanks!
However, there is no Controls.SearchBoxPTop.NotActivated (bg, bdr) element. BTW, after using the searchbox and clearing it, it never returns to the NotActivated state. I don't remember if this happened on previous versions. You can see in DarkRED why I'm asking for both these things: https://dl.dropboxusercontent.com/u/10773406/DarkREDFlat3.xml
(I chose to use a "highlight" bg for the activated searchbox because in some panels search is activated by default, and without the highlight sometimes I don't notice it, but I'd prefer if it returns to NotActivated when it loses the focus.)
Of course if this implies too much work I can go back to use a uniform background (but I will still need Controls.SearchBoxPTop.NotActivated bg, bdr).

The PlayingIcons look a bit blurry. Are you sure about the resolution? Also I think a bug was introduced: After opening Musicbee, if you start playing a different song from the current playlist, the PlayingIcon flashes on the last song played before closing the app. Again, if it's too complicated to solve you can roll back the changes made for these icons, because as I've said earlier they aren't a big priority.

PS: Sorry for being such a pain in the a**
Last Edit: January 21, 2016, 10:16:47 PM by endeavour1934

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
The PlayingIcons look a bit blurry. Are you sure about the resolution? Also I think a bug was introduced: After opening Musicbee, if you start playing a different song from the current playlist, the PlayingIcon flashes on the last song played before closing the app.
the blur will be addressed for the next update. But what do you mean by "the PlayingIcon flashes on the last song played before closing the app. "?
playing another song causes MB to close?

hiccup

  • Hero Member
  • *****
  • Posts: 9149
This is a bit weird, and before I dive into this further, maybe somebody can confirm this. (I checked this with a few skins)

I have set <element id="Panel.HeaderButtonOverride.Highlight" bg="2,254,6" />
But this doesn't have any effect at all when I click, or hoover over a self-created toolbar button (text button, no icon).

I also have created a toolbar button: "View: Toggle Show Thumbnail Browser" (with icon)
As soon as I click that button, suddenly for the other 'text' toolbar button the above highlight element coloring is activated.

To illustrate,
When I press the toolbar button (1) for 'show thumbnail browser', then toolbar button (2) gets the highlight color. (But the other button (3) doesn't)




edit:

And after the MB window loses focus after that, the button gets to look like this:


Last Edit: January 21, 2016, 11:04:11 PM by hiccup

hiccup

  • Hero Member
  • *****
  • Posts: 9149
The current Weblink colouring overrule element results in this rather vague image:



instead of this:



Therefor this is a request for an image overrule element for that.

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
@Steven
Thanks for adding those new elements. It doesn't seem like MenuIcon fg=XXX is having any effect though.
PS: It would also be nice to have a bitmap override for the menu icon, but it's a low priority.
Last Edit: January 22, 2016, 03:06:09 AM by Alumni

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Thanks for adding those new elements. It doesn't seem like MenuIcon fg=XXX is having any effect though.
PS: It would also be nice to have a bitmap override for the menu icon, but it's a low priority.
its working fine here so i wont be able to help you with that
<element id="MenuIcon" fg="250,10,70" />

i probably wont do a bitmap override because there is special handling for aligning to the fonts used and for dpi scaling that needs special treatment
Last Edit: January 22, 2016, 07:24:10 AM by Steven

endeavour1934

  • Full Member
  • ***
  • Posts: 207
But what do you mean by "the PlayingIcon flashes on the last song played before closing the app. "?
playing another song causes MB to close?
I just saw that the bug was in a previous beta too.

1. Load a few tracks (let's say 10) on the Playing Tracks list.
2. Start playing track #3.
3. Close MusicBee
4. Open MusicBee
5. Start playing track #7        ---> PlayingIcon.Default flashes on #3 before moving to #7.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
1. Load a few tracks (let's say 10) on the Playing Tracks list.
2. Start playing track #3.
3. Close MusicBee
4. Open MusicBee
5. Start playing track #7        ---> PlayingIcon.Default flashes on #3 before moving to #7.
would you mind sending me your settings file? (help/ support/ view settings)
also could you confirm you are selecting a new song from the Now Playing list in the right sidebar

endeavour1934

  • Full Member
  • ***
  • Posts: 207
would you mind sending me your settings file? (help/ support/ view settings)
also could you confirm you are selecting a new song from the Now Playing list in the right sidebar
File: https://dl.dropboxusercontent.com/u/10773406/MusicBee3Settings.ini
yes, I'm using Playing Tracks element docked on the right panel, but also happens if it's docked in the main panel, left panel...

BTW, also noticed that if I move the Playing Tracks element from the right panel to the main panel it still uses the NowPlayingList[TrackDetail] appearance, but after reopening the app it switches to Content[TrackDetail] appearance.