Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 330786 times)

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
<element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
to override the id="PreferencesPanel.Default" colours is not working for MB3
the auto dj panel overrides are not supported in v3. This is to simplify the maintenance required

Bummer :(
That panel can look a bit off if the main panel colours are radically different to the preferences panel ones

MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34993

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34993
My request is: either a separate element for the 'dividers', or perhaps make these dividers dependent on: id="Content[TrackDetail].Body.Default", which shares a similar and actual practical purpose:
i wont do this but i have made a small tweak so if the border color is the same as the bg2 color then an automatically generated color is used


hiccup

  • Hero Member
  • *****
  • Posts: 9152
My request is: either a separate element for the 'dividers', or perhaps make these dividers dependent on: id="Content[TrackDetail].Body.Default", which shares a similar and actual practical purpose:
i wont do this but i have made a small tweak so if the border color is the same as the bg2 color then an automatically generated color is used

That solution seems to work for most semi-dark skins.
But for very dark skins it's still a bit problematic:


 

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
using a gradient on mini player produces all sorts of problems in MB3
i actually didnt intend to support that but forgot to disable the bg2 via the skin settings. However it turns out to be straight-forward so its done for the next update

thanks! looks brilliant :)



could we have overrides for the new Last.fm Recommendations and Statistics navigator icons, please



and I'll try to twist your arm :)
I'm begging you to reconsider just <element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
(or maybe a new MB3 override! huh!! huh!!)
Please, please, please...
   

(I'm grovelling now, in case you hadn't guessed) :D
Last Edit: January 18, 2016, 11:55:02 PM by Bee-liever
MusicBee and my library - Making bee-utiful music together

endeavour1934

  • Full Member
  • ***
  • Posts: 207
One error and (very) small spacing requests:

http://i.imgur.com/aOUkyJG.png

PS: Hmmmmm, also I think the Tab icons are a bit misaligned (They are 1px too high Actually, i think the text is 1px too low —not aligned with custom command text buttons—). Same thing happens on the Playlist Manager left playlist browser.

Last Edit: January 19, 2016, 04:53:33 PM by endeavour1934

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34993
could we have overrides for the new Last.fm Recommendations and Statistics navigator icons, please



and I'll try to twist your arm :)
I'm begging you to reconsider just <element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
(or maybe a new MB3 override! huh!! huh!!)
while i appreciate that a plugin icon may not work well with a skin, i dont have control over future plugins that are created. Given those two are mine and i am making changes to skin handling i will enable a last.fm icon override
for the 2nd i already answered that.

edit:
added "LastFmPluginIcon" for the two last.fm plugin icon overrides
Last Edit: January 19, 2016, 07:47:31 PM by Steven

hiccup

  • Hero Member
  • *****
  • Posts: 9152
With MB v2, the element id="ScrollBarMargin" makes it possible to have a (visually) thinner scroll bar, but it doesn't affect the background of the scroll bar which will keep the same width as it had before.
It would be nice for v3 that when the scroll bar is set to be thinner, it's background gets thinner too.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34993
One error and (very) small spacing requests:

http://i.imgur.com/aOUkyJG.png

PS: Hmmmmm, also I think the Tab icons are a bit misaligned (They are 1px too high Actually, i think the text is 1px too low —not aligned with custom command text buttons—). Same thing happens on the Playlist Manager left playlist browser.
i will do the tab icon adjustment so the icon offset is consistent and the missing overlay mask.
The thumbnail icon placement is something i attempted to address a while ago but is problematic to change. I probably wont have time to look at that again.
For the vertical spacing in the Playing Tracks layout, please keep in mind it needs to work alongside the main panel when the main panel is not in artwork layout. In my opinion having 2-3px doesnt work well when the main panel is in Track Details or Album and Tracks layout.
As a compromise i am happy to increase the spacing by 1px and that also makes it consistent with the navigator on the opposite side of the window.
Of course in the Now Playing window which is intended more for display than for functionality, the vertical spacing is already padded more.


Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34993
With MB v2, the element id="ScrollBarMargin" makes it possible to have a (visually) thinner scroll bar, but it doesn't affect the background of the scroll bar which will keep the same width as it had before.
It would be nice for v3 that when the scroll bar is set to be thinner, it's background gets thinner too.
while that would be possible for v3, i feel its too much to do/ risky for introducing bugs at this point

hiccup

  • Hero Member
  • *****
  • Posts: 9152
With MB v2, the element id="ScrollBarMargin" makes it possible to have a (visually) thinner scroll bar, but it doesn't affect the background of the scroll bar which will keep the same width as it had before.
It would be nice for v3 that when the scroll bar is set to be thinner, it's background gets thinner too.
while that would be possible for v3, i feel its too much to do/ risky for introducing bugs at this point

Ok. Should I just forget about it, or maybe throw it up again in the future after v3 is an official release?

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
for the 2nd i already answered that.

I know you did.  I was begging & grovelling to try and get you to change your mind or consider a new override just for the main autoDJ bg and fg colours.
Guess it didn't work.  The re-boot of my old Tundra series just wont be the same :D
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34993
Ok. Should I just forget about it, or maybe throw it up again in the future after v3 is an official release?
feel free to raise it again after the v3 release