Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 329856 times)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe

- fixes for the above
- for the music explorer there are quite a few colours involved even though it all looks the similar. How strongly do you feel about it?
- <element id="Controls.SearchBox.Lowlight" />and <element id="CaptionBar.SearchBox.Lowlight" /> - i dont really understand what you are looking to acheive and lowlight attribute only affects the text and not the remaining textbox area

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
<element id="Controls.SearchBox.Lowlight" />and <element id="CaptionBar.SearchBox.Lowlight" /> - i dont really understand what you are looking to acheive and lowlight attribute only affects the text and not the remaining textbox area

I'm trying to get a way to delineate the search box when it's in use.

With the border attribute of <element id="CaptionBar.SearchBox.Default"/> working again (thank you very much for that BTW) I can get this:

Lowlight


Default


but I think the border doesn't work very well with the MB3 design.

So, with a bg attribute for <element id="Controls.SearchBox.Lowlight" /> and <element id="CaptionBar.SearchBox.Lowlight" /> I could achieve this:

Lowlight


Default


Something that fits in with MB3 style.
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe

i have added
  <element id="CaptionBar.SearchBox.NotActivated" bg="10,245,0" bdr="255,0,0" />
  <element id="Panel.SearchBox.NotActivated" bg="240,0,0" bdr="0,0,255" />
and also a column browser override. If not provided it falls back to the FilterPanel... elements, and if that is not provided then the main panel elements (as with v2.5)
  <element id="ColumnBrowser.ListHeader" bg="252,252,252" bg2="248,248,248" fg="0,0,0" bdr="225,225,225" />
  <element id="ColumnBrowser.Default" bg="253,253,253" fg="0,0,0" />
  <element id="ColumnBrowser.ListAlternating.Default" bg="253,253,253" fg="0,0,0" />
  <element id="ColumnBrowser.Highlight" bg="245,236,172" bdr="227,216,152" fg="0,0,0" />
  <element id="ColumnBrowser.Lowlight" bg="232,232,232" fg="0,0,0" bdr="225,225,225" />
  <element id="ColumnBrowser.ScrollBar" bg="150,150,150" bg2="130,130,130" bdr="0,0,0" />
  <element id="ColumnBrowser.ScrollBarBackground" bg="253,253,253" />
Last Edit: December 19, 2015, 01:19:06 PM by Steven

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
i have added
  <element id="CaptionBar.SearchBox.NotActivated" bg="10,245,0" bdr="255,0,0" />
  <element id="Panel.SearchBox.NotActivated" bg="240,0,0" bdr="0,0,255" />

just had a quick trial of these - looks good!
greatly appreciated. :)
MusicBee and my library - Making bee-utiful music together

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
i have added
  <element id="CaptionBar.SearchBox.NotActivated" bg="10,245,0" bdr="255,0,0" />
  <element id="Panel.SearchBox.NotActivated" bg="240,0,0" bdr="0,0,255" />

just had a quick trial of these - looks good!
greatly appreciated. :)

think this looks even better than I thought it would
just a few minor teething troubles:

- when in caption bar, search close/clear button is not using CaptionBar.SearchBox.Default attributes
  still using .NotActivated colours
  works fine when below caption bar

- after close/clear search button is used,  active colours are still shown
  new .NotActivated colours are not repainted on area
MusicBee and my library - Making bee-utiful music together

hiccup

  • Hero Member
  • *****
  • Posts: 9149
The border elements in the column browser don't seem to respect the id="FilterPanel.Disabled" settings.

Sportura Pinstripe skin in v2:



and in v3:


Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
The border elements in the column browser don't seem to respect the id="FilterPanel.Disabled" settings.
using the skin you posted on nov 29, it works fine for me. Can you confirm you are using the lastest MB version and the same skin?

hiccup

  • Hero Member
  • *****
  • Posts: 9149
Apologies, it seems I was a few versions behind. It's fine indeed with the latest version.
(you are working too fast!)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
- when in caption bar, search close/clear button is not using CaptionBar.SearchBox.Default attributes
  still using .NotActivated colours
  works fine when below caption bar

- after close/clear search button is used,  active colours are still shown
  new .NotActivated colours are not repainted on area
the search reset button is fixed
for the 2nd point, the colours are only used when the "search" prompt is showing. Once the search box is used, it stays with the activated colours

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
the search reset button is fixed

thank you

for the 2nd point, the colours are only used when the "search" prompt is showing. Once the search box is used, it stays with the activated colours

OK. Thanks for the clarification.
 I thought it would be like the search box on Library Explorer and close completely, returning to the .NotActivated colours
MusicBee and my library - Making bee-utiful music together

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Have found with some skins it's hard to pick a fg colour that works on the player progress bar when used bottom/top and middle.
Perhaps a fg attribute for <element id="PlayerFlat.ProgressBarMiddle" /> ?

There is also no PlayerTopFlat. equivalents for:
<element id="PlayerFlat.ProgressBarMiddle" bg="xxx,xxx,xxx" />
<element id="PlayerFlat.NotLovedIcon" fg="xxx,xxx,xxx" />
MusicBee and my library - Making bee-utiful music together

hiccup

  • Hero Member
  • *****
  • Posts: 9149
@Steven,

If I recall correct, you mentioned a while back that for new skins it is preferred not to use transparency for the top border elements anymore.

Since you had quite some challenges with borders in W10, are there other aspects relating to creating border elements for new skins to be taken into account?
For example, should the sizes of the border elements be different than before? Is there an effect on these elements between them displaying differently between full-screen vs minimized?

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Since you had quite some challenges with borders in W10, are there other aspects relating to creating border elements for new skins to be taken into account?
For example, should the sizes of the border elements be different than before? Is there an effect on these elements between them displaying differently between full-screen vs minimized?
transparency should be handled - i made some changes a while ago.
For the win10 borders, just be aware the way its handled is MB uses the outer-most pixel for the frame bitmaps. However they should still be set to the current sizes because windows 7-8 still need to be handled.
Maximisation should need no special consideration

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Have found with some skins it's hard to pick a fg colour that works on the player progress bar when used bottom/top and middle.
Perhaps a fg attribute for <element id="PlayerFlat.ProgressBarMiddle" /> ?

There is also no PlayerTopFlat. equivalents for:
<element id="PlayerFlat.ProgressBarMiddle" bg="xxx,xxx,xxx" />
<element id="PlayerFlat.NotLovedIcon" fg="xxx,xxx,xxx" />
i have put in PlayerFlat.ProgressBarMiddle and PlayerFlat.NotLovedIcon (not tested)
for the progress bar, hopefully it will work without the extra element
the way it works is if that element is not supplied (which would have been the case before this change for docked at top) then MB defaults to an automatically generated colour

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Player(Top)Flat.NotLovedIcon (not tested)

Yep. Not working yet :(

PlayerTopFlat.ProgressBarMiddle, on the other hand, is working fine :)

for the progress bar, hopefully it will work without the extra element

I personally think a FG attribute is needed for both
<element id="PlayerFlat.ProgressBarMiddle" />
<element id="PlayerTopFlat.ProgressBarMiddle" />
for some of the more difficult skin colour combos, but I can live without it.
I'm trying not to add too much to the 3.0 workload.

Also found that the thumbnail browser is not using the .ScrollBarBackground attributes from Panel settings or from FilterPanel overrides (when used)
MusicBee and my library - Making bee-utiful music together