Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 330285 times)

redwing

  • Guest
Is there a way not showing that 1px border on the right like v2.5 on the left?


hiccup

  • Hero Member
  • *****
  • Posts: 9149
Is there a way not showing that 1px border on the right like v2.5 on the left?



If I am correct, to draw those borders, v3 doesn't display the exact pixel borders as they are in the border images, but for the left and right ones it only looks at the most left pixels, and for the top it calculates some average from that image.
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
If I am correct, to draw those borders, v3 doesn't display the exact pixel borders as they are in the border images, but for the left and right ones it only looks at the most left pixels, and for the top it calculates some average from that image.
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

And I'm sure Steven said that rounded corners stuffs up Windows 10, so all borders now need to be square.
MusicBee and my library - Making bee-utiful music together

hiccup

  • Hero Member
  • *****
  • Posts: 9149
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

And I'm sure Steven said that rounded corners stuffs up Windows 10, so all borders now need to be square.

Ah yes, true indeed.
The transparent corner pixels are being ignored anyway for v3, but it might be safe to color them accordingly now to prevent some possible unexpected colouring.

redwing

  • Guest
If I am correct, to draw those borders, v3 doesn't display the exact pixel borders as they are in the border images, but for the left and right ones it only looks at the most left pixels, and for the top it calculates some average from that image.
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

I don't understand what you mean. All skins I've been testing show the same 1px border surrounding any windows. I'm sure that's what Windows is doing but my question is whether it's possible to hide that border like v2.5 using some sort of override setting.

hiccup

  • Hero Member
  • *****
  • Posts: 9149
I don't understand what you mean. All skins I've been testing show the same 1px border surrounding any windows. I'm sure that's what Windows is doing but my question is whether it's possible to hide that border like v2.5 using some sort of override setting.

I was assuming you were creating a skin, and had troubles with getting the correct border colours.
But I understand you are referring to the thin border line Windows 10 is adding. Steven has spent lots of time and effort on getting the behavior of borders right for v3, and explained he can't avoid this line showing up.

redwing

  • Guest
I was assuming you were creating a skin, and had troubles with getting the correct border colours.
But I understand you are referring to the thin border line Windows 10 is adding. Steven has spent lots of time and effort on getting the behavior of borders right for v3, and explained he can't avoid this line showing up.

Thanks for the info! That's too bad. Most of my colored skins look as if something's broken when resized and with any popup window.
Steven, can't you provide an override setting that would handle border images just like v2.5?

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
A missing element is needed for the compact player when viewed in artist picture mode, since the previous maroon color is still visible.

element id="NowPlayingArtistTrackInfo"

Last Edit: February 02, 2016, 02:24:40 PM by Alumni

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
Can anyone confirm that the column/filter browser does not currently support alternating row colors?
Edit: I found an old post saying it was intentionally not supported, but it also mentioned an override might be added at a later date.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
Thanks for the info! That's too bad. Most of my colored skins look as if something's broken when resized and with any popup window.
Steven, can't you provide an override setting that would handle border images just like v2.5?
i wont answer the question right now but what do you mean by looking broken when resized?
The single px borders are drawn by windows with the exception of the top border line. When the window is active the top border line should match (maybe with a very slight variation) but when the window is inactive then MB sets the inactive colour to gray because the real colour is not made available via an API. It doesnt seem to match for your screenshot. Is this what you are refering to?

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
A missing element is needed for the compact player when viewed in artist picture mode, since the previous maroon color is still visible.
thats fixed for the next update

hiccup

  • Hero Member
  • *****
  • Posts: 9149
Can anyone confirm that the column/filter browser does not currently support alternating row colors?
Edit: I found an old post saying it was intentionally not supported, but it also mentioned an override might be added at a later date.

It's possible. There have been elements added so you can separately set coloring (and alternating lines) for both  id="FilterPanel  and  id="ColumnBrowser.

redwing

  • Guest
Thanks for the info! That's too bad. Most of my colored skins look as if something's broken when resized and with any popup window.
Steven, can't you provide an override setting that would handle border images just like v2.5?
i wont answer the question right now but what do you mean by looking broken when resized?
The single px borders are drawn by windows with the exception of the top border line. When the window is active the top border line should match (maybe with a very slight variation) but when the window is inactive then MB sets the inactive colour to gray because the real colour is not made available via an API. It doesnt seem to match for your screenshot. Is this what you are refering to?

I was referring to the top border line of the main window (inactive) and all border lines surrounding preferences panel (active) in my screenshot.

Alumni

  • Sr. Member
  • ****
  • Posts: 1007
It's possible. There have been elements added so you can separately set coloring (and alternating lines) for both  id="FilterPanel  and  id="ColumnBrowser.

I put the same code for both of those and it only works for the column browser.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34992
I was referring to the top border line of the main window (inactive) and all border lines surrounding preferences panel (active) in my screenshot.
i will check this out on my win10 machine tomorrow. The borders are (should be) controlled by windows, except the top border as described. So i dont know why your active preferences screen would show the wrong border colours