Author Topic: Skin- and visual errors related to, and skinning requests for MusicBee v3  (Read 330117 times)

hiccup

  • Hero Member
  • *****
  • Posts: 9149
personally i agree with you, its just that i recall comments about the search box being better placed where it is now. I dont want to add an option for this. Before i go and change anything does anyone else have any comments on this

If I understand correctly, and this is about the search field and the toolbar icons being pushed up all the way flush to the top without a 'buffering'pixel:

I would like to have the 'buffering pixel' too.
Both for 'looks', but also because when in full-screen mode, it is now not possible to drag the top border to resize the whole MusicBee window at locations where the search box or toolbar icons are.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
the search box only has 1px it can be pushed down
The problem is in v2.5 the way window is done is quite different to v3 and didnt need to follow some of the windows standard behaviors. So when MB was maximised MB could maintain the full header height. In v3, the caption bar is actually set 8px off the screen (by windows) so it leaves less space available (check with any standard windows application such as notepad and you will see 8px removed from the header height).
So can you confirm thats really what the issue is ie. less vertical height making it look different.
For skinned borders i could probably do something about it but it would be a non-trivial exercise

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10940
the search box only has 1px it can be pushed down
The problem is in v2.5 the way window is done is quite different to v3 and didnt need to follow some of the windows standard behaviors. So when MB was maximised MB could maintain the full header height. In v3, the caption bar is actually set 8px off the screen (by windows) so it leaves less space available (check with any standard windows application such as notepad and you will see 8px removed from the header height).
So can you confirm thats really what the issue is ie. less vertical height making it look different.
For skinned borders i could probably do something about it but it would be a non-trivial exercise

I see.  I think even that 1 pixel would help cosmetically, just to make it a little less crowded.

The reason it looks different is the gradient I'm using, but I can adapt the gradient to the space available.  However, if I adapt the top border for Win 10, it will no longer match the other borders in Win 7.  I can make different versions, but then that becomes a bit confusing for the user.  And what about people creating new skins on Windows 10?  They won't be able to see how it would look on Windows 7.  So I think for the sake of both skinners and users, if you can make the borders consistent across all versions of Windows, it would be worth the effort.
Last Edit: November 28, 2015, 05:54:18 PM by psychoadept
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest patches
(Unzip and overwrite existing program files)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
i will have a look at it and if i think its too hard i will just do the 1px adjustment - but it will probably be ok

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
Update: The issue is with Panel.ChildHeader.Default bdr value.  It shows up on bottom in the main panel and on top in the right.
can you send me your settings file as i still cant reproduce any incorrect behavior and could you also confirm the corruption happens on startup or do you need to do some action for it to happen?

edit:
nevermind - its when you have the spectrum visualiser at the top


psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10940
I'd like to be able to put a border here, connected to the tab border (in other words, I'd like to have one both above and below panel.childheader.default):



MusicBee Wiki
Use & improve MusicBee's documentation!

Latest patches
(Unzip and overwrite existing program files)

hiccup

  • Hero Member
  • *****
  • Posts: 9149
I'd like to be able to put a border here, connected to the tab border (in other words, I'd like to have one both above and below panel.childheader.default):



Steven created a new element for that last week:
<element id="TabsBar.BorderLine" bdr="xxx,xxx,xxx" />

But that one is not working when the tabs are in the caption bar, so for that we would need another new one:
<element id="TabsBar.TabInCaptionBar.BorderLine" bdr="xxx,xxx,xxx" />

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
for the next update i have added 4px to skinned caption bar when maximised for skinned window borders (thats still 4px less than in normal state)

Bee-liever

  • Member
  • Hero Member
  • *****
  • Posts: 3871
  • MB Version: 3.6.9255 P
Hope this can be achieved as the maroon colour doesn't work with all skins:
yes i will add a new skin element but i am leaving that sort of thing until the new GUI is mostly done

don't forget this one.
It's the maroon rectangle in the Now Playing Tab and compact player, with the Title, Artist and Album (YYYY) info on it.
MusicBee and my library - Making bee-utiful music together

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990
this has the extra caption bar area. I will look at the requests but still not really in a position to do so in earnest yet

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe

hiccup

  • Hero Member
  • *****
  • Posts: 9149
this has the extra caption bar area

That's looking good.
not an issue at all, but I noticed the area where you cannot grab the caption bar to move/resize is rather large. (yellow area)
And after some erratic fiddling, enlarging and minimalizing the whole window, sometimes a 'close' button appears at a strange location in the caption bar.


hiccup

  • Hero Member
  • *****
  • Posts: 9149
When maximizing, the tabs in the caption bar get a duplicate top border line



maximized:



('jistme on the outlook' skin)

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34990