Author Topic: Dummy skin or how to change the colour of an element  (Read 42317 times)


jistme

  • Guest
I can't get these stars to change color.



Following the color in your sheet it should be:
<element id="Player.StarRating.Default" fg="196,197,197"/>
but changing the value doesn't change the color.
(also I notice it is under the header \\ --- NOW PLAYING POPUP), but this printscreen is not from a popup?

lnminente

  • Sr. Member
  • ****
  • Posts: 1049
Verified here too. So i did this:
Starting from the beginning of the file i search for .StarRating
Then i found a element ending with .StarRating.Hightlight which is not present for elements starting with Player.
I created the element Player.StarRating.Highlight and gave it a value of a very different color from the others, for example 255,0,0
So it seemed the 196,197,197 started to work again when changing it

This is what i added <element id="Player.StarRating.Highlight" fg="255,0,0"/>

jistme

  • Guest
My eyes are square, gonna call it quits for today.

If interested, here is the current result:
http://www.mediafire.com/?58999o1u3y3e1

My two main challenges for the moment:
- can't get the star rating fixed (will try again later this week)
- still a slight difference in color in the side panel player D(ark) L(ight)



Thnx again for your great work and help!
 
Last Edit: July 06, 2012, 08:56:42 AM by jistme

lnminente

  • Sr. Member
  • ****
  • Posts: 1049
That's nice, you have done a lot in only one day!! :o

I would use variables for making easier in a future changing some colours  http://getmusicbee.com/forum/index.php?topic=6203.new#new
Last Edit: July 04, 2012, 01:40:56 AM by lnminente

jistme

  • Guest
Thnx, your tools and tips made it possible.
The link to the new SkinCreator is dead, it looks like Steven removed it from nblseed.

jistme

  • Guest
Strange, that solution works in your dummy xml, but not in mine.
Probably the rating colors are overruled by some other setting in the sheet. It's beyond me.

Anyhow, I am already quite happy with the result:

http://www.mediafire.com/?58999o1u3y3e1

Verified here too. So i did this:
Starting from the beginning of the file i search for .StarRating
Then i found a element ending with .StarRating.Hightlight which is not present for elements starting with Player.
I created the element Player.StarRating.Highlight and gave it a value of a very different color from the others, for example 255,0,0
So it seemed the 196,197,197 started to work again when changing it

This is what i added <element id="Player.StarRating.Highlight" fg="255,0,0"/>
Last Edit: July 04, 2012, 01:12:48 PM by jistme

jistme

  • Guest
I solved it, I know how, but I don't know why?

These three lines were somewhere in the beginning of the xml sheet (lines 118,119,120):

<element id="Player.StarRating.Default" fg="255,0,0" />
<element id="Player.StarRating.Lowlight" fg="0,255,0" />
<element id="Player.StarRating.Highlight" fg="0,0,255"/>

Changing the color values there have no effect at all.

Then I moved them to lines (200,201,202), and then it works?

I'm confused, so the order is important, but how?

Example skins: ('test fail' and 'test pass')
http://www.mediafire.com/?3vqcql26qwcdd
(use main player non-flat layout)

lnminente

  • Sr. Member
  • ****
  • Posts: 1049
mmm I see, it works the same here.

BTW I have discovered something strange in the midnight skin (so in dummy too):
-The elements Player.StarRating.Default and Player.StarRating.Lowlight are defined two times, one for "Players" and another for "Now playing popup". Don't know if its a bug or if it has one reason for being there :/

OrB

  • Guest
I see. As far as i remember there was a problem to make it work. (sorting/moving some lines up/down as jistme noticed)
so i dont think its an error to see the first occurrence as a kind of initialization. (fg="0,0,0")
But maybe you can find out a better way   :)

lnminente

  • Sr. Member
  • ****
  • Posts: 1049
Updated with the following changes (link in first post):
Changed bg in PlayerSidebar.Control.Default to 255,30,27"
Player.StarRating.Default and Player.StarRating.Lowlight are present only one time now
Removed alpha channels
Added the latest new elements
Last Edit: July 06, 2012, 11:20:18 AM by lnminente

jistme

  • Guest
Great!

two remarks:
- lines 83 & 85 seem duplicate
- these two might be handy:
<element id="MiniPlayer.StarRating.Default" bg="125,125,125" fg="175,175,175"/>
<element id="MiniPlayer.StarRating.Lowlight" fg="50,50,50"/>

lnminente

  • Sr. Member
  • ****
  • Posts: 1049
- these two might be handy:
<element id="MiniPlayer.StarRating.Default" bg="125,125,125" fg="175,175,175"/>
<element id="MiniPlayer.StarRating.Lowlight" fg="50,50,50"/>
They are actually present in lines 151 and 152 having these values:
Code
<!-- 99--> <element id="MiniPlayer.StarRating.Default" bg="141,136,126" fg="223,228,229"/>
<!-- 100--> <element id="MiniPlayer.StarRating.Lowlight" fg="51,57,56"/>

I'm going to take a look for keeping only one of the lines 83 and 85, thanks

lnminente

  • Sr. Member
  • ****
  • Posts: 1049
I have fixed it too and created a collaborative online document with the colours part of the dummy skin. Anyone should be able to editing it for any improvement. It's here: http://piratepad.net/U1JHY5UGcZ

jistme

  • Guest
Sorry, missed that, xml brain overload ;-)

- these two might be handy:
<element id="MiniPlayer.StarRating.Default" bg="125,125,125" fg="175,175,175"/>
<element id="MiniPlayer.StarRating.Lowlight" fg="50,50,50"/>
They are actually present in lines 151 and 152 having these values:
Code
<!-- 99--> <element id="MiniPlayer.StarRating.Default" bg="141,136,126" fg="223,228,229"/>
<!-- 100--> <element id="MiniPlayer.StarRating.Lowlight" fg="51,57,56"/>