Author Topic: Additional Tagging & Reporting Tools  (Read 928372 times)

boroda

  • Sr. Member
  • ****
  • Posts: 4595
- will check the issue. all this escaping is too complex. i'm afraid we wont succeed to find all possible bugs.
- 'delete all' always worked this way. i think i'll add 'delete preinstalled' button.

redwing

  • Guest
For me, "delete all" always deleted non-custom presets and only left custom presets in AppData folder. Very useful.
If I want to delete a custom preset, used "delete" button. As I said this has changed since you updated all presets.

boroda

  • Sr. Member
  • ****
  • Posts: 4595
now its evening at moscow, dont want to inspect the code, had a quick look at it and, yes, 'delete all' wont just delete all presets, there are something more sophisticated, but haven't changed this code for ages. there are some comparison of various dates/times, i think i'll change it to just delete non-custom presets (every preset has a flag if its custom, which cannot be changed by users).


boroda

  • Sr. Member
  • ****
  • Posts: 4595
- Tried case conversion code, not working. The saved preset shows ^(.\*) instead of ^(.*)
- Since the previous version, "delete all" button in ASR window deletes all presets. I lost all my custom presets. Also the saved MSR presets shouldn't be deleted and need to be treated as custom presets.

http://www.mediafire.com/file/5t156t19ttpzzqz/mb_TagTools_2018-03-21-rc.zip

redwing

  • Guest
- If you have not imported any ASR presets and try to save a MSR preset, then you get this error:

System.NullReferenceException: Object reference not set to an instance of an object.
   at MusicBeePlugin.AdvancedSearchAndReplaceCommand.Preset..ctor(Preset originalPreset, String presetNameSuffix, Boolean copyGuidIfsuffixAbsent)
   at MusicBeePlugin.MultipleSearchReplaceCommand.saveButton_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

But once it starts working after you have imported presets, then it keeps working even if you have no imported presets.

- Case code still doesn't work.

If I use \@tc($1)
the saved preset also has \@tc($1)

So I have to use \\@tc($1)
then saved preset is working but MSR window still doesn't work (even preview is wrong).

- Checked escape sequences for meta-characters and all are working fine. Delete all button now doesn't delete custom presets plus MSR presets.

boroda

  • Sr. Member
  • ****
  • Posts: 4595
i'll make more meaningful error message if base msr preset is missing.

its strange, but both *^(.*)/\@tc($1) and *^(.*)/\\@tc($1) is working fine for me (i mean ASR).

msr window doesn't support asr functions. its intended, but probably should be fixed.

redwing

  • Guest
You mean the user should import MSR preset first to make the command save a preset?
Can't it just use the preset in plugin folder even if it's not imported?

redwing

  • Guest
Also I noticed remove leading zeros presets (both of them) have a bug.
If a file has no target tag (track#), it writes "SYNTAX ERROR" to the tag.

boroda

  • Sr. Member
  • ****
  • Posts: 4595
You mean the user should import MSR preset first to make the command save a preset?
yes. don't want to change this behavior.

its strange, but both *^(.*)/\@tc($1) and *^(.*)/\\@tc($1) is working fine for me (i mean ASR).
i'll leave it as is, but MSR now saves escaped ASR functions.

Also I noticed remove leading zeros presets (both of them) have a bug.
If a file has no target tag (track#), it writes "SYNTAX ERROR" to the tag.
will check it.

msr window doesn't support asr functions. its intended, but probably should be fixed.
its fixed.

http://www.mediafire.com/file/vu7nfex1vbq9t4e/mb_TagTools_2018-03-21.zip

boroda

  • Sr. Member
  • ****
  • Posts: 4595
Also I noticed remove leading zeros presets (both of them) have a bug.
If a file has no target tag (track#), it writes "SYNTAX ERROR" to the tag.
actually its very serious bug, which concerns almost all presets, especially its risky for auto-applied presets. thanks for this finding! now asr wont write SYNTAX ERROR! to tags (though it still will display this message in preview table).

http://www.mediafire.com/file/vu7nfex1vbq9t4e/mb_TagTools_2018-03-21.zip

redwing

  • Guest
Case code is working, but noticed a very strange bug.

Try this with MSR preset

*(in\|of\|on)/\\@lc($1)

Those words are not working. If you use other words, or with @tc, it's working.


redwing

  • Guest
It worked fine before you started working on MSR command. Must be an introduced bug.

redwing

  • Guest
now asr wont write SYNTAX ERROR! to tags (though it still will display this message in preview table).

Yep, it's fixed. Thanks!