Author Topic: Bitmap skin support for 125% Windows scale?  (Read 2214 times)

T010

  • Jr. Member
  • **
  • Posts: 44
Hello,
I'm in the process of creating a custom bitmap skin but one thing that nags me are the blurry custom icons. Yes, I do provide 3 dpi variants for each image (100% 150% 200%)

My Windows is set to the recommended 125% scale on a non-retina monitor, but MusicBee accepts only either 100% or 150% scale images, while upscaling -- and thus making unsharp -- the provided 100% image if Windows is set to 125%.

Could there be an option/update to MusicBee that either allows skin creators to provide a 125% version of each custom icon, or an update that makes MusicBee downscale any provided 150% icon to the 125% Windows scale.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34416
I have updated the skin creator to support 125%
http://www.mediafire.com/file/9lawezbun0xac76/SkinCreator.zip/file

however while looking at this i discovered MB is doing something silly and only using the 200% images. This fixes that
https://getmusicbee.com/patches/MusicBee35_Patched.zip
unzip and replace the existing musicbee application files

T010

  • Jr. Member
  • **
  • Posts: 44
Wow that is some quick support! Thank you very much, the icons indeed looks sharp at 125% now. And I didn't even provide dedicated 125% variants yet. So I assume you downscale the 150 or 200 variants as of now. Nice!

However, some bugs were introduced. The preview inside the SkinCreator appears fine, but once saved and opened in MusicBee itself, these bugs appear. From what I can see, it affects the main player controls panel, where most of the custom icons no longer respect their on/off states; plus sizing issues where some button states don't respect the 125% setting but scale down to a 100% version. PlayPause button is showing Pause state only. Volume slider is kinda broken. Love button (in not-loved state) is replaced by Banned button.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34416
Can you send me a link to the skin creator folder so i can see for myself.
I only added 125% to the skin creator so not expecting any of the bugs you state

T010

  • Jr. Member
  • **
  • Posts: 44
I just unzipped and copied the SkinCreator.exe file from the above link into my skin folder (along with the two dll files, but those don't seem to cause the issue as I also tried their older versions I had previously unzipped).

However, using my older SkinCreator.exe -- thus not using the above supplied SkinCreator update -- the icons in MusicBee are just how they were/are supposed to be. And because the latest MB patch downscales the 150% icons for 125% users just fine, I think you/we should not bother with creating separate _125 icon variants

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34416
somehow an old .exe was included. I have updated the same link with the new skincreator.exe

T010

  • Jr. Member
  • **
  • Posts: 44
Oops! haha, works fine for me now. Thanks
Last Edit: August 26, 2022, 10:03:12 AM by T010

T010

  • Jr. Member
  • **
  • Posts: 44
I found that using this latest SkinCreator, MB will no longer downscale higher dpi (150% 200%) icons to 125% users; whilst the older SkinCreator did exactly that just fine.
So while the latest SkinCreator does indeed support 125% images, when a skin creator does not provide those, but does provide 150% 200% images, MB will show and upscale the 100% image to 125% users - getting us back where we started: with blurry icons  :-\

I think MB should check if 125% is provided, then use those. If 125% is not provided, use 150% (or 200%) and downscale that.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 34416
it would be helpful if you PM me a link for the skin creator files that are your source if you dont want to post a link here.
The logic to choose which size icon to use is in MB itself, not the skin creator. And the most recent MB versions should choose the next highest image to downscale
Last Edit: August 21, 2022, 10:07:54 AM by Steven