Author Topic: LyricsReloaded (Latest)  (Read 71108 times)

hiccup

  • Hero Member
  • *****
  • Posts: 8013
Hm, this seems to work:

Code
- [regex, 'Letra\sde.*com.*\n', ""]
But please review/test it before possibly adding it, I'm not completely confident in what I am doing here…
Last Edit: November 06, 2022, 04:24:42 PM by hiccup

Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
Yep, that does the job.
This is what I used but what you came up with works well too.

Code
- [regex, 'Letra de &quot.*?<br/><br/>', ""]

The additions have been included in both Genius providers (v1.2.0.4 has that change).
And thanks for the info on the edit section of the previous post - will certainly be using that.
The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
Code
- [regex, 'Letra de &quot.*?<br/><br/>', ""]
Have you tested it on the tracks I mentioned? It doesn't work for me?

Quote
And thanks for the info on the edit section of the previous post - will certainly be using that.
Ideally the plugin engine would just ignore empty lines (containing spaces or tabs) when loading yml's. But I'm not sure if that's easy to do.

Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
Have you tested it on the tracks I mentioned? It doesn't work for me?
I only had a look at Simone's Mal acostumado and it had worked.
Let me see with the rest.
The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
Aren't <br/><br/> html codes?
Just to make sure we're on the same page: I added the regex line under post-filters.
Are html codes within a regex working there too?


Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
Aren't <br/><br/> html codes?
Just to make sure we're on the same page: I added the regex line under post-filters.
Are html codes within a regex working there too?
Yes and yes to both questions.
The plugin retrieves the webpage content in html format.

The Letra de "..." com ... line appears like this along with the lyrics.


I can't say for sure but from previous tests, I think both "/n" and "<br>" usually match the same thing.
In some yml's, I've noticed the two being used interchangeably.
But just to be on the safe side, I always prefer using <br> as its the one that always appears when I inspect the source code of the webpage.

To get some clarity also, are you saying the Genius providers in v1.2.0.4 do not remove that line
or that the same regex I used in the post-filters section isn't working for you?
The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
To get some clarity also, are you saying the Genius providers in v1.2.0.4 do not remove that line
or that the regex you came up with and included to the post-filters section isn't working for you?
All I did was replacing the line that I had created (see screenshot) with the one that you posted.
I'll now download the updated version of LR and see what happens…

Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
Oh I see what's wrong now.
When adding that line on my side, I added the regex above the br2nl (i believe it's a filter that replaces <br> tags with new lines automatically).

So on your side, the <br> tags were most likely stripped before the regex line could do its thing.
Add it above br2nl and it should work.
The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
The downloaded version seems to work fine indeed.
The only difference in the YML that I can spot right now is that '- br2nl' switched positions and is now lower in the chain?
Could that be it?

Ah well, it's working, thanks for your troubles again, case closed ;-)

edit:
So that was it indeed ;-)

Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
Yeah, I kinda made things complicated for no reason.
I should have just used the one you provided since it would work fine regardless of its position in the filters section.
The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
Well, far as I understand your version will be rock solid.
My version might fail in case some lyric happens to have 'Letra and com' in one line as an actual lyric.
That's probably a chance of one in a zillion, but still…

Please keep doing you ;-)

Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
By the way, the UDL you are using for editing your providers in Notepad++ , did you ever share it anywhere on the forum?
I redownloaded your other three, but none of them seem to be designed for yml's.

All along, I've been hurting my eyes with the default white that Notepad++ offers.
I would very much appreciate using your colours going forward. Care to share the UDL?

The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
I would very much appreciate using your colours going forward. Care to share the UDL?
So you are using Notepad++ also?
I haven't received that much feedback on the NPP UDL's that I have shared, so my attention to maintaining that is not that high.

I just PM'ed you a link to my 'LyricsReloaded' UDL.
It's very basic without much 'clever' mechanisms though.
(well, maybe I'm selling myself short here; try adding a comment, I made some effort in having those displaying nicely too)

Let me know if you like it, and if you have suggestions for improvements?

Perhaps I will share it publicly later, but it's probably too niche for that.
Last Edit: November 06, 2022, 08:32:54 PM by hiccup

Mayibongwe

  • Sr. Member
  • ****
  • Posts: 1139
  • Heal The World
Sorry for the late response.
No room for improvements, it's perfect as it is.

Just to visualize what I was seeing before and what I am now (courtesy of hiccup's UDL)
The source code to any of my contributions is available on the same download link as the add-ons

hiccup

  • Hero Member
  • *****
  • Posts: 8013
Just to visualize what I was seeing before and what I am now
That's great to hear.
Just curious: did you add the highlighting for xml comments yourself?
It's probably not a problem to use those for the LyricsReloaded plugin, but far as I know yml uses # to comment things out.
So that's what my udl is using too.

edit:
Did you use the most recent version that I pm'ed you?
I notice a small difference with my version. (that will format commas also)
Last Edit: November 20, 2022, 03:01:12 PM by hiccup