2. What's the etiquette when modifying someone elses plugin and making it available to everyone else? It's completely based on Boroda's source code and no way I could have done it from scratch. But I have modified the code quite a bit and I think anyone still rocking an iPod will like the changes I have made, especially if they have a large library.Common etiquette is to discuss it with the original developer of the plugin. Boroda seems to appear on the fourm every three or four months and it looks like he was online today. I suggest a PM to him and hope for an answer.
I'll give that a crack when I've finished. I'm pretty much done except for the query above about Sync_FileStart()
Is there a better place to ask or do I just have to hope Steven sees this eventually? I understand he doesn't spend all day on the forums. I just want to make sure I'm posting in the right place. I'll give some more info anyway so he knows what I'm talking about.
In the orginal code for this plugin, Sync_FileStart() and Sync_FileEnd() bookend the code that does all the sync work. From what I can gather, it's how the plugin sends the file to Musicbee to perform any conversions and display info to the user about the sync progress.
The issue is sometimes Sync_FileStart() returns a converted file when I have all the conversion options unticked. Also some of the files getting converted were ripped from CD with MusicBee and encoded with MusicBee's default encoder settings so I don't understand why it would think they need to be re-encoded at Sync time.
For now I have bypassed those 2 commands and just use MB_SetBackgroundTaskMessage to inform the user of the sync progress. It works fine but it means the user can't use the conversion options in MB and it also doesn't display a summary if a file fails to copy over at the end.
The files that previously got converted synced perfectly fine with iTunes in their original form so the conversion was unnecessary.
One other issue is it also doesn't display the correct counter at the top of the sync window when it's running. eg) instead of saying "35 of 36000 songs", it says "35 of No songs".
Personally I'm fine with how I have the plugin now because I won't be using the conversion options, but I figured if there was a bug it was worth looking into and other users might appreciate it.