Author Topic: LyricsReloaded (Updated)  (Read 164121 times)

frankz

  • Sr. Member
  • ****
  • Posts: 3834
I haven't changed anything besides adding / editing / deleting providers in a very very long time.  Certainly nothing related to the guts of how the plugin interacts with MB (because I don't know how).

I think MB treats the plug-in as one provider and then the plugin does what it does internally.  I'm inclined to believe it's always been that way.
Last Edit: December 13, 2020, 11:45:50 PM by frankz

sveakul

  • Sr. Member
  • ****
  • Posts: 2438
Thanks!  That choice must be looking outside the LRU plugin then, as you suggested.

Comtezero

  • Newbie
  • *
  • Posts: 4
Hi !
I'm now on the last version of the plugin.
I got a little problem with some lyrics
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Genius
16/12/2020 04:31:21 [INFO] Genius tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://genius.com/pain-of-salvation-unfuture-lyrics
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Musixmatch
16/12/2020 04:31:21 [INFO] Musixmatch tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://www.musixmatch.com/lyrics/pain-of-salvation/unfuture
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Cušpajz
16/12/2020 04:31:21 [INFO] Cušpajz tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://cuspajz.com/tekstovi-pjesama/pjesma/pain-of-salvation/unfuture.html
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Hindi Lyrics
16/12/2020 04:31:21 [INFO] Hindi Lyrics tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://www.hindilyrics.net/lyrics/of-Unfuture.html
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Letras de músicas
16/12/2020 04:31:21 [INFO] Letras de músicas tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://letras.mus.br/pain-of-salvation/unfuture/
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - MetroLyrics
16/12/2020 04:31:21 [INFO] MetroLyrics tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://www.metrolyrics.com/unfuture-lyrics-pain-of-salvation.html
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Musixmatch_Asian
16/12/2020 04:31:21 [INFO] Musixmatch_Asian tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://www.musixmatch.com/lyrics/Pain-of-Salvation/Unfuture
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Oldies Lyrics
16/12/2020 04:31:21 [INFO] Oldies Lyrics tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://oldielyrics.com/lyrics/pain_of_salvation/unfuture.html
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Smriti
16/12/2020 04:31:21 [INFO] Smriti tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://smriti.com/hindi-songs/unfuture
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Song Lyrics
16/12/2020 04:31:21 [INFO] Song Lyrics tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://www.songlyrics.com/pain-of-salvation/unfuture-lyrics/
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Teksty
16/12/2020 04:31:21 [INFO] Teksty tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://teksty.org/pain-of-salvation,unfuture,tekst-piosenki
16/12/2020 04:31:21 [DEBUG] Lyrics request: Pain of Salvation - Unfuture - Panther - Urban Lyrics
16/12/2020 04:31:21 [INFO] Urban Lyrics tries to load the lyrics...
16/12/2020 04:31:21 [DEBUG] The constructed URL: http://www.urbanlyrics.com/lyrics/painofsalvation/unfuture.html
16/12/2020 04:31:21 [INFO] No lyrics found.
16/12/2020 04:31:21 [DEBUG] no lyrics found from Smriti
16/12/2020 04:31:21 [DEBUG] gzip compression detected
16/12/2020 04:31:21 [DEBUG] gzip compression detected
16/12/2020 04:31:21 [WARN] The pattern <font face="verdana">(?<lyrics>.*?)</font> didn't match!
16/12/2020 04:31:21 [INFO] No lyrics found.
16/12/2020 04:31:21 [DEBUG] no lyrics found from Hindi Lyrics
16/12/2020 04:31:21 [WARN] The pattern <p\sclass="text\sclearfix">(?<lyrics>[\s\S]*?)</p> didn't match!
16/12/2020 04:31:21 [INFO] No lyrics found.
16/12/2020 04:31:21 [DEBUG] no lyrics found from Cušpajz
16/12/2020 04:31:21 [DEBUG] gzip compression detected
16/12/2020 04:31:21 [WARN] The pattern <div\s+class="songText"[^>]*>(?<lyrics>.*?)</div> didn't match!
16/12/2020 04:31:21 [INFO] No lyrics found.
16/12/2020 04:31:21 [DEBUG] no lyrics found from Teksty
16/12/2020 04:31:21 [DEBUG] gzip compression detected
16/12/2020 04:31:21 [WARN] The pattern <div id="lyrics-body">(?<lyrics>.*?)</div> didn't match!
16/12/2020 04:31:21 [INFO] No lyrics found.
16/12/2020 04:31:21 [DEBUG] no lyrics found from MetroLyrics
16/12/2020 04:31:21 [DEBUG] gzip compression detected
16/12/2020 04:31:21 [DEBUG] gzip compression detected
16/12/2020 04:31:22 [INFO] No lyrics found.
16/12/2020 04:31:22 [DEBUG] no lyrics found from Oldies Lyrics
16/12/2020 04:31:22 [DEBUG] lyrics found from Musixmatch!
16/12/2020 04:31:22 [DEBUG] lyrics found from Musixmatch_Asian!
16/12/2020 04:31:22 [INFO] No lyrics found.
16/12/2020 04:31:22 [DEBUG] no lyrics found from Song Lyrics
16/12/2020 04:31:22 [DEBUG] gzip compression detected
16/12/2020 04:31:22 [WARN] The pattern <div id="div_letra"[^>]*>(?<lyrics>.*?)</div> didn't match!
16/12/2020 04:31:22 [INFO] No lyrics found.
16/12/2020 04:31:22 [DEBUG] no lyrics found from Letras de músicas
16/12/2020 04:31:22 [DEBUG] gzip compression detected
16/12/2020 04:31:22 [WARN] The pattern <div class="lyrics">(?<lyrics>[\s\S]*?)</div> didn't match!
16/12/2020 04:31:22 [INFO] No lyrics found.
16/12/2020 04:31:22 [DEBUG] no lyrics found from Genius

As you can see http://genius.com/pain-of-salvation-unfuture-lyrics get me to the lyrics but it seems the plugin doesnt find them.

frankz

  • Sr. Member
  • ****
  • Posts: 3834
I do not know why that would be.  I have just tested Genius from here and it works just fine.  Maybe there's some regional difference to the way Genius presents their pages?  I don't know.

When you view source on the lyrics page and see this...
Code
        <div class="lyrics">
          
            <!--sse-->

...then the pattern matches.  Looking here, it's there on the page you provided.  If it's different where you are (total speculation as to the reason) then Genius will never match the lyrics and you'll have to create a custom YML that matches what you see at the start of the plain text lyrics.

If it's not working consistently for you, I'd suggest moving one of the other providers that does work higher in the list.  It seems Musixmatch also found lyrics for this song.



Comtezero

  • Newbie
  • *
  • Posts: 4
https://imgur.com/a/dVjrV9F

here, it's inside the multiple div with class "Lyrics__Container..."
So there's like one verse inside the first one, one into the second one and so on...

frankz

  • Sr. Member
  • ****
  • Posts: 3834
I'm sorry, I don't know any other way to express "View Source" or "Plain Text Lyrics"



Like I said, if it's different where you are, though, you will have to create a custom YML to handle your specific situation.

hiccup

  • Sr. Member
  • ****
  • Posts: 7790
I am confused:
Setting up a clean install I thought to try out what results the different providers give for a selection of tracks in my library so I could decide on enabling/priorities for the available providers.
So I thought to enable only one provider at a time and see what results they give.

But after trying the third one I noticed the results were exactly the same for all three providers I had tried.
The same songs got lyrics, the same ones didn't get lyrics, and the same ones got wrong lyrics.

Am I doing something wrong or am I misunderstanding something?
Or maybe a coincidence, and should I try them all one by one?


frankz

  • Sr. Member
  • ****
  • Posts: 3834
Lolo and chartlyrics are not in this plugin

Quote
Current Providers
Cušpajz
Genius
Letras de músicas
Metrolyrics
Musixmatch_Asian
Musixmatch
Oldies Lyrics
Smriti
Song Lyrics
Teksty
Urban Lyrics
Hindi Lyrics

What does the log say?

hiccup

  • Sr. Member
  • ****
  • Posts: 7790
Lolo and chartlyrics are not in this plugin

What does the log say?

Ah, so the first two are defaults in MusicBee.
And even if they are not enabled in the settings, they still get sourced.
And… always as top priority before any providers you have actually enabled and set as priority.
Strange, but am I correct in thinking this is how it works?

Also strange: I have not checked 'save lyrics'.
And yet after a restart the lyrics are still there.
Any clue where they are stored? In the mbl file itself perhaps?
(in testing the providers this probably also resulted in me seeing lyrics that were already there and not freshly retrieved by the latest activated provider)

No need for going through the log at this moment I think?

frankz

  • Sr. Member
  • ****
  • Posts: 3834
I don't know how the sourcing works from MB to the providers other than the plugin is seen as one provider.

Lyrics are cached at /%AppData%/Local/MusicBee/InternalCache/Lyrics

hiccup

  • Sr. Member
  • ****
  • Posts: 7790
I don't know how the sourcing works from MB to the providers other than the plugin is seen as one provider.
Lyrics are cached at /%AppData%/Local/MusicBee/InternalCache/Lyrics

Thnx, I found the .dat files that contain the lyrics.
So that explains the identical results I saw for the providers I checked even with having 'save lyrics' disabled.
I wasn't expecting that lyrics are still being saved even when you have disabled saving them.

On a side note, even if you delete the music files from the library, the lyrics .dat files remain.
Probably not a big issue, but I would expect them to get deleted also.

Maybe MB's option 'reset artwork cache' could be enhanced with 'reset lyrics cache'.
I don't know, it's not really a big issue for me now I understand a bit better how things work.

But it does severely complicate testing which lyrics providers to enable/order.

And the caching stuff makes it hard (impossible?) to simply delete lyrics that are completely wrong.
Last Edit: December 29, 2020, 05:50:37 PM by hiccup

hiccup

  • Sr. Member
  • ****
  • Posts: 7790
Ah, so the first two are defaults in MusicBee.
And even if they are not enabled in the settings, they still get sourced.
And… always as top priority before any providers you have actually enabled and set as priority.
Strange, but am I correct in thinking this is how it works?

I now see they don't get sourced when they are disabled.
It was the cached lyrics.dat files that mislead me to believe this.

sveakul

  • Sr. Member
  • ****
  • Posts: 2438
hiccup you can take a look at the batch file I use to clear lyrics cache (last section of the code) and a few other things from a Portable install; maybe it can help. Modify to your taste:

Code
cd C:\MusicBee\AppData
del AlbumCoverHashes.dat &

cd C:\MusicBee\AppData\Dependencies\Spectrogram_Images
del *.* /q &

cd C:\MusicBee\AppData\mb_LyricsReloaded
del mb_LyricsReloaded.log &

@ECHO OFF

Set dir="c:\MusicBee\AppData\InternalCache\AlbumCovers"

Echo Deleting all files from %dir%
del %dir%\* /F /Q

Echo Deleting all folders from %dir%
for /d %%p in (%dir%\*) Do rd /Q /S "%%p"
@echo Folder deleted.

@ECHO OFF &

Set dir="c:\MusicBee\AppData\InternalCache\Lyrics"

Echo Deleting all files from %dir%
del %dir%\* /F /Q

Echo Deleting all folders from %dir%
for /d %%p in (%dir%\*) Do rd /Q /S "%%p"
@echo Folder deleted.

exit