Skinning Requests for 3.2

[redwing]

Thanks but it has couple of issues.

- It's not stable. The same skin shows the new grey wavebar and next time when it's loaded it shows its own black wavebar. Sometimes switching between wavebar and progress bar turns the color. Turning on and off of auto pick color option always brings its own color back.

- When the grey wavebar is drawn on the picture, if you disable "Draw controls on picture" option, the wavebar gets placed lower than it's original position. Switching to progress bar and switching back fixes it:



- Also the invisible track info issue with Cotton skin remains unresolved.

[redwing]

Or did you mean Compact.Player.Wavebar and Compact.Player.Wavebar.Inner shouldn't be used? I thought the new wavebar color would only be applied when it's drawn on the picture, but now it overrides separate player bar as well?

[Steven]

It wasn't resetting the colours or layout when switching "draw controls on picture".
Thats fixed now
https://getmusicbee.com/patches/MusicBee33_Patched.zip

[redwing]

Thanks! Now they're working great!

Probably last issue regarding compact mode. Lengthy title overlaps with rating.

[redwing]

Lengthy title overlaps with rating.

It happens only with wavebar and works fine with progress bar. Why not make it consistent?

[Steven]

It happens only with wavebar and works fine with progress bar. Why not make it consistent?

of course - it's fixed for the next update

[Steven]

https://getmusicbee.com/patches/MusicBee33_Patched.zip

[redwing]

Looks fine now. Thanks!

[redwing]

Can you fix one more thing about compact mode?

It's the position of play/pause button which needs to move 1px left both in wavebar and progress bar mode.

[Steven]

its just the (non-slim) pause button that needs adjustment right? the play button itself looks fine to me

[redwing]

Play button with wavebar looks fine but play button with progress bar needs to move left.

[redwing]

The non-slim pause button for click to play in album covers view has the same issue.

[Steven]

I believe all the issues should be resolved now:
https://getmusicbee.com/patches/MusicBee33_Patched.zip

[redwing]

Yep, all looks fine now. Thanks!

[Bee-liever]

Could the auto-highlight for left/right panel collapse/expand icon be tweaked?

Default:


Highlight:


Currently it works:

• OK for mid-coloured foregrounds on light backgrounds;
• excellent for mid-coloured foregrounds on dark backgrounds;
• but no change on bright foregrounds on light backgrounds;
• not very good for dark foregrounds on mid-coloured backgrounds.

I'll leave it to you to decide if the algorithm can be tweaked for suitability for all cases or whether adding fg2 override to the elements

Code

<element id="Panel.StatusBarControl.Default" fg="49,58,23" fg2="250,0,0"/>
<element id="Panel.StatusBarControlInPanel.Default" fg="158,168,132" fg2="250,0,0"/>
<element id="Panel.StatusBarControlBelowPlayer.Default" fg="42,52,20" fg2="250,0,0"/>

would be better, to only be used as needed.