Undo?

[redwing]

Nothing unusual from the logged info?

Edited "Best For Last" to "Best For Last Last"

9/29/2013 9:53:50 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,save title=Best For Last
9/29/2013 9:54:00 AM - undo batch count=1
9/29/2013 9:54:00 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,current title=
9/29/2013 9:54:00 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,restoring title=Best For Last
9/29/2013 9:54:00 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,restored title=Best For Last
9/29/2013 9:54:00 AM - saving 1
9/29/2013 9:54:00 AM - saved

The title is still "Best For Last Last"

Why was the current title left empty?

[Steven]

this logs a bit more info:
http://www.mediafire.com/?f0ebsy291jnc22c

also i wonder if you have any plugins running that might intefere in some way eg. the tags tool plugin might somehow be updating files in response to an edit

[redwing]

Look at this.

I changed "Someone like You" to "Someone like You You." But it's logged as follows.

9/29/2013 10:50:12 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,save title=Someone like You

At this point, when looked from mp3tag, the filename is already "Someone like You You.mp3", but MB logged wrong info.

Now doing undo.

9/29/2013 10:50:47 AM - undo batch count=1
9/29/2013 10:50:47 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,current title=
9/29/2013 10:50:47 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,restoring title=Someone like You
9/29/2013 10:50:47 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,restored title=Someone like You
9/29/2013 10:50:47 AM - saving 1
9/29/2013 10:50:47 AM - saved

No changes in title, it's still "Someone like You You."

Now I edited the title to "Someone like You"

It's logged as follows:
9/29/2013 10:51:11 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You You.mp3,save title=Someone like You You

So it's always one step behind.

[redwing]

So basically it is trying to edit a non-existent file. That's why undo doesn't work.

(I'll be back in an hour)

[Steven]

ok, so you have your library auto-organised, so the filename changes because the title has changed.
If you do run the new debug version from above that could confirm it but it sounds a likely reason

[redwing]

The debug version was the same one. I tried with the new one before. So the log is the same as the previous. Again, no changes.

9/29/2013 11:47:55 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,save title=Someone like You
9/29/2013 11:48:31 AM - undo batch count=1
9/29/2013 11:48:31 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,current title=
9/29/2013 11:48:31 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,restoring title=Someone like You
9/29/2013 11:48:31 AM - E:\Music Files\Pop\A\Adele\21\11 Someone like You.mp3,restored title=Someone like You
9/29/2013 11:48:31 AM - saving 1
9/29/2013 11:48:31 AM - saved

[Steven]

no matter as file renaming would create an issue - this should fix the issue if thats what it is in your case:
http://www.mediafire.com/?88152a66tya4a5t

[redwing]

Now it's working. Tested with a few fields and artwork, and all worked well. Thanks!

[Steven]

thank you for finding that issue!
this version also includes a hotkey "Edit: Undo Tags"

http://musicbee.niblseed.com/V2_2/MusicBee_Exe_Patched.zip

[redwing]

Thanks!

BTW is "auto-tag by track" not undoable? I ran one, but the menu UI says "Undo - Auto-tag by Track - No files." And running undo didn't make any changes.

[Steven]

its been tested and should work. I guess your auto-tag operation didnt change anything so i can tweak it so it doesnt show in the undo list operations with no updates

[redwing]

You're right. Some fields were changed but now I remember it said updated with error. Tried again with the fully updated file, and undoing it worked like a charm. Thanks!

<edit> I thought about that, and probably that's the moment the user really needs undo when auto-tag ended up with partial updating and errors. If that can't be supported, that's fine. But please have a look.

[Steven]

any files that have been updated, even if it updated one file only and then the auto-tag operation failed, you should still be able to undo the changes. The undo list updates at the same time as when a file is updated. I would expect in your test none of the files were updated in that case.
I have updated the link so it excludes auto-tag operations with no updates.

[redwing]

I would expect in your test none of the files were updated in that case.

Did some more tests, and, you're right, the file was not updated.

When auto-tag by track ended up with a message "Auto-tag completed with errors," often it updates some field only for main panel and/or tag editor. But tag inspector shows that's not a real value. Select file> right-click> Send to> File Rescan reverts it to the previous, real value for main panel and/or tag editor. Is this a bug?

If I run undo with the fake value displayed, MB says the file is no longer existent. If I remove the dead link, a right one shows up. So undo is working fine even in such cases.

[Steven]

When auto-tag by track ended up with a message "Auto-tag completed with errors," often it updates some field only for main panel and/or tag editor. But tag inspector shows that's not a real value. Select file> right-click> Send to> File Rescan reverts it to the previous, real value for main panel and/or tag editor. Is this a bug?

what is the error for that in the error log?