Author Topic: Undo?  (Read 19516 times)

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10318
It works for me!  The only issue I see so far is that when I have the tag editor in the main panel, save a change and then undo it, the contents of the tag editor don't go back until I refresh or rescan the file.

I trust it will be possible to assign this to a hotkey once it's been tested for a while?  (Is there a hotkey for saving changes in the tag editor?  If not, that would be awfully nice, too.)
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest beta patch (3.4)
(Unzip and overwrite existing program files)

redwing

  • Guest
1. Edited track title either from main panel or with tag editor.
2. Saved.
3. Edit> Undo> File Tags: Edit - 1 file
4. No changes.

The track is not a playing track. What am I doing wrong?

psychoadept

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10318
1. Edited track title either from main panel or with tag editor.
2. Saved.
3. Edit> Undo> File Tags: Edit - 1 file
4. No changes.

The track is not a playing track. What am I doing wrong?

It doesn't sound like you're doing anything different from me.  I tried it both ways, too, just to be sure.  Hmm.  Just trying to think what else might be different.  Node, view...?
MusicBee Wiki
Use & improve MusicBee's documentation!

Latest beta patch (3.4)
(Unzip and overwrite existing program files)

redwing

  • Guest
Tried with several files in different views, from no filter node, different filters,...
I don't see any changes. File Rescan doesn't help either.

redwing

  • Guest
Perhaps only 1 undo for the most recent edit action only would suffice? - that would keep the UI simple

BTW I thought he meant per track, but now I realized it was for all.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 32050
i guess i will need to give you a debug version which i will do later today if you are happy to run it

redwing

  • Guest
i guess i will need to give you a debug version which i will do later today if you are happy to run it

Sure. Thanks!

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 32050
before i do that can you confirm by re-editing the file and checking with the tag inspector that the tags really are not restored? I am having trouble seeing how it could not work other than a display bug perhaps

redwing

  • Guest
Confirmed with several tests after the tag was edited (changed) and after running undo (no changes).

redwing

  • Guest
BTW this is what I see from the menu UI.

- "Edit - No files"
- Edited one file. Now it says "Edit - 1 file"
- Run undo, no changes in the tag, and it still says "Edit - 1 file"
- Once again running undo, no changes in the tag, and now it says "Edit - No files"


Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 32050
could you run this, edit the title only and then undo
info will be logged at the end of the error log
http://www.mediafire.com/?f0ebsy291jnc22c

redwing

  • Guest
Edited "Best For Last" to "Best For Last Last"

9/29/2013 9:53:50 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,save title=Best For Last
9/29/2013 9:54:00 AM - undo batch count=1
9/29/2013 9:54:00 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,current title=
9/29/2013 9:54:00 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,restoring title=Best For Last
9/29/2013 9:54:00 AM - E:\Music Files\Pop\A\Adele\19\02 Best For Last.mp3,restored title=Best For Last
9/29/2013 9:54:00 AM - saving 1
9/29/2013 9:54:00 AM - saved

The title is still "Best For Last Last"

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 32050
i'm sorry redwing but i dont think i can help any further with that

redwing

  • Guest
Tried with no settings file. Just the same. So it's not about my settings.

I wonder if it's only me having this problem. Please report here if any of you have the same problem.

Steven

  • Administrator
  • Hero Member
  • *****
  • Posts: 32050
you might also check that the file is being updated in windows explorer and see what mp3tag says, although it should always give the same results as the tag inspector