Heya,
I tried this again and it now occasionally works, but never on first attempt on my test as an undo action should (imo).
An example (this happened 5+ times when I was testing this):
- Rated a flac file with 5 stars (= value of 100)
- checked it's written to file (via 'Tag Inspector')
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
Then, after the above:
- Rated an .mp3 file with 5 stars (= value of 255 )
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- BUT NOW the menu entry "executed Edit->Undo ->" does read "File Tags: No Changes"
Sometimes it did this (3 times when I was testing this):
- Rated a flac file with 5 stars (= value of 100)
- checked it's written to file (via 'Tag Inspector')
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- rating value was undone correctly
Occasionally it did this as well (2 times when I was testing this):
- Rated a flac file with 5 stars (= value of 100)
- checked it's written to file (via 'Tag Inspector')
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
Then, after the above:
- Rated an .mp3 file with 5 stars (= value of 255 )
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- NOW suddenly both tags have been re-set to the previous value (= value of 1 = 1 star repectively )
And on one occasion this happened:
- Rated a flac file with 5 stars (= value of 100)
- checked it's written to file (via 'Tag Inspector')
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
Then, after the above:
- Rated an .mp3 file with 5 stars (= value of 255 )
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- nothing happened.
- executed Edit->Undo -> "File Tags: Rating - 1 file"
- NOW suddenly ONLY the mp3 tag has been re-set to the previous value (= value of 1 = 1 star repectively )
It's funny though - for all other metadata value edits (Artist, Album as well as completely custom fields like my own 'Instrumental' field) 'undo' works without any problems.. it's only undo-ing the Rating field value change that seems to be completely erratic.
Cheers.
c.
ps. I just tested this after I updated to 3.1.6336 with the latest patch.
pps. on further testing, there's some more consistency to this.
Looks like the first step hardly ever does ever undo anything, but consecutive undo do seem to mostly work (unless it looses its' undo queue completely).
I now was able to set 5 different ratings (from a flac file with no rating at all, I changed rating to: 5, then 1, then 4, then 2, then 3 [stars]). And all of which, but the last was correctly undo-able a few times, but it never remembered the last step, i.e. that the file actually had no rating in the beginning... so once it was back to 5 stars, there was no undo queue anymore.
Could it be that the initial rating value of the file contributes to the erratic ness ? I.e. I seem to see more consistent behaviour if I only test with files that do have a rating from the start... if it has no rating at all, things seem to go the erratic route more often.