getmusicbee.com

General => MusicBee Wishlist => Topic started by: Kaelri on May 01, 2012, 04:09:54 AM

Title: Disable Menu Bar in Caption Area
Post by: Kaelri on May 01, 2012, 04:09:54 AM
I understand the logic behind this change, but having the menu bar in the caption area is really not appropriate for all Windows themes. On my system, for instance, it looks like this:

(http://kaelri.com/temp/fora/SSmusicbeemenucaption.png)

I would really appreciate the option to either restore the traditional menu bar, or perhaps to have the new menu bar hidden unless the Alt key is pressed (consistent with Windows Explorer's menu behavior in Vista/7).
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 02, 2012, 08:07:50 PM
i suspected some people might not like having the menus done this way.
One option i am considering is to auto-hide the menu so it only appears when the mouse in the caption bar area (for both skinned and non-skinned borders) - i dont think the menu is so commonly used that it would inconvience doing it this way. I dont think using the Alt key being pressed would work well as thay can be used as part of a hotkey.
Does anyone have any strong views or suggestions on this? Of course i could just add an option to have the menu not displayed in the caption bar
Title: Re: Disable Menu Bar in Caption Area
Post by: mikebo on May 02, 2012, 09:16:20 PM
Maybe a menu button like in firefox and opera

(http://i.i.com.com/cnwk.1d/i/tim/2011/01/14/Firefox_4_beta_9_and_8_menu_button.png)
Title: Re: Disable Menu Bar in Caption Area
Post by: Alexis on May 03, 2012, 12:06:25 AM
I like Mikebo's suggestion.  Seems like a number programs taking that approach.  The skins I use work well with current configuration, but seems like the suggested approach could address it very well.
Title: Re: Disable Menu Bar in Caption Area
Post by: ma_t14 on May 03, 2012, 12:31:29 AM
+1 but make it optional

But when enabled make it so that tabs appear in the title bar to conserve space, that is the next natural step I think.
Title: Re: Disable Menu Bar in Caption Area
Post by: Kaelri on May 03, 2012, 04:04:44 AM
One option i am considering is to auto-hide the menu so it only appears when the mouse in the caption bar area (for both skinned and non-skinned borders) - i dont think the menu is so commonly used that it would inconvience doing it this way.
I think this is a fine solution. :)

I'm not as wild about the button idea. To me, the point of not skinning window borders in the first place is to make MusicBee more visually consistent with the rest of Windows. Having any elements in the caption area detracts from this goal. However, a button would certainly be smaller and less conspicuous than the whole menu.
Title: Re: Disable Menu Bar in Caption Area
Post by: Blinghound on May 03, 2012, 01:49:37 PM
Viewing this thread made me realize that the skin setting 'AutoHideMenu' does not function as it used to, is this due to the recent changes made to the caption bar? Thank you
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 04, 2012, 07:25:15 PM
Viewing this thread made me realize that the skin setting 'AutoHideMenu' does not function as it used to, is this due to the recent changes made to the caption bar? Thank you
its only enabled that way when the player panel is on the top but i am going to change it so the menu docking is configurable from the View menu (dockable in the caption bar, below the caption bar or auto-hidden)
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 05, 2012, 02:29:27 PM
this has the customisation for the menu dock
it can be set in the Layout preferences or the View main menu

also should show the menu text clearer than before when docked in the windows glass caption area
http://musicbee.niblseed.com/V2/MusicBee_Exe_Patched.zip
Title: Re: Disable Menu Bar in Caption Area
Post by: Kaelri on May 05, 2012, 04:21:30 PM
Perfect! Thanks so much for responding to our feedback. I know your time is limited these says.

Only one small bug to report: when the menu bar is set to auto-hide, the MusicBee caption appears to be a little below-center, and the white glow around the letters is enforced even when the theme doesn't require it. Here's a screenshot (with a Notepad caption for comparison).

(http://kaelri.com/temp/fora/SSmusicbeecaption.png)
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 05, 2012, 05:43:40 PM
its easy to draw the text without the glow but i dont know how to determine if the theme should have text drawn without a glow.
Title: Re: Disable Menu Bar in Caption Area
Post by: Kaelri on May 05, 2012, 05:56:24 PM
In that case, I would suggest simply removing or reducing the glow. (It's not even used consistently by Microsoft applications in Aero default, so I doubt it would be missed here.)
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 05, 2012, 07:45:21 PM
i dont agree with having the text not glow for most people and it doesnt work when you have the window over a background of similar color to the text.
I have taken a guess at a condition for when text should not glow, so could you try this:

http://musicbee.niblseed.com/Patches/MusicBee.zip

if it doesnt work, could you let me know how you managed to get the caption bar a solid colour without using the windows basic theme so i can test it myself
Title: Re: Disable Menu Bar in Caption Area
Post by: Kaelri on May 05, 2012, 08:31:18 PM
No difference, unfortunately:

(http://kaelri.com/temp/fora/SSmusicbeecaption2.png)

This wasn't an issue before the menu bar change in last week's beta:

(http://kaelri.com/temp/fora/SSmusicbeecaption3.png)

That's why I assumed that it must have been a simple change. If it's not, though, I understand if you'd rather not spend time on it; this is kind of a niche issue, I realize.

I'm using the third-party "Shadow" theme for Windows (here (http://krissirk.deviantart.com/art/Shadow-for-7-148071499)), which requires patching a system files (patcher here (http://deepxw.blogspot.com/2008/11/universal-theme-patcher.html)). I can vouch for the safety of both of these utilities.
Title: Re: Disable Menu Bar in Caption Area
Post by: ma_t14 on May 05, 2012, 08:33:55 PM
...
I'm using the third-party "Shadow" theme for Windows (here (http://krissirk.deviantart.com/art/Shadow-for-7-148071499)), which requires patching a system files (patcher here (http://deepxw.blogspot.com/2008/11/universal-theme-patcher.html)). I can vouch for the safety of both of these utilities.

Does that mean that conventional themes won't exhibit this problem? If that is true, I think that having clear text in menu items is more important...
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 05, 2012, 09:49:26 PM
this issue is completed unrelated to the menu text clearness.
I have made one more attempt at this (i dont want to install anything that changes the windows system files so wont install the custom theme)

http://musicbee.niblseed.com/Patches/MusicBee.zip

if it still doesnt work (could you let me know), then you can edit MusicBeeSettings.ini
- exit the new MB version
- it will add on the 18th line
<SystemDisableGlow>false</SystemDisableGlow>
- restart, Help/Support/View Settings file
- keep the file open
- exit MB, and change the value to true and save
- restart and the text should not glow
Title: Re: Disable Menu Bar in Caption Area
Post by: Kaelri on May 05, 2012, 10:10:39 PM
Here's what I get with the new patch:

(http://kaelri.com/temp/fora/SSmusicbeecaption4.png)

When I disable the glow in MusicBeeSettings.ini, I get:

(http://kaelri.com/temp/fora/SSmusicbeecaption5.png)

Actually, I sort of like it that way. :D But I think the best solution would be to go back to the previous behavior, but allow users to manually disable glow in MusicBeeSettings.ini, if they so desire. (It obviously doesn't merit a place in the preferences GUI, since this issue probably affects only a tiny minority of users. I certainly don't mind doing a little plaintext tweaking.)

Thanks again for spending so much time on this. Your attention to detail really sets MusicBee apart.
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 05, 2012, 10:22:21 PM
hopefully this version should use the correct text colour when glow is disabled:
http://musicbee.niblseed.com/Patches/MusicBee.zip
Title: Re: Disable Menu Bar in Caption Area
Post by: Kaelri on May 05, 2012, 10:31:51 PM
Success!

(http://kaelri.com/temp/fora/SSmusicbeecaption6.png)
Title: Re: Disable Menu Bar in Caption Area
Post by: Alexis on May 07, 2012, 03:45:50 PM
Hi Steven

With this  change... if autohide is enabled,  it does not work on hover when in theatermode, so the 'close' button id not present.


update:

And on escaping Theatermode... it would  then not work in the main player unless the player is restarted.
Title: Re: Disable Menu Bar in Caption Area
Post by: mikebo on May 07, 2012, 04:38:58 PM
I'm also having issues

(http://i.imgur.com/rGniI.png)

there is a bright line across caption and the gap between menubar and panels is now bigger.
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 07, 2012, 06:28:16 PM
this should fix both the reported issues:
http://musicbee.niblseed.com/V2/MusicBee_Exe_Patched.zip

mikebo, i dont know how to get the glow exactly like windows does - i am following the microsoft suggested approach but it is a little different
Title: Re: Disable Menu Bar in Caption Area
Post by: Alexis on May 07, 2012, 06:33:23 PM
Thank you Steven.
Title: Re: Disable Menu Bar in Caption Area
Post by: mikebo on May 07, 2012, 07:55:54 PM
Thanks, it's fixed. Don't worry about the glow.

Another problem I've noticed is that the window decoration (aero glass or whatever) flickers black when the window is maximized.
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 07, 2012, 09:09:22 PM
it should be barely noticable now, however if too many glitches keep getting reported with this i might just revert to using the standard windows functionality for when the menu bar is docked below the caption bar. All that will mean is the application will need to be restarted when switching the menu dock

http://musicbee.niblseed.com/V2/MusicBee_Exe_Patched.zip
Title: Re: Disable Menu Bar in Caption Area
Post by: mikebo on May 07, 2012, 11:44:32 PM
It's much better now, Thank you.
Title: Re: Disable Menu Bar in Caption Area
Post by: Steven on May 08, 2012, 10:26:18 PM
i decided to change it so when the window borders are not skinned and you have the menu displayed below the caption bar then it will use the standard windows caption bar. The only small downside is MusicBee will need to be restarted when changing the menu dock. This version should also remove any flicker when the menu is auto-opened/hidden in a windows glass caption bar, with the small downside that when resizing the window will show black flickering when the menu is auto-hidden only. None of the above applies for skinned borders

http://musicbee.niblseed.com/V2/MusicBee_Exe_Patched.zip