getmusicbee.com

Support => Bug Reports => Topic started by: tjinc on May 16, 2023, 09:43:13 PM

Title: Rating Type Custom Tag Bug
Post by: tjinc on May 16, 2023, 09:43:13 PM
MusicBee version 3.5.8509 P

When displaying a custom tag of type 'rating' in the main panel all seems to work as expected, i.e. you can click on the stars to set the rating. However this field does not then work when used in criteria in auto playlists or playlist mixers.

It appears that clicking on the stars in the main panel sets tag values of 1 to 5 (1 for one star.....5 for five stars) but, when using this field as criteria in an auto playlist, it filters on tag values of 20 to 100 (20 for 1 star.....100 for 5 stars).

Note that if the values of 20 to 100 are manually entered via the Tag Editor window then the correct number of stars are displayed in the main panel and then any auto playlist using this field as a criterion contains the expected results.
Title: Re: Rating Type Custom Tag Bug
Post by: hiccup on May 19, 2023, 07:19:16 PM
Confirmed that it doesn't seem to work properly for auto-playlists.
Title: Re: Rating Type Custom Tag Bug
Post by: frankz on May 19, 2023, 08:32:13 PM
I use stars in my auto-playlists all the time and extensively and it appears to work fine.  

If I click three stars in the interface to rate a song, tag inspector shows a 60 rating.  

The one issue is in auto-playlists is that in some instances it shows the graphical stars and in some instances it shows the numerical ratings.  This appears to be a visual problem rather than an operational one, because it seems to work correctly either way, and if you look in the *.xautopf file for the playlist the proper numerical values are listed there no matter how it's displayed in the GUI.

It may be relevant that I store ratings in my files, not in the database.  OP doesn't mention how the ratings are being stored.
Title: Re: Rating Type Custom Tag Bug
Post by: hiccup on May 19, 2023, 08:43:08 PM
I use stars in my auto-playlists all the time and extensively and it appears to work fine.  
Am I wrong in assuming you overlooked this part?:

When displaying a custom tag of type 'rating'…
And also the title of the post ;-)
('custom' is the keyword here)
Title: Re: Rating Type Custom Tag Bug
Post by: frankz on May 19, 2023, 10:26:50 PM
I use stars in my auto-playlists all the time and extensively and it appears to work fine. 
Am I wrong in assuming you overlooked this part?:

When displaying a custom tag of type 'rating'…
And also the title of the post ;-)
('custom' is the keyword here)
Your assumption is not wrong.  Carry on.
Title: Re: Rating Type Custom Tag Bug
Post by: hiccup on May 19, 2023, 10:41:57 PM
Carry on.
Carrying on.
(as instructed)
Title: Re: Rating Type Custom Tag Bug
Post by: Steven on May 20, 2023, 06:11:56 AM
I am not sure this is a bug. How are you entering the custom tag value? If you are typing a value in the tag editor then you need to realise MB uses a 0-100 scale for ratings
So 4 stars will be represented as 80
Title: Re: Rating Type Custom Tag Bug
Post by: hiccup on May 20, 2023, 07:06:37 AM
Only speaking for myself on my brief testing this:

I set the rating in the main panel, track details:
(https://i.imgur.com/te4spZh.png)

And the auto-playlist editor asks for a star value, not a numeric value:
(https://i.imgur.com/XHubmoC.png)
Title: Re: Rating Type Custom Tag Bug
Post by: Steven on May 20, 2023, 07:12:55 AM
ok, so i can reproduce the issue when selecting a rating from the main panel
Title: Re: Rating Type Custom Tag Bug
Post by: tjinc on May 20, 2023, 07:37:24 AM
Yes, as Hiccup detailed and you have reproduced, clicking on the rating stars in the main panel is, or shows, the issue.
If you check the custom tag values after doing so you can see that they are set to 0 to 5 and not 0 to 100.
Title: Re: Rating Type Custom Tag Bug
Post by: Steven on May 20, 2023, 09:21:45 AM
This should fix the issue:
https://getmusicbee.com/patches/MusicBee35_Patched.zip
unzip and replace the existing musicbee application files
Title: Re: Rating Type Custom Tag Bug
Post by: tjinc on May 20, 2023, 10:28:09 AM
All looks good now, thanks.
Title: Re: Rating Type Custom Tag Bug
Post by: melsonic on January 14, 2024, 11:35:33 PM
I'm using the current MB version 3.5.8778 and have defined a custom tag of type rating (for danceability). I find the same issue as the initial poster. However, not with the auto-playlist editor, but with the "star selector" in the Browser column (1). This selector only displays a value range of 0 to 5 in 0,5 resolution.

I had therefore entered all "danceability" ratings not by clicking in the track list (2) which creates values in the 0-100 range, but as numeric values 1 to 5 in the Tag Editor (4). As the custom rating field in the track list displays both value ranges well, this has been working for me so far.

However, I had to find that it is not possible to program a filter (3) on my custom rating tag with values 0 to 5.

I conclude, that a custom tag range 0 to 100 is intended for all rating functions in MB.
Thus, the selector in the Browser column should be updated to work in that range, too.

Besides, MB is a great program!!
Thank you,
Wolfgang

PS.
Tried the patch you provided, yet it doesn't change anything. Since the current MB version is younger than the patch, it's been implemented in program already, I guess.

(https://i.imgur.com/mj07M85.jpg)
Title: Re: Rating Type Custom Tag Bug
Post by: Steven on January 16, 2024, 09:06:50 AM
this should fix the issue:
https://getmusicbee.com/patches/MusicBee35_Patched.zip
unzip and replace the existing musicbee application files
Title: Re: Rating Type Custom Tag Bug
Post by: melsonic on January 16, 2024, 07:59:16 PM
Hi Steven, appreciate the support.

Unfortunately, patch35 didn't change the situation. Also, this seem to be the same patch files you had provided May 20, last year. I had tried this already.

Let me demonstrate again: I created a "test" rating tag from scratch and used it on a single file:

In "Case 1" I set a value by clicking 4 "test" stars in the track list.
Result: "4" stars in the track list, numeric value "80" in the tag editor, "5" stars in the column browser (which is an error).
=> The column browser cannot display the value "80". It needs values between 0 and 5 to operate correctly.

In "Case 2" I set a value of "3" in the tag editor.
Result: "3" stars in the track list, numeric value "3" in the tag editor (of course), "3" stars in the column browser
=> column browser works correctly this way, i.e. in numeric range 0 to 5.

As a sidenote: It is remarkable, that the rating field in the track list shows the correct number of stars in "0 to 5" and also in "0 to 100" range.

I use the custom rating tag that I created in my library to rate "danceability" like case 2. This way the column browser works properly.
However and as previously posted, it is not possible to create a library filter with that rating tag. Library rating filter needs the "100" value range.

So, in my opinion, it is the custom rating in the column browser, that should be changed to operate on 0 to 100 range.
Everything else works fine and in good harmony.

Thanks,
Wolfgang

CASE 1:
(https://i.imgur.com/oC6WVEC.jpg)

CASE 2:
(https://i.imgur.com/ZAIHIHf.jpg)
Title: Re: Rating Type Custom Tag Bug
Post by: phred on January 16, 2024, 08:10:58 PM
this seem to be the same patch files you had provided May 20, last year. I had tried this already.
All v3.5 patches have the same file name. If Steven posted a patch today, it most definitely is not the same patch file as was posted last May. If you haven't yet applied the patch, open MB > Help > About and make note of the version. Then close MB and apply the patch. Then check the version again. If it's still the same you either have already applied this patch, or you are applying it incorrectly.
Title: Re: Rating Type Custom Tag Bug
Post by: melsonic on January 16, 2024, 09:37:50 PM
Hi Phred,
thanks for your comment and justified remarks.
Good point to check the version number!

I checked a couple of things ...

MB current download from website:
MusicBee 3.5.8698
Released on October 25, 2023

I get the same version info in "About MusicBee" with the "old" files, i.e. unpatched.
(I had copied and put aside the original files before patching and just tested that).

MusicBee 3.5.8778 is the version info after patching (regardless  May 20, 2023 or Jan 16, 2024).

I also compared the files from the May 20, 2023 patch (downloaded before my first post) against the ones in the zip provided yesterday. Same size zip, and same size and modification date of all 23 files in the zips. Must be the same patch.

I conclude that I have patched MB successfully, yet still get the results as demonstrated.

[edit] just noticed that there's a "MusicBee36_Patched.zip" to be found under
https://getmusicbee.com/patches
The zip contains only the MB exe and a plugin. I applied it and the version number is still 3.5.8778 and no change to the problem.
[/edit]

And there's something else ... when clicking the custom rating tag in the track list, "sometimes" the following error is thrown (patched and unpatched, I post both below):

UNPATCHED:
MusicBee v3.5.8698.34385D  (Win10.0), 16 Jan 2024 22:33:

System.NullReferenceException: Object reference not set to an instance of an object.
   at #=z8mB0Fz3gRyk8qBovNJ28mMU=.#=zAZqLRMvzyo5F.#=zPVQzk3oz$qZ8(MouseEventArgs #=zK60pSUM=)
   at #=zt5kC_QUQpputtcn$QshTvmU=.#=z736DGfnq_ItJ.OnMouseDown(MouseEventArgs #=zK60pSUM=)
   at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at #=zjZcuVJ9KFZhdDg0h0npILj0=.WndProc(Message& #=zUkWzezk=)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

PATCHED:
MusicBee v3.5.8778.33537D  (Win10.0), 16 Jan 2024 22:36:

System.NullReferenceException: Object reference not set to an instance of an object.
   at #=z5e7_4uuh$HfAwio_Tm9cUp0=.#=zL4FmKnJZ65vV.#=zvR$nB1MV2HCo(MouseEventArgs #=zqECjfPg=)
   at #=zE6YBU4y2wooHvgf9T9QQykg=.#=zBiRIfrVx2F5a.OnMouseDown(MouseEventArgs #=zqECjfPg=)
   at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at #=zMaPzD13qqrKN7bfWCRzs5nU=.WndProc(Message& #=zppTazko=)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Title: Re: Rating Type Custom Tag Bug
Post by: phred on January 16, 2024, 10:12:18 PM
While the current patch version is 3.x.8778, the patches released in May 2023 were in the range of .8526 through .8540. You could not have possibly downloaded a patch in May and wound up with .8778, which Steven released on January 13 2024.

And if you downloaded the 3.6 patch and applied it, you could not possibly wind up with a 3.5 version.

So my guess is you're not applying the patch correctly. You need to extract the files in the downloaded ZIP and copy them to your current MB installation directory. If when doing so, you're not getting a warning from Windows that the files already exist, you're putting the files in the wrong place.

I suppose it's possible you have more than one MB installation on your PC. One is the Installer version and the other might be the Portable or the Windows Store version. What's the path to musicbee.exe when you -launch- MB the way you usually do? And what's the path to where you're putting the unzipped patch files?
Title: Re: Rating Type Custom Tag Bug
Post by: melsonic on January 16, 2024, 11:34:36 PM
Thanks Phred, I'm always running
"C:\Program Files (x86)\MusicBee\MusicBee.exe"

The Properties/Details of my current MB exe do read
  File version 3.6.8778-33610
  Date Modified 2024-01-13 08:41

That file origins from
MusicBee36_Patched.zip
downloaded an hour+ ago.

And the version number indeed reads "3.6.8778" ... I had not read correctly.

Patch files are on D:
(A) D:\LOC\Downloads\_sw\_done\MusicBee35_patch_2023-05-20\MusicBee35_Patched.zip
    dated 2024-01-14 23:17

(B) D:\LOC\Downloads\_sw\_done\MusicBee35_patch_2024-01-16\MusicBee35_Patched.zip
    dated 2024-01-16 20:00

(C) D:\LOC\Downloads\_sw\_done\MusicBee36_patch_2024-01-16\MusicBee36_Patched.zip
    dated 2024-01-16 22:45

Unpatched 3.5. files are in
D:\LOC\Downloads\_sw\_done\MusicBee35_unpatched files\MusicBee35_unpatched files.zip

No unzipped patch files around and it takes of course an admin override to actually replace the files in the program directory.

You are also correct in that I never downloaded the true May 20 patch. I just called it May 20 because I used the download link Steven had provided in his post that day. That link and the link he provided the other day lead to the same file in the patch directory. The May 20 patch file doesn't exist anymore in that location.

Nevertheless, I would uphold that I applied the patches correctly and will leave the matter as is for now.
Thanks for your efforts.

(https://i.imgur.com/6m9f5KL.jpg)
Title: Re: Rating Type Custom Tag Bug
Post by: phred on January 17, 2024, 01:56:41 AM
Thanks for the additional information. I don't see anything wrong and it does appear that you've applied the patch properly. It was your comment that you patched to 3.6 and MB still showed 3.5 that sparked my concern you were doing something incorrectly. But that's now attributed to your misreading.

Note the link to the most recent patch is always the same. And the filename of the most recent patch is always the same. Neither the link nor the filename change. So a patch that Steven links to in May, when downloaded eight months later, will download the most recent patch. Which is why what you thought was the May patch was in fact the patch from earlier this week.

As for the issue you're having, I have nothing to add or suggest. You'll just have to wait for Steven (or someone brighter than me) to offer up an idea.
Title: Re: Rating Type Custom Tag Bug
Post by: Steven on January 17, 2024, 07:33:16 AM
The patch is only done for v3.5 so far. I have re-uploaded the file
https://getmusicbee.com/patches/MusicBee35_Patched.zip
Title: Re: Rating Type Custom Tag Bug
Post by: melsonic on January 17, 2024, 07:25:39 PM
Thank you so much, Steven!

I confirm that the problem with the Column Browser display of custom tags of type 'rating' is gone.
I already edited my 'danceability' tags from the 0-5 range to the 0-100 range and built a library filter (4 -5 stars) on that tag.
Works like a charm.

For the record: MusicBee Version with todays patch: 3.5.8781 and no more error message when clicking the custom tag rating in the track list.