getmusicbee.com

General => MusicBee Wishlist => Topic started by: Anti on June 19, 2011, 09:32:16 PM

Title: Bookmarking within tracks
Post by: Anti on June 19, 2011, 09:32:16 PM
In my 'A-B Repeat' thread (http://getmusicbee.com/forum/index.php?topic=3687.0)
'bookmarking' was mentioned so I thought I'd create a new thread for this feature request.

During playback, it would be nice to click a button or use a keyboard shortcut to add a 'bookmark' to the track.
Optionally you could be asked to name the bookmark and add a note/description.

Later, you'd go to a 'bookmark list view' to see all your bookmarks.
Clicking one would take you to that particular spot within the track (the point at which the bookmark was created).

This would be useful for finding particular parts of an audio file in podcasts, audiobooks and language courses.

Any thoughts?
Title: Re: Bookmarking within tracks
Post by: ma_t14 on June 20, 2011, 06:30:26 AM
Having a feature to play audiobooks but not being able to bookmark makes no sense. These two should go together.  8)

I really like the approach Kmplayer takes regarding bookmarking. Whenever you make a bookmark a spot appears on the seek-bar defining its position. Then if you mouse over these spot there's a description that you have previously used to describe the bookmark. The last feature actually is not there but it would be a nice idea, don't you think?

Here have a look:

(http://i.imgur.com/goPBs.jpg)
Title: Re: Bookmarking within tracks
Post by: VX on June 20, 2011, 07:56:11 AM
During playback, it would be nice to click a button or use a keyboard shortcut to add a 'bookmark' to the track.
Optionally you could be asked to name the bookmark and add a note/description.

Later, you'd go to a 'bookmark list view' to see all your bookmarks.
Clicking one would take you to that particular spot within the track (the point at which the bookmark was created).

This would be useful for finding particular parts of an audio file in podcasts, audiobooks and language courses.

Having a feature to play audiobooks but not being able to bookmark makes no sense. These two should go together.  8)

+1 Sounds quite reasonable.
Title: Re: Bookmarking within tracks
Post by: bigelow13 on June 20, 2011, 05:30:11 PM
+1 for this. It really makes sense, and it's pretty nice when you really love the solo at 5:32 in X song...
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 23, 2011, 10:38:54 PM
I'm bumping this thread because I find the audiobook support really lacking without this feature  :P
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 09:17:06 AM
i've added bookmarking support:
http://www.mediafire.com/?fdor4w2tvfy4p0s

you can display a Bookmarks node set in the Layout preferences (default is off because i think most people wouldnt use this feature)
a start/stop bookmark hotkey is available - starts/stops bookmarking the current playing track
or you can also right click start/stop bookmarking in the Bookmarks main panel
you can edit a comment by clicking on the comment field in the Bookmarks main panel
the bookmark can be removed using the delete key or right click/ Remove
Title: Re: Bookmarking within tracks
Post by: VX on July 31, 2011, 12:27:05 PM
Thank you very much for implementing this.  :) I really missed that feature.

However, it would be much more intuitive when bookmarks for the now playing track could be created from the player control panel directly.
It's just one extra bookmark button, which could be hidden optionally just like buttons for equaliser, shuffle, repeat and Last.fm.

After clicking the button user could give optional comment for the bookmark start. Clicking it once again would stop bookmarking.

I would add another option for Repeat menu: 'Repeat bookmarked parts of the track'. What do you think ???

What is the shortcut key to add a bookmark ??? Is it predefined  ??? I suggest to use CTR+D, which is standard for internet browsers, including Internet Explorer  (http://windows.microsoft.com/en-US/windows7/Internet-Explorer-keyboard-shortcuts), Opera, Safari, Firefox (http://www.7is7.com/software/firefox/shortcuts.html) and others.
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 01:00:15 PM
you can create a command button (from the hotkeys preferences screen when you assign "Now Playing: Start/ Stop Bookmark")
however i will change the command button so you can assign different text depending whether the bookmark is stopped or not

for repeating, just set it to Repeat One on the player control panel and it will loop the bookmark
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 04:21:38 PM
Thanks Steven for the implementation  :)

There seems to be a bug. When you play a bookmark from within the bookmarks node and then play the track from within the music library it plays the bookmarked section of the track.

I would expect to play bookmarks ONLY from within the bookmarks node, I don't want bookmarks to be messing with the lengths of the tracks within my music library
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 04:55:54 PM
i dont find that behavior. If you edit the track in the library and go to the Settings tab is the start and end time ticked?
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 04:56:30 PM
Yes
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 04:58:25 PM
just untick those settings then
can you give me an exact set up steps
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 05:04:22 PM
can you give me an exact set up steps

I set the bookmark hotkey to Ctrl + Shift + D. go to music library start playin a track, use bookmark start and then end, go to bookmarks node play the bookmark from that track, now go to music library play track from where bookmark was taken, track plays bookmarked section NOT full length of the track.

Quote
just untick those settings then

I know and did already but it would be quite annoying to do this every time you bookmarked the track
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 05:12:09 PM
well i am baffled the because i dont get this behavior following those steps and looking at the code i cant see how its possible

could you do your steps up to where you end the bookmark, then before playing it from the main library, open the main library file from the tag editor and see if those 2 settings are ticked (you might find the track is read-only until you restart)
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 05:17:25 PM
even if I restart musicbee and play the track from music liibrary I get the bookmarked section unless I untick start/end time in edit  :-\
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 05:20:48 PM
is it possible to create a video of your steps? I would like to see if you start a bookmark, then edit the file in the tag editor whether the start time setting is already ticked, or whether both get ticked only when you end the book mark.
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 05:21:08 PM
Quote
could you do your steps up to where you end the bookmark, then before playing it from the main library, open the main library file from the tag editor and see if those 2 settings are ticked (you might find the track is read-only until you restart)

No they are not. Only when I open the bookmark from node, then click Stop (forgot to mention that), and then open track from music library the option becomes ticked
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 05:21:59 PM
If the above does not help either, tell me and I will create a video
Title: Re: Bookmarking within tracks
Post by: Steven on July 31, 2011, 05:43:14 PM
well i still cant reproduce or be sure of whats going on but as a guess you have some setting that is updating the playing file (eg. missing lyrics or artwork thats updating the playing track), so i've put a block in if its updating a bookmarked file
Let me know how this version goes:
http://www.mediafire.com/?wuvvy88dsurcs45
Title: Re: Bookmarking within tracks
Post by: ma_t14 on July 31, 2011, 05:49:28 PM
That fixed it! Thank you for going with me all the way to the end  :)
Title: Re: Bookmarking within tracks
Post by: ma_t14 on August 21, 2011, 02:07:17 PM
When bookmarking was implemented I didn't expect it to be 1 solution to 2 requests at once. Both bookmarking and A-B repeat was accomplished with a single implementation. The idea was ingenious! But there is a problem. Let me explain:

When I imagine bookmarking in audio/video and the way it is implemented in all the programs I used it acts more like "jump to the bookmarked position". So lets say I have 3:00 track and bookmark at 1:55 I expect the track to start at the defined position but continue playing to the very end. In simple words bookmark refers only to the starting point and the ending point is always assumed to be the end of the track.

The way it is now it is very difficult to accomplish this unless you seek to the end of the track and use the hotkey to define tthe ending point of the bookmark.

It would make more sense if when you press the bookmark hotkey it will assume that the ending point is the end of the track unless the user selects another point manually (like now)

I thought that was the way it is now, but I assumed wrong. Now when you set a starting point and change track the ending point of the bookmark is the point last played before changing track.

It is a simple and transparent change that wouldn't affect current functionality and follow the standard way every other software does bookmarking.
Title: Re: Bookmarking within tracks
Post by: Steven on August 21, 2011, 04:13:30 PM
it should be assuming the end point is the end of the track unless you press the bookmark hotkey again or hit the stop key. So how are you doing this?
Title: Re: Bookmarking within tracks
Post by: ma_t14 on August 21, 2011, 04:51:20 PM
It should be doing that even if you change track
Title: Re: Bookmarking within tracks
Post by: p-mob on August 21, 2011, 05:31:34 PM
Is it possible to add a bit more funcionality to the bookmarking?
Following scenario:
Audiobooks that are very long, and have only one track. 4 to 10 hours, for example.
If MusicBee can do only a start bookmark, and play from this point on, this will be very helpful.
In addition, the same behavoiur for multi track audiobooks/albums. It should work as follows:
I press a defined key shortcut or button on the screen. Then a start bookmark will be created.
Then in the bookmarks there should be one point in the context menu for the bookmark "play rest of the album from this point".
Then MusicBee plays the rest of the album/audiobook (whatever), even when it has multiple following tracks.
That would be perfect!
Title: Re: Bookmarking within tracks
Post by: Steven on August 21, 2011, 05:43:30 PM
i've changed it so if you dont explictly end the bookmark it assumes the end of track
Title: Re: Bookmarking within tracks
Post by: p-mob on August 21, 2011, 06:34:58 PM
Will it play the following tracks of the same album too?
Title: Re: Bookmarking within tracks
Post by: boroda on August 21, 2011, 10:00:45 PM
1. It seems that hotkey description in prefs/hotkeys is messed: 'off' actually means 'Start bookmark' and 'on' means 'End bookmark'.

2. How can I see the list of existing bookmarks? Cant find it. Using 1.3.4249.
Title: Re: Bookmarking within tracks
Post by: ma_t14 on August 21, 2011, 10:02:12 PM
You have to enable the node in preferences/layout
Title: Re: Bookmarking within tracks
Post by: boroda on August 21, 2011, 10:05:21 PM
Thanks. Can I see bookmarks for currently playing track only (maybe on 'progressbar')?
Title: Re: Bookmarking within tracks
Post by: ma_t14 on August 21, 2011, 10:07:34 PM
I too wish that was possible. See my first post on the first page

http://getmusicbee.com/forum/index.php?topic=3767.msg20491#msg20491 (http://getmusicbee.com/forum/index.php?topic=3767.msg20491#msg20491)
Title: Re: Bookmarking within tracks
Post by: Adson on August 25, 2011, 08:26:55 PM
Then in the bookmarks there should be one point in the context menu for the bookmark "play rest of the album from this point".
Then MusicBee plays the rest of the album/audiobook (whatever), even when it has multiple following tracks.
That would be perfect!

+ 1
The current solution works fine with single-track audio books but is not very helpful for bookmarking audio books with multiple tracks.
At least it should be possible to jump to the directory in which the bookmarked track is located manually.

Thanks

A.