getmusicbee.com

Support => Developers' Area => Skins => Topic started by: coldhanded on July 27, 2022, 08:42:55 PM

Title: Hide last.fm scrobble button - fluenx skin
Post by: coldhanded on July 27, 2022, 08:42:55 PM
Continuing this discussion here as to not hijack the original skin thread. (https://getmusicbee.com/forum/index.php?topic=30903.0)

As the title states I am trying to hide the last.fm button on the fluenx skin by diego (https://github.com/diego-pvlk/mb-skins/tree/a83bf7c0556c60ae9ebd80dd76d5d9711ca2354c/Fluenx%20Dark). I have managed to hide the button with the flag:
Code
<element id="HideScrobbleButtonSupported">true</element>
However this causes the wavebar to overlap with the right buttons as shown here: (https://i.imgur.com/CIneheu.png)

What I have tried so far

Replacing the tracklove element with:
Code
<element id="TrackLove" parent="TrackInfoPanel">
  <left relativeTo="EqualiserButton.Left" offset="-73" />
Copying the entirety of the skin.xml to the skin_wavebar.xml

Copying the entirety of the skin_wavebar.xml to the skin.xml

All of which either had no effect on the alignment or gave an error upon compiling with SkinCreator. Any help is appreciated links to the skin files are above.

EDIT:

Solved see Reply #2 (https://getmusicbee.com/forum/index.php?topic=36942.msg202712#msg202712)
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: hiccup on July 28, 2022, 04:06:40 PM
I'm sorry coldhanded, I now see that I overlooked some things in my previous instructions. So that's probably why things didn't work for you.

Here are new instructions that should work for all cases.

1. in Fluenx-BASE.xml
    Add these two lines in the <settings> category:

Code
<element id="HideScrobbleButtonSupported">true</element>
<element id="HideScrobbleButtonOffset">0</element>
(it enables the user to hide the Scrobble button)


2. in skin.xml :
    Find the element for TrackLove, and replace the line that positions it horizontally to this:

Code
<element id="TrackLove" parent="TrackInfoPanel">
<left relativeTo="EqualiserButton.Left" offset="-73" />
(it makes it that the 'Love' button gets anchored to the EQ button instead of to the right side of the panel, making its positioning dynamic)


3. also in skin.xml
    At the bottom of the xml, replace the replacement element for TrackLove with:

Code
<replacementElement id="TrackLove" replaceWith="EqualiserButton.Right" offsetAdjustment="-36" />
(it makes it that when the 'Love' button is disabled, other elements get anchored to the EQ button instead)


4. There is no need to change anything in the wavebar.xml
(because there is no element in it that affects or overrules the above changes)


Let me know if this works as expected for you?
 
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: coldhanded on July 28, 2022, 08:21:47 PM
Thank you for all of your help hiccup these instructions worked perfectly!

My issue now is there is a gap in the space where the button was. I have tried adjusting the <right relativeTo="TrackRating.Left" offset="-6" /> line in the wavebar section of the skin_wavebar.xml however this only moves the wavebar itself (no changes to progress bar) and ends up overlapping with the timestamp as shown here:
(https://i.imgur.com/DnwG5ay.png)

EDIT:
Did some digging in the skin.xml and skin_wavebar.xml and found the offsets that needed adjusting.


(https://i.imgur.com/Sx5RxLm.png)
(https://i.imgur.com/Z75sMuT.png)

The edited skin can be downloaded here (https://www.mediafire.com/file/v5pxsw6tlwtty0r/Fluenx_Dark_and_Cold.xmlc/file)
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: hiccup on July 29, 2022, 05:14:38 PM
The edited skin can be downloaded here (https://www.mediafire.com/file/v5pxsw6tlwtty0r/Fluenx_Dark_and_Cold.xmlc/file)
That one gives me this:
(https://i.imgur.com/BuhPOjc.png)

I think it can best be done using the offset in the main skin.xml
(I completely forgot and overlooked that earlier)

A new plan:

In Fluenx-BASE.xml
Code
<element id="HideScrobbleButtonSupported">true</element>
  <element id="HideScrobbleButtonOffset">-223</element>
 
In skin.xml
Code
<element id="TrackLove" parent="TrackInfoPanel">
  <left relativeTo="LastFmButton.Right" offset="-68" />
   and at the bottom
Code
<replacementElement id="TrackLove" replaceWith="LastFmButton.Right" offsetAdjustment="0" />
(as it was from the beginning)

Leave the wavebar.xml original
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: coldhanded on July 29, 2022, 07:07:34 PM
The edited skin can be downloaded here (https://www.mediafire.com/file/v5pxsw6tlwtty0r/Fluenx_Dark_and_Cold.xmlc/file)
That one gives me this:
(https://i.imgur.com/BuhPOjc.png)

Not sure what's going on there are you sure that is the correct skin? The screenshots above the download link are what it looks like for me.
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: hiccup on July 29, 2022, 07:22:26 PM
Not sure what's going on there are you sure that is the correct skin? The screenshots above the download link are what it looks like for me.
What does it look like for you when you don't have the 'Love' and/or the LastFM button hidden?
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: coldhanded on July 29, 2022, 07:47:03 PM
Oh right haha that would make sense I always keep those turned off so that is not an issue for me however if you are so inclined please feel free to post a version with support for those buttons, I am sure somebody would appreciate it.
Title: Re: Hide last.fm scrobble button - fluenx skin
Post by: ZINHAR on November 02, 2022, 01:21:56 PM
Came here to confirm hiccup's last suggestion works flawlessly, I made a pull request (https://github.com/diego-pvlk/mb-skins/pull/1) over at the original repo.
  
You can download the updated skins from my repo:
Fluenx Dark.xmlc (https://github.com/FaridZelli/mb-skins/raw/main/Fluenx%20Dark/Fluenx%20Dark.xmlc)
Fluenx Dark - With Stop Button.xmlc (https://github.com/FaridZelli/mb-skins/raw/main/Fluenx%20Dark%20-%20With%20Stop%20Button/Fluenx%20Dark%20-%20With%20Stop%20Button.xmlc)

(https://i.imgur.com/RmxJq40.png)
(https://i.imgur.com/egvlCmY.png)