getmusicbee.com

Support => Bug Reports => Topic started by: Bizy on June 25, 2021, 08:39:03 PM

Title: Vertical tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 25, 2021, 08:39:03 PM
Hello there!

It's been some time, that means:  I've been merely enjoying MB all that time... :-D

Now this issue pops up again - while doing some tagging.  
I've tried to address it before, but maybe I wasn't clear enough.

Here's a video:
Vertical Tag Editor - Inconsistencies (https://imgur.com/FpkU4gB)

Aim:  1) replace genre 'Klezmer & Co' by klezmer + save
2) add '4' to (custom) tag 'fuif' + save

What happens:
1) genre:  'Klezmer & Co' --> 'klezmer' and save
2) genre: 'Klezmer & Co' reappears
[3) CHECK with standard tag editor (edit or shift+enter):  'klezmer' has been saved]
4) genre:  'Klezmer & C'o still visible
fuif:  '4' and save
5) '4' disappears
[6) CHECK with standard tag editor:  'Klezmer & Co' has been saved, fuif: '4' has been saved]

What is expected:
1) genre: 'Klezmer & Co' --> 'klezmer' & save
2) genre: 'klezmer' remains visible
3) fuif: '4' and save
4) '4' remains visible
(without having to check, of course)

Thanks for possibly looking into this.
b.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: phred on June 25, 2021, 10:27:17 PM
I'm not so sure this is a bug as I expect others would also be reporting similar activity. And they're not.

Make sure the file(s) you're trying to change are not read-only.
Make sure you have permissions for the directory in which the files reside.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 25, 2021, 10:59:48 PM
@Fred:
- They're not read-only.
- I have permissions.

Have you tried to reproduce it?
In the video I show 4 simple reproducable steps to do so (they take less than a minute):
- Open vertical tag editor
- Change one tag and save
- Check with standard tag editor (edit or shift+enter)
- Change another tag and save
- Check with standard tag editor

It happens EVERY time, in both the most recent fully installed and portable version, and on several computers, with internal and external disks.
And I've been observing it for more than a year now, so also with several former MB versions - see former posts of me.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: frankz on June 25, 2021, 11:08:52 PM
It's because the track is currently playing (in use).  Tags are written to the file after play, when the file is no longer in use.  While the file is being played, it is essentially read-only (to my understanding) as phred suggested.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 25, 2021, 11:26:01 PM
@Frankz:  Okay, I tried that.  (So:  changing and saving a tag two times while the song is playing, checking what has been saved when the song isn't playing anymore - as you seem to suggest that the changes are saved when the song isn't playing anymore.)
Result: same (so:  first tag change has not been saved).

So basically you're saying:  you can't edit tags (more than one time) with vertical tag editor while a song is playing.
And that is not a bug?

(Btw:  I can edit tags as many times as I want with the standard tag editor (shift+enter or edit) whíle the song is playing - without this problem.   So in my opinion, this ís a problem (bug) related to the vertical tag editor.)
(Using standard tag editor is my 'workaround', but using the vertical tag editor would be easier and more efficient - without this problem, of course.)
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: chrctrlmt on June 25, 2021, 11:41:34 PM
I have been having a very similar issue.  MusicBee doesn't always reflect changes to metadata, such as adding artwork, until doing a full rescan, or otherwise making a change to the file itself, or files within the same folder, triggering something.  At first I thought it was related to having files on an external drive, but even after moving them to an internal drive it persisted, then again on an entirely different machine.  It's caching the metadata but won't pick up changes for whatever reason.  I use an external tag editor.  Figured it was just me, but idk.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 25, 2021, 11:51:32 PM
@chrctrlmt:  your issues might also be slightly different ;-)

For if the right tags appear after scanning, that means at least that all the changes have been saved rightly.

In this case - but that's an assumption, based on what I see with 'edit' - only the second change has been saved, and rescanning won't show the first change (as the old tag of the first change has been saved again together with the new tag of the second change).  
I'll try this out (rescanning, but with a smaller library).

EDIT:  my hypothesis was right:  rescanning doesn't show the first tag change either.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Steven on June 26, 2021, 07:55:08 AM
i can reproduce the reported issue but only when using the vertical tag editor when the track is playing. Until its fixed, I suggest you use the standard tag editor (shift enter)
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 26, 2021, 12:44:11 PM
Thanks, Steven, for picking it up!!
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Steven on June 27, 2021, 05:22:03 AM
https://getmusicbee.com/patches/MusicBee34_Patched.zip
unzip and replace the existing musicbee application files
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 27, 2021, 12:01:11 PM
Waw!! Thanks!

Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 27, 2021, 12:48:53 PM
Euh... I forgot to ask:  can I do this for both the standard and portable version?

EDIT:  I see I could have expressed myself more clearly.  So I made some changes in what I wrote:  
- replaced 'tag editor' with 'vertical tag editor'
- replaced 'edit' with 'standard tag editor'
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: phred on June 27, 2021, 01:46:48 PM
Euh... I forgot to ask:  can I do this for both the standard and portable version?
Yes, the patch will work for the installer and portable versions, but not the Windows Store version.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Bizy on June 27, 2021, 02:44:35 PM
Yes, thanks.  I couldn't wait, so I tried it out anyway...  ;-)

Very happy... :-D
(very smooth work flow now, for tagging...)

Thanks again!!
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: purplebee on June 30, 2021, 04:46:44 AM
Sorry to revive this thread but I'm not sure if I should open a new one when my problem is similar.

I use MB a lot to clean tags I don't use. So far so good, except for one tag in particular: ASIN. The issue is: After I delete it in the Tag Inspector, if I open it again that tag will still be there.

The affected files aren't read-only, as I delete other tags along with ASIN and only that one remains.
I've made sure I'm not playing the affected files when I try to edit tags.
I've tried to do the same with Mp3Tag and it can successfully delete the tag.

Edit: I forgot to add that this doesn't always happen, but has happened to me with multiple releases.
The same thing happened to me with the DISCID tag too, but only twice.
Title: Re: Tag editor: inconsistencies in saving tags and visibility.
Post by: Steven on June 30, 2021, 09:14:42 AM
if you send a link to the problem file i will have a quick look, but i can tell you there is no special treatment for tag: ASIN