getmusicbee.com

Support => Questions => Topic started by: phred on November 18, 2020, 01:51:50 PM

Title: Edits with Tag Inspector
Post by: phred on November 18, 2020, 01:51:50 PM
I'm not sure this is a bug, but it is certainly unusual behavior. Using 3.4.7626 P, but I've seen it occasionally on various versions going back probably a year or so.

I select a track and open the Tag Editor. I then open the Tag Inspector and edit a tag and save it. The Tag Editor then flashes the red warning icon next to the Save button. The warning states that "the file(s) being edited have been updated outside of MusicBee - you may need to rescan..."

This is incorrect. The file(s) were edited using the Tag Inspector. Does the warning mean that editing with the Tag Inspector requires a rescan? I've never seen those changes not picked up by MB when saving the Tag Editor.
Title: Re: Edits with Tag Inspector
Post by: hiccup on November 18, 2020, 02:04:51 PM
Same here. (also for at least a year I think)
But I never made an effort in analyzing and replicating the exact circumstances when this happens, so I also didn't report it.
But it's a real thing for sure.
Title: Re: Edits with Tag Inspector
Post by: phred on November 18, 2020, 02:11:59 PM
But it's a real thing for sure.
Thanks for confirming my sanity, albeit temporary.
Title: Re: Edits with Tag Inspector
Post by: hiccup on November 18, 2020, 05:45:27 PM
Thanks for confirming my sanity, albeit temporary.

Not addressing the sanity part (I have a meeting about you with some other white-coated fellows later on), but I am pretty sure this was raised before.
Even in the last week by a French forum member I believe. (I now can't find that post though)

I do recall it occurring a few times when I had both the tag editor docked at the bottom, and the vertical tag editor open.
But I can imagine that that is asking for some problems.

But it also happened with using only the docked tag editor.
Perhaps I will put some effort in trying to replicate it and focus on the the circumstances the coming week.
Title: Re: Edits with Tag Inspector
Post by: The Incredible Boom Boom on November 18, 2020, 07:27:38 PM
I do recall it occurring a few times when I had both the tag editor docked at the bottom, and the vertical tag editor open.
But I can imagine that that is asking for some problems.

But it also happened with using only the docked tag editor.

Now that it's been mentioned, I too have also been seeing the warning icon more often since I docked the Tag Editor and when making changes inside MusicBee. I'll try undocking it and messing around and see if it's as frequent.
Title: Re: Edits with Tag Inspector
Post by: phred on November 18, 2020, 08:01:01 PM
I don't use the docked Tag Editor. Mine is a separate floating window.
Title: Re: Edits with Tag Inspector
Post by: phred on November 18, 2020, 08:03:00 PM
Not addressing the sanity part (I have a meeting about you with some other white-coated fellows later on)
When the meeting ends, if there's an extra white coat with long sleeves and strings at the end, save it for me.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 19, 2020, 06:35:33 AM
Are the files on a network share? There have been some reports of this before and the diagnosis was that it takes some time for the file modification time to update ie. MB gets the old modification time
If these are network share files, I might disable the functionality for UNC paths but if you have it mapped to a drive letter then it will still behave the same way
Title: Re: Edits with Tag Inspector
Post by: hiccup on November 19, 2020, 08:44:15 AM
Are the files on a network share?

In my case, no.
Title: Re: Edits with Tag Inspector
Post by: phred on November 19, 2020, 11:44:06 AM
Are the files on a network share?
Yes, my files are on a partition of my NAS which I have mapped as drive letter Z:
Title: Re: Edits with Tag Inspector
Post by: The Incredible Boom Boom on November 19, 2020, 03:56:18 PM
Are the files on a network share?
Yes, my files are on a partition of my NAS which I have mapped as drive letter Z:

Same here, but mine aren't mapped.
Title: Re: Edits with Tag Inspector
Post by: frankz on November 19, 2020, 08:11:28 PM
I, too, feel like I have been seeing the "updated outside MB" warning more recently - network share no drive mapping. 
Title: Re: Edits with Tag Inspector
Post by: Mr. Trev on November 19, 2020, 08:14:41 PM
I'll jump in with a me too.

NAS. Network share, Not drive mapped.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 19, 2020, 08:31:18 PM
and is this only after saving with the tag inspector?
Title: Re: Edits with Tag Inspector
Post by: phred on November 19, 2020, 08:39:14 PM
and is this only after saving with the tag inspector?
While not 100% of the time, yes, I've only see it when saving a tag or tags using the Tag Inspector.
Title: Re: Edits with Tag Inspector
Post by: frankz on November 19, 2020, 10:24:41 PM
Mine seems to be related to rating songs or embedding lyrics on a computer that's not the one hosting the network share. 

The rating thing is a problem which I had before that you solved, but seems to have returned recently.
Title: Re: Edits with Tag Inspector
Post by: Mr. Trev on November 19, 2020, 10:26:49 PM
and is this only after saving with the tag inspector?

I typically only use the tag editor to remove tags, but yes that's the case for me.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 21, 2020, 12:06:21 AM
I can't reproduce this and i don't see why saving with the tag inspector would be any different to saving a file normally with the tag editor.
I guess i can create a debug version if anyone is willing to do some tests
Title: Re: Edits with Tag Inspector
Post by: phred on November 21, 2020, 03:33:22 AM
I guess i can create a debug version if anyone is willing to do some tests
Whenever you can get to it I'll run the debug.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 21, 2020, 03:53:53 AM
could you run this version and send me the new entries in the error log when it happens
http://www.mediafire.com/file/5anyl9lupbmab3m/MusicBeeDebugTimeStamp.zip/file
Title: Re: Edits with Tag Inspector
Post by: phred on November 21, 2020, 02:56:13 PM
could you run this version and send me the new entries in the error log when it happens
Outside of MB I created a 'test' album. I launched the debug version and placed the files in the Inbox. I spent twenty minutes using the Tag Inspector to edit various tags in the same manner I was doing when I first posted about this. Not once did I get the warning. There are about 100 entries in the Error Log, which I can PM to you if you feel they'll be useful. Otherwise I will keep trying to get the warning and will send the log when it happens.

It might be helpful is someone else who is experiencing this would run the debug also.

Thanks for trying to look into this.
Title: Re: Edits with Tag Inspector
Post by: hiccup on November 21, 2020, 03:29:32 PM
It might be helpful is someone else who is experiencing this would run the debug also.

I just ran the debug version, very quickly got the error and pm'ed the log file.
A pretty standard portable (test) installation, not tweaked much, a very small library on local drive, same partition as the install.

Just a thought, perhaps regional formatting plays some role?
(I am using Windows in English, but have the regional settings for date time etc. in Dutch. Differences in dots and comma's and such)
Title: Re: Edits with Tag Inspector
Post by: phred on November 21, 2020, 03:44:24 PM
(I am using Windows in English, but have the regional settings for date time etc. in Dutch. Differences in dots and comma's and such)
I'm using US English along with US regional settings. I was seeing this warning for quite some time until I installed the debug version. Now I can reproduce it. But I'll keep trying to make it happen.
Title: Re: Edits with Tag Inspector
Post by: hiccup on November 21, 2020, 03:51:41 PM
(I am using Windows in English, but have the regional settings for date time etc. in Dutch. Differences in dots and comma's and such)
I'm using US English along with US regional settings. I was seeing this warning for quite some time until I installed the debug version. Now I can reproduce it. But I'll keep trying to make it happen.

Yeah, but since others than me are reporting this with using a nas, perhaps these nas systems do something with time/date formatting that MB is not expecting?

Or maybe there are different reasons for this happening. Timing, latency, time formatting, ...
Title: Re: Edits with Tag Inspector
Post by: phred on November 21, 2020, 04:19:07 PM
In reply #22 I typed "Now I can reproduce it." That should have read "Now I CAN'T reproduce it."

My music files are also on a NAS, but typically when editing tags the files are in the Inbox, which is on a local drive. Which was the situation during this past week. I will try reproducing the issue using files in the NAS.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 21, 2020, 10:49:03 PM
@hiccup, thanks for sending the log. What is your configuration for the tag editor? Do you have the vertical tag editor displayed and were you editing from that same panel?
Title: Re: Edits with Tag Inspector
Post by: hiccup on November 21, 2020, 11:03:13 PM
@hiccup, thanks for sending the log. What is your configuration for the tag editor? Do you have the vertical tag editor displayed and were you editing from that same panel?

No, only the docked tag editor, and I only edited one tag and then clicked 'save'.
Testing it for the last 10 minutes using pretty much the same procedure didn't trigger the error message once.

But since this is a pretty much plain-vanilla testing portable install, I should be able to do some more specific testing occasionally the coming days (or weeks), and set my mind to see if I can spot some not-so-obvious pattern.
It's quite a mystery to me at this moment.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 21, 2020, 11:31:28 PM
No, only the docked tag editor, and I only edited one tag and then clicked 'save'.
In your case, the issue is specific to saving a file with the docked tag editor and is due to the file in some cases being checked before the file is actually saved.
It should be fixed for the next update
Title: Re: Edits with Tag Inspector
Post by: Mr. Trev on November 21, 2020, 11:37:22 PM
could you run this version and send me the new entries in the error log when it happens
http://www.mediafire.com/file/5anyl9lupbmab3m/MusicBeeDebugTimeStamp.zip/file

Just sent a PM of my log too.
Hope it helps
Title: Re: Edits with Tag Inspector
Post by: Steven on November 21, 2020, 11:39:25 PM
Just sent a PM of my log too.
Hope it helps
same question as for hiccup - are you using the docked tag editor? and you don't have the vertical tag editor displayed?
Title: Re: Edits with Tag Inspector
Post by: Mr. Trev on November 21, 2020, 11:54:52 PM
Just sent a PM of my log too.
Hope it helps
same question as for hiccup - are you using the docked tag editor? and you don't have the vertical tag editor displayed?

If by docked you mean "show in main panel", no. I use floating window.

I also don't use the vertical editor.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 22, 2020, 05:26:33 AM
@Mr. Trev, in your case the file modification time returned by the server is not updating in a timely manner ie. its returning the old file modification time. I will put in a delay as i suspect it gets updated on the server a second or two afterwards
Title: Re: Edits with Tag Inspector
Post by: phred on November 22, 2020, 11:16:38 PM
@Steven...

I have still not been able to reproduce the issue I stated in my OP. I have tried many times during the day and never once has the warning appeared. This is with the debug version you created for this issue.

I am going to update to the latest 3.4 patch and see what happens.

Hopefully I'll never see it again. If I do, I'll have a backup of the album I'm working on and will reinstall the debug version and overwrite the tracks with the original unedited tracks.

EDIT: I know you haven't changed anything regarding this issue but I just patched to 3.4.7631 P and used the Tag Inspector to edit some tracks from two of the albums that caused me to open up this thread and not once did I see the warning.

I'd be curious to know if any folks who said they've seen it before see it now.
Title: Re: Edits with Tag Inspector
Post by: Steven on November 23, 2020, 08:03:07 AM
This version has a delayed check for the file modification timestamp. Hopefully this fixes the issue but I cant test and be sure so let me know how it goes

https://getmusicbee.com/patches/MusicBee34_Patched.zip
unzip and replace the existing musicbee application files
Title: Re: Edits with Tag Inspector
Post by: Mr. Trev on November 23, 2020, 09:07:09 PM
I gave this version a try using the exact same process as before and got the same result. Files need to be rescanned.

Personally, I'm not sure it's worth wasting too many calories try to fix my situation. It's never really bothered me that much.

Cheers
Title: Re: Edits with Tag Inspector
Post by: phred on December 04, 2020, 08:03:43 PM
I've only seen it when saving a tag or tags using the Tag Inspector.
This has suddenly changed.
I was editing tags in the Tag Editor (-not- the Tag Inspector) and got the same message as when I started this thread: Tags were made outside of MB and may need to be rescanned. (Or something close to that.) I thought the screenshot would've captured the warning message, but it didn't. I was editing the title tag and using a hotkey (Edit: Save/ Goto Next) to move from track to track.The warning appeared upon each move. I wasn't using a hotkey when this was happening in the Tag Inspector.
(http://i.imgur.com/VD3SM0Ul.jpg) (https://i.imgur.com/VD3SM0U.jpg)