getmusicbee.com

Support => Bug Reports => Topic started by: Bee-liever on January 15, 2020, 01:00:22 AM

Title: AutoDJ restrictions override selection mode
Post by: Bee-liever on January 15, 2020, 01:00:22 AM
Not sure if this is a bug or by design.

If select by album in 'selction mode', as expected I get a nice random mix of complete Albums.

If I want to restrict those albums to similar artists as the seed track and select 'only include tracks from artists' in the 'restrictions:' settings,
the Album selection gets overridden and I only have tracks.

Shouldn't the 'Album' selection mode still be active?
Or should there be a new drop down in restrictions, 'albums from artists'?

(http://i.imgur.com/ZVo2R9H.jpg) (https://imgur.com/ZVo2R9H)
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on January 16, 2020, 04:18:24 PM
It has been coded so that only random tracks work with similar artist restrictions. I think it would be a fairly substantial change to address it for v3.3 but i will see if it can be corrected in v3.4
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on January 17, 2020, 09:51:46 PM
Thanks for looking in to this.
BTW Good luck on the new job and relocation, Steven (or is it really Harry  :o  )
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on February 16, 2020, 10:22:23 AM
its done for v3.4 - here is an alpha version if you want to try it out

http://www.mediafire.com/file/rkx9mn38mybdpaa/MusicBee.zip/file
Title: Re: AutoDJ restrictions override selection mode
Post by: phred on February 16, 2020, 04:24:33 PM
its done for v3.4 - here is an alpha version if you want to try it out
Please refresh my failing memory. Should the zipped exe be placed in my current MB directory? Since I've learned long ago never to assume anything, I assume running v4 will have no impact on v3 in the same directory, right?
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on February 16, 2020, 07:57:36 PM
i suggest you create a separate 3.3 portable installation and overwrite musicbee.exe with v3.4
Title: Re: AutoDJ restrictions override selection mode
Post by: phred on February 16, 2020, 09:06:49 PM
i suggest you create a separate 3.3 portable installation and overwrite musicbee.exe with v3.4
Perfect. Thanks.
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on February 16, 2020, 09:10:03 PM
its done for v3.4 - here is an alpha version if you want to try it out

Thank you. Had a quick try and seems to be working fine.
Will have a longer test later today.
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on February 17, 2020, 09:16:44 PM
Two things noticed:

1.  Only seems to work if source is 'library';

2.  If initial list size truncates an album, when upcoming tracks is populated as tracks are played the album tracks are not continued.  A new album is selected.
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on February 19, 2020, 11:02:19 AM
this version should work better
http://www.mediafire.com/file/rkx9mn38mybdpaa/MusicBee.zip/file
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on February 21, 2020, 10:11:38 AM
this version should work better
unfortunately not  :(

It does select albums from other track sources besides library now but:

1.  Ignores seed track and selects similar artists albums from source;

2.  Reverts back to track selection after Auto DJ started;

3.  Still does not add the rest of album if initial list cuts tracks from end of full album.
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on February 22, 2020, 08:31:04 AM

It does select albums from other track sources besides library now but:

1.  Ignores seed track and selects similar artists albums from source;

2.  Reverts back to track selection after Auto DJ started;

3.  Still does not add the rest of album if initial list cuts tracks from end of full album.
1 was intentional but i have reconsidered. 2 is probably related to 3 and i can see a few scenarios where 3 can happen so could you try again
http://www.mediafire.com/file/rkx9mn38mybdpaa/MusicBee.zip/file

edit:
i see if the dj is started by the dj button in the player bar, its still not working so i will look into that
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on February 24, 2020, 07:50:49 AM
edit:
i see if the dj is started by the dj button in the player bar, its still not working so i will look into that
i take that comment back - i was using a playlist as the source and only some of the album tracks were in the playlist. The latest 3.4 update from above should work as expected
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 10, 2020, 02:40:05 AM
@Bee-liever, did you ever try this out again?
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 10, 2020, 09:39:39 AM
Sorry no.  :(
Have been a bit busy the last couple of weeks.
Things are quitening down for now, and I'm hoping to get some time over the Easter break.

Will post details as soon as I can leave it to run for an hour or so.
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 11, 2020, 01:07:31 PM
Continue to have problems with this one:
3.  Still does not add the rest of album if initial list cuts tracks from end of full album.
otherwise everything else seems to be working great.

Still hoping this request can be intergrated https://getmusicbee.com/forum/index.php?topic=30621.0 (https://getmusicbee.com/forum/index.php?topic=30621.0).
Hate having to save screenshots of my filters so they can be reconstucted at a later date  :(
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 12, 2020, 10:57:07 AM
I still cant reproduce this issue. Could you send me a link to your settings file?
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 13, 2020, 03:07:56 AM
PM sent
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 13, 2020, 09:56:31 AM
Well i still cant reproduce this. How are you starting the DJ?
And it goes back to the expected behavior after the truncated album has played?

edit:
could you try with the similar artist filter unticked?
if that makes a difference then this version might resolve the issue
http://www.mediafire.com/file/rkx9mn38mybdpaa/MusicBee.zip/file
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 13, 2020, 01:03:38 PM
I start from the AutoDJ panel in a locked tab.
Select 'Preview' and then 'Start DJ'

Works fine selection/playing-wise.  MB just never cues up the rest of the partial album in the Preview screen. Starts cueing up another album that matches the selection criterea.

similar artist filter unticked made no difference.

I went back and looked in 3.3 and the entire album is loaded in the preview screen even if the list then exceeds the initial list + upcoming tracks settings.  This doesn't occur in 3.4
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 15, 2020, 11:18:47 AM
If you are only referring to the Preview screen then yes it now truncates to the initial list size. The functionality was rewritten and it now doesnt lend itself to showing the complete album in that circumstance in the preview screen. If I get more complaints on that then I could do something but for now it doesnt seem that important.
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 15, 2020, 12:22:11 PM
If you are only referring to the Preview screen then yes it now truncates to the initial list size. The functionality was rewritten and it now doesnt lend itself to showing the complete album in that circumstance in the preview screen.
Ahh! But it's not just the preview screen. In 3.4 when you press 'Start DJ' to load that list into the player, that's all that is loaded.  If your selection mode is by album, the missing album tracks from a partially-displayed album in the preview panel are not added for play.  This is regardless of whether similar artist filter is unticked or ticked.
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 15, 2020, 12:26:33 PM
Ahh! But it's not just the preview screen. In 3.4 when you press 'Start DJ' to load that list into the player, that's all that is loaded.  If your selection mode is by album, the missing album tracks from a partially-displayed album in the preview panel are not added for play.  This is regardless of whether similar artist filter is unticked or ticked.
To be clear, once you start playing the remaining tracks will eventually get included on the playing tracks panel (not the auto-dj preview panel) right?
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 15, 2020, 12:48:28 PM
To be clear, once you start playing the remaining tracks will eventually get included on the playing tracks panel (not the auto-dj preview panel) right?
No they don't.  This is the truncated list I've been talking about.
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 15, 2020, 12:58:25 PM
In that case i wont be able to help further. The remaining tracks on the album should get added to the Playing Tracks panel one by one once the dj needs to add more tracks based on the upcoming tracks parameter
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 15, 2020, 01:04:32 PM
No they don't.  This is the truncated list I've been talking about.
For clarity, it's only that initial list from when starting in the preview screen that doesn't get the extra tracks populated in the playing tracks panel.  Once it's past the point of the missing album tracks, everthing works fine.
Full albums get populated, track-by-track into the playing tracks list.
Matches the similar artist filter in album mode perfectly.
Title: Re: AutoDJ restrictions override selection mode
Post by: Steven on April 15, 2020, 01:08:20 PM
For clarity, it's only that initial list from when starting in the preview screen that doesn't get the extra tracks populated in the playing tracks panel.  Once it's past the point of the missing album tracks, everthing works fine.
I cannot reproduce that - even with your settings. For me, the extra tracks get added at the point the dj needs to satisfy the upcoming tracks parameter and i see no reason for it not to do that.
Title: Re: AutoDJ restrictions override selection mode
Post by: Bee-liever on April 15, 2020, 01:34:19 PM
I cannot reproduce that - even with your settings. For me, the extra tracks get added at the point the dj needs to satisfy the upcoming tracks parameter and i see no reason for it not to do that.
OK. I'll chalk it up to weirdness on the 3.4 test install on my old laptop.
When 3.4 goes into beta, I'll see what happens on the main desktop install.
Thanks for getting the similar artist filter working for albums all the same  :)