getmusicbee.com

General => MusicBee Wishlist => Topic started by: phred on November 16, 2018, 06:59:05 PM

Title: Ability to Display More Than One Highlight Rule
Post by: phred on November 16, 2018, 06:59:05 PM
I'd love to see the ability to display more than one rule. I am currently using one rule to display a color when a track has no lyrics. I'd like the ability to add additional 'highlight' columns to show another color for tracks with low bitrates, and another to show no BPM. Currently only one highlight can be displayed and it's whichever rule MB sees first as a match.

Thanks.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Sofocl on November 17, 2018, 03:12:48 AM
+1
Title: Re: Ability to Display More Than One Highlight Rule
Post by: redwing on November 17, 2018, 12:59:53 PM
+1

This is a five-year-old wish of mine:

One of the unresolved issues with highlighting feature is how to display the field for tracks meeting multiple rules. Currently only one color can be shown for tracks, and if a track meets multiple rules, color of the higher-order rule applies to it. Thus there's no way to know if a track highlighted with a certain color meets other rules as well.

How about splitting the color bar into pieces when the tracks displayed on the main panel with highlight column enabled are meeting more than one rule? If there's a track meeting three rules, then all bars for displayed tracks would be split into three pieces of different colors. The order of color would follow the order of the rules. This way, the user would be able to identify tracks meeting multiple rules.

It would look something like this:

(http://i.imgur.com/FqsP5px.png)

Not requesting unlimited number of color bars but even three would be great improvement.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: phred on November 17, 2018, 01:33:29 PM
Not requesting unlimited number of color bars but even three would be great improvement.
Yes, while unlimited would be best, three would suffice.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: vzell on November 17, 2018, 01:39:48 PM
+1
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Sidar on November 17, 2018, 04:37:18 PM
+1
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Steven on November 18, 2018, 10:02:33 AM
https://getmusicbee.com/patches/MusicBee33_Patched.zip

The number of matches displayed is now a configurable in the highlighting rules, limited to a maximum of 3 (the main reason for 3 max is space constraints on the grid album and tracks view). Also only one match displays in the album covers view due to visual constraints in that view
Title: Re: Ability to Display More Than One Highlight Rule
Post by: phred on November 18, 2018, 12:41:02 PM
This is really great. Thanks very much Steven.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: redwing on November 18, 2018, 01:57:48 PM
Thanks a lot for implementing this! It will make highlighting feature a lot more useful as now each track can show what rules it meets and what not.

limited to a maximum of 3

I think 3 is enough for color bars as we can also use separately or mix up with text coloring option.
One minor issue is icons always take precedence over color bars regardless of the order of rules. I guess multi-bar users should avoid using icons.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Steven on November 18, 2018, 02:29:48 PM
I forgot you can also show the highlight field directly in the expanded panel of the Album Covers view.
Thats also implemented now
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Bee-liever on November 19, 2018, 11:15:55 AM
Thank you very much for this! Greatly appreciated  :)

One minor issue is icons always take precedence over color bars regardless of the order of rules. I guess multi-bar users should avoid using icons.
Or could we have MB resize the icons (7x14 with 2 selection, 4x14 with 3 selection) and mix those in with the standard colour bars?

Yes they would be distorted, but the colouring would be similar enough to easily recognize the matching icon.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Bee-liever on November 22, 2018, 11:35:48 AM
Or could we have MB resize the icons (7x14 with 2 selection, 4x14 with 3 selection) and mix those in with the standard colour bars?

Yes they would be distorted, but the colouring would be similar enough to easily recognize the matching icon.

Another idea for doing this would be to allow user defined smaller icons.
eg: the one I have for high resolution 24/96 flac files
HiRes.png 16x16

If I have smaller icons for when using 2 or 3 matches (named as HiRes_x2.png / HiRes_x3.png) in my Icon folder, then MB could use those along with the standard colour tags for the other matches.

If the smaller icons don't exist, than MB uses the current default of only showing the large icon for the first match
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Steven on November 22, 2018, 05:38:55 PM
Another idea for doing this would be to allow user defined smaller icons.
eg: the one I have for high resolution 24/96 flac files
HiRes.png 16x16

If I have smaller icons for when using 2 or 3 matches (named as HiRes_x2.png / HiRes_x3.png) in my Icon folder, then MB could use those along with the standard colour tags for the other matches.

If the smaller icons don't exist, than MB uses the current default of only showing the large icon for the first match
if you set the max displayed to 2, MB would display icons ending in _x2.png, where they are 8x16 px
if you set the max displayed to 3, MB would display icons ending in _x3.png, where they are 5x16 px
if those named icons are not present for any active rule, only a single 16x16px icon is displayed for the first matching rule - there would need to be an x2 or x3 icon for every rule for this to work

does that match what you were thinking?
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Bee-liever on November 22, 2018, 09:04:35 PM
does that match what you were thinking?

Yes please!
(Hmmm.  How come it sounds so much better the way you have written it out?  ;)  )
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Steven on November 24, 2018, 06:09:46 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip

implemented ability to display multiple icons as well as described
if you set the max displayed to 2, MB would display icons ending in _x2.png, where they are 8x16 px
if you set the max displayed to 3, MB would display icons ending in _x3.png, where they are 5x16 px
if those named icons are not present for any active rule, only a single 16x16px icon is displayed for the first matching rule - there would need to be an x2 or x3 icon for every rule for this to work
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Bee-liever on November 25, 2018, 10:40:15 AM
Thank you Steven.  Looks good.

Although I didn't realise when you said:
- there would need to be an x2 or x3 icon for every rule for this to work
you also meant the ones you didn't have any icon assigned for  ???

Ah well. That was easily fixed.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Bee-liever on December 03, 2018, 06:57:47 PM
I noticed that the main Highlighting Rules Editor and the one for the Album Covers view, while having two separate and distinct rules list are sharing the matches displayed setting.

Is it possible to change Album Covers list so it has it's own "matches displayed" setting?
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Steven on December 03, 2018, 07:20:09 PM
for album covers, the functionality is unchanged (intentionally due to visual constraints) so only 1 rule is used. I see the dialog is showing the display count setting, so i will remove that
Title: Re: Ability to Display More Than One Highlight Rule
Post by: Bee-liever on December 04, 2018, 08:50:04 AM
for album covers, the functionality is unchanged (intentionally due to visual constraints) so only 1 rule is used. I see the dialog is showing the display count setting, so i will remove that

And I also worked out that when using icons here, I need to provide extra full-size ones labelled *_x2 and *_x3 respectively.
Title: Re: Ability to Display More Than One Highlight Rule
Post by: phred on February 11, 2022, 06:12:16 PM
I forgot you can also show the highlight field directly in the expanded panel of the Album Covers view.
Thats also implemented now
Steven-

If I read this correctly, opening the expanded view of an album (in album cover view) should show highlighting. While I do see the single highlight on the album cover itself (in the -not- expanded view) I do not see any highlight next to the track in the expanded view.

In the fields displayed config, I changed album artist to highlight as a test. The highlight rule is "no lyrics" and the two tracks showing do not have lyrics. Nor do they show the highlight, which you can see on the album cover at the top.

Unless I'm misunderstand your comment, I'm assuming the highlight color would appear as it does on tracks view - a red rectangle next to the track name.
(http://i.imgur.com/lRxfc7Tl.jpg) (https://i.imgur.com/lRxfc7T.jpg)