getmusicbee.com

Support => Developers' Area => Skins => Topic started by: Steven on September 12, 2018, 08:00:49 PM

Title: New default skin for v3.3 and "slim" icons
Post by: Steven on September 12, 2018, 08:00:49 PM
For v3.3 I am in the process of changing the default skin which is now based on an older Threshold skin from Alumni and of course endeavour1934 for many of the icons and design.
I have added a new skin setting:
Code
<element id="SlimIcons">true</element>


which causes some aspects of the layout to change, such as the default player icons, progress bar and some of the stock icons.
I think some skins would benefit from it. You are still in control of the icons that are overridable.

I would be interested in feedback about the new default skin so far and also whether the "slim icons" setting might be useful

https://getmusicbee.com/patches/MusicBee33_Patched.zip
unzip into the musicbee folder
run MusicBee33.exe and then choose the skin "MusicBee3Test"
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 12, 2018, 08:13:46 PM
Buttons (including Windows close button) are misaligned in preferences and some popup panels.
Yes, I think the slim icons give a more consistent look with other icons. But the progress bar is a little hard to tell from the background.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 12, 2018, 10:22:29 PM
Buttons (including Windows close button) are misaligned in preferences and some popup panels.
Yes, I think the slim icons give a more consistent look with other icons. But the progress bar is a little hard to tell from the background.
fixed now - same link
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 12, 2018, 10:30:42 PM
Yes, it's fixed.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: zkhcohen on September 13, 2018, 08:14:10 AM
I don't have a test environment set up atm.

Screenshots of the skin?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 13, 2018, 09:16:38 PM
You can unzip the files into an existing install without touching the existing MB install - there is no need to set up a separate test environment.

Here is a screenshot anyway:
(https://getmusicbee.com/images/forum/NewDefaultSkin2.jpg)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Alumni on September 14, 2018, 07:47:42 AM
Nice to see the default skin being refreshed. I like the new look.
As for the icons and buttons, will they be SVG based?
How about the addition of a default "dark" skin?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 15, 2018, 01:06:26 AM
I think this can be a good opportunity to add some improvements to the player bar UI.

1. Support hh:mm:ss format for long tracks

Two ideas:
- Add time format to "Configure Fields" setting under Preferences> Tags (2) settings
- Or clicking on a time column value could toggle to mmm:ss and hh:mm:ss format with progress bar cursor display simply following it.

2. Show the currently set volume level on tooltip when the mouse is over the volume slider

3. Some more noticeable indicators of whether the player is currently on (play/pause rather than stop)

- An optional skin element that sets the bg color of the display panel when it's on
- An optional spectrum visualizer mode that displays it on the background of display panel (yes, short and wide)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 15, 2018, 08:43:45 AM
As for the icons and buttons, will they be SVG based?
no, i wont implement direct loading of SVG images into MusicBee ie. only via the skin creator tool for the player panel.
However if anyone is willing to create 150% images for the icons then i would incorporate those

How about the addition of a default "dark" skin?
you mean when windows has dark mode enabled. Thats a good idea, but i would only do that if someone created a default dark skin thats similar to the new default skin as I simply dont have the time or skill to be good at it.


Also to provide some more clarity around this new "SlimIcons" setting. You can use it on any skin, and what it will (eventually) do is:
- use the same single px icons from the new default skin unless an override is provided
- use the new single px player controls for standard skins
- use single px icons where the icon cant be overriden eg. left/right panel collapse/expand icon
- narrow the progress bar
- adjust the fonts from Bold to Regular in various places (panel headers, default player panel text, etc)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 15, 2018, 08:48:51 AM
I think this can be a good opportunity to add some improvements to the player bar UI.

1. Support hh:mm:ss format for long tracks

Two ideas:
- Add time format to "Configure Fields" setting under Preferences> Tags (2) settings
- Or clicking on a time column value could toggle to mmm:ss and hh:mm:ss format with progress bar cursor display simply following it.

2. Show the currently set volume level on tooltip when the mouse is over the volume slider

3. Some more noticeable indicators of whether the player is currently on (play/pause rather than stop)

- An optional skin element that sets the bg color of the display panel when it's on
- An optional spectrum visualizer mode that displays it on the background of display panel (yes, short and wide)
i think i am fine with the first 2, but not sure what you mean with point 3
could you explain both of those some more?
For the spectrum visualiser, would the player controls layout overlap - i guess not so you would imagine the panel being higher (something like zune? not that i know how they did that fuzz effect)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 15, 2018, 03:42:50 PM
Something like the following mockups:

Stop / Playing / Spectrum on the background

(https://i.imgur.com/KUNGtAa.png)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 18, 2018, 07:05:07 PM
All Alumni/ endeavour1934's single px icons have now been incorporated directly into MB, so just by setting <element id="SlimIcons">true</element> will load the icons without the need to provide them in your skin.
Additionally it also includes 150% versions of the icons, so will look much sharper at high DPI resolutions

Lastly if anyone is interested, i could add a skin element to recolour the icons eg. you want to use them on a dark skin. But i wont do that unless someone says they want it



http://www.mediafire.com/file/p4tr75b8dt1bkr6/MusicBee33.zip
unzip into the musicbee folder
run MusicBee33.exe and then choose the skin "MusicBee3Test"
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 18, 2018, 08:42:25 PM
i could add a skin element to recolour the icons eg. you want to use them on a dark skin

That would be very useful when creating a skin in various background colors. I would assume it would work not just for the default icons but for custom icons (for inbox, music, etc) as well.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 18, 2018, 09:33:13 PM
I would assume it would work not just for the default icons but for custom icons (for inbox, music, etc) as well.
I only had in mind the new single px icons that would be the default for the slimicons setting. Thats because they are all the same colour and hence safe to recolour.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 18, 2018, 09:37:29 PM
OK. Still that would be useful.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 19, 2018, 07:47:33 PM
for the next 3.3 alpha i have added:
Code
IconColourOverride.Default fg=XXX
IconColourOverride.Disabled fg=XXX
IconColourOverride.Highlight fg=XXX
IconColourOverride.Highlight is used for the edit save button on mouse over, and IconColourOverride.Disabled is used on the back/forward buttons in the header

Its applied to most icons, except a few such as the rss podcast feed icon. However I am not sure how well this will work in practice as I can imagine you might not want it applied to some icons i have enabled this, so I will need feedback on icons it shouldnt be applied to
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 25, 2018, 06:18:37 PM
Includes the above icon colour override settings and I have also changed the default skin some more. I will have a look at the other requests next

https://getmusicbee.com/patches/MusicBee33_Patched.zip
unzip into the musicbee folder
run MusicBee33.exe and then choose the skin "MusicBee3Test". Delete the existing Skins\MusicBee3Test.xml skin if you installed an earlier version


(https://getmusicbee.com/images/forum/NewDefaultSkin2.jpg)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: alec.tron on September 25, 2018, 11:23:32 PM
Random chime in from the side line (as I saw a fair few newbies confused about this - and I miss it on computers where there's no dedicated hardware media keys...)... would be lovely if we could have a stop-button in the default UI ;)
Churs.
c.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: psychoadept on September 25, 2018, 11:48:35 PM
Random chime in from the side line (as I saw a fair few newbies confused about this - and I miss it on computers where there's no dedicated hardware media keys...)... would be lovely if we could have a stop-button in the default UI ;)
Churs.
c.

There is a stop button, you just have to press... I forget if it's ctrl or shift to make show up
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 26, 2018, 01:21:07 AM
Random chime in from the side line (as I saw a fair few newbies confused about this - and I miss it on computers where there's no dedicated hardware media keys...)... would be lovely if we could have a stop-button in the default UI ;)
Churs.
c.

Right click on the player bar> Panel layout > Show Stop Button
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 26, 2018, 01:40:14 AM
for the next 3.3 alpha i have added:
Code
IconColourOverride.Default fg=XXX
IconColourOverride.Disabled fg=XXX
IconColourOverride.Highlight fg=XXX
IconColourOverride.Highlight is used for the edit save button on mouse over, and IconColourOverride.Disabled is used on the back/forward buttons in the header

Its applied to most icons, except a few such as the rss podcast feed icon. However I am not sure how well this will work in practice as I can imagine you might not want it applied to some icons i have enabled this, so I will need feedback on icons it shouldnt be applied to

IconColourOverride.Default works well, but the other two elements have no effect.

Code
<element id="IconColourOverride.Default" fg="120,120,120" />
<element id="IconColourOverride.Disabled" fg="200,0,0" />
<element id="IconColourOverride.Highlight" fg="0,0,200" />

<element id="SlimIcons">true</element>

I think it works fine with most icons. Try yourself with this Dark Fine Tuned skin: https://www.dropbox.com/s/77v2qfhekxeg601/Onyx33.xmlc?dl=1
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 26, 2018, 01:45:10 AM
BTW can you support color overrides for the 4 elements Playing/PausedIcon.Default/Highlight that will use the default icons only in a different color?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: zkhcohen on September 26, 2018, 01:54:22 AM
Are 3.2.XX Changes being pushed to the 3.3 alpha or is it a fork?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 26, 2018, 02:02:39 AM
Are 3.2.XX Changes being pushed to the 3.3 alpha or is it a fork?

It's supposed to include all changes so far.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 26, 2018, 07:20:58 AM
MB33 won't launch with the following errors (PMed my settings file):
thats fixed now
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 26, 2018, 06:37:09 PM

IconColourOverride.Default works well, but the other two elements have no effect.

Code
<element id="IconColourOverride.Default" fg="120,120,120" />
<element id="IconColourOverride.Disabled" fg="200,0,0" />
<element id="IconColourOverride.Highlight" fg="0,0,200" />
for the back/forward buttons which is the only place i believe IconColourOverride.Disabled would be used, its getting overriden by Panel.HeaderButtonOverride.Disabled
so infact is redundant
Similarily for EditSave in the vertical tag editor which is the only place the .Highlight would be used, its also being overriden
So i will remove:
<element id="IconColourOverride.Disabled" fg="200,0,0" />
<element id="IconColourOverride.Highlight" fg="0,0,200" />


I think it works fine with most icons. Try yourself with this Dark Fine Tuned skin: https://www.dropbox.com/s/77v2qfhekxeg601/Onyx33.xmlc?dl=1
yes i agree it does appear to be working well

BTW can you support color overrides for the 4 elements Playing/PausedIcon.Default/Highlight that will use the default icons only in a different color?

Code
PlayingIconColourOverride.Default fg=XXX
PlayingIconColourOverride.Highlight fg=XXX
PausedIconColourOverride.Default fg=XXX
PausedIconColourOverride.Highlight fg=XXX
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 27, 2018, 12:08:11 AM
Thanks! the new elements work well.

I found one icon it shouldn't be applied - Apple Music logo in more albums tab of Music Explorer.

One more, alert icon. In some places it looks fine like in the album auto-tagger, but not in other places like in the tag manager.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 27, 2018, 07:48:14 AM
This is what i thought would happen where more and more exceptions will keep getting found. I will look into the ones you have reported
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 27, 2018, 07:49:09 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip

Fixes the reported recoloured icons.
Also has the volume tooltip (intentionally only shows when over the volume button only or the mouse wheeled) and now automatically shows hours.
Along with some other changes such as the Expanded Panel in the artwork layout now shows artists in the same way as the Album and Tracks layout ie. no longer on a separate line.
And the mini-player visualiser for the large artwork view is now on the bottom panel rather than over the darkened album artwork.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 27, 2018, 08:30:16 PM
Thanks for the improvement!

One thing I noticed is for tracks longer than 2 hours it doesn't show track duration and only shows track position. Can't it show the both?

Another issue is the slim icon setting. Are you gonna offer two default skins with it enabled and disabled? If so, I will have to offer the two versions too for the dark fine tuned skins. Or can that be a user setting?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on September 27, 2018, 08:54:48 PM
One thing I noticed is for tracks longer than 2 hours it doesn't show track duration and only shows track position. Can't it show the both?
thats fixed now

Another issue is the slim icon setting. Are you gonna offer two default skins with it enabled and disabled? If so, I will have to offer the two versions too for the dark fine tuned skins. Or can that be a user setting?
For the default skin, it will be the new one with the thin icons. The old skin will probably be available as "MusicBee3Classic"
For other skins that use the setting I am not sure as i can see in your case that would be a lot of skins if both are available. But also I dont want to have it as a user config setting because I imagine very few skins will implement it, so it just another confusing thing for users when it doesnt work
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on September 27, 2018, 09:07:18 PM
Yeah, I see your point. Thanks for the fix!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on October 02, 2018, 09:26:23 PM
for the next 3.3 alpha i have added:
Code
IconColourOverride.Default fg=XXX
also added if you want to use a specific colour when tabs/icons are displayed in the caption bar and the caption bar is a distinct colour from the main panels
Code
  <element id="CaptionBarIconColorOverride" fg="225,225,225" />
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on October 26, 2018, 11:25:14 AM
One more, alert icon. In some places it looks fine like in the album auto-tagger, but not in other places like in the tag manager.

Alert icon in the tag manager still gets recolored by IconColourOverride.Default when it shouldn't.
Also it shouldn't recolor AddTabIcon & AddTabIconInCaptionBar.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on October 27, 2018, 09:52:13 AM
Also it shouldn't recolor AddTabIcon & AddTabIconInCaptionBar.
why is this icon different to all others?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on October 27, 2018, 10:11:17 AM
Because it needs to be the same color as the text on the tabs bar. Without the icon overrides, MB auto-colors it with fg of TabsBar.Tab.Default.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on October 27, 2018, 10:50:39 AM
Because it needs to be the same color as the text on the tabs bar. Without the icon overrides, MB auto-colors it with fg of TabsBar.Tab.Default.
I can accept that
For the alert icon, I think we are starting to get into the grey area of icon recolouring handling needing to be different for the main panel. I will probably add a new color element for overriding icons in the main panel (eg. alert icon, zero rating icon)

edit:
if you provide a custom icon for the alert or zero rating icon, it now just uses what you include in the skin. Otherwise when no icon overrides are provided, MB will still apply the recolour value
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on October 27, 2018, 11:33:51 AM
Working fine now. Thanks!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 01, 2018, 05:04:40 PM
Noticed you have changed mini player love icons for 3.3 and I tried to override them, but they get recolored too. Can you make them (MiniPlayerLastFmLove, MiniPlayerLastFmLoveBright & MiniPlayerLastFmNotLove) exceptions too?

Another issue is in large picture view there's no way to love/rate since they get hidden under player controls.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 01, 2018, 06:56:43 PM
Noticed you have changed mini player love icons for 3.3 and I tried to override them, but they get recolored too. Can you make them (MiniPlayerLastFmLove, MiniPlayerLastFmLoveBright & MiniPlayerLastFmNotLove) exceptions too?

Another issue is in large picture view there's no way to love/rate since they get hidden under player controls.
looking at the code, only "MiniPlayerLastFmNotLove" is being recoloured. I will change that one for the next update

I am aware the rating handling is not great in that config. As long as you dont move the mouse too much above the ratings field it will stay displayed
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 02, 2018, 01:38:22 AM
looking at the code, only "MiniPlayerLastFmNotLove" is being recoloured. I will change that one for the next update

Thanks! Latest patch still doesn't work though it appears to have been updated (no need to rush. Just reporting in case you have included the change).

I am aware the rating handling is not great in that config. As long as you dont move the mouse too much above the ratings field it will stay displayed

I can see that works if the visualizer is not shown. With the visualizer shown below it, no way to access without hiding them.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 03, 2018, 10:53:40 AM
looking at the code, only "MiniPlayerLastFmNotLove" is being recoloured. I will change that one for the next update

Thanks! Latest patch still doesn't work though it appears to have been updated (no need to rush. Just reporting in case you have included the change).

I am aware the rating handling is not great in that config. As long as you dont move the mouse too much above the ratings field it will stay displayed

I can see that works if the visualizer is not shown. With the visualizer shown below it, no way to access without hiding them.
It should have been included. If its still not right, i will look into it further.

The mini-player handling is addressed now but still with the requirement not to move the mouse too far above the rating
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 03, 2018, 11:32:58 AM
MiniPlayerLastFmNotLove has no effect though MiniPlayerLastFmLoveBright is working.

Now I can love/rate in large picture view regardless of visualizer setting. Thanks!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 03, 2018, 10:39:39 PM
it should be fixed now
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 04, 2018, 04:16:51 AM
Yes, it's working now. Thanks!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 08, 2018, 11:30:42 AM
Noticed 3.3 now draws Windows caption buttons if they're not supplied. Can you support color overrides for those? That will make standard skins really small just like the new default skin and also make skinning easier.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 10, 2018, 04:49:43 PM
Noticed 3.3 now draws Windows caption buttons if they're not supplied. Can you support color overrides for those? That will make standard skins really small just like the new default skin and also make skinning easier.
i have added:
CaptionBarButtonColorOverride fg=xxx
CaptionBarButtonHighlightColorOverride bg=xxx

where CaptionBarButtonColorOverride is the symbol coloring and CaptionBarButtonHighlightColorOverride is the background when the mouse is over the button
as with Windows, the close button highlights with red
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 10, 2018, 06:40:08 PM
Thanks for the support!
Unfortunately all highlight images get recolored by IconColourOverride.Default.
Also can you support fg of CaptionBarButtonHighlightColorOverride too?

There's one more image that shouldn't get recolored. It's the default splash image when no custom splash image is supplied.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 10, 2018, 06:58:20 PM
Unfortunately all highlight images get recolored by IconColourOverride.Default.
Can you give me a specific example (element name) and post a screenshot? It might be obvious to you as you can see it, but its not easy for me to figure out exactly what you mean
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 10, 2018, 07:16:06 PM
PMed a test skin. See highlight images for caption buttons.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 10, 2018, 07:29:40 PM
thanks for sending the skin.
The reported issues should be fixed now

Also for the highlight image, i have added a fg as requested
CaptionBarButtonColorOverride fg=xxx
CaptionBarButtonHighlightColorOverride bg=xxx fg=xxx

https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 10, 2018, 07:33:22 PM
It's all working fine now. Thanks for the fix!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 11, 2018, 06:49:25 PM
The red love icon gets recolored in every place - all panels, players including compact/mini mode.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 11, 2018, 07:42:32 PM
the patched version is updated to not recolour that icon
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on November 11, 2018, 07:45:35 PM
It's fixed. Thanks!
Title: skin suggestions
Post by: colagen on November 20, 2018, 05:19:16 PM
Hi,

The default skin have been updated recently, it's now much cleaner and pleasant.
There is still some points which make the UI look a little bit old fashioned, so here they are. You could say that my eyes are too sensitive, and i won't deny : )

(https://thumb.ibb.co/ntm92A/musicbee-markers-on.png) (https://ibb.co/ntm92A) (https://thumb.ibb.co/koXSpq/musicbee-markers-off.png) (https://ibb.co/koXSpq)

1 : this close button attached to this tracklist stand out too much in my opinion. It's not an important UI element because you don't need to close this tracklist, you open a new one, or you scroll below, but who is gonna close it ? I think it would be more logical to put just a cross without any background, using the color of the tracks titles.

2 : The play button there is a little bit too big too. It's taller than the album name

3 : it would look better imho if the selected item background was full with, going under the scrollbar. The scrollbar would then just overlap the content, like most apps nowadays. On most skins, the scrollbar zone have the same background color than the whole column, so it would work and it would look more clean. The tracklist which extend below each albums cover could be full with also, it would look better. (But then there is more work to do in order to see the scrollbar even above a dark tracklist, so it's probably trickier to do)

4 : There is a little vertical gap between the top of each tab and the bottom of the caption bar. I think this gap is useless visually, it would be cleaner without it.

5 : there is too much horizontal space around those 4 buttons on the right. Generally on the whole control bar, the horizontal gaps between elements aren't distributed harmoniously/regularly.

6 : the selected item background isn't vertically aligned with the text inside

7 : The search bar looks old fashioned, with this very dark border

Apart from those point, the UI since this 3.3 update look a little bit more like a modern app, which is great.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 24, 2018, 10:22:53 PM
re: point 5, i did make some adjustments but cant remember if they were in the last official beta release.
Are you using the latest patch version?
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: colagen on November 25, 2018, 12:12:45 AM
Yes, v3.3.6902. Actually, the vertical and horizontal spaces depend of the layout options chosen for this control bar. That's why i use the wave seekbar, the vertical alignement of the elements is better with it (just one pixel too close to the bottom border though : )

I used to be a webdesigner, so i'm quite sensitive to that i guess.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 25, 2018, 10:57:48 AM
what font do you use and could you post the screenshot in full size?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: colagen on November 25, 2018, 01:04:52 PM
Default font on windows, so Segoe UI i guess.
The screenshots are fullsize, if you click on the tumbnail, it redirect to the fullsize version.
My screen isn't 72dpi though, it's higher (15.6'' and 1920x1080), but it doesn't seem to make a difference with 1366 x 768, and 100% text size on windows

Here is a different screen shot, without the wavebar, where the vertical misalignment is more obvious. And there is even more horizontal space lost around the elements, which could be used for a wider progress bar, imho
(https://i.ibb.co/09w4vCG/Untitled-1.png) (https://ibb.co/09w4vCG)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on November 26, 2018, 08:08:42 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip

i have made several tweaks so the spacing should be better. If you are going to post more screenshots then please post them full size
Title: Re: New default skin for v3.3 and "slim" icons
Post by: cptchi on November 29, 2018, 06:53:32 PM
Steven the new layout looks sooooooo good. This is crazy. I leave for a few months and MB gets so many changes. Keep up the good work.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on December 02, 2018, 09:53:47 AM
PlayingIconColourOverride.Default fg=XXX
PlayingIconColourOverride.Highlight fg=XXX
PausedIconColourOverride.Default fg=XXX
PausedIconColourOverride.Highlight fg=XXX

Would it be possible to make those work in the expanded panel of album covers view too? Also for the custom icons for those as they currently lose their color? If it interferes with auto-pick color option, can it work at least when the option is disabled?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on December 02, 2018, 08:13:26 PM
Also for the custom icons for those as they currently lose their color?
i dont understand this question

when the expanded panel has auto-colouring disabled, it now uses the icon override colours if set
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on December 02, 2018, 08:43:34 PM
Thanks for supporting it!

What I requested was to show the custom icons. But if I add those settings, it now shows the color. So never mind!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 19, 2019, 08:19:15 PM
When trying to load the 3.3 slim skin with MB v3.2, it fails with this error.

System.TypeInitializationException: The type initializer for '#=zWgVSKukqeXygRQzGXqeUxNg=' threw an exception. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at #=zWgVSKukqeXygRQzGXqeUxNg=..cctor()
   --- End of inner exception stack trace ---
   at #=zWgVSKukqeXygRQzGXqeUxNg=..ctor(Boolean #=zV9eAh3T8Ivy6eWUzPA==, Boolean #=zfKHrQhLCbj2d)
   at #=zxi2ztvXlrgvl0YoLwsbUcbLajWOM..ctor()
   at #=zl3G$ts$_9zIRoQdlmns30$2c9Koz.Main(String[] args)

Is it about Windows caption buttons? And is it possible you can make them working with 3.2 as well?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 19, 2019, 08:40:26 PM
i would need to make another v3.2 release that rejected those skins, but of course there would still be users who wont be using that update.
I can think of 3 ways to address the issue:
- include the caption bar images in the skin. I can send them to you if you want to use the same ones that i have
- only include the skin in the release package (as is the case for the default skin)
- give the skins a new extension that would be ignored by older MB versions but i really would prefer not to do that
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 19, 2019, 08:48:55 PM
For Dark-Fine Tuned skins, I will post a 3.3 slim version on the thread and some users will try to load with v3.2 after downloading them.
Can you send the images to me? If it has any issue with color match, I will include my own images.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 19, 2019, 09:11:41 PM
https://www.mediafire.com/file/jend0k94tpk79as/CaptionBarImages.zip/file
https://www.mediafire.com/file/s9qv85ceie8r706/CaptionBarImages_24.zip/file

use: CaptionBarButtonColorOverride to override the colours
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 19, 2019, 09:22:47 PM
use: CaptionBarButtonColorOverride to override the colours

But v3.2 won't read the element? If it can, no need to add images.

BTW doesn't it require 150%, 200% version for these icons for high DPI display? I only use SVG files for them, so I don't know how SkinCreator handles them.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 19, 2019, 09:40:28 PM
no v3.2 wont be able to apply that element
the skincreator should create the appropriate scaled bitmap images
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 19, 2019, 10:08:54 PM
I am still confused.

you can now supply 30x28px images for the close, minimimise, maximise, restore buttons
you still need to supply 28x15px images for backwards compatibility. Also make sure these new ones are after the existing 28x15px images
use FormMinimiseButton2, FormMaximiseButton2, FormRestoreButton2, FormCloseButton2, FormMinimiseHighlightButton2, FormMaximiseHighlightButton2, FormRestoreHighlightButton2, FormCloseHighlightButton2

So I have been supplying two kind of icons for them 28x15 & 30x28.
But your image files are 30x28 & 45x42.
Was this changed at some point?

Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 19, 2019, 10:18:05 PM
if you want the skin to work with all MB versions, you need the smaller sizes as well
since the slim icons only fully work with v3.3 and i am not making the skin openly available on a forum topic ie. its only in the release, i am not concerned about backward compatibility
the 45x42 is for 150% dpi scaling. If you are using the skin creator with SVG images then you dont need to worry about that
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 19, 2019, 10:22:47 PM
Then 28X15 icon support only helps users of pre-3.1 version of MB? Doesn't it matter with Windows version?
If so, I will stop supplying them as well.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 20, 2019, 06:53:59 AM
windows version doesnt matter and from memory pre v3.1 sounds correct
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 21, 2019, 02:59:38 AM
I have some suggestions about the way the new standard skin handles the four player controls on the right side (equalizer, last.fm, repeat, shuffle) as, in my view, they have some issues.

- Equalizer button shows the same color for both on and off. But the differences in their shape are not easy to tell unlike other controls.
- No mouse-over highlight color unlike the left-side controls. I know it shows tooltip instead, but they show up a little late and immediate color change would be more noticeable and assuring.
- They are not consistent across different player modes. For some reason, the default skin shows the same color for the sidebar player as the main player, if you use color overrides for them, they behave the same as compact/mini mode where those controls display disabled color when the main player show default color.

Try this code to see what I mean.
Code
<?xml version="1.0" encoding="utf-8"?>
<root dependsOn="MusicBee3.xmlc">
<element id="PlayerSidebar.Control.Default" fg="0,0,255" />
<element id="PlayerSidebar.Control.Disabled" fg="255,0,0" />
<element id="PlayerSidebar.Control.Highlight" fg="0,255,0" />
</root>
Here's a summary of my suggestions:
(https://i.imgur.com/D0yMtL5.png)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 21, 2019, 09:31:56 PM
i have made a number of changes:
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 22, 2019, 04:20:02 AM
Thanks! Now the controls on the main player are consistent with those on the sidebar player (except compact/mini mode). And the mouseover color is now used for those controls (not sure why they use auto-generated colors instead of PlayerFlat.Control.Highlight).
The problem is the differences between different color shades are hardly noticeable (especially with the default skin) because they are slim icons in 1px-width lines. They seem to require either a different hue or some background image (like Groove) for a mouseover image.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 22, 2019, 12:17:47 PM
Play/pause button & volume slider need to get moved 1px down to get vertically centered with other elements.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 23, 2019, 10:41:27 AM
Play/pause button & volume slider need to get moved 1px down to get vertically centered with other elements.
i spent quite a bit of time ensuring controls line up under various font and configuration settings so could you post a screenshot?
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 23, 2019, 11:03:55 AM
Sure.

(https://i.imgur.com/qpL2zGa.png)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 23, 2019, 11:12:51 AM
i need to see it in the context of everything else ie. the entire player panel, the dpi scale for your screen and also which font you are using
Title: Re: New default skin for v3.3 and "slim" icons
Post by: phred on May 23, 2019, 11:21:00 AM
Based strictly on the screenshot, it looks to me like play/pause needs to move down, while volume needs to move up.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 23, 2019, 11:32:09 AM
i need to see it in the context of everything else ie. the entire player panel, the dpi scale for your screen and also which font you are using

PMed my settings file. dpi is 100%. It happens with a fresh installation too when multiple lines option is enabled.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 23, 2019, 06:04:13 PM
Thanks for sending the settings file. Yes i can reproduce when using the slim icons and multiple lines or album cover is displayed.
It will be fixed for the next update

https://getmusicbee.com/patches/MusicBee33_Patched.zip

edit:
I also just updated it to always use PlayerFlat.Control.Highlight - not sure why i did the auto-colouring
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 23, 2019, 07:29:43 PM
Thanks! Now they look vertically aligned with those settings.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 23, 2019, 08:52:59 PM
I also just updated it to always use PlayerFlat.Control.Highlight

My slim version skins are working fine now but the default skin needs a different highlight color - very hard to tell a difference.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 24, 2019, 05:15:11 AM
Repeat One button has no mouseover image.

(https://i.imgur.com/mWyk4IN.png)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 24, 2019, 02:40:09 PM
Depending on the highlight color, icon can be almost invisible.

(https://i.imgur.com/9mRqoPg.png)

Would be great if you could support either fg2 for Panel.Body.Highlight and Panel.ChildBody.Highlight or a skin setting that forces fg to both text and icon for the two elements though I'd prefer the former.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 25, 2019, 05:38:03 AM
Any skins containing Compact.Player.MetroButton element doesn't display slim player controls properly when wavebar is enabled in compact mode.

(https://i.imgur.com/TV3L0cs.png)

It also disrupts vertical alignment of player controls in the main player when wavebar is enabled.

Try with the following code:

Code
<?xml version="1.0" encoding="utf-8"?>
<root dependsOn="MusicBee3.xmlc">
<element id="Compact.Player.MetroButton.Default" bdr="150,150,150" />
<element id="Compact.Player.MetroButton.Highlight" bdr="50,50,50" />
</root>
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 25, 2019, 09:09:12 AM
These are addressed for the next update. Note that metro buttons are not supported for slim icons due to their size
Repeat One button has no mouseover image.
Any skins containing Compact.Player.MetroButton element doesn't display slim player controls properly when wavebar is enabled in compact mode.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 25, 2019, 09:57:38 AM
Would be great if you could support either fg2 for Panel.Body.Highlight and Panel.ChildBody.Highlight or a skin setting that forces fg to both text and icon for the two elements though I'd prefer the former.
for the next update, when highlighted, the text colour is used
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 25, 2019, 11:03:44 AM
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 25, 2019, 12:02:17 PM
For some reason, again I still can't get the updated patch from the link. I had to use a proxy to download the latest one.

for the next update, when highlighted, the text colour is used

Thanks! But now it keeps showing the black color when lowlighted. Can you make it use the text color when lowlighted as well?

The album icon in library explorer has the same issue.

(https://i.imgur.com/6HWoVTC.png)
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 25, 2019, 01:48:58 PM
For some reason, again I still can't get the updated patch from the link. I had to use a proxy to download the latest one.

I found out other browsers are downloading the latest version properly, and it was an issue with Chrome that cached the file.
After clearing all cache, it now downloads the updated patch.

https://superuser.com/questions/344087/does-chrome-cache-a-downloaded-file
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 25, 2019, 09:48:50 PM
Thanks! But now it keeps showing the black color when lowlighted. Can you make it use the text color when lowlighted as well?
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 26, 2019, 01:11:41 AM
Thanks!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 26, 2019, 06:57:34 AM
These changes introduced a new bug. If you right-click on any library filter, all others nodes below it disappear from the left navigator.
I've PMed you all my slim version skins. Try with any of those, but for some reason this doesn't happen with the default skin.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 26, 2019, 07:54:32 AM
for some reason this doesn't happen with the default skin.

It's IconColourOverride.Default element that causes the issue.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on May 26, 2019, 08:15:38 AM
These changes introduced a new bug. If you right-click on any library filter, all others nodes below it disappear from the left navigator.
I've PMed you all my slim version skins. Try with any of those, but for some reason this doesn't happen with the default skin.
thats fixed for the next update

https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on May 26, 2019, 12:37:30 PM
It's fixed. Thanks!
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on June 16, 2019, 07:00:17 PM
Then 28X15 icon support only helps users of pre-3.1 version of MB? Doesn't it matter with Windows version?
If so, I will stop supplying them as well.

I noticed this icon is still used for the close button of tag/artwork manager. As I no longer supply them for my skins, the auto-generated mouse-over color for the button with dark skins is too dark (try with Dark-Fine Tuned skins). Can you fix it?
Otherwise, I'll have to update skins with the icons included.
Title: Re: New default skin for v3.3 and "slim" icons
Post by: Steven on June 16, 2019, 07:20:26 PM
this should work better:
https://getmusicbee.com/patches/MusicBee33_Patched.zip

the image is entirely auto-generated and does not use any included icons
Title: Re: New default skin for v3.3 and "slim" icons
Post by: redwing on June 16, 2019, 07:25:07 PM
the image is entirely auto-generated and does not use any included icons

I see. It works great now. Thanks for the fix!