getmusicbee.com

Support => Developers' Area => Skins => Topic started by: redwing on November 01, 2017, 02:35:10 PM

Title: Skinning Requests for 3.2
Post by: redwing on November 01, 2017, 02:35:10 PM
- Support for new (optional) player controls for bitmap skins: Play Previous/Next Album

- Image overrides for "UnknownAlbum" and "UnknownGenre"
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on November 09, 2017, 10:10:22 AM
override for highlight border in <element id="NowPlayingPopup.Body"
(I actually think bdr attribute use to do this in 2.5)
(https://i.imgur.com/7dFKWID.png)

support for extra "open Auto DJ settings" image in bitmap skins
(https://i.imgur.com/SjQUQF1.png)

support for highlight colouring on override "EditSave" icon
either as auto-colouring (as other icons in the header currently do) or the addition of an "EditSaveHighlight" image
(https://i.imgur.com/OG1tRmd.jpg)
Title: Re: Skinning Requests for 3.2
Post by: Alumni on December 07, 2017, 06:02:22 AM
I found out that Windows color accents can be read from the following registry key, maybe MusicBee could take advantage of these values?

Code
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Accent
Title: Re: Skinning Requests for 3.2
Post by: redwing on March 03, 2018, 08:34:18 AM
Support for bg/fg for tag editor or only for vertical tag editor.
Title: Re: Skinning Requests for 3.2
Post by: Steven on March 03, 2018, 09:10:51 AM
i will start looking at skinning requests in the next week or two
Title: Re: Skinning Requests for 3.2
Post by: Alumni on March 31, 2018, 01:30:55 PM
I was wondering what skin elements to edit for the playlist header bar?

As for requests, it would be helpful to have an override for the status bar if player controls are docked in the top panel.
Title: Re: Skinning Requests for 3.2
Post by: hiccup on March 31, 2018, 02:43:56 PM
I was wondering what skin elements to edit for the playlist header bar?

As for requests, it would be helpful to have an override for the status bar if player controls are docked in the top panel.

You should be able to find that with the help of: Sample Skin (https://getmusicbee.com/addons/skins/113/sample-skin/)
Title: Re: Skinning Requests for 3.2
Post by: redwing on March 31, 2018, 03:11:45 PM
I was wondering what skin elements to edit for the playlist header bar?

I think it's using bg and fg of MusicExplorerHeader element.

@Steven;

Can you support an override for that including bg2 for the gradient? Also support bg2 for MusicExplorerHeader element too.
Title: Re: Skinning Requests for 3.2
Post by: Steven on March 31, 2018, 06:33:34 PM
- Image overrides for "UnknownAlbum" and "UnknownGenre"
- Unknown album its already there as: "NoArtwork"
- I have added "UnknownGenre" for the next update. I recommend 128px for the 100%dpi image
Title: Re: Skinning Requests for 3.2
Post by: redwing on March 31, 2018, 07:04:11 PM
- Image overrides for "UnknownAlbum" ...
its already there as: "NoArtwork"

I meant the record image that thumbnail browser shows for "All Albums" item when "Album" is selected.
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 01, 2018, 01:02:25 PM
I was wondering what skin elements to edit for the playlist header bar?

I think it's using bg and fg of MusicExplorerHeader element.

Yes this does seem to be the case, except when auto-pick panel colors is enabled then it goes by that instead.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 01, 2018, 01:58:18 PM
override for highlight border in <element id="NowPlayingPopup.Body"
(I actually think bdr attribute use to do this in 2.5)
looking at the code, its always been hardcoded to grey. I have changed it to use the panel border colors if it is different to the background color

support for extra "open Auto DJ settings" image in bitmap skins
- for the next update, i have added "AutoDjSettingsButton". For reference, the MB one is 11x3px but it doesnt have to be the same size

I meant the record image that thumbnail browser shows for "All Albums" item when "Album" is selected.
- thats in the next update as "UnknownAlbumIcon"
- and in case you missed by edit: I have added "UnknownGenre" for the next update. I recommend 128px for the 100%dpi image
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 01, 2018, 02:13:43 PM
Would it be possible to override the image that pops up when dragging and dropping playlist items?
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 01, 2018, 03:56:01 PM
- thats in the next update as "UnknownAlbumIcon"
- and in case you missed by edit: I have added "UnknownGenre" for the next update. I recommend 128px for the 100%dpi image

Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 01, 2018, 04:26:16 PM
support for highlight colouring on override "EditSave" icon
either as auto-colouring (as other icons in the header currently do) or the addition of an "EditSaveHighlight" image
i have changed the default save button and default colouring to be consistent with the other buttons.
In all cases the highlight background/border is the same for all the buttons, including when you have a custom "EditSave" button
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 01, 2018, 07:22:53 PM
Support for bg/fg for tag editor or only for vertical tag editor.
done for the vertical tag editor in the next update:

<element id="VerticalTagEditor" bg="r,g,b" fg="r,g,b" />


http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 01, 2018, 10:04:41 PM
Would it be possible to override the image that pops up when dragging and dropping playlist items?
for the next update i have added
DragIcon - it needs to be 24x28px
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 01, 2018, 10:35:51 PM
I was wondering what skin elements to edit for the playlist header bar?

I think it's using bg and fg of MusicExplorerHeader element.

@Steven;

Can you support an override for that including bg2 for the gradient? Also support bg2 for MusicExplorerHeader element too.
The playlist header colour is generated from the album cover.
I can add support for bg2 on the MusicExplorerHeader element
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 02:37:04 AM
I was wondering what skin elements to edit for the playlist header bar?

I think it's using bg and fg of MusicExplorerHeader element.

@Steven;

Can you support an override for that including bg2 for the gradient? Also support bg2 for MusicExplorerHeader element too.
The playlist header colour is generated from the album cover.
I can add support for bg2 on the MusicExplorerHeader element

I'd like to use a different color (from Music Explorer header) for the panel when the auto-pick option is disabled.
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 03:52:40 AM
support for extra "open Auto DJ settings" image in bitmap skins
- for the next update, i have added "AutoDjSettingsButton". For reference, the MB one is 11x3px but it doesnt have to be the same size

Can you show me an example code?
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 08:35:31 AM
support for extra "open Auto DJ settings" image in bitmap skins
- for the next update, i have added "AutoDjSettingsButton". For reference, the MB one is 11x3px but it doesnt have to be the same size

Can you show me an example code?
Code
  <element id="AutoDjSettingsButton">
iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAA1klEQVQ4jc2SsUoDQRiE10IDIqTOAwRUMCCkTJuHUiwsBONjWKQ2r2B/qcI1WZJKrrjiyO3+8yEpxM4iJLsgEZx2mI/hn9+5fyXvfUfSA7AEPoGVpKe6ri+y4bIsz4B3SW9mNvDed2KM18BU0ryqqvMkwMzuJM2ccye7nqRXYJIESFpIGu7z2rbtS/rIATZN03QP+cDXvnZHbXCfucFLErCzwk1RFKcxxitgCqwl3SYBzv38wSPggS2wBp7NbAz4EMJlFnJIIYTRsSDL1FpZSer9Ovwn+gZY2cZuENOVQQAAAABJRU5ErkJggg==
  </element>
is it not working?
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 08:56:17 AM
It doesn't work. No need to adjust ShuffleButton element in the skin.xml file?
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 09:06:49 AM
it only works for standard player layout ie. if you are using a bitmap skin, its not supported
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 09:09:21 AM
OK. I thought it was for bitmap skins.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 10:58:28 AM
for the next update:
- in the playlist header, when auto-pick colours is disabled, then fg2 is now used (from the "MusicExplorerHeader" element)
- in the playlist header, bg2 from the MusicExplorerHeader element is now used
- in the playlist header, although fg2 is used, the "Edit Playlist" text is still slightly lightened
- in the music explorer header ("MusicExplorerHeader", a gradient background colour (bg2) is now supported
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 02, 2018, 11:08:30 AM
Is there a setting to make scrollbar corners square instead of rounded? If not that would be nice.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 11:34:42 AM
Is there a setting to make scrollbar corners square instead of rounded? If not that would be nice.
can you post a screenshot so i am sure what you mean
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on April 02, 2018, 12:13:35 PM
support for extra "open Auto DJ settings" image in bitmap skins
- for the next update, i have added "AutoDjSettingsButton". For reference, the MB one is 11x3px but it doesnt have to be the same size

it only works for standard player layout ie. if you are using a bitmap skin, its not supported

OK. I thought it was for bitmap skins.

Yeh. Me too. 'Cause that's what I originally requested  ???
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 02, 2018, 12:15:21 PM
Is there a setting to make scrollbar corners square instead of rounded? If not that would be nice.
can you post a screenshot so i am sure what you mean

This is what it currently looks like:

(https://i.imgur.com/dOWFo19.jpg)

Here's how I'd like it to look:

(https://i.imgur.com/0JIIctt.jpg)
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 12:59:32 PM
Is there a setting to make scrollbar corners square instead of rounded? If not that would be nice.
for the next update i have added:
Code
	<element id="ScrollBarSliderSquare">true</element>
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 01:33:34 PM
i think i have done all the requests except for this and the auto-dj settings in bitmap skins
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

- Support for new (optional) player controls for bitmap skins: Play Previous/Next Album
redwing, are you looking to replace the existing 2 controls or 2 extra, and how important is this to you?
I cant see this being done for standard skins, except perhaps as a functional setting applied against the existing buttons
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 01:50:48 PM
My plan was adding them as extra buttons for bitmap skins. If it's too much, then it's fine. They can be already added as toolbar buttons.

BTW can you support optionally adding stop button to the standard player bar in progress bar in middle layout?
To make things simple, the button can be really tiny without having to reposition other buttons when it's added. But it would be very useful.
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 02, 2018, 02:52:40 PM
i think i have done all the requests except for this and the auto-dj settings in bitmap skins
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

Bumping an earlier request in case you missed it (not a big deal though).

it would be helpful to have an override for the status bar if player controls are docked in the top panel
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 03:26:04 PM
it would be helpful to have an override for the status bar if player controls are docked in the top panel
Panel.StatusBar.Default and Panel.StatusBarControl.Default are the defaults
and
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are overrides when the player is docked at the top
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 03:45:13 PM
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are overrides when the player is docked at the top

No, those work when docked at the bottom.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 02, 2018, 04:57:18 PM
BTW can you support optionally adding stop button to the standard player bar in progress bar in middle layout?
To make things simple, the button can be really tiny without having to reposition other buttons when it's added. But it would be very useful.
yes thats fine and supported for the next update

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 02, 2018, 06:42:41 PM
Thanks! Working great!
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on April 02, 2018, 10:58:57 PM
it would be helpful to have an override for the status bar if player controls are docked in the top panel
Panel.StatusBar.Default and Panel.StatusBarControl.Default are the defaults
and
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are overrides when the player is docked at the top
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are overrides when the player is docked at the top

No, those work when docked at the bottom.

Panel.StatusBar.Default and Panel.StatusBarControl.Default are used when the status bar is below the player controls and docked in the bottom panel.
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are used when status bar is above the player bar when docked in the bottom panel OR the player controls are docked in the top panel.
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 03:02:22 AM
OR the player controls are docked in the top panel.

For me it always uses the two default elements when the player bar is docked at the top.
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 03, 2018, 05:02:52 AM
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are used when status bar is above the player bar when docked in the bottom panel OR the player controls are docked in the top panel.

As redwing said this is not how it works, when player controls are docked in the top panel the values used for the status bar are from Panel.StatusBar.Default and not Panel.StatusBarInPanel. If it worked the other way around it would solve my problem.
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on April 03, 2018, 07:19:19 AM
Panel.StatusBar.Default and Panel.StatusBarControl.Default are used when the status bar is below the player controls and docked in the bottom panel.
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are used when status bar is above the player bar when docked in the bottom panel OR the player controls are docked in the top panel.

Sorry redwing and Alumni, my apologies, you are correct!
I put the OR bit after the wrong element  :-[

It should have read:
Panel.StatusBar.Default and Panel.StatusBarControl.Default are used when the status bar is below the player controls and docked in the bottom panel OR the player controls are docked in the top panel.
Panel.StatusBarInPanel.Default and Panel.StatusBarControlInPanel.Default are used when status bar is above the player bar when docked in the bottom panel.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 07:46:00 AM
As redwing said this is not how it works, when player controls are docked in the top panel the values used for the status bar are from Panel.StatusBar.Default and not Panel.StatusBarInPanel. If it worked the other way around it would solve my problem.
is it that you need an extra setting for when the status bar is below the player but touching each other?
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 03, 2018, 08:04:51 AM
is it that you need an extra setting for when the status bar is below the player but touching each other?

Yeah, my goal is for the status bar to "blend in" with the player only when it's placed directly underneath.
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 03:12:07 PM
i have changed the default save button and default colouring to be consistent with the other buttons.
In all cases the highlight background/border is the same for all the buttons, including when you have a custom "EditSave" button

Can you support this for the vertical tag editor too? For some skins, it's not clear whether the mouse is over the save icon when you're trying to save.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 06:18:30 PM
i have changed the default save button and default colouring to be consistent with the other buttons.
In all cases the highlight background/border is the same for all the buttons, including when you have a custom "EditSave" button

Can you support this for the vertical tag editor too? For some skins, it's not clear whether the mouse is over the save icon when you're trying to save.
for the next update i have changed the vertical tag editor and also the main panel tag editor to use the same brightening algorithm thats used for all other controls
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 06:33:44 PM
is it that you need an extra setting for when the status bar is below the player but touching each other?
Yeah, my goal is for the status bar to "blend in" with the player only when it's placed directly underneath.
for the next update an additional override for when the status bar is on the bottom and the player is directly above it
Code
<element id="Panel.StatusBarBelowPlayer.Default" bg=xxx,xxx,xxx fg=xxx,xxx,xxx />
<element id="Panel.StatusBarControlBelowPlayer.Default" fg="xxx,xxx,xxx" />



http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 06:44:27 PM
A minor bug with Auto-DJ settings:
That panel has two slider bars and while slider buttons are using Controls.SliderButton.Default/Disabled elements, slide bars don't use Controls.SliderBar.Default/Disabled elements.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 06:59:01 PM
A minor bug with Auto-DJ settings:
That panel has two slider bars and while slider buttons are using Controls.SliderButton.Default/Disabled elements, slide bars don't use Controls.SliderBar.Default/Disabled elements.
it looks like i intentionally coded it that way and i vaguely recall there was a reason so would prefer to leave as-is
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 07:05:59 PM
i have changed the default save button and default colouring to be consistent with the other buttons.
In all cases the highlight background/border is the same for all the buttons, including when you have a custom "EditSave" button

Can you support this for the vertical tag editor too? For some skins, it's not clear whether the mouse is over the save icon when you're trying to save.
for the next update i have changed the vertical tag editor and also the main panel tag editor to use the same brightening algorithm thats used for all other controls

Thanks! It works better. But still the color change looks subtle. For instance, the color of the icon changes from 150,150,150 to 170,170,170 with the default skin.
How about adding the highlight background too just as the main panel tag editor had in the previous version?
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 07:17:04 PM
sorry but no. The main panel tag editor was done that way for historical reasons and not consistent with how all other controls are brightened. The Vertical Tag editor was done yet another way, but now its all the same
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 07:29:46 PM
OK. Still it would be great if you support "EditSaveHighlight" image to override the auto-coloring.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 07:38:13 PM
i could do that but which skin do you not think the auto-colouring is not working well enough? (not promising to change it)

edit:
for the next update i have bumped up the brightness for dark skins
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 07:55:14 PM
Almost all skins have some issues either with main panel tag editor or with vertical tag editor.

This is an example of Dark Fine Tuned skin.
The top two are normal and the bottom two are with the mouse over.
The left one is main panel tag editor and the right one is vertical tag editor.

(https://i.imgur.com/nTK3lEi.png)

Can you notice the differences easily?
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 08:03:05 PM
for the next update i have bumped up the brightness for dark skins

Light skins have issues too. Try with Pastels skin.
I'd appreciate if you support "EditSaveHighlight" image. I'd like to make clear contrast between the two images.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 08:12:58 PM
A new version is available adjusted for all skins. I would rather get the auto-colouring working better as its used in many places
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 08:27:33 PM
I can see you bumped up about +10 in RGB values. A little more noticeable.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 09:15:36 PM
I have tweaked it some more. Personally i think its fine now with dark skins but i do agree some of the neutral/ multi-colour skins need more tweaking
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 03, 2018, 09:49:30 PM
The custom EditSave image doesn't show up for vertical tag editor. Is it intended?
How about showing the highlight close button for the main panel tag editor's close button too?
It shows only when floating, not when docked at the bottom.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 03, 2018, 10:01:30 PM
The custom EditSave image doesn't show up for vertical tag editor. Is it intended?
yes, as the header colours could be very different
Title: Re: Skinning Requests for 3.2
Post by: hiccup on April 04, 2018, 07:23:56 AM
The borders for the icons in the tag editor panel are no longer showing at mouse-over:

It was like this:

(https://i.imgur.com/yImwZIr.png)

(https://i.imgur.com/6H6Gyti.png)

Now you can hardly notice a mouse-over:

(https://i.imgur.com/31B92UJ.png)

(Sportura Pinstripe)
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 04, 2018, 03:08:29 PM
When grouping header is enabled in Album & Tracks compact grid view, splitter line color is not following Content[AlbumAndTracks].ArtistSplitterLine element. It only works in detailed view. Also compact view uses another splitter line just below sub-header. Looks like we need new elements for them.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 04, 2018, 07:13:44 PM
Now you can hardly notice a mouse-over:

(https://i.imgur.com/31B92UJ.png)

(Sportura Pinstripe)
i have tweaked it further for dark skins. For the next update the adjustment is now very similar to what you are using on the player controls
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 04, 2018, 07:23:24 PM
The custom EditSave image doesn't show up for vertical tag editor. Is it intended?
yes, as the header colours could be very different
maybe it would be better to keep them the same, so i will also implement it on the vertical tag editor
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 04, 2018, 08:11:59 PM
When grouping header is enabled in Album & Tracks compact grid view, splitter line color is not following Content[AlbumAndTracks].ArtistSplitterLine element. It only works in detailed view. Also compact view uses another splitter line just below sub-header. Looks like we need new elements for them.
the change was intentional
the following are overrides for the next update:
Code
<element id="Content[AlbumAndTracks].GridHeaderSplitterLine" bg=xxx,xxx,xxx />
<element id="Content[AlbumAndTracks].GridTrackSplitterLine" bg=xxx,xxx,xxx />
the track splitter line is only used if there are no alternating row colours set (or the same)
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 04, 2018, 08:30:48 PM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: hiccup on April 04, 2018, 08:51:29 PM
I believe the recent changes to the tag editor panel icons are a a deterioration.

Just checking another skin (Jistme the Bee), and that one also looked much better before the change.

It used to be like this:
(https://i.imgur.com/FNeCstA.png)

and now:
(https://i.imgur.com/eXisfx1.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 04, 2018, 09:16:47 PM
thats because you are not using a transparent background on the image. Its easy enough to make MB apply transparency
Title: Re: Skinning Requests for 3.2
Post by: hiccup on April 04, 2018, 09:21:26 PM
thats because you are not using a transparent background on the image. Its easy enough to make MB apply transparency

So adding transparency will bring back the borders on highlight?
Then I will try that and change my affected skins accordingly.
But it's still a pity for older skins that are no longer maintained that might suffer from the recent change.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 04, 2018, 09:27:47 PM
no, it will make the highlighting work better
redownload the latest version to see what i mean
Title: Re: Skinning Requests for 3.2
Post by: hiccup on April 05, 2018, 10:21:52 AM
no, it will make the highlighting work better
redownload the latest version to see what i mean

It's a little bit better, but still worse for many skins compared to how it was before.
And it's not only about the save icon, it's about the other command icons located there also.

For skins that have highlight borders on these icons, it was carefully designed like that on purpose.
Removing these borders affects them in a negative way.


Just two other skins where the highlighting has gotten worse:

It used to show like this:
(https://i.imgur.com/MaVH7YO.png)

And now it's like this:
(https://i.imgur.com/HTfTwop.png)

I hope something can be done that will not break the designs of existing skins.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 05, 2018, 06:26:55 PM
for the next update, images that are already very bright and near the 255 limit will be dimmed instead on mouse over

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 05, 2018, 09:10:24 PM
- I have added "UnknownGenre" for the next update. I recommend 128px for the 100%dpi image

Why does this element work differently from other icons? Can't I override its color? With Dark Fine Tuned skin, it always changes the image color to some grey one.

Also can you support an element to override the background of the genre icon in thumbnail browser that shows for "all genres" item? For other unknown- images, I can use its own bg color to override it. But it doesn't work for the genre icon since it's also used for music explorer.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 05, 2018, 09:20:02 PM
would it work ok if the icon override is only used in the thumb browser and i will leave the music explorer one to use the standard icon?

Controls.GenreThumb fg=xxx,xxx,xxx re-colours the standard genre icon (and mistakenly the override icon as well but thats fixed for the next update)
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 05, 2018, 09:31:23 PM
would it work ok if the icon override is only used in the thumb browser and i will leave the music explorer one to use the standard icon?

Controls.GenreThumb fg=xxx,xxx,xxx re-colours the standard genre icon (and mistakenly the override icon as well but thats fixed for the next update)

Thanks! With Controls.GenreThumb element removed, music explorer icon now shows its own color, but not for the genre icon in thumbnail browser. If I have to choose one, this way would work better than not being able to override music explorer icon.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 05, 2018, 09:44:17 PM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
The genre icon override now only applies to the thumb browser and as such the recommended size is now 70px
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 05, 2018, 09:58:40 PM
So Controls.GenreThumb is still needed as it now colors genre icon in music explorer node.

The genre icon override now only applies to the thumb browser and as such the recommended size is now 70px

I noticed if the size is a little bigger or smaller, all genres item shows artist or album picture. It doesn't happen with other unknown icons when the same size of image is used.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 05, 2018, 10:00:58 PM
I noticed if the size is a little bigger or smaller, all genres item shows artist or album picture. It doesn't happen with other unknown icons when the same size of image is used.
i dont understand. Perhaps you could post a screenshot?
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 05, 2018, 10:07:10 PM
[link removed]

This doesn't happen with UnknownAlbumIcon element when the same small image is used.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 05, 2018, 10:18:59 PM
its the same now
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 05, 2018, 10:24:20 PM
Yes, it's fixed.
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 06, 2018, 11:27:15 AM
Regarding the mouse-over color for the buttons on the tag editor header, I see you have tweaked brightness a bit more, but still that doesn't work well for most skins. You should compare it with floating mode where it uses buttons with highlight color.
I think tweaking brightness is not enough, it needs to change hue. It would work best if it uses the bg of Controls.Button.Highlight for the mouse-over color, but other auto-generated colors would be also fine as long as its hue is distinctively different.
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on April 09, 2018, 05:52:05 AM
For the Large Album layout, the main panel area can already be overridden by:
<element id="Content[NowPlaying].Body.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
but if a scrollbar is displayed it uses the colours from Panel.ScrollBar.Default (or Panel.ChildBody.ScrollBar [if used]).

Could we please have:
<element id="Content[NowPlaying].ScrollBar" bg="X,X,X" bdr="X,X,X" />
<element id="Content[NowPlaying].ScrollBar.Lowlight" bg="X,X,X" bdr="X,X,X" />

OR

the thin scrollbar that is used in Artist Picture / Album Colour Mix.
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 10, 2018, 06:23:29 PM
these have been added and apply to when the Large Album view is used in the Now Playing panel:
Code
<element id="Content[NowPlaying].ScrollBar" bg="X,X,X" bdr="X,X,X" />
<element id="Content[NowPlaying].ScrollBar.Lowlight" bg="X,X,X" bdr="X,X,X" />
<element id="Content[NowPlaying].ScrollBarThumb" bg="X,X,X" bg2="X,X,X" fg="X,X,X" />
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 11, 2018, 09:19:05 AM
Correct me if I'm wrong, but it seems track info text in wavebar (bitmap) layout is only supported for multi-line text.
Would it be possible to add support for single line text, positioned above the wavebar?
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on April 11, 2018, 12:21:54 PM
these have been added and apply to when the Large Album view is used in the Now Playing panel:
Thank you!  :)

-----------------------------------------------------

Just a minor misalignment, noticeable in multi-colour skins.

(http://i.cubeupload.com/xIzNnh.jpg)

Controls.VerticalMenu is 4px short of matching InputPanel.Default (see Mellon Remix or Future Shock skins)
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 11, 2018, 06:56:10 PM
Controls.VerticalMenu is 4px short of matching InputPanel.Default (see Mellon Remix or Future Shock skins)
thats fixed for the next update
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on April 13, 2018, 11:53:47 AM
Controls.VerticalMenu is 4px short of matching InputPanel.Default (see Mellon Remix or Future Shock skins)
thats fixed for the next update
My OCD thanks you  :D

___________________________

Currently the fg of <element id="VolumeVisualiser" /> controls both the text (channels and dB levels) and the base visualiser colour.

Could we please have:
<element id="VolumeVisualiserText" fg="X,X,X" />
to override just the text part.
For some skins I'd like to be able to create greater contrast in the colours of the visualiser, but still have the text match the majority of text in the other panels.
Title: Re: Skinning Requests for 3.2
Post by: redwing on April 13, 2018, 03:36:30 PM
Could we please have:
<element id="VolumeVisualiserText" fg="X,X,X" />

+1
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 14, 2018, 04:42:16 PM
<element id="VolumeVisualiserText" fg="X,X,X" />
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: Alumni on April 22, 2018, 11:24:11 AM
The playlist header's album artwork placeholder seems to be auto-generated. Could it instead use custom images supplied with "NoArtwork" or "AlbumIcon" elements?
Title: Re: Skinning Requests for 3.2
Post by: Steven on April 22, 2018, 05:28:40 PM
The playlist header's album artwork placeholder seems to be auto-generated. Could it instead use custom images supplied with "NoArtwork" or "AlbumIcon" elements?
the next update will use the new "UnknownAlbumIcon" override image when present. That image is used for the thumb browser


http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 12, 2018, 03:23:21 PM
Is there any interest in having a setting that tells MB to automatically recolour the player controls panel and the controls based on the album cover?
I think some of the skins would work quite well with that.
It would require using one colour for all the controls and setting the alpha on each control as appropriate
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 13, 2018, 11:19:55 AM
Is there any interest in having a setting that tells MB to automatically recolour the player controls panel and the controls based on the album cover?
I think some of the skins would work quite well with that.
It would require using one colour for all the controls and setting the alpha on each control as appropriate

It's funny you should mention that, I have been thinking about the same thing. I believe Windows is already doing something similar with Groove Music, for example;
https://news-cdn.softpedia.com/images/news2/fluent-design-now-available-for-all-windows-10-users-in-latest-groove-update-516211-6.jpg
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 13, 2018, 11:28:20 AM
It was actually your threshold light skin that i was looking at but i think it could work well with any neutral skin.
As mentioned, the panel controls would need to be the same colour in the bitmap skin, using alpha values as appropriate, and MB would choose the fg and bg for everything in the panel based on the album cover, preserving the alpha values.
Also its recommended to set:
<element id="WindowBorderWidth">0</element>
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 14, 2018, 09:25:43 AM
It was actually your threshold light skin that i was looking at but i think it could work well with any neutral skin.
As mentioned, the panel controls would need to be the same colour in the bitmap skin, using alpha values as appropriate, and MB would choose the fg and bg for everything in the panel based on the album cover, preserving the alpha values.
Also its recommended to set:
<element id="WindowBorderWidth">0</element>

I look forward to experimenting with it.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 14, 2018, 08:16:31 PM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

note i have only tested this against the ThresholdLight skin. Its possible some buttons might cause an issue (rendering issue) so let me know if that does happen

all you need to do is set:
Code
<element id="PlayerAutoColor">true</element>

here is a simple way to experiment with it without having to edit the original bitmap skin:
Code
<?xml version="1.0" encoding="utf-8"?>
<root dependsOn="ThresholdLight.xmlc">
<element id="PlayerAutoColor">true</element>
<element id="WindowBorderWidth">0</element>
</root>

note your skin should use a single background colour and for volume button, progress bar, and progress button, MB will search for the skin background colour and make the parts of those controls with that colour transparent. For the progress and volume buttons, any parts that are not the button edge colour will be made transparent or semi transparent (this is needed to handle the type of buttons used in the threashold skin). If thats a problem for your skin let me know and i will add a setting to disable the behaviour
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 15, 2018, 10:58:37 AM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

note i have only tested this against the ThresholdLight skin. Its possible some buttons might cause an issue (rendering issue) so let me know if that does happen

all you need to do is set:
Code
<element id="PlayerAutoColor">true</element>

here is a simple way to experiment with it without having to edit the original bitmap skin:
Code
<?xml version="1.0" encoding="utf-8"?>
<root dependsOn="ThresholdLight.xmlc">
<element id="PlayerAutoColor">true</element>
<element id="WindowBorderWidth">0</element>
</root>

note your skin should use a single background colour and for volume button, progress bar, and progress button, MB will search for the skin background colour and make the parts of those controls with that colour transparent. For the progress and volume buttons, any parts that are not the button edge colour will be made transparent or semi transparent (this is needed to handle the type of buttons used in the threashold skin). If thats a problem for your skin let me know and i will add a setting to disable the behaviour

Nice! This is working rather well so far. If I may make a suggestion, I think it would make sense if the player controls are never inverted (from white to black), but rather limit the background color's maximum brightness to still maintain readability. As it is now this seems to only affect some shades of yellow and green.

PS: Do you plan on adding a toggle inside MusicBee to enable/disable auto-coloring?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 04:57:29 PM
automatically recolour the player controls panel and the controls based on the album cover

It looks good with Dark Fine Tunes skins as well.

Though most of bitmap skins of mine either freeze or won't start (probably because they use multiple bg colors) I don't think this feature will fit them well anyway. This would look nice mostly with either black or white skins. I will change Pastels skins to use the default player for 3.2, so they will also benefit from this feature.

But I think this should be a user setting (panel layout option of player bar) rather than a skin setting. How about adding this as an option and disable it when it detects multiple bg colors, etc.? Another approach would be to force the default player bar if it's not supported for the bitmap player bar when this option is enabled.

Also it would be great this feature supports compact and mini player mode as well.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 06:09:37 PM
Ideally this would be another user setting for any skin, but i think its going to be too difficult to achieve that and too much effort.

What I plan to do is support the following 21 skin settings
<element id="PlayerAutoColor">true</element>
<element id="PlayerAutoColorDefault">true</element>

- The first indicates auto-colouring works with the skin and that the skin has been designed with this in mind
- The second indicates whether auto-colouring is enabled by default. If not provided, default will be true
The user will be able to toggle the auto-colouring for skins that have the "PlayerAutoColor" setting

I will have a look at whats involved for the compact player and mini-player


If I may make a suggestion, I think it would make sense if the player controls are never inverted (from white to black), but rather limit the background color's maximum brightness to still maintain readability. As it is now this seems to only affect some shades of yellow and green.
that was the plan but i see yellow is defeating the algorithm so i will make some further tweaks


I will change Pastels skins to use the default player for 3.2, so they will also benefit from this feature.
currently the functionality only works with custom bitmap skins or derived from custom bitmap skins
I just tried with a pastel skin and i see a couple more tweaks are needed

edit:
On further thought i will just leave it up to the user to disable the auto-colouring setting. You will still need to set: <element id="PlayerAutoColor">true</element>
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 06:49:34 PM
currently the functionality only works with custom bitmap skins or derived from custom bitmap skins

For me it works with xml skins as well with the two lines added.

BTW can't it work with DisableSinglePxBorder setting enabled?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 07:03:59 PM
I just tried and it works fine without WindowBorderWidth set to 0. Then DisableSinglePxBorder setting works fine.
So is that setting not really needed?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 07:15:00 PM
Clicking on restore/maximize button changes player controls colors when this feature is enabled.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 07:16:33 PM
For me it works with xml skins as well with the two lines added.

BTW can't it work with DisableSinglePxBorder setting enabled?
you will find the progress bar doesnt display properly, at least for the skins i tried plus there are sections of code not implemented for standard layouts.

DisableSinglePxBorder works and you dont have to set WindowBorderWidth = 0, but you have a 1px or 4px border un-coloured border around the player panel depending on the windows version. I guess it might not be too bad if its a dark skin

Clicking on restore/maximize button changes player controls colors when this feature is enabled.
working fine here. Are you using a custom bitmap skin and if so which one?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 07:24:24 PM
Try with Dark Fine Tuned skins.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 07:35:51 PM
Thats using the standard player layout so it will mis-behave and the progress bar wont work properly.
If you want to implement it, i will look at whats involved. I guess it will make the feature more obvious if more skins can support it
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 07:37:46 PM
Yes, please support the feature for the default player bar.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 09:48:10 PM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

this version now supports standard skins and user control over the auto-colouring
right click/ Panel Layout/ Auto-Pick Panel Colours
For custom skins, <element id="PlayerAutoColor">true</element> is still required so the user has the option to choose auto-colouring

@redwing, I wasnt able to reproduce the bug when resizing. Its possible i already fixed it without realising but if it still happens let me know the details.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 10:06:21 PM
Still happening. If you use metro buttons, it will be more obvious.

(https://i.imgur.com/GLBBx0Z.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 10:15:54 PM
i will need your settings file as i still cant reproduce this. If you minimise and restore MB are the invalid colours still displayed?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 10:16:45 PM
So the problem is that when resized the player controls and volume slider button start using their original colors.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 10:18:48 PM
yes i expected that but i cant reproduce. If you minimise and restore MB are the invalid colours still displayed?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 10:22:53 PM
PMed the settings file.

Minimize has no issue. Only restore/maximize. Yes, it keeps the changed colors.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 15, 2018, 10:33:27 PM
i can reproduce with your settings and it should be fixed now if you re-download.

I see the volume button when in text mode is not coloured and i will fix that for the next update
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 15, 2018, 10:36:37 PM
Working fine now. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 16, 2018, 05:52:32 AM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

this version now supports standard skins and user control over the auto-colouring
right click/ Panel Layout/ Auto-Pick Panel Colours
For custom skins, <element id="PlayerAutoColor">true</element> is still required so the user has the option to choose auto-colouring

Cool, I have added support to my most recent skin (link (https://getmusicbee.com/forum/index.php?topic=24964.0)).

By the way, have you thought about optionally displaying a gradient/blur effect for the auto-picked color player background?
Title: Re: Skinning Requests for 3.2
Post by: Sizzlinol on May 16, 2018, 05:05:48 PM
Regarding the auto-pick panel colors, I made a mockup of how it would (kind of) look like if it would use the same colours as the gradient-less expanded album panel. I think this would be an improvement in terms of contrast and consistency, and it also looks truer to the actual album covers in most cases. Oh, and please ignore those horrible player controls I created. They only showcase the colour changes. The player controls on the left side could also get their colours from the expanded panel's generated fg colour instead (in this case black; was too lazy to change it before posting), and on mouse-over the controls could turn blue (which is in this case the actual highlight colour). I would probably prefer this, too.

Below you can see how it is implemented as of now. Above my suggestion in comparison. Just a thought. :)

___

(https://i.imgur.com/cS3UAoW.png)
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 16, 2018, 05:10:28 PM
I just tried with a pastel skin and i see a couple more tweaks are needed

It looks better except the progress bar with a dotted line. Can you improve that? If it's not easy, never mind. I'll change to default player bar.

have you thought about optionally displaying a gradient/blur effect for the auto-picked color player background?

That's a good idea. It could give solid / blurred color option.

I tested with various album covers and I think the algorithm could improve a little.
The colors it picks up are too dark. No light colors at all. Also most white background covers are picked up as yellow/greenish color that makes no differences with real yellow/green colored covers. Why not use light grey instead for them?
The overall colors it shows are not so diverse and you only see some similar colors all the time out of various colors of covers.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 16, 2018, 05:59:33 PM
I just tried with a pastel skin and i see a couple more tweaks are needed
It looks better except the progress bar with a dotted line. Can you improve that? If it's not easy, never mind. I'll change to default player bar.
you will need to change it to use a single colour or at least not use the panel background colour (based on the top left pixel)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 16, 2018, 06:37:50 PM
I tested with various album covers and I think the algorithm could improve a little.
The colors it picks up are too dark. No light colors at all. Also most white background covers are picked up as yellow/greenish color that makes no differences with real yellow/green colored covers. Why not use light grey instead for them?
The overall colors it shows are not so diverse and you only see some similar colors all the time out of various colors of covers.
While i do agree the colours are not so diverse, the darkness is intentional to ensure the controls are always strongly visible. I think darkness works best with both dark and neutral skins, whereas light colours can look too bright on dark skins or "mushy" on neutral skins.
I will spend some time on the weekend experimenting some more though. Having a quick look at the colours used by Groove, it appears to go down the same route (I may be proved wrong but thats what i am seeing for some bright album covers)
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 16, 2018, 06:59:09 PM
I just tried with a pastel skin and i see a couple more tweaks are needed
It looks better except the progress bar with a dotted line. Can you improve that? If it's not easy, never mind. I'll change to default player bar.
you will need to change it to use a single colour or at least not use the panel background colour (based on the top left pixel)

I fixed the dotted line. It was about the shape of progress bar. I changed it from a rounded to a squared rectangle.
Is it possible to show different colors for progress bar and fill like the default player bar? (also for volume slider and player buttons in different states)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 16, 2018, 07:10:30 PM
I fixed the dotted line. It was about the shape of progress bar. I changed it from a rounded to a squared rectangle.
Is it possible to show different colors for progress bar and fill like the default player bar? (also for volume slider and player buttons in different states)
its no problem for the progress and volume slider (will be set to 50%)
for the player buttons, thats more problematic because of the way other skins handle that. I guess i can add a setting to instruct MB to use the same highlighting approach as default skins
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 16, 2018, 07:19:05 PM
That sounds good. And what I meant for the progress bar and volume slider is all different colors for the button / bar / fill like the default one.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 16, 2018, 08:22:56 PM
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

without doing anything, the contrast should be better for a number of the controls.

when the following is set, it will behave much closer to the contrasts used by standard skins
Code
<element id="PlayerAutoColorUsingStandardSkinRules">true</element>
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 16, 2018, 08:55:36 PM
Thanks! It's working great.

The only remaining issue with Pastels skins is its circled progress button is not rendered properly. Do you think you can improve it, or I need to change its shape?

(https://i.imgur.com/73J0kHr.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 16, 2018, 09:02:17 PM
the reason will be because you are using different colours, even small differences. Different alpha is OK.
MB detects the first edge colour and then applies different levels of transparency to account for the differences.
If its a problem i guess the new setting could override that so MB just blindly recolours the button preserving the alpha
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 16, 2018, 09:15:34 PM
the reason will be because you are using different colours, even small differences. Different alpha is OK.

I tried that. But it only makes the inner color of button more homogeneous with no improvement in rendering the circle shape.

(https://i.imgur.com/PyJhkxL.png)

If its a problem i guess the new setting could override that so MB just blindly recolours the button preserving the alpha

I'd like to try that to see if it works.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 16, 2018, 10:22:53 PM
the button colouring now uses the PlayerAutoColorUsingStandardSkinRules setting
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 16, 2018, 11:02:20 PM
the button colouring now uses the PlayerAutoColorUsingStandardSkinRules setting

That fixed the issue. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 17, 2018, 01:43:53 AM
While i do agree the colours are not so diverse, the darkness is intentional to ensure the controls are always strongly visible. I think darkness works best with both dark and neutral skins, whereas light colours can look too bright on dark skins or "mushy" on neutral skins.
I will spend some time on the weekend experimenting some more though. Having a quick look at the colours used by Groove, it appears to go down the same route (I may be proved wrong but thats what i am seeing for some bright album covers)

I'm not sure if it still works this way, but the last time I used it Groove Music would apply your personalized color accent to the playing controls background. At the time Windows 10 only let you choose between the built-in 48 preset colors, all of which seemed to pair nicely with Groove's interface.

On an unrelated subject, I have a request for the volume slider in bitmap skins - would it be possible to make the volume indicator icon automatically toggle to the "muted" status when the volume slider is lowered to zero?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 17, 2018, 07:08:34 AM
I just tried with a pastel skin and i see a couple more tweaks are needed
It looks better except the progress bar with a dotted line. Can you improve that? If it's not easy, never mind. I'll change to default player bar.
I realise now what the issue is with the progress bar in the pastel skin and will be fixed for the next update, so you can revert it back to using rounded corners if you wish
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 17, 2018, 04:24:34 PM
I realise now what the issue is with the progress bar in the pastel skin and will be fixed for the next update, so you can revert it back to using rounded corners if you wish

That'd be great. Thanks!

One issue with this feature is that enabling/disabling the option requires a restart, which is not obvious. What happens if it's in the middle of file saving for lots of files, volume analysis, or file conversion? Maybe it should pop up a confirmation window in such a case asking if the user really wants a restart.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 17, 2018, 08:25:40 PM
I have been experimenting with using a blurred album cover to give the panel colours some texture. It can look really good, but to get it working well across many album covers in terms of the panel controls showing clearly means i need to flatten the blur to the point that its hardly worth doing for the normal narrow type player panel.
Additionally if MB detects the contrast for the player controls is not strong enough, it will just use a solid background colour.
I have widened the panel colour range - it still orients toward dark colours but better than before

Based on feedback, i might remove the blur effect
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 17, 2018, 09:07:18 PM
Tweaked some more. I feel its ok now
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 17, 2018, 09:45:33 PM
Looks good and the colors are more diverse.

One issue is it colors 50% player controls (volume slider, progress bar, disabled buttons) in dark grey for some covers and it doesn't look good. Those covers are picked up as 32,32,32 color with a previous version but the controls looked fine.

(https://i.imgur.com/on9M5BF.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 17, 2018, 09:47:36 PM
i just uploaded a new version that improves the contrast. If its still bad, would you mind sending me a couple of the covers
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 17, 2018, 09:56:43 PM
Looks better with the new version.

https://art.alphacoders.com/arts/view/96700
https://www.philcollins-fr.com/Discographie/gen/albums/15genesis.jpg
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 17, 2018, 10:26:34 PM
The phil colins one is improved but the other i dont think i can do much about

I do think this blurred colouring works much better with wider player panels such as the RedStone one
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 17, 2018, 10:39:54 PM
The problem with the two covers is it colors the controls in the same value for each RGB component (e.g. 94,94,94 for the progress bar), not reflecting the color composition ratio of the picked-up cover color. These are the only exceptions. Looks like the algorithm is flawed for these colors.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 17, 2018, 11:44:23 PM
The flaw may have something to do with its previous algorithm. Those covers were picked up as 32,32,32 and with that color the neutral controls colors look fine. So it may still treat those covers having neutral colors when they no longer do.
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 18, 2018, 07:20:36 AM
I have been experimenting with using a blurred album cover to give the panel colours some texture. It can look really good, but to get it working well across many album covers in terms of the panel controls showing clearly means i need to flatten the blur to the point that its hardly worth doing for the normal narrow type player panel.
Additionally if MB detects the contrast for the player controls is not strong enough, it will just use a solid background colour.
I have widened the panel colour range - it still orients toward dark colours but better than before

Based on feedback, i might remove the blur effect
Tweaked some more. I feel its ok now
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

I like what you've done here. The end result is satisfying more often than not and I'd consider it to be an improvement.
Perhaps a setting for enabling the gradient effect could be set from the XML, since not every skin might benefit from it.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 18, 2018, 07:26:33 PM
I have adjusted the colour picker and control colours. It should work much better now with the edge cases but if you are still seeing bad control colours then let me know

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 18, 2018, 08:28:00 PM
Working fine now. Haven't seen an unmatched color case so far with the new version. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 20, 2018, 08:22:35 AM
Working fine now. Haven't seen an unmatched color case so far with the new version. Thanks!

Same here, looking good!
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 20, 2018, 08:54:43 PM
I have now added the Compact Player. Overall I dont think it works that well in the Compact Player (except perhaps the Large Album view) but since i've done it i will leave it in.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 20, 2018, 11:21:02 PM
I have now added the Compact Player. Overall I dont think it works that well in the Compact Player (except perhaps the Large Album view) but since i've done it i will leave it in.

Thanks! It's working great in other views as well.

BTW when restarting MB in pause state with Pastels skin in compact mode with auto-pick enabled, player bar GUI gets broken with this error. If I switch to the main player and return, it works fine:

System.NullReferenceException: Object reference not set to an instance of an object.
   at #=ztbLdcyFg9pF19zw_BhoEuu2p_Vim.#=zH3Y7ir_g1eSu.#=zftACOWsXsACV.#=zLAAmvNI=(PaintEventArgs #=zlpG6Wrc=)
   at #=ztbLdcyFg9pF19zw_BhoEuu2p_Vim.#=zH3Y7ir_g1eSu.#=qI7rf9zuOrT6U5df0ec5u3P5rP6$7EZV9AMIPDd3wM7M=._Lambda$__0(Graphics #=zdoq4zGY=)
   at #=zpydkJqQ14dGLbTNz6IxtlZw=.#=zqW8ZY$A4NY5F.#=zCW$eQZ0=(Graphics #=zdoq4zGY=, #=zgR4wtGqW6RdicdmPBw== #=z$Qouso78DAma, Rectangle #=zttszTSWUvXbS, Rectangle #=z1L9LTUhwIM70)
   at #=ztbLdcyFg9pF19zw_BhoEuu2p_Vim.#=zH3Y7ir_g1eSu.OnPaint(PaintEventArgs #=zlpG6Wrc=)
   at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
   at System.Windows.Forms.Control.WmPaint(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.Form.WndProc(Message& m)
   at #=zz_lnlPchTyLB8AnNzk9$UWA=.WndProc(Message& #=zBYXMPTQ=)
   at #=ztbLdcyFg9pF19zw_BhoEuu2p_Vim.#=zH3Y7ir_g1eSu.WndProc(Message& #=zBYXMPTQ=)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 21, 2018, 07:09:58 AM
thats fixed now, however i notice the wavebar colours are not being set so i will fix that for the next update
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 21, 2018, 01:24:02 PM
Yes, it's fixed. Thanks!

Two issues:

(https://i.imgur.com/tn52Aij.png)

- When disabling auto-pick option, the volume slider button is not colored correctly with Pastels skin. Switching to the main player and back fixes it.

- This is not about this new feature but when track info is drawn over the main panel (Artist Picture view & Album Color Mix view) I think it should use automated color for the text like Large Album view since the current color is only meant for the track info in the now playing panel.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 21, 2018, 09:23:46 PM
- When disabling auto-pick option, the volume slider button is not colored correctly with Pastels skin. Switching to the main player and back fixes it.
- This is not about this new feature but when track info is drawn over the main panel (Artist Picture view & Album Color Mix view) I think it should use automated color for the text like Large Album view since the current color is only meant for the track info in the now playing panel.
these are fixed now, along with the missing wavebar colouring:
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 21, 2018, 09:36:14 PM
All look good now. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Alumni on May 22, 2018, 01:34:38 PM
Just a thought - what if the Music Explorer header background was auto-colored from the artist picture, to match the playlist header's behavior?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 01:34:01 PM
Recently MB hangs occasionally since started using the auto-pick color option for the player bar. It keeps playing but doesn't respond to any input and the process has to be killed. When that happens, the track info part on the player bar has inverted colors, but not sure whether it's the cause or the result of the hang. Anyone else experiencing the same thing?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 03:16:26 PM
I have been using this constantly and not had that happen. However i can imagine one place it might happen so could you try this version.
Also if you notice it doesnt recolour the player panel or track text on switching songs, could you let me know

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 03:34:04 PM
Still happens. Hanged twice in 5 minutes. When it hangs, it doesn't re-color the player bar, showing its original color (dark fine tuned skin).
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 03:54:13 PM
Or something like this:

(https://i.imgur.com/euflFul.png)

Though the album has no covers, it shows some colors. If it doesn't hang, it shows no colors (black).
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 04:31:20 PM
Could you send me your settings as it seems you can easily reproduce this. When you are testing are you clicking the next track button or playing to normal completion?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 04:57:31 PM
PMed it.

This time I'm clicking on the next button in shuffle mode to reproduce the bug. But so far it happened without my intentional clicking.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 05:12:43 PM
i havent been able to reproduce it so far after 10 mins, but one thing i did notice is when changing folders in the left navigator the panel is being regenerated for no good reason. If you changed folders around the time the song changed, then its possible some conflict might be happening, so do you think thats what you might have been doing?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 05:27:40 PM
No, I'm just clicking on the next button without changing folders and can reproduce the bug.
Do you think it could have something to do with the library size for locating the linked artwork to pick up the color in a seemingly very short time? For my pop filter, it's hard to reproduce the bug where all albums have a single embedded cover whereas classical filter consistently hangs after about 10 to 15 shuffled tracks have played. They have multiple, not-square, large artworks linked and the library size is huge.
 
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 05:58:53 PM
I still cant reproduce. What you say does sound like it could be related, although I am also using fairly large pictures (1200x1200).
Also the colours get cached the first time the album is displayed in the player, so the size doesnt matter too much after that. There is a file in the appData folder called: "AlbumCoverHashes.dat"
if you delete it, MB will need to recalculate the colours for the albums played again which might affect the timings and hence the issue occuring

If you run this version
http://www.mediafire.com/file/o4ag7grthsy8xet/MusicBeeDebugLock.zip

and when it locks, send me the last few entries in the error log might shed some light
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 06:09:05 PM
PMed the whole entries. Looks like you fixed something, this time it was hard to reproduce it.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 06:51:00 PM
i have made some progress. It does look like its somehow related to slow loading of pictures (prob large and/or embeded in the file)

could you run this version and report the log

http://www.mediafire.com/file/whb52o4do6x622g/MusicBeeDebugLock.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 06:59:33 PM
PMed it.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 07:11:15 PM
It really has a problem with no cover albums, as it frequently hangs. PMed the log.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 07:17:59 PM
i was just going to retract the statement about large album covers. I suspect it might be to do with overflowing track text in the player panel. Do you think it might happen only for that situation ie. when the track text needs to scroll?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 07:26:31 PM
I'm not sure but even if that's the case that alone won't explain the bug since lots of files with long text play fine.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 07:33:19 PM
its the only thing that looks plausible to me at the moment and might happen with exceptionally long text.
Could you try this version - its not a debug version:
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 07:44:54 PM
It still happens.

I think it's not about specific images or albums but a timing issue. Does it have some time restraint that it has to pick up a color in a given time? If it takes a bit longer for some albums for whatever reasons, how about displaying the original color first and later change the color?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 07:54:54 PM
I think you are right about it being a timing issue causing some sort of clash.
Before i go back to a debug version i can see one more thing it might well be:

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 08:07:05 PM
Great! It no longer hangs.
Occasionally a few albums made the player bar look like this:
 
(https://i.imgur.com/DUJk9Iy.png)

But it never freezes. If I go back, then it colors right. So only this issue needs to be addressed.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 08:13:23 PM
I have never seen that happen. It looks like the play position and the progress bar have not been reset, or is it other way around?
Is that the skin player bg colour or the last auto-colour?
If you minimise and restore MB does it recover the colours.
Also if you use the RedStone skin, does it happen with that?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 08:27:57 PM
It happens very rarely. Just tried with Redstone and about three albums out of more than 100 albums tried showed like this

(https://i.imgur.com/tYq1inb.png)

In this case when I moved the mouse over the player bar, it colored the whole bar right.

So it would have frozen MB with previous versions. Still when this happens, it creates additional MB icon in the notification area. If I move the mouse over it, it disappears.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2018, 08:30:56 PM
try this version:
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

if it still happens, see my previous post as i edited it with additional questions
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2018, 08:38:34 PM
Thanks! It seems it's fixed for both skins. Can't reproduce it any more.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2018, 08:44:57 AM
If you look closely at the movement of the progress bar, it repeats go and stop. Can you improve it?

(https://i.imgur.com/PhzgbPD.gif)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 27, 2018, 09:05:53 AM
you mean its a slightly jerky movement?
For custom skins it moves 1px at a time which might be more noticable depending on the song length. For standard skins, the bar movement supports fractional offsets using anti-aliasing which makes it a bit smoother but that can make a bad flickering effect on some of the custom skins. If this is what you are referring to then i guess i could add a setting
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2018, 09:10:03 AM
Can't you make it move less than 1px at a time like a tenth of it?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 27, 2018, 09:18:41 AM
An application can only draw to whole pixels. There are techniques like to give the illusion of fractional offsets which is what i was referring to.
I will make the setting configurable for custom skins but there i cannot say whether when enabled it will produce a flickering effect for your skin
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2018, 09:40:10 AM
Just tried other players and all had the same issue (Groove was the worst).
If you add the setting, I'll try it to see if it could improve without flickering.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 27, 2018, 10:36:37 AM
if its the pastel skins, i think it should work well
Code
<element id="PlayerProgressFractions">true</element>
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2018, 10:54:54 AM
Thanks a lot!

It makes a huge improvement with all bitmap skins of mine. None of it shows flickering. I'll add the setting to all for 3.2.
Title: Re: Skinning Requests for 3.2
Post by: Alumni on June 05, 2018, 12:53:43 PM
Is there an override for the lyrics panel?
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 05, 2018, 02:28:24 PM
Is there an override for the lyrics panel?
no - just lyrics and not the other child panels such as bio, track info? If its all of those sub-panels then use:
Panel.ChildBody.Default
Title: Re: Skinning Requests for 3.2
Post by: Alumni on June 06, 2018, 09:14:14 AM
Is there an override for the lyrics panel?
no - just lyrics and not the other child panels such as bio, track info? If its all of those sub-panels then use:
Panel.ChildBody.Default

Problem is I can't change Panel.ChildBody.Default without it also affecting elements in other places, like the devices node.
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 06, 2018, 07:54:22 PM
For the next v3.2 update, I have added the following that when supplied overrides: Lyrics; Artist Biography and TrackInfo panels
Code
ElementPanel.Default
ElementPanel.ScrollBarThumb
ElementPanel.ScrollBarBackground
ElementPanel.ScrollBar
ElementPanel.ScrollBar.Lowlight

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 06, 2018, 08:10:48 PM
I have come to like the player auto-colouring quite a bit and one thing I am thinking of doing is making auto-colour of the player panel turned on by default. Of course it would only be applied with standard skins or custom skins that state its supported.
However I am wondering how skin authors might feel about that as it could be interpreted as overriding your skin by default so not fully respecting your work.
If anyone objects (send me a PM if you wish) I can do this by adding another skin setting that allows you to specify auto-colour as the default.
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 07, 2018, 04:09:16 AM
I have come to like the player auto-colouring quite a bit and one thing I am thinking of doing is making auto-colour of the player panel turned on by default. Of course it would only be applied with standard skins or custom skins that state its supported.
However I am wondering how skin authors might feel about that as it could be interpreted as overriding your skin by default so not fully respecting your work.
If anyone objects (send me a PM if you wish) I can do this by adding another skin setting that allows you to specify auto-colour as the default.

How about offering a setting that disables auto-coloring as the default that works for standard skins as well?
If a skin is with a specific non-neutral color theme, the auto-color option may not make it look better. For instance, my Bee Latte skin uses the standard player bar but I don't like to have auto-coloring option applied to it by default.
Then skin authors could decide whether to support the auto-coloring feature for custom skins and whether to apply it by default for any kind of skins. Without such settings, the option will be enabled by default (for supported skins) as you planned.
Title: Re: Skinning Requests for 3.2
Post by: Alumni on June 07, 2018, 09:15:12 AM
For the next v3.2 update, I have added the following that when supplied overrides: Lyrics; Artist Biography and TrackInfo panels
Code
ElementPanel.Default
ElementPanel.ScrollBarThumb
ElementPanel.ScrollBarBackground
ElementPanel.ScrollBar
ElementPanel.ScrollBar.Lowlight

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip

Thanks, that will help. I just tested this with 3.2.6731 and I'm not seeing any changes with these elements in the right sidebar (I double checked the code, looks OK).

I have come to like the player auto-colouring quite a bit and one thing I am thinking of doing is making auto-colour of the player panel turned on by default. Of course it would only be applied with standard skins or custom skins that state its supported.
However I am wondering how skin authors might feel about that as it could be interpreted as overriding your skin by default so not fully respecting your work.
If anyone objects (send me a PM if you wish) I can do this by adding another skin setting that allows you to specify auto-colour as the default.

Either suggestion sounds fine to me. I would take it a step further and also enable album cover in player controls by default.
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 07, 2018, 06:20:14 PM
@Alumni, the new overrides are there now

I have changed the behavior so on the very first initialisation, MB will default to auto-colours - it should be fine as MusicBee3 is the default skin. You can now explictly disable auto-colouring for your standard skin using
Code
<element id="PlayerAutoColor">false</element>

http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 08, 2018, 04:00:21 PM
Somehow I thought you're referring to when switching to another skin rather than when installing MB first time.
I don't know why I thought so, but it wouldn't make much sense.
Anyway I'm not gonna disable the feature for any of my standard skins, but hope another skinner may find the setting useful.
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 08, 2018, 06:14:26 PM
Somehow I thought you're referring to when switching to another skin rather than when installing MB first time.
I don't know why I thought so, but it wouldn't make much sense.
Anyway I'm not gonna disable the feature for any of my standard skins, but hope another skinner may find the setting useful.
i was originally but changed my mind and left that setting in case someone found it useful
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 14, 2018, 02:44:44 AM
When auto color pick option is enabled with Pastels skins, track info scroll overlaps with track duration. If that option is off, it works fine.
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 14, 2018, 06:27:52 PM
When auto color pick option is enabled with Pastels skins, track info scroll overlaps with track duration. If that option is off, it works fine.
i can reproduce this for the pastel skins and its fixed for the next update
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 14, 2018, 07:14:10 PM
With some album covers, track selector in album covers view is almost illegible when auto-pick color option is enabled.

https://i.imgur.com/13V06i8.jpg
https://i.imgur.com/HFrNsxE.jpg
https://i.imgur.com/r23DF4i.jpg
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 14, 2018, 08:24:35 PM
this will improve things
http://musicbee.niblseed.com/V3_2/MusicBee32_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 14, 2018, 09:03:06 PM
Thanks! The scroll issue for Pastels skins is fixed, and the text contrast has improved.
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 28, 2018, 07:27:53 AM
the following are overrides for the next update:
Code
<element id="Content[AlbumAndTracks].GridHeaderSplitterLine" bg=xxx,xxx,xxx />
<element id="Content[AlbumAndTracks].GridTrackSplitterLine" bg=xxx,xxx,xxx />
the track splitter line is only used if there are no alternating row colours set (or the same)

I noticed, even with alternating row colors set, the track splitter line gets forced when a custom background image is used.
But it uses a slightly different color from Content[AlbumAndTracks].GridTrackSplitterLine which is only used just below the sub-header.

(https://i.imgur.com/nFtQHwI.png)

In the screenshot above, 200,0,0, is set for Content[AlbumAndTracks].GridTrackSplitterLine but track splitter line uses an auto-generated 217,80,80 color except the first row just below the sub-header.
If no custom background is used with no alternating row colors set, then it correctly uses 200,0,0 for all track splitter lines.
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 28, 2018, 07:39:49 AM
an alpha (175) is applied to lines when using custom backgrounds
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 28, 2018, 07:44:20 AM
OK. So it's intentional, then it's fine. I thought it's a bug.
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on June 30, 2018, 02:49:24 AM
For the progress and volume buttons, any parts that are not the button edge colour will be made transparent or semi transparent (this is needed to handle the type of buttons used in the threashold skin). If thats a problem for your skin let me know and i will add a setting to disable the behaviour

I know it's probably too late for 3.2, but could you please make a change that if that top LH pixel is transparent, than the progress and volume buttons are applied "as is" ie: no transparency or alpha adjustments
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 30, 2018, 09:08:03 AM
the way it works at the moment is the top LH pixel is checked for transparency and also the very centre pixel is compared to the colour of used at the top of the main player panel - if it is not the same and the top LH is transparent then the bitmap is not adjusted at all, apart from re-colouring to the album cover colours.
If meeting those 2 criteria is a problem i would be ok to add another setting to force the behavior. Are you able to send the skin so i can see why it is a problem?
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on June 30, 2018, 11:58:09 AM
Are you able to send the skin so i can see why it is a problem?

PM sent
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 30, 2018, 01:52:24 PM
Its actually the opposite of what i thought you meant.
I dont see a solution for the volume button at least for v3.2, unless you change it to 2 colours like the progress button.
For the progress button, why didnt you just set the alpha to 1 on the top left pixel? I would have thought that could have been an acceptable solution

edit:
given the buttons are white on the outer edge, i guess a setting that tells MB to use the colours as-is without any re-colouring could work well enough. Let me know if thats acceptable. It would mean the inner ring of the progress button would be blue which wont work so well with some panel background colours
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on July 01, 2018, 02:26:20 AM
For the progress button, why didnt you just set the alpha to 1 on the top left pixel? I would have thought that could have been an acceptable solution

(https://i.imgur.com/IF7C7w1.png)

setting just the top LH pixel to the background colour works but it becomes blurred/pixelated.

(https://i.imgur.com/pwQS8u7.jpg)

This isn't as noticable on the larger buttons and doesn't occur when auto-pick is not used

(https://i.imgur.com/oM1of1a.jpg)

That's why I thought an option to use the original image (with a slight colour adjustment to blend with the album auto-colour) would be a workable option.
Title: Re: Skinning Requests for 3.2
Post by: Steven on July 01, 2018, 08:44:25 AM
I will add support for an additional progress bar button image and volume button image that is used for the auto-coloured setting. It would need to be a single colour with the appropriate alpha values. I will probably only add support in v3.3 but i will confirm later today

edit:
having a look at whats involved i will leave this to v3.3
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on July 01, 2018, 11:30:46 AM
Thank you for looking at the feasiblity of it for 3.2 though  :)
Title: Re: Skinning Requests for 3.2
Post by: redwing on August 25, 2018, 02:04:07 PM
Can you support skinning queue numbers in the playing tracks list panel?
I'd like to skin it like the right one for my Cotton skin (the left one is how it looks currently):

(https://i.imgur.com/djlsMZ9.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on August 26, 2018, 10:50:09 AM
i have added:
Code
id="NowPlayingList.SequenceInfo" bg fg fg2 bdr
note that fg2 is used for the "-" sign when a track is marked to be skipped
Title: Re: Skinning Requests for 3.2
Post by: redwing on August 26, 2018, 12:21:34 PM
Thanks! Working great!
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 01, 2018, 06:11:59 AM
- When an item is selected in the preferences, a dotted line surrounds it. It's invariably 0,0,0 and hence almost invisible with dark skins.

(https://i.imgur.com/OqgjLli.png)

Can you make the color auto-adapt to the background or provide an override?

- This is Cotton skin and see that the track text keeps flickering when it scrolls.
(https://i.imgur.com/GQ5mk6t.gif)

I first thought it's about some setting but it turned out it happens with any skins if the fg of the text is not too dark.
For instance, try this with the default skin:

Code
<element id="PlayerFlat.DisplayPanel" bg="255,255,255" fg="150,150,150" />
Can you improve it?
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 01, 2018, 06:28:33 PM
- This is Cotton skin and see that the track text keeps flickering when it scrolls.
(https://i.imgur.com/GQ5mk6t.gif)

I first thought it's about some setting but it turned out it happens with any skins if the fg of the text is not too dark.
For instance, try this with the default skin:

Code
<element id="PlayerFlat.DisplayPanel" bg="255,255,255" fg="150,150,150" />
Can you improve it?
probably not, MB is using the most efficient windows API (that i know of) for the scrolling and rendering. I think its because its scrolled 1px each tick makes it slightly jumpy and to get it smooth would require fractional px scrolling which the windows API doesnt directly support. Having said that, your gif looks more jumpy that what i see on my machine
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 01, 2018, 06:53:29 PM
Having said that, your gif looks more jumpy that what i see on my machine
It's a low quality GIF only with 16 FPS.

to get it smooth would require fractional px scrolling which the windows API doesnt directly support.
Yes, a new setting just like the PlayerProgressFractions setting for the progress bar would be great that would work for the scrolling track text.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 01, 2018, 08:27:34 PM
- When an item is selected in the preferences, a dotted line surrounds it. It's invariably 0,0,0 and hence almost invisible with dark skins.

(https://i.imgur.com/OqgjLli.png)

Can you make the color auto-adapt to the background or provide an override?
i have put something into the next v3.3 update but it seems to have a mind of its own about what colour is actually used, and on dark skins its bright white
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 03, 2018, 02:47:23 AM
i have put something into the next v3.3 update but it seems to have a mind of its own about what colour is actually used, and on dark skins its bright white

For the skins I've tested, it seems using the same color as the text and works well. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 16, 2018, 05:47:20 PM
I'm working on a multi-line version of some skins and have the following issues & requests (PMed a skin I'm currently working on).

- Right after playing a track with long artist value, playing a track with shorter artist value shows some remaining text of the previous artist on the display panel.

(https://i.imgur.com/eZ8Lbq5.png)

If you move the mouse over the area, it disappears.

- When using split track position/duration, the position of those change in accordance with the displayed digits, and the progress bar keeps the fixed position.

(https://i.imgur.com/6kAqSrc.png)

I'd like to rather have position/duration fixed in their position with a variable progress bar length to left-align them with the multi-line track text. Can you support such a skin setting?

- Currently if multi-line is enabled they keeps showing in the wavebar layout as well. Can you add an option to hide the multi-line track text in the wavebar layout?

- Also it would be great if FontSize attribute for track position element is working for the wavebar layout as well so that a smaller font could be used.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 16, 2018, 08:05:36 PM
- Right after playing a track with long artist value, playing a track with shorter artist value shows some remaining text of the previous artist on the display panel.
I think its because you need to add another 8px to the height for the playing track text eg. set the bottom rule to -14 instead of -22.
I should be able to do something about it on the MB side as well

I will look at the other items later

edit:
for the 2nd point, i could add an alignment setting. However the spacing will potentially be quite large ie. the width used for the track position would need to allow for "9:99:99" so in most cases there will be a lot of space to the left of the progress bar. Left me know if you still think that works for you
actually the spacing is up to your layout. Its easy for me to add a setting that forces far alignment (left align on the left progress and right align on the right duration)
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 17, 2018, 12:29:37 AM
I think its because you need to add another 8px to the height for the playing track text eg. set the bottom rule to -14 instead of -22.

That fixed it. Thanks!

Its easy for me to add a setting that forces far alignment (left align on the left progress and right align on the right duration)

Yes, that's what I requested.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 17, 2018, 07:12:21 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip

support for these have been added
Code
<element id="PlayerSplitProgressTextFarAlign">true</element>
<element id="PlayerWaveBarHideMultiLine">true</element>

for the last request you want the wavebar layout to use the same font that can be specified for the progress bar layout? (I wont add an additional setting for the wavebar only) I think that should be fine but want to make sure I understood what you are asking
edit:
actually looking at the code it appears to me the custom font only applies to the wavebar layout or when the track position and duration are not split
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 17, 2018, 08:45:10 PM
Thanks! Working great.
The only issue is when PlayerSplitProgressTextFarAlign is set track progress/duration gets placed a bit too far away from the wave bar.
And the progress is 7px more away from the wave bar than the duration.

(https://i.imgur.com/xy9OZhM.png)
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 17, 2018, 09:10:39 PM
Also I'm wondering if you could support a custom template for multi-line text (maybe it could take a specific format as multi-line text).
Then people could use functions and display album, year, or other tags depending on the track genre.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 17, 2018, 09:56:42 PM
Maybe multi-line text can be a panel layout option?
For now a multi-line version has to be released as a separate skin, but most part of the two skins are exactly the same except some part in the display panel. Even if it would require a restart of MB, it would be much more efficient if a single skin can support the both (single/multi-line) options, starting from the default skin.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 18, 2018, 06:19:23 PM
yes thats a good idea. So the multi-line text will be configurable what gets displayed in the two lines and displayed where the single line text is no matter which skin is used. I have adjusted the spacing for the wavebar which is avilable now
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 18, 2018, 07:22:00 PM
Thanks for the fix!

Then I'll wait until the new option is added to see what needs to be adjusted for bitmap skins.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 18, 2018, 08:34:19 PM
I think for custom skins, i will leave it as is where you explicty set the multiple line display and have control over the positioning and layout.
I will however make the text displayed configurable to 2 lines and maybe font/ contrast control as well.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 18, 2018, 09:08:04 PM
OK. Then what about the PlayerInfoCentered setting? Are you gonna add another setting for 2-line text or the setting will center 2-line text as well?
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 18, 2018, 09:33:48 PM
OK. Then what about the PlayerInfoCentered setting? Are you gonna add another setting for 2-line text or the setting will center 2-line text as well?
it now respects the "PlayerInfoCentered" setting

Title: Re: Skinning Requests for 3.2
Post by: redwing on October 18, 2018, 09:58:31 PM
Thanks! That works.

multiLine="true" will be no longer needed, or does that always force 2-line text?

If track text height of a bitmap skin is less than 40px, then MB will auto-expand it when 2-line text is enabled?
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 18, 2018, 10:07:35 PM
multiLine="true" will be no longer needed, or does that always force 2-line text?

If track text height of a bitmap skin is less than 40px, then MB will auto-expand it when 2-line text is enabled?
for custom skins, the only way to set 2 line (multiline) is
Code
<element id="TrackText" parent="Panel" multiLine="true">
and nothing has changed in that regard ie. the skin will need to allow enough space for the 2 lines to displayed. I did consider your earlier suggestion but i dont think it will work well enough for most custom skins.

I might make it a configurable setting for standard skins. When multi-line is enabled for custom (or standard skins if i do implement it), I will provide a way to customise the fields but I havent done that yet.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 18, 2018, 10:13:51 PM
OK, I got it.
But can you make multi-line custom skin display single-line text optionally?
Then still a single custom skin can display both options, otherwise I will have to release two versions.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 18, 2018, 10:24:11 PM
OK, I got it.
But can you make multi-line custom skin display single-line text optionally?
Then still a single custom skin can display both options, otherwise I will have to release two versions.
sure - but I need to think about how to handle the height adjustment that would be needed when toggled from multi-line to single line
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 18, 2018, 10:25:50 PM
Great! Take your time.

Why not just display text in the middle with no adjustment to player images?
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 20, 2018, 11:18:02 AM
Why not just display text in the middle with no adjustment to player images?
Thats certainly the simplest thing to do. However to accomodate the 2nd line the track text panel would need at least 20px extra (perhaps more so its not too squashed) compared to the single line text, so thats quite a bit of wasted space with in the single line mode.
So are you sure about this?
If MB did adjust the height automatically it will probably be OK as MB already does that when a user sets a large font. Perhaps design the panel with single line height in mind and the extra height needed for the 2nd line can be configurable in the skin
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 20, 2018, 12:15:58 PM
Perhaps design the panel with single line height in mind and the extra height needed for the 2nd line can be configurable in the skin

If that's possible, then why did you say custom skins need enough space for 2-line text and my earlier suggestion won't work well enough for most custom skins?
If you're now saying that it can be supported, that would be great if it could auto-adjust display panel height in accordance with the font size and the number of lines for track text in the user setting.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 20, 2018, 03:28:00 PM
Perhaps design the panel with single line height in mind and the extra height needed for the 2nd line can be configurable in the skin

If that's possible, then why did you say custom skins need enough space for 2-line text and my earlier suggestion won't work well enough for most custom skins?
the current font height adjustment works well enough on all custom skins for small font height adjustments but the requirement here is for a large adjustment to accommodate an extra line and wont work well in all cases eg. the Tron Punk skin
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 21, 2018, 04:58:25 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip

multi-line track text display for the main player is now user configurable for the standard skins and any custom skins that enable support
Code
<element id="PlayerMultilineSupported">true</element>
you can right click/Customise... on the player panel to set the fields displayed. I will later add this config setting to the Preferences/Layout(1) tab.
Only the top field scrolls if its too wide. Also the top line font uses the configured font and the 2nd line is set smaller and less contrast but that is not configurable
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 07:54:40 PM
Thanks for the support! Noticed the following issues:

- It requires a restart to change the displayed font size of the second line.
- Multi-line text overlaps with the progress bar of some custom skins e. g. Cotton or Gray skin especially with a large font.
- Now custom skins created with <multiLine="true"> attribute show no track text.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 08:26:49 PM
Two more issues:

- It also doesn't work with custom skins having track text over progress bar (e.g. Dark Green Bee) in that first line doesn't show up. For now this setting doesn't work properly with any of my custom skins.
- Even when PlayerInfoCentered is set false, multi-line text is always center-aligned.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 21, 2018, 08:48:16 PM
- It requires a restart to change the displayed font size of the second line.
- Multi-line text overlaps with the progress bar of some custom skins e. g. Cotton or Gray skin especially with a large font.
- Now custom skins created with <multiLine="true"> attribute show no track text.
1 and 3 are fixed
2 is another example of why its not automatically enabled for custom skins. The simplest thing on my side is to change it so you specify a y adjustment for the track text eg. in the Cotton skin case -6 would work well enough
Code
<element id="PlayerMultilineYAdj">-6</element>

https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 21, 2018, 08:50:11 PM
- It also doesn't work with custom skins having track text over progress bar (e.g. Dark Green Bee) in that first line doesn't show up. For now this setting doesn't work properly with any of my custom skins.
- Even when PlayerInfoCentered is set false, multi-line text is always center-aligned.
the first wont be supported.
for the second, at least for standard skins it will be forced. But if you are referring to a custom skin then i guess thats a bug
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 08:59:17 PM
So it looks like custom skins still need to be initially created with enough panel height to work well with multiple line setting.
But then it can't show the single line. Are you gonna support this, or it has to be a separate version?
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 09:00:57 PM
for the second, at least for standard skins it will be forced. But if you are referring to a custom skin then i guess thats a bug

Yes, I'm referring to a custom skin. Try La La Bee.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 21, 2018, 09:08:05 PM
- It also doesn't work with custom skins having track text over progress bar (e.g. Dark Green Bee) in that first line doesn't show up. For now this setting doesn't work properly with any of my custom skins.
the first wont be supported.
i take that back, i will have a look at adding support this

So it looks like custom skins still need to be initially created with enough panel height to work well with multiple line setting.
But then it can't show the single line. Are you gonna support this, or it has to be a separate version?
I dont think you need to add extra space for it to work well. In the cotton-skin case its the way your specified the layout for the track text using verticalcenter. You can see there is plenty of height available but the centering messes up the adjustments MB applies. There are other reasons for other skins, so thats why i would rather you tell MB how much extra to adjust the y position.

"But then it can't show the single line" - i dont understand this comment unless its in relation to the Dark Green Bee skin
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 09:22:30 PM
OK, I got it. Just created a custom skin with enough panel height but with no <multiLine="true"> attribute. With the new setting PlayerMultilineSupported enabled, this seems to support the both options.
But the track text gets placed a bit higher than when <multiLine="true"> is used. I'll try to tweak the skin code to see if it can achieve proper spacing without the attribute.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 09:50:16 PM
its the way your specified the layout for the track text using verticalcenter. You can see there is plenty of height available but the centering messes up the adjustments MB applies.

Changed the code using trackinfopanel top and now it works fine. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 21, 2018, 10:07:27 PM
- Try with Cotton skin and notice the second line, when it's long, overlaps with track position on the right unlike the first line.

- When it starts scrolling, the left alignment is not respected with PlayerInfoCentered not set. Compare when it scrolls with when not.

(https://i.imgur.com/cwtZxr9.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 22, 2018, 07:13:21 PM
- Try with Cotton skin and notice the second line, when it's long, overlaps with track position on the right unlike the first line.

- When it starts scrolling, the left alignment is not respected with PlayerInfoCentered not set. Compare when it scrolls with when not.
the first is fixed for the next update
for the second, i have always known that there is a 3px left text padding for standard font sizes that causes the non-scrolling position to look like its 3px to the right of when scrolling is in progress. Infact i now have a partial solution. But the difference in your case is 5px, so can you confirm you are using a large font? I dont think whether centering is used should make any difference
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 07:39:05 PM
I was using 12pt but default size made no differences.
It's PlayerSplitProgressTextFarAlign setting that adds 2 more px. If that setting is off, it's always 3px regardless of font size.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 22, 2018, 08:03:17 PM
The padding for 12pt is 4px.
In any case the scrolling text display should now show in the same apparent position as the static text display, and the static text display position is the same as older versions ie. 3/4px offset from the exact track text panel bounds

https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 08:12:50 PM
The second line is still centered with PlayerInfoCentered not set.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 08:22:31 PM
In any case the scrolling text display should now show in the same apparent position as the static text display, and the static text display position is the same as older versions ie. 3/4px offset from the exact track text panel bounds

With PlayerSplitProgressTextFarAlign set, now default font size shows 1px of padding while 12pt shows no padding. I can live with this.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 22, 2018, 08:31:06 PM
The second line is still centered with PlayerInfoCentered not set.
should be fixed now
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 08:39:37 PM
Now Cotton skin looks like this:

(https://i.imgur.com/MH3Jt2v.jpg)

Code
<left relativeTo="TrackRating.Right" offset="18"  />
<right relativeTo="ProgressBar.Right" offset="-20" />
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 08:47:06 PM
The second line is still centered with PlayerInfoCentered not set.
should be fixed now

Thanks! But the second line seems 1px off.

(https://i.imgur.com/MzwZ1ed.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 22, 2018, 08:57:30 PM
it will depend on the fonts used, but this is accomodated for now
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 09:08:25 PM
Thanks! Cotton skin's center alignment issue is not fixed yet.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 22, 2018, 09:28:59 PM
it should be now
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 09:41:02 PM
Thanks! Working great now!
Now the only remaining issue is custom skins having track text over progress bar in that they don't show the first line.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 22, 2018, 09:54:31 PM
PMed a test skin with track text over progress bar.
It shows the first line only when title is long enough to scroll. But it keeps flickering and the progress bar movement is not correct.
That might give you some hint about what's going on.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 23, 2018, 06:28:35 PM
its implemented now:
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 23, 2018, 09:39:21 PM
Thanks! It works now.
But there's an issue. fg2 of PlayerFlat.DisplayPanel colors both track text on progress bar's filler part and the 2nd line of track text.
The fg for the filler part may need an override.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 23, 2018, 09:43:37 PM
But there's an issue. fg2 of PlayerFlat.DisplayPanel colors both track text on progress bar's filler part and the 2nd line of track text.
The fg for the filler part may need an override.
I literally just uploaded a change for that. However the 2nd line doesnt have any colour override for when the progress bar is over the text. Thats not easy for me to implement and I probably wont
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 23, 2018, 09:47:25 PM
Thanks! It looks better.

There's one more issue. The 2nd line is visible in the wavebar layout.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 23, 2018, 09:53:40 PM
thats fixed now
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 23, 2018, 09:56:13 PM
Yep, that fixed it. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 24, 2018, 09:01:05 AM
For custom skins with a normal progress bar, 2nd line is visible in the wavebar layout with PlayerWaveBarHideMultiLine not set. This is a bug, right? Or does that setting have to be set not to show 2nd line in the wavebar layout?
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 24, 2018, 06:50:23 PM
For custom skins with a normal progress bar, 2nd line is visible in the wavebar layout with PlayerWaveBarHideMultiLine not set. This is a bug, right? Or does that setting have to be set not to show 2nd line in the wavebar layout?
The default assumption when multi-line is enabled within the custom skin definition (<element id="TrackText" parent="Panel" multiLine="true">) is the multi-line track details are always visible and PlayerWaveBarHideMultiLine is required so its not displayed. If you dont set the flag and the text would be obscured by the wavebar then the results will be unpredicatable.
If you are not using multiLine="true" but are infact referring to <element id="PlayerMultilineSupported">true</element> then that sounds like a bug but i would need the skin in question to see whats going on.
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 24, 2018, 06:56:26 PM
If you are not using multiLine="true" but are infact referring to <element id="PlayerMultilineSupported">true</element> then that sounds like a bug but i would need the skin in question to see whats going on.

Yes, that's the case. PMed the skin.
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 24, 2018, 07:02:44 PM
For custom skins with a normal progress bar, 2nd line is visible in the wavebar layout with PlayerWaveBarHideMultiLine not set. This is a bug, right? Or does that setting have to be set not to show 2nd line in the wavebar layout?
I am not seeing this behaviour with the skin you sent. Could you post a screenshot?
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 24, 2018, 07:11:36 PM
(https://i.imgur.com/EGdWEeH.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 24, 2018, 07:16:57 PM
i was looking at the wrong skin of yours - i can reproduce this now, and fixed now
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 24, 2018, 07:38:01 PM
It's fixed. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Steven on October 24, 2018, 08:44:23 PM
To save future confusion, v3.3 is now MusicBee.exe
Title: Re: Skinning Requests for 3.2
Post by: redwing on October 24, 2018, 09:00:21 PM
OK. I'll update my posts.
Title: Re: Skinning Requests for 3.2
Post by: redwing on November 09, 2018, 07:05:24 AM
What would happen if a custom skin supplies only 200% bitmap images for player images? Can MB scale them down properly when 100% or 150% images are needed? If there's no downsides with that, that would be much easier for creating images and it will also make custom skins much smaller.
Title: Re: Skinning Requests for 3.2
Post by: Steven on November 10, 2018, 02:02:36 PM
What would happen if a custom skin supplies only 200% bitmap images for player images? Can MB scale them down properly when 100% or 150% images are needed? If there's no downsides with that, that would be much easier for creating images and it will also make custom skins much smaller.
if you supply SVG images, MB automatically creates 100%, 150% and 200% png images for the player panel. If you are refering to appending "_200" to a .png image file or text representation, then as it stands MB only scales up so would only use the 200% image when the dpi scaling is 200%+
I have found in the past actually getting better results scaling small images up from 150% to 200% than the other way around.

Although i have expressed concern on skin size in the past, that was in relation to those included in the release package and i subsequently reduced the number of skins. I dont think skin size would matter too much for the load times. But if skin size is a concern i can also implement down scaling from 200%.
Title: Re: Skinning Requests for 3.2
Post by: redwing on November 10, 2018, 02:16:50 PM
I found some 150-200% images created by SkinCreator from svg files are flawed. For instance, the square inside stop button of Cotton/Gray skin is not centered in larger images. Also La La Bee skin's buttons look quite different when larger images are created by it. I think I will add PNG files instead for those images.

But if it can't do the downscaling job precisely, then I'll just add all images since 100% will be most widely used.
Title: Re: Skinning Requests for 3.2
Post by: Steven on November 16, 2018, 06:43:13 PM
To exactly align an element to the track position and an element to the duration when the position and duration are split (using "PlayerSplitProgressYOffset" and alignment "PlayerSplitProgressTextFarAlign" enabled), the following should be set:
Code
<element id="PlayerAlignElementToPosition">TrackText</element>
<element id="PlayerAlignElementToDuration">TrackRating</element>
The values can be any valid player panel element id. See redwing's gray skin to see what I mean if its not clear.
Title: Re: Skinning Requests for 3.2
Post by: redwing on November 16, 2018, 06:54:58 PM
Thanks for the support! Now they keep aligned regardless of font size and DPI scaling.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 24, 2019, 03:36:12 PM
Try with my Cotton skin.
With a dark album cover, caption bar icons are invisible in large picture mini mode.

(https://i.imgur.com/RuGayRY.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 25, 2019, 11:04:14 AM
this addresses the issue:
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 25, 2019, 12:19:54 PM
Thanks! Now it looks fine.

Another issue with compact mode.

(https://i.imgur.com/dYvlhke.png)

The white color used in the wavebar above and the background below was meant for white player bar & white sidebar. But it's applied in the wrong context and doesn't look good. Dark skins look worse as they draw a black wavebar in the middle. How about making the wavebar transparent or using an auto-generated color instead?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 25, 2019, 03:21:57 PM
The white color used in the wavebar above and the background below was meant for white player bar & white sidebar. But it's applied in the wrong context and doesn't look good. Dark skins look worse as they draw a black wavebar in the middle. How about making the wavebar transparent or using an auto-generated color instead?
are you using Compact.Player.Wavebar and Compact.Player.Wavebar.Inner?
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 25, 2019, 03:25:42 PM
Yes.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 25, 2019, 03:32:48 PM
Also got this error once when enabling "Draw controls on picture" option which crashed the entire main panel. But can't replicate any more.

System.OverflowException: Arithmetic operation resulted in an overflow.
   at #=zqIFyU0Mn_0K0sYassc7n3PE=.#=zj7mO6GI812c_(Graphics #=zd3cOQpU=, Bitmap #=zACiwcoc=, Rectangle #=z$Bp6aLo=, Double #=ziuvbimkuI5$c, Int32 #=zXlQ3049S4Ywv)
   at #=zqIFyU0Mn_0K0sYassc7n3PE=.#=zFOMFtTyhA8Kn(Graphics #=zd3cOQpU=, String #=zsBEid9I=, Font #=z63UoR64=, Rectangle #=z$Bp6aLo=, Color #=z0MWmv_Q=, Color #=zr8wVXDw=, TextFormatFlags #=zJlLwXfo=, Double #=ziuvbimkuI5$c, Int32 #=zXlQ3049S4Ywv)
   at #=zqIFyU0Mn_0K0sYassc7n3PE=.#=zjdAtlE95xVtH(Graphics #=zd3cOQpU=, String #=zsBEid9I=, Font #=z63UoR64=, Rectangle #=z$Bp6aLo=, Color #=z0MWmv_Q=, Color #=zr8wVXDw=, ContentAlignment #=z2pW2Szw=, #=zzTe9vg6WnkR9eYF78EEXYNI= #=zWPFEnusfPRw0, #=z9ApGLLlsL8oX1dlBrVCQw8M= #=zGX33c4k=, Double #=ziuvbimkuI5$c, Int32 #=zXlQ3049S4Ywv)
   at #=z$woEFW4433hH9i501vu1JpEXPn1O.#=zcTFhq6XR8qAC.#=zG5$azL4s_IZh.#=zPhqRDNc=(PaintEventArgs #=zYZsMZzs=)
   at #=z$woEFW4433hH9i501vu1JpEXPn1O.#=zcTFhq6XR8qAC.#=zq9$iFkOWQEppUbXGosR_prc=(Object #=z8z_G1NQ=, PaintEventArgs #=zYZsMZzs=)
   at System.Windows.Forms.Control.OnPaint(PaintEventArgs e)
   at #=zVfKXbxyp8SO$WRS3sRSp913sed$EZe8H2A==.#=qZ5qjmuNdI8N7chJ_KkqV6bCxSzw0A5jXDXRo_iMhxUE=(PaintEventArgs #=zYZsMZzs=)
   at #=zVfKXbxyp8SO$WRS3sRSp913sed$EZe8H2A==.#=qf1y2u7fv6ynE3ImIvGoP3mBxV3yBNxMyL$g9oNwZ9qw=._Lambda$__0(Graphics #=zd3cOQpU=)
   at #=znUlalJBYIYsDhyyA4k_zIC8=.#=zsSJPEao1OhaD.#=zq2AXUVo=(Graphics #=zd3cOQpU=, #=zSlHGwsSd$dDeCMj_SA== #=zmSk7LhZ$yOv2, Rectangle #=zaU1AyBhsEQR$, Rectangle #=zN0sdKsvgtU9W)
   at #=zVfKXbxyp8SO$WRS3sRSp913sed$EZe8H2A==.OnPaint(PaintEventArgs #=zYZsMZzs=)
   at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
   at System.Windows.Forms.Control.WmPaint(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 25, 2019, 04:19:19 PM
Yes.
ok, i get your point now
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 25, 2019, 09:48:19 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2019, 01:21:59 AM
Thanks but it has couple of issues.

- It's not stable. The same skin shows the new grey wavebar and next time when it's loaded it shows its own black wavebar. Sometimes switching between wavebar and progress bar turns the color. Turning on and off of auto pick color option always brings its own color back.

- When the grey wavebar is drawn on the picture, if you disable "Draw controls on picture" option, the wavebar gets placed lower than it's original position. Switching to progress bar and switching back fixes it:

(https://i.imgur.com/XmfbuXm.png)

- Also the invisible track info issue with Cotton skin remains unresolved.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2019, 01:41:31 AM
Or did you mean Compact.Player.Wavebar and Compact.Player.Wavebar.Inner shouldn't be used? I thought the new wavebar color would only be applied when it's drawn on the picture, but now it overrides separate player bar as well?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2019, 10:50:52 AM
It wasn't resetting the colours or layout when switching "draw controls on picture".
Thats fixed now
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2019, 12:39:39 PM
Thanks! Now they're working great!

Probably last issue regarding compact mode. Lengthy title overlaps with rating.

(https://i.imgur.com/tUI5ahx.png)
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2019, 03:04:52 PM
Lengthy title overlaps with rating.

It happens only with wavebar and works fine with progress bar. Why not make it consistent?
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2019, 03:41:31 PM
It happens only with wavebar and works fine with progress bar. Why not make it consistent?
of course - it's fixed for the next update
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 26, 2019, 04:12:33 PM
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 26, 2019, 04:29:06 PM
Looks fine now. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2019, 02:51:37 PM
Can you fix one more thing about compact mode?

It's the position of play/pause button which needs to move 1px left both in wavebar and progress bar mode.

(https://i.imgur.com/ogNJXqX.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 27, 2019, 02:53:55 PM
its just the (non-slim) pause button that needs adjustment right? the play button itself looks fine to me
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2019, 02:59:29 PM
Play button with wavebar looks fine but play button with progress bar needs to move left.
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2019, 03:10:50 PM
The non-slim pause button for click to play in album covers view has the same issue.

(https://i.imgur.com/1RkecZo.png)
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 27, 2019, 03:35:04 PM
I believe all the issues should be resolved now:
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on May 27, 2019, 03:41:35 PM
Yep, all looks fine now. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on May 28, 2019, 04:17:12 AM
Could the auto-highlight for left/right panel collapse/expand icon be tweaked?

Default:
(https://i.imgur.com/nA22Un4.jpg)

Highlight:
(https://i.imgur.com/XjV9icT.jpg)

Currently it works:

I'll leave it to you to decide if the algorithm can be tweaked for suitability for all cases or whether adding fg2 override to the elements
Code
<element id="Panel.StatusBarControl.Default" fg="49,58,23" fg2="250,0,0"/>
<element id="Panel.StatusBarControlInPanel.Default" fg="158,168,132" fg2="250,0,0"/>
<element id="Panel.StatusBarControlBelowPlayer.Default" fg="42,52,20" fg2="250,0,0"/>
would be better, to only be used as needed.
Title: Re: Skinning Requests for 3.2
Post by: Steven on May 28, 2019, 06:17:04 PM
I definitely dont want to tweak the algorithm at this point in the release but that is my preferred solution as that algorithm is used in a number of places, so i will leave it to v3.4
Could you send me the skin or let me know its name?
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 10, 2019, 12:19:35 PM
There's an issue with computing the bottom of the track text when the track text is drawn over the progress bar.
As you can see, when playing, 1px of the bottom text gets cut off and it's more pronounced when slim icon setting is enabled.

(https://i.imgur.com/Z2QLgb6.png)

It's my Dark Green Bee skin, and Bee-liever's bee78 skin shows the exact same behavior.
I tried with v3.1 and it was the same, so obviously it's been always the case since it's supported.
Title: Re: Skinning Requests for 3.2
Post by: Steven on June 10, 2019, 07:10:51 PM
yes it looks like it would have always been the case that once play started, 1px from the bottom is cut off and right if the text was long enough
This fixes that:
https://getmusicbee.com/patches/MusicBee33_Patched.zip
Title: Re: Skinning Requests for 3.2
Post by: redwing on June 10, 2019, 07:30:20 PM
It's fixed now. Thanks!
Title: Re: Skinning Requests for 3.2
Post by: Bee-liever on June 21, 2019, 01:55:23 PM
I definitely dont want to tweak the algorithm at this point in the release but that is my preferred solution as that algorithm is used in a number of places, so i will leave it to v3.4
Could you send me the skin or let me know its name?
Sorry Steven, forgot about this post  :-[
In order (left-to-right across the image)
MusicBee3
Midnight
Mellon Remix
Summertime (Tundra Series)