getmusicbee.com

General => MusicBee Wishlist => Topic started by: Steven on November 06, 2016, 03:53:28 PM

Title: Artwork Management Changes for version 3.1
Post by: Steven on November 06, 2016, 03:53:28 PM
*easier access to and use of artwork sizes, both dimensions and storage space
I guess you mean showing it in the main panel as a field. I have been looking at this, and i dont think i can implement it without negatively impacting performance vs. how many people would actually use it. What i could do is add it as a field in the files to edit filter for artwork, so that information only shows in that dedicated panel. It would still be slow like the small artwork filter, although i could make some improvements to that so it caches the data so its slow only the first time. I can probably also include this in the new files to edit panel:
*ability to quickly see if all tracks from the same album have the same artwork (not just similar images, but actually the same)


*ability to see all artwork attached to a file in the main panel, or at the very least the number of images (for instance, a small number overlay that could be displayed on the artwork shown)
*some better tool for editing multiple artworks than the current tag editor panel
could you explain some more how you think those might work
Title: Re: Artwork Management Changes for version 3.1
Post by: psychoadept on November 07, 2016, 12:35:34 AM
*easier access to and use of artwork sizes, both dimensions and storage space
I guess you mean showing it in the main panel as a field. I have been looking at this, and i dont think i can implement it without negatively impacting performance vs. how many people would actually use it. What i could do is add it as a field in the files to edit filter for artwork, so that information only shows in that dedicated panel. It would still be slow like the small artwork filter, although i could make some improvements to that so it caches the data so its slow only the first time. I can probably also include this in the new files to edit panel:
*ability to quickly see if all tracks from the same album have the same artwork (not just similar images, but actually the same)

I'm open to other ideas, but that sounds reasonable.

Quote
*ability to see all artwork attached to a file in the main panel, or at the very least the number of images (for instance, a small number overlay that could be displayed on the artwork shown)
could you explain some more how you think those might work

Obviously the main panel thing would depend on the view.  It wouldn't be possible to do in the main panel in Tracks view, but maybe the artwork panel could show how many artwork files are attached to selected tracks (I'd think just for a single album at a time or it would be too hard to calculate).  Then you could click on the number to open something like a tag inspector for artwork, a window similar to the Google search window that showed all the different artwork in a grid and would allow it to be deleted or attached to all files, etc.

In Artwork view, I think there's already been a suggestion for showing all the artwork for an album across the top of the expanded panel. I think you could still find a way to incorporate the artwork tag inspector as above.

In Album & Tracks view, maybe the artwork in the main panel could work like tracks view, but if info is displayed to the right of the artwork, then there would be an arrow or something you could press to show all the artwork for that album down the left side of the panel.

Quote
*some better tool for editing multiple artworks than the current tag editor panel

This would be the "artwork tag inspector".  I figure artwork would be shown in a grid, rather than a column, ideally with file info on each piece visible, too.  You could delete an image or add it to all tracks the same way as tags in the tag inspector, and reorder them however you wanted.  I think this should come up automatically when you paste artwork onto a track or tracks with multiple images, so that you can decide whether to replace an existing image or add a new one (maybe you could optionally disable that, if you didn't care about multiple artworks).

That's just what I'm thinking off the top of my head.  I don't have the how set in stone.
Title: Re: Artwork Management Changes for version 3.1
Post by: Bee-liever on November 07, 2016, 04:25:21 AM
In Artwork view, I think there's already been a suggestion for showing all the artwork for an album across the top of the expanded panel.
Whew! Took me ages to find it.
Buried way back in May, 2014   :o
http://getmusicbee.com/forum/index.php?topic=12934.msg77993#msg77993 (http://getmusicbee.com/forum/index.php?topic=12934.msg77993#msg77993)
Title: Re: Artwork Management Changes for version 3.1
Post by: psychoadept on November 07, 2016, 06:31:20 AM
In Artwork view, I think there's already been a suggestion for showing all the artwork for an album across the top of the expanded panel.
Whew! Took me ages to find it.
Buried way back in May, 2014   :o
http://getmusicbee.com/forum/index.php?topic=12934.msg77993#msg77993 (http://getmusicbee.com/forum/index.php?topic=12934.msg77993#msg77993)

Thanks!  I thought it was your suggestion, but I didn't have the patience to go looking.

Further thoughts I've had for the "Artwork Tag Inspector": maybe the user could have some control over the size of thumbnails shown (similar to Album Art Downloader - I'll get a gif soon).  Also, with multiple artwork shown in Album & Tracks or Artwork view, the context menu could include commands like "Delete from Album" and "Attach to Whole Album" or something to that effect.  Just an extension of what's possible now, with some obvious artwork commands in the context menu and the full set of tools in the artwork editing window.

Oh, a similar tool that would let us see and select multiple images for download would be icing on the cake... But not nearly as high a priority, imo.
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 07, 2016, 10:28:49 PM
I have split this from the 3.1 topic so as not to clutter it.

I have adjusted the current small artwork files to edit filter so it now has the primary picture dimensions, encoding and file size, and the number of pictures for the file displayed in the main panel.
The filter also shows files in an album with artwork thats inconsistent with other files in the same album.
So the filter is now "Small and Inconsistent Artwork". It should be ready tomorrow or the day after once i have adjusted the UI.
Its actually been quite surprising and useful to me to see all the album files in my collection that have inconsistent artwork
Title: Re: Artwork Management Changes for version 3.1
Post by: psychoadept on November 07, 2016, 11:30:41 PM
Awesome!  I can't wait to try it out.
Title: Re: Artwork Management Changes for version 3.1
Post by: Iasc on November 08, 2016, 09:30:49 AM
Will you are on artwork for 3.1 would it be possible to look at the artwork storage concepts discussed in this thread?

http://getmusicbee.com/forum/index.php?topic=9659
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 08, 2016, 09:33:17 PM
This has most of the new artwork filter functionality done. I still plan to add a couple of context menu items to convert PNG to JPEG or resize the arwork
http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip

the menus Tools menu now has a separate Artwork menu, so its
Tools/ Artwork/ Show Files with Inconsistent or Small Artwork

As mentioned above, the first time will still be slow to load, but after that it should be much faster.

Note the "inconsistent album artwork" filter is only checking the primary artwork for each file in an album and the artwork count per file. I felt it would complicate the GUI too much to also do a comparison of the secondary artwork pictures

Title: Re: Artwork Management Changes for version 3.1
Post by: Bee-liever on November 09, 2016, 05:02:41 AM
Looks good
I didn't know I still had all those embedded artwork left.  I thought I had deleted them all ages ago!

I think it is having a problem with artwork in ASX duplicate files though:
Code
MusicBee v3.1.6156.38728 (Win10.0), 9 Nov 2016 15:58:

System.ArgumentNullException: Value cannot be null.
Parameter name: image
   at System.Drawing.Graphics.DrawImage(Image image, Int32 x, Int32 y, Int32 width, Int32 height)
   at System.Drawing.Graphics.DrawImage(Image image, Rectangle rect)
   at MusicBee.MusicBeeMain.#=qOJ9l1Op3BpgoLUNnSTM43lz4ZiuDq26q$JUPQHZT0xc=.#=qda4$dmsVv9YCfrjBx7FBZniroJvAWlUF16fGgGrUxAw=.#=qVH0N4QgYfEXuZ1TdcYY8IA==._Lambda$__0(Graphics #=qgNfCFb9t52U6daZxNj1kfg==)
   at #=qfDoFO__y1MIetOj6Z0STuQ==.#=qkRDqXj3_lCKEN47oG0zrkA==.#=qU_qy6Q8p5Q4cEAF2uMYSDw==(#=qadkLRawVbkouLxpNZxZHmGLq2lv3j_yFhHJi6khEIbU= #=qMrsthX7mx4euof4Rsc1aWA==)
   at #=qfDoFO__y1MIetOj6Z0STuQ==.#=qvEUcLK3KVPqrMxWlKQKHwp0XLW0sLAHi_OmxISMn8HU=.#=q9DGj$vXBA4_dWJPZttamrA==(#=qadkLRawVbkouLxpNZxZHmGLq2lv3j_yFhHJi6khEIbU= #=qPXO6bOILX8Cwz_xv46FNdg==)
   at MusicBee.MusicBeeMain.#=qOJ9l1Op3BpgoLUNnSTM43lz4ZiuDq26q$JUPQHZT0xc=.#=qda4$dmsVv9YCfrjBx7FBZniroJvAWlUF16fGgGrUxAw=.#=qxGnoH9$6hOWtRSN8Y4h4qA==(#=qs_43HGjZVFfyCH8ZhKF0myc5VC2wkZ83sjjGOiPAz$0=[] #=qGNFbyrPlxpoqt0OHJEgKLg==)
   at MusicBee.MusicBeeMain.#=qOJ9l1Op3BpgoLUNnSTM43lz4ZiuDq26q$JUPQHZT0xc=.#=q9K7Kh3xmJgnKfOGS6LATemGrQn41CRv3UbVwO6FQkhc=(Object #=q81I1zJuZ2wCiQNisizSPKw==, #=qgUWuQ0Srt_Mn_Vg$81ZBabqfhaqrudTb6UB6frFR_SX4cubs8R6tWEkOlob5kCuLTPIgpH2WlhE9zaMikh_R_A== #=qMF0gLv8OFqd67xIoiIFHEw==)
   at #=ql1Mc3YfCdOu3P2CCFrTqZwrkHIXHz1ZKAAZRT8hx_l8=.#=qXLtPBqkp7D569dBbvFQYtrrxY9uOYBgfvwQNjXIJTu8=(#=qgUWuQ0Srt_Mn_Vg$81ZBabqfhaqrudTb6UB6frFR_SX4cubs8R6tWEkOlob5kCuLTPIgpH2WlhE9zaMikh_R_A== #=qhpw4ur0cvYHzJi5qLajU4Q==)
   at MusicBee.MusicBeeMain.#=qp08s$hWv8rsDsu0ZlOvb6Ve9PDKdtNwnDKHDcDZDf_g=.#=qXLtPBqkp7D569dBbvFQYtrrxY9uOYBgfvwQNjXIJTu8=(#=qgUWuQ0Srt_Mn_Vg$81ZBabqfhaqrudTb6UB6frFR_SX4cubs8R6tWEkOlob5kCuLTPIgpH2WlhE9zaMikh_R_A== #=qgbsAP$42tIN7oB2KWgb_5w==)
   at #=ql1Mc3YfCdOu3P2CCFrTqZwrkHIXHz1ZKAAZRT8hx_l8=.#=qis6htLGCtG_wBWcLQ7vM5A==.#=qCmIuKXsLJbIdA$dyvEUKa58wYkULSxgBGrJS2eZSyZ4=(Int32 #=qvNi_9dwd5sMjuVLsIniHTw==, Boolean #=q5XnHmdFBJqYwUjIzb$wLcw==, Boolean #=qkLEX77ndf_cgBLbtqMZWpvwnMC4hwTQ7JTTX_UwEHRQ=)
   at #=ql1Mc3YfCdOu3P2CCFrTqZwrkHIXHz1ZKAAZRT8hx_l8=.#=qis6htLGCtG_wBWcLQ7vM5A==.#=qzS_BUDFu1O9IH8VTFbfbSFxo57Ibw990yikSG$TjSO92y3p8V6EwaDqx67c80TTc(Int32 #=qvQC8TtbAJOdInybd8KEdHA==, Keys #=qHpveC_s6w6RA3o6GcO8p9w==)
   at #=ql1Mc3YfCdOu3P2CCFrTqZwrkHIXHz1ZKAAZRT8hx_l8=.#=qis6htLGCtG_wBWcLQ7vM5A==.OnMouseDown(MouseEventArgs #=qMhR3$VLL29L1FZKl1s$ptw==)
   at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at #=qpUhUc7FtcLPqFe6_evpahnOFiIyzJm_75nJaNpsg3ok=.WndProc(Message& #=qtOYvPY0HsCzCU4RIeNLPXA==)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 06:50:19 AM
I think it is having a problem with artwork in ASX duplicate files though:
i updated the code after i initially posted this and you might have an earlier version so redownload it.
Title: Re: Artwork Management Changes for version 3.1
Post by: Bee-liever on November 09, 2016, 07:19:52 AM
you might have an earlier version so redownload it.
yep. updated to 3.1.6156.40889 and no problem with ASX files or corrupted artwork
as it's an early version, I assume jumping back to top of list after each edit will be fixed later.
just mentioning it now so nobody else picks up on it
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on November 09, 2016, 01:29:53 PM
The size column shows file size rather than picture size for some files (mp3).
 

(http://i.imgur.com/oCXnWg4.png)


Also can you support sorting by each column? Maybe there's a way to sort, keeping tracks grouped by album, like sorting based on the largest value of tracks in each album.
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 06:54:43 PM
The size column shows file size rather than picture size for some files (mp3).
thats fixed for the next update.

as it's an early version, I assume jumping back to top of list after each edit will be fixed later.
just mentioning it now so nobody else picks up on it
thats addressed for the next update
Title: Re: Artwork Management Changes for version 3.1
Post by: psychoadept on November 09, 2016, 07:02:38 PM
I haven't been able to test extensively yet, but the first thing I noticed was that all the files shown in the inconsistent artwork filter used the highlighting color I assigned for non-mp3 tracks (and yes, they are mp3s).  Some of them retained that color outside of the filter, too.
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 07:20:27 PM
I haven't been able to test extensively yet, but the first thing I noticed was that all the files shown in the inconsistent artwork filter used the highlighting color I assigned for non-mp3 tracks (and yes, they are mp3s).  Some of them retained that color outside of the filter, too.
If you are using "Kind" in the rule then what is happening is MB is using that field for the artwork encoding. I can do something about that but can you confirm thats what you are using
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 09, 2016, 07:32:26 PM
Very nice addition, Steven.

I do find one aspect of it that isn't working as -I- expected it to, and am not sure if it's a bug, or the intended behavior.

I select 'non-square artwork' (for example) and edit the album art that is now square. At first I expected it to disappear as the artwork is now square. When it didn't drop off the list, I clicked 'refresh' thinking that would clear it from the list. But it doesn't. The behavior is the same no matter which search options are selected.

I think it would be more useful if the artwork is edited to exceed the criteria searched, then it should disappear. Ideally automatically, but if not, then at least with the refresh.
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 09, 2016, 07:44:40 PM
And if the edited/corrected artwork is not going to disappear upon being changed, shouldn't the list at least update?
(http://i.imgur.com/jDLtO86.jpg)
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 07:44:56 PM
it should automatically drop off and the properties update. Did you edit and save the artwork using the Tag Editor and does it drop off the list on restart of MB?
Title: Re: Artwork Management Changes for version 3.1
Post by: psychoadept on November 09, 2016, 07:45:17 PM
If you are using "Kind" in the rule then what is happening is MB is using that field for the artwork encoding. I can do something about that but can you confirm thats what you are using

That's probably it.  I could change the rule to use .ext, instead.
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 09, 2016, 07:50:06 PM
it should automatically drop off and the properties update. Did you edit and save the artwork using the Tag Editor and does it drop off the list on restart of MB?
The properties update, but it doesn't drop off the list. Editing was done with the Tag Editor while in the search results. Are you saying in order for it to drop off the list one has to restart MB? And redo the search? That's rather inconvenient. Couldn't/shouldn't it automatically disappear? Or at least disappear when 'refresh' is clicked. Right now 'refresh' does nothing if the list is already populated.
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 07:55:02 PM
it should automatically drop off the list without restart or refresh.
When you say the properties update, do the properties displayed in the main panel update? (not the right sidebar which i would expect to always reflect what the latest state is)

edit:
do you have "don't update file modification time" set in the Tags(1) preferences?

edit2:
thats how i can reproduce the issue. Infact that was something i was planning on looking at next anyway so it should be fixed soon but you should either not use this new functionality until its fixed or enable that option
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 09, 2016, 08:02:12 PM
it should automatically drop off the list without restart or refresh.
Doesn't happen to me.

Quote
When you say the properties update, do the properties displayed in the main panel update? (not the right sidebar which i would expect to always reflect what the latest state is)
No they don't. Look at the screenshot I posted in reply #16. That's -after- the artwork edit.
a) if it should drop off the list after the edit, you can see that it's still present.
b) if the properties should update after the edit, you can see that they haven't.

And yes, the status bar shows 'x files updated.'
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 08:03:05 PM
i dont think you saw my edits.
For the next update, i have put in something that will handle your usage with the Tags(1) option i mentioned as long you edit in the search results
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 09, 2016, 08:17:37 PM
edit:
do you have "don't update file modification time" set in the Tags(1) preferences?
No, that preference is not enabled.

Quote
edit2:
thats how i can reproduce the issue. Infact that was something i was planning on looking at next anyway so it should be fixed soon but you should either not use this new functionality until its fixed or enable that option
Good to hear. I'll probably continue to use it as is until you fix it since there are such a large number of tracks on the list that I can at least get a start on fixing them. It's still better 'broken' than not having the functionality at all.

i dont think you saw my edits.
Correct. I hadn't. That's one reason why I rarely edit posts these days. It's better to just post a 2nd reply.
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 09, 2016, 10:15:35 PM
fixes for the above:
http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
 
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 09, 2016, 10:25:21 PM
That's great Steven. Now working as expected. Thank you.
Title: Re: Artwork Management Changes for version 3.1
Post by: psychoadept on November 13, 2016, 03:12:48 AM
A few thoughts:

*I think it would make sense to force a tab with one of these filters open to be pinned until the filter is manually closed.  My biggest frustration with the filters is that if I accidentally navigate away, there's no way to get back to the filter except to go through the tools menu and wait for it to generate the list again.

*It would be nice to have "search internet for picture" in the context menu for the artwork filters

*I love the artwork column that shows all the artwork.  It would be nice to be able to delete artwork directly from that column (with warning message).
Title: Re: Artwork Management Changes for version 3.1
Post by: phred on November 13, 2016, 04:05:43 AM
*It would be nice to have "search internet for picture" in the context menu for the artwork filters

*I love the artwork column that shows all the artwork.  It would be nice to be able to delete artwork directly from that column (with warning message).
+1 for both of these
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 13, 2016, 08:40:18 PM
i have added more right click context menu support for the pictures displayed in the Artwork column

http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
Title: View artwork show all artwork
Post by: НКВД on November 14, 2016, 08:21:32 PM
Hello, i would like to suggest following:

Image rotation inside show artwork popup (if more than one cover present).

So inside view artwork popup all available cover art can be scrolled through using mousewheel, keyboard arrows or sweeping.
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on November 16, 2016, 08:45:23 PM
fix with the "Save as organised artwork" command for when the artwork was embedded - the embedded artwork is now actually removed from the music file:

http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on July 12, 2017, 04:53:14 PM
How about making Artwork Manager working only for the selected (and filtered) node like Duplicates Manager?
Then it would be much easier to manage artwork for a small group of files like albums just for one artist to quickly check dimensions.
Currently opening this takes a while to read and process all the files in the library which is not necessary in most times.
Title: Re: Artwork Management Changes for version 3.1
Post by: vzell on July 13, 2017, 06:42:55 AM
+1
Title: Re: Artwork Management Changes for version 3.1
Post by: Sidar on July 13, 2017, 03:50:11 PM
+1
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on July 16, 2017, 07:11:00 PM
How about making Artwork Manager working only for the selected (and filtered) node like Duplicates Manager?
this is done for the next v3.1 update, also including all the tagging tool filters
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on July 17, 2017, 12:56:56 AM
Working great! Thanks!
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on July 17, 2017, 01:56:11 AM
Regarding managing artwork in general, I think it would be great if MB could support converting .PNG to .JPG format to save space.
I recently learned MB can do that when linking new image files:
if you put .jpg on the end of the template it will convert to .jpg
eg.
Cover.jpg
will convert png files to jpeg

But I don't see such an option for embedded artwork. Also it's not possible to convert existing .PNG artwork to .JPG.

While googling it, I saw some apps are supporting such a feature:
https://www.blisshq.com/music-library-management-blog/2017/01/31/converting-itunes-album-art-jpeg/

So I think it would be great if there's a setting in preferences to enforce .JPG format for saving (either embedding or linking) artwork and if artwork manger could support a new command "Convert artwork to .JPG" for existing artwork. Then it would help reducing file size as MB now reclaims the freed up space when it's >4K.

The file size only reduces if the saving is >4K.
Title: Re: Artwork Management Changes for version 3.1
Post by: vzell on July 17, 2017, 05:42:44 AM
+1
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on July 17, 2017, 03:37:05 PM
i have added a context menu command to convert to JPEG when right clicking on a picture in the Artwork Manager tool
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on July 17, 2017, 05:01:53 PM
Thanks! So it can convert multiple tracks at once only when they have the exactly same PNG image. Can't it convert multiple albums at once with different PNG images?
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on December 28, 2017, 06:03:25 PM
Two issues with Album Artwork Manager tool:

(https://i.imgur.com/q0eeFCX.png)

1. To be useful, it should show the image for selected files as is, keeping its aspect ratio. Compare it with its actual image on the artwork panel on the right.

2. Its context menu has "Remove" command. I thought it would remove the link to the image file, but it actually deletes the image file from the computer. Can you make it two commands, "Remove the link" and "Delete the image file"?
Title: Re: Artwork Management Changes for version 3.1
Post by: Steven on December 30, 2017, 09:11:42 AM
i agree with both points and have made a change for the next v3.2 update
Title: Re: Artwork Management Changes for version 3.1
Post by: redwing on December 31, 2017, 03:30:31 PM
Thanks for the improvement! Working great!

Can you add a hotkey to show this tool so that we could set up either hotkey or a toolbar button for quick access?