getmusicbee.com

General => MusicBee Wishlist => Topic started by: redwing on October 05, 2016, 07:16:58 AM

Title: Artist picture in the main panel
Post by: redwing on October 05, 2016, 07:16:58 AM
Would be great if artist picture element could be placed in the main panel.


(http://i.imgur.com/E9Bt0wW.png)


Like the mockup, when it's placed at the top of the main panel, it would look better without its own header bar.

Also please add picture managing context menu commands (next picture, save artist picture, etc.) to artist picture element as well.
Title: Re: Artist picture in the main panel
Post by: Iasc on October 05, 2016, 08:28:13 AM
+1
Title: Re: Artist picture in the main panel
Post by: fabulario on October 05, 2016, 09:52:51 AM
+1

Or something like the top of the music explorer:

(http://i.imgur.com/s2gzRSxl.jpg) (http://i.imgur.com/s2gzRSx.jpg)

(Redwing, excuse me for using your mockup)
Title: Re: Artist picture in the main panel
Post by: redwing on October 05, 2016, 10:01:42 AM
Or something like the top of the music explorer:

I don't get the point. What would be different from using music explorer node?
Title: Re: Artist picture in the main panel
Post by: fabulario on October 05, 2016, 10:55:30 AM
I don't get the point. What would be different from using music explorer node?

Unless I have not been able to find these options, in the music explorer you can't use the thumbnails browser, and can't hide the column with the most played/rated songs.
(By the way, adding these options to the explorer would make me very happy  8) )

I do not intend to add the music explorer options (like artists, profile, etc.) to the main panel.

I propose to use only the aesthetics of music explorer (the bar and the photo of the artist, and maybe the genres and years) as an alternative to the photo of the artist that you propose. So I've used your mockup.
Title: Re: Artist picture in the main panel
Post by: Steven on October 10, 2016, 08:28:41 PM
I don't get the point. What would be different from using music explorer node?

Unless I have not been able to find these options, in the music explorer you can't use the thumbnails browser, and can't hide the column with the most played/rated songs.
i will do the original request for v3.1, but for v3.0 & v3.1, i have decided to enhance the filter panel in the Music Explorer so you can now optionally show the artist pictures in the filter panel, and equally for the thumb browser displayed in the normal main panel you can just show text only without a thumbnail.
Its already the case the Top Tracks/ Rating panel can be hidden - I think i only recently did that. Just click the "Artist Information" menu in the music explorer main panel header.
Although I have tested it myself, I would appreciate others testing it as well

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

edit:
there is one small bug where the top of the filter panel is showing "All Artists". I will fix that so its not displayed
thats fixed now
Title: Re: Artist picture in the main panel
Post by: fabulario on October 10, 2016, 10:15:08 PM
It works perfectly.
Thank you very much, Steven. For me this is a great improvement  :)
Title: Re: Artist picture in the main panel
Post by: redwing on October 11, 2016, 08:02:00 AM
Great improvement!

Just click the "Artist Information" menu in the music explorer main panel header.

This is not obvious. Now I can see why new users are missing clicking on main panel header button. How about always showing the checkmark as before?
Title: Re: Artist picture in the main panel
Post by: Steven on October 11, 2016, 07:06:01 PM
updated to improve synchronisation when tags are changed in other tabs or files added/removed to the library

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Artist picture in the main panel
Post by: redwing on October 11, 2016, 10:03:55 PM
Can you improve the behavior of music explorer tab when it's locked? It doesn't change at all unlike now playing tab with changed node and changed playing track. If you open a new music explorer tab, it's all updated but not the locked one.
Title: Re: Artist picture in the main panel
Post by: Steven on October 11, 2016, 10:09:24 PM
Can you improve the behavior of music explorer tab when it's locked? It doesn't change at all unlike now playing tab with changed node and changed playing track. If you open a new music explorer tab, it's all updated but not the locked one.
i am not sure i understand what you mean by "music explorer tab when it's locked"
if you are refering to not changing the selected artist when the song changes, thats intentional
Title: Re: Artist picture in the main panel
Post by: redwing on October 11, 2016, 10:14:30 PM
Sorry, should have said when the tab is pinned.
Title: Re: Artist picture in the main panel
Post by: Steven on October 11, 2016, 10:21:10 PM
I am still not understanding the point or issue you are raising. When I pin (or Navigation Lock) the Music Explorer tab, i dont see any unexpected behavior, nor any difference as compared to the Now Playing tab (or any other tab for that matter)

In what way do you think it should change when the playing track changes?
Title: Re: Artist picture in the main panel
Post by: redwing on October 11, 2016, 10:27:00 PM
if you are refering to not changing the selected artist when the song changes, thats intentional

I understand it keeps the selected artist as long as you stay in the node (tab). But once you leave from the node and come back, shouldn't it change to the playing artist? Because that's how the node works if you open a new music explorer tab.
Not only selected artist but the list of artists in filtering panel as well doesn't change when the node is pinned even when you're coming from a different library filter.
Title: Re: Artist picture in the main panel
Post by: Steven on October 12, 2016, 06:58:17 AM
I understand what you are saying now. I probably wont change anything for v3 though
Title: Re: Artist picture in the main panel
Post by: Steven on October 16, 2016, 10:00:01 AM
the original request is done for v3.1
Title: Re: Artist picture in the main panel
Post by: redwing on October 16, 2016, 10:19:58 AM
Thanks a lot!
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 12:33:53 AM
Just tried v3.1 yet it has some issues.
When placed along with filtering browsers in the main panel, it doesn't work correctly. The top of the filtering browser cuts off, and the tickbox for stacking should be removed as it makes no sense in the main panel. And never use it with horizontal column browser as the artist picture element no longer shows up. PMed my setting file - the element is put in the main panel in panel configuration settings but it doesn't show up.
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 10:15:36 AM
i was able to have a look at your settings this morning. The artist picture is 0 height, so just drag the panel to give it some height. I will investigate why it defaulted to 0 height and the vertical column browser arrangement issue.
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 10:52:56 AM
You're right. It was reduced to 0 height.
Some other issues:

- It needs a minimum height. I just reduced it to "below 0" size by dragging horizontal column browser below it up to the caption bar. Now I can't resize artist picture element anymore. (I found a way to recover it. Remove the element from the main panel, exit, run v3.0, exit, and then run v3.1 again)
- The order of elements matters. Try column browser/thumbnail browser/artist picture/files order for the main panel and you will see it breaks the UI.
- Maybe some elements (or some layouts) shouldn't be allowed to be placed in the main panel along with artist picture element to make things simpler.
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 07:07:44 PM
the reported issues should be fixed now:
http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 07:47:09 PM
These issues persist.

- It needs a minimum height. I just reduced it to "below 0" size by dragging horizontal column browser below it up to the caption bar. Now I can't resize artist picture element anymore.
- The order of elements matters. Try column browser/thumbnail browser/artist picture/files order for the main panel and you will see it breaks the UI.
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 07:50:39 PM
is the modification time of musicbee.exe 19:04 and the file size=6201 ?
its working fine (now) for me
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 07:56:07 PM
It's 19:04 but file size is 6,349,312.
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 08:08:59 PM
using your settings file where the column browser is not included i can reproduce the 2nd issue only. Thats fixed now:

http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 08:16:09 PM
PMed my settings file. You will see artist picture element has "below 0" height.
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 08:33:12 PM
i have put in handling for existing cases where it is <0 but it shouldnt be possible to create that situation in the newer versions

http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 08:46:00 PM
Thanks but still it easily breaks the UI.
Add column browser and thumbnail browser to the main panel as well and try changing the layout of column browser from horizontal to vertical, etc. (PMed my settings file again)
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 09:34:25 PM
this should address the issue from your settings file but i dont have time for now to go through the steps to reproduce and trap other conditions that might cause issues

http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip

edit:
i think i know how you are triggering the unexpected conditions. Its the order the artist picture is arranged in the configuration dialog - whether its before or after the column browser/ thumb browser. You will still be able to break things but i wont fix it until tomorrow
Title: Re: Artist picture in the main panel
Post by: Steven on October 25, 2016, 10:05:03 PM
i have made a more complete fix for the issue i found. Same link as before. Its only partially tested though
Title: Re: Artist picture in the main panel
Post by: redwing on October 25, 2016, 10:08:11 PM
Thanks! Working great now.
I'll report back if I notice any issue but it seems all are fixed.
Title: Re: Artist picture in the main panel
Post by: redwing on October 27, 2016, 02:19:45 AM
Found one more bug - hiding thumbnail browser breaks the UI. PMed my settings file.
Title: Re: Artist picture in the main panel
Post by: redwing on October 27, 2016, 03:07:47 AM
I saw visualizer (graphic) is now added to v3.1 as an element. Maybe it can be placed in the main panel as well just like artist picture element?
Title: Re: Artist picture in the main panel
Post by: Steven on October 27, 2016, 07:57:32 PM
yes thats a good idea and is now supported. Stacking it with the artist picture wont work though, and i will disable that option for future updates.

http://musicbee.niblseed.com/V3_1/MusicBee31_Patched.zip
Title: Re: Artist picture in the main panel
Post by: redwing on October 27, 2016, 10:30:04 PM
Working great. Thanks!