getmusicbee.com

Support => Developers' Area => TheaterMode => Topic started by: redwing on March 07, 2016, 10:54:46 AM

Title: TM bugs with v3
Post by: redwing on March 07, 2016, 10:54:46 AM
http://i.imgur.com/myLOC4s.png (Rdio Style)

- The scrollbar appears when playing track changes in shuffle mode or when selecting a track via now playing assistant. The scrollbar is actually the one for right main panel from the tab this TM was launched.
- Clicking on shuffle button and repeat button doesn't instantly change the icon though it functions.
- Clicking on shuffle button toggles to auto-dj mode as well.

All these happen with embedded TM as well. The same TM view is working perfectly with v2.5.
Title: Re: TM bugs with v3
Post by: Steven on March 07, 2016, 06:15:11 PM
thanks for reporting that. Looks like i missed copying over some code from v2.5
I have tested and all should be fixed for the next update. However for the scrollbar issue, i am slightly uncomfortable with the change i am making to fix it and would appreciate you confirm when you close TM and return to the main window that all the scrollbars look ok.
Title: Re: TM bugs with v3
Post by: Steven on March 07, 2016, 10:44:16 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: TM bugs with v3
Post by: redwing on March 08, 2016, 03:35:46 AM
Thanks, all bugs are fixed.
Not a big deal, but scrollbars are still flashing for a very short time when using hotkey to view TM.

http://i.imgur.com/pXul3FG.png
Title: Re: TM bugs with v3
Post by: Steven on March 08, 2016, 06:32:05 PM
i have made a change for the next update that hopefully will stop the flashing, although i dont see it myself so i cant be completely sure its addressed
Title: Re: TM bugs with v3
Post by: Steven on March 08, 2016, 09:43:50 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: TM bugs with v3
Post by: redwing on March 08, 2016, 10:12:05 PM
Thanks, but it wasn't addressed.

http://i.imgur.com/5RsDLfv.png

But not a big deal as it's only happening for a short moment while running the hotkey.
Title: Re: TM bugs with v3
Post by: Steven on March 09, 2016, 08:47:03 PM
i can reproduce this if using the hotkey from within the theatre mode panel itself and also to a lesser extend when switching between some theatre mode skins.
I have made a change in the plugin to better handle those scenarios
Title: Re: TM bugs with v3
Post by: Steven on March 09, 2016, 09:53:47 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: TM bugs with v3
Post by: redwing on March 10, 2016, 02:36:19 AM
Excellent! It's now working perfect!
Title: Re: TM bugs with v3
Post by: redwing on May 15, 2016, 08:46:51 AM
On full-screen mode of TM, "Show Now Playing Assistant" command doesn't work either via context menu command, hotkey, or on-click button.

[edit] I see it works and opens the popup window but just doesn't take focus from the main window. Same when running "Show equalizer & DSP" command. Many apps (like web browsers or office apps) support opening popups on full-screen mode. Hope you support it but if you can't, temporarily turning off full-screen mode could be an alternative to show the popup window.
Title: Re: TM bugs with v3
Post by: Steven on May 15, 2016, 05:34:45 PM
thats addressed for the next patch update
Title: Re: TM bugs with v3
Post by: redwing on May 15, 2016, 06:38:07 PM
Yes, it's working now. Thanks!
Title: Re: TM bugs with v3
Post by: redwing on May 17, 2016, 06:23:15 PM
- set the theater panel to a fixed size:
  <settings fixedWidth="300" fixedHeight="100" />

Fixed size setting doesn't work with v3. Is this a bug or no longer supported?
Title: Re: TM bugs with v3
Post by: Steven on May 17, 2016, 06:42:32 PM
i removed it as it was too much effort to add support for it in v3 vs. how often it was being used.
Title: Re: TM bugs with v3
Post by: redwing on May 17, 2016, 06:50:43 PM
OK. Thanks for clarifying.
Title: Re: TM bugs with v3
Post by: redwing on May 18, 2016, 08:18:17 PM
Gallery element doesn't show playing artist's backdrops under some situations. Try the following steps with Rdio Style skin.

1. Play a track.
2. Click on the Gallery button on the right then it will show artist backdrops.
3. Click on the button again and return to the original album view.
4. Play another artist's track.
5. Click on the Gallery button but it keeps showing previous artist's backdrops.
Title: Re: TM bugs with v3
Post by: Steven on May 19, 2016, 07:35:20 PM
that should be addressed for the next patch update
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: TM bugs with v3
Post by: Steven on May 19, 2016, 07:59:15 PM
i should add i have implented a 45 second minimum for the picture rotation interval in order to reduce strain on the artwork hosting sites
Title: Re: TM bugs with v3
Post by: redwing on May 20, 2016, 04:37:02 AM
Thanks! That's fixed but there's another bug with gallery element.
If you play a soundtrack song in the gallery mode, it shows movie backdrops properly. But if you start playing the song in album view and then switch to gallery mode, it shows artist backdrops.
Title: Re: TM bugs with v3
Post by: redwing on June 13, 2016, 05:26:37 AM
1. In compact mode, use "show TM" hotkey. Then you can't close TM:

10.0.10586.0 - 3.0.6007.34903 - System.NullReferenceException: Object reference not set to an instance of an object.
   at MusicBeePlugin.Plugin.CloseTheatreMode(Boolean dispose)
   at MusicBeePlugin.Plugin.TheatrePanel.closeMenuItem_Click(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

2. In full-screen TM mode, use "switch to compact mode" hotkey. Then you can't close TM:

10.0.10586.0 - 3.0.6007.34903 - System.NullReferenceException: Object reference not set to an instance of an object.
   at MusicBeePlugin.Plugin.CloseTheatreMode(Boolean dispose)
   at MusicBeePlugin.Plugin.TheatrePanel.ExecuteClickFunction(FunctionId action, Int32 offset)
   at MusicBeePlugin.Plugin.TheatrePanel.OnMouseDown(MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

3. Also auto-hidden left navigator pops up over TM if you move the mouse to the left edge.
Title: Re: TM bugs with v3
Post by: Steven on June 13, 2016, 07:08:08 AM
i cant reproduce 1 or 2, although i agree that for 1, MB is not switching to TM from the compact player and when you return to the main player the TM panel is open and cant be closed but no error for me.
Could you send me your settings file
Title: Re: TM bugs with v3
Post by: redwing on June 13, 2016, 07:33:37 AM
PMed my settings file.

For #2, with Theater Panel Dock> fullscreen mode, run any TM and execute the hotkey for "switch to compact player". Then nothing happens and you can't close the TM. At that point if you unhide Windows taskbar, it shows two instances of MB: one for TM another for MB main app:

(http://i.imgur.com/R2xmxK5.png)

If you close the upper one, then you return to MB, exiting from TM.
Title: Re: TM bugs with v3
Post by: Steven on June 13, 2016, 08:03:51 PM
those should all be fixed for the next v3 patch update however i was never able to reproduce the actual error itself
for 1, the theater mode panel will not start unless you are in the main player
Title: Re: TM bugs with v3
Post by: redwing on June 16, 2016, 01:25:48 PM
#2 & #3 got fixed.

for 1, the theater mode panel will not start unless you are in the main player

For #1, it's still possible to run "Show TM" hotkey from compact mode. And then if you execute the hotkey for "switch to compact player" from a full-screen-mode TM, there's no way you can exit from the TM:

10.0.10586.0 - 3.0.6010.38110 - System.NullReferenceException: Object reference not set to an instance of an object.
   at MusicBeePlugin.Plugin.CloseTheatreMode(Boolean dispose)
   at MusicBeePlugin.Plugin.TheatrePanel.closeMenuItem_Click(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

I know this won't be a big issue for most users. You can ignore this.
Title: Re: TM bugs with v3
Post by: redwing on November 01, 2017, 02:40:16 PM
TM artist bio doesn't work properly for multiple artists.

For a track with Display Artist value "Georg Solti; Chicago Symphony Orchestra"

TM bio says "No biography for Georg Solti" while main artist bio panel shows his bio.
Title: Re: TM bugs with v3
Post by: Steven on November 02, 2017, 07:20:29 PM
thats fixed for the next v3.2 update
Title: Re: TM bugs with v3
Post by: redwing on November 02, 2017, 11:18:53 PM
It's fixed. Thanks!
Title: Re: TM bugs with v3
Post by: redwing on July 29, 2018, 01:08:00 PM
"AlbumTracks" element doesn't respect album grouping setting.
I am using album as tracks in their own folder setting, but the element sees albums as having the same album name & album artist value.
So if I play an album, it searches and adds all albums in my library with the same album name & album artist to the list.
But it doesn't play tracks from other albums. Just plays only the selected album, skipping tracks from other albums.

(https://i.imgur.com/8zU51mS.png)
Title: Re: TM bugs with v3
Post by: redwing on July 29, 2018, 05:41:35 PM
While running "Album Wall" TM view, got this error:

System.OutOfMemoryException: Out of memory.
   at System.Drawing.Graphics.CheckErrorStatus(Int32 status)
   at System.Drawing.Graphics.DrawImage(Image image, Rectangle destRect, Rectangle srcRect, GraphicsUnit srcUnit)
   at #=zRolAABWz5_TDjg4efWnnbIc=.#=ztEK2FwPd9hJvuQ2Y8ZTIQqY=.#=z4IDngpo=(Graphics #=zUkD6D0g=, Rectangle #=zmrMPp_RS$rMf, Rectangle #=zCFAHZq9pgA_S)
   at #=zXxXSmQRNWGbHFrp_FaUH8AKK0R3p.#=zBvVbxP1Gh5dJhKsUDVHS6Xk=(#=ztEK2FwPd9hJvuQ2Y8ZTIQqY= #=zYhuv4qg=, Size #=zBu8$7sw=, Color& #=z1JubINI=, #=ztEK2FwPd9hJvuQ2Y8ZTIQqY=& #=zIvDndNdpLBMi, Bitmap& #=zfpmcnnimvm0ATiKDzA==, Single& #=zjNSaua7OsAbsyU2cSw==)
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zwuQAAd1tyY5n.#=zk2sLifXpGy9GT3sXuw==.#=zj6wW$su_HagK2Azn1_GBC$E=(#=ztEK2FwPd9hJvuQ2Y8ZTIQqY= #=zYhuv4qg=)
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zwuQAAd1tyY5n.#=zk2sLifXpGy9GT3sXuw==.#=zCQ8neV4KhtQ_DX68pw==(#=ztEK2FwPd9hJvuQ2Y8ZTIQqY= #=zYhuv4qg=, Boolean #=zmxXpOtOvmNmt3OFWNA==)
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zwuQAAd1tyY5n.#=zk2sLifXpGy9GT3sXuw==.#=zCQ8neV4KhtQ_DX68pw==()
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zwuQAAd1tyY5n.#=zk2sLifXpGy9GT3sXuw==.#=zA92ZOdJby4k5(#=zEZdJ4fL4YkImN_SVvAtYp68= #=zrZMsmLI=)
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zwuQAAd1tyY5n.#=zk2sLifXpGy9GT3sXuw==.#=z8UNsrUU=(Boolean #=zjCLmrGY=)
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zEfAH4k6f1g2U(Boolean #=zehLlS_asfIMO1PO_RQ==, Boolean #=zFqDNeoCoUVnu)
   at #=ztAIepnSW1NZrEKMzAlsVuaq9msUN.#=zFqwQ$H$QFX$F(#=z09AO1DVPdNQsCnfLpCvwrW0= #=z9wiBwwyuuwpI, Boolean #=z6Ht_qMmEOwWJ, #=zL9bBQ$M= #=zWl1VaDQ=, #=z1gyPYN9nAxRk6nUAJRrfQhg= #=zCSlpzpDkrw3c, Boolean #=zH9Y41_NrrJ13, #=zw7Q0ImlWAngqOH5XNTrmm$c= #=zAf2zxsPkN3eR, #=zEZdJ4fL4YkImN_SVvAtYp68=[] #=zn0SZbo2aZDYI, Boolean #=zhe501rXE7_De)

I think it's about the file size of cover images. For albums with small image files, it's working fine. I got this error from albums with about 2 MB cover image in average. The view displays 36 cover images. Does this mean then it can't handle about 70 MB of cover image in total?
Title: Re: TM bugs with v3
Post by: Steven on July 29, 2018, 07:31:14 PM
I wont be able to look at this for a few days but i can say its not necessarily to do the with the bitmap size and that error can be thrown for other reasons. I will need the picture in question when i come to look at this.
The actual error in this was with the main player controls auto-colouring. Just a thought - were you viewing the "Now Playing" tab and do you have the main player controls panel hidden when viewing the Album Wall skin?
Title: Re: TM bugs with v3
Post by: redwing on July 29, 2018, 07:48:53 PM
No, I'm running a full-screen TM. Just tried with auto-pick color option disabled, but it made no differences.
What's happening is it shows no covers at all or only a few covers with the rest either as nothing or as "NoArtwork" image.
Sometimes it shows all images correctly, but if I click on play next button, no covers show up. The error is not always thrown, but the covers are not displayed properly most of the time, again only with big image files.
Title: Re: TM bugs with v3
Post by: redwing on July 30, 2018, 03:49:27 PM
I have tested with various albums with different image file size and am pretty sure the issue is about handling large image files.

When you have time, download this image: https://www.grappa.no/wp-content/uploads/2017/05/PSC1356.jpg

The image is about 4 MB. Then embed it to 40 tracks and run the TM for the album to see if you can replicate the issue.
Title: Re: TM bugs with v3
Post by: Steven on July 31, 2018, 06:56:15 PM
both the reported issues should be addressed now:
https://getmusicbee.com/patches/MusicBee32_Patched.zip
Title: Re: TM bugs with v3
Post by: redwing on July 31, 2018, 07:24:04 PM
Yep, both issues are fixed now. Thanks a lot!