getmusicbee.com

General => MusicBee Wishlist => Topic started by: Steven on March 04, 2014, 06:36:26 PM

Title: Improved Visualiser Support
Post by: Steven on March 04, 2014, 06:36:26 PM
I have updated the visualiser handling with the following changes:
- now plays back normally when using ASIO or WASAPI output
- better handling for Winamp visualisers. For this i have overridden the handling for Winamp desktop mode so hopefully it will no longer crash.
- also using the Alt D keys will run the desktop mode for WMP and BassBox visualisers

I will post a link later
Title: Re: Improved Visualiser Support
Post by: Steven on March 04, 2014, 08:09:48 PM
this has the new functionality:
http://musicbee.niblseed.com/V2_4/MusicBee_Exe_Patched.zip
Title: Re: Improved Visualiser Support
Post by: redwing on March 05, 2014, 06:31:39 AM
It's working much better without crashing at all. Before this, some strict steps were required for operating it to avoid a sudden crash. But I have two wishes, both of which were possible before:
- Allow to place MB on desktop mode upon clicking on the icon from taskbar. Separating MB from milkdrop was possible before though that wasn't intended.
- Can't find the way to use milkdrop specific commands. Pleas allow to use some, if not all, frequently used commands, including preset selection list, display of the current preset name, and ability to run the previous or next preset or keep the current preset.

two small things:
- If Alt-D is assigned to this feature, maybe the key needs to be reserved?
- "Press F1 for help" message displays at the bottom when milkdrop starts.
Title: Re: Improved Visualiser Support
Post by: Steven on March 06, 2014, 10:23:34 PM
this version now separates musicbee from the visualiser in desktop mode (MB is minimised but can be restored)
I havent tested it extensively so it is possible i have overlooked some combination of settings but i will test further.

I dont think i can do anything about the F1 message

http://musicbee.niblseed.com/V2_4/MusicBee_Exe_Patched.zip
Title: Re: Improved Visualiser Support
Post by: redwing on March 07, 2014, 12:23:02 AM
Working great! Excellent job!

Now the only remaining wish is the ability to select and navigate with presets. As lots of them are not that good, this discerning, skipping, sticking ability is really necessary. If you can't restore its own command set, please offer some keys for such functionality.
Title: Re: Improved Visualiser Support
Post by: Steven on March 07, 2014, 06:59:39 PM
this version now handles the keys used by the winamp visualiser:
http://musicbee.niblseed.com/V2_4/MusicBee_Exe_Patched.zip

the only thing i needed to change which i didnt really want to do is now Escape will close FullScreen and Desktop modes, but wont close the visualiser entirely, That requires using the right click menu or the main menu
Title: Re: Improved Visualiser Support
Post by: redwing on March 07, 2014, 08:18:16 PM
Thanks for the update! The keys are working well except preset selection list (hotkey: L). The list box loads fine, but arrow keys don't work.

I can see your point about escape key. That was the case before as well, especially when MB's separated on full-screen mode or desktop mode. Just like before, the hotkey for visualizer works best in any cases.
Title: Re: Improved Visualiser Support
Post by: lnminente on March 07, 2014, 11:35:55 PM
A lot better, before it used to give a lot of "out of memory" errors. Working great now. Thanks Steven (y)
Title: Re: Improved Visualiser Support
Post by: Steven on March 08, 2014, 09:57:38 AM
the keys should now work in the L mode:
http://musicbee.niblseed.com/V2_4/MusicBee_Exe_Patched.zip
Title: Re: Improved Visualiser Support
Post by: redwing on March 08, 2014, 11:16:42 AM
Now it's working perfect. Thanks a lot!
Title: Re: Improved Visualiser Support
Post by: redwing on March 11, 2014, 08:13:44 PM
When MB is placed over milkdrop on desktop mode, clicking on the visualizer part does not take focus from MB. This makes impossible to use milkdrop specific keys on desktop mode. If I change to full screen mode and then return to desktop mode, then those keys start working. But then clicking on any place, whether on milkdrop or MB, again returns it to the previous state, MB's not returning focus.
Title: Re: Improved Visualiser Support
Post by: Steven on March 11, 2014, 08:59:24 PM
i guess i am not understanding what you are saying or you are encountering a very weird bug. When desktop mode is enabled, clicking on the winamp visualiser on the desktop takes focus from musicbee as clicking on any window would. I have no problems using the milkdrop keys on the visualiser in any circumstance.
The only incorrect behavior (which i wont be able to resolve) is when MB is focused , desktop mode enabled and you press a milkdrop key in MB then MB executes the key and so does the milkdrop visualiser
Title: Re: Improved Visualiser Support
Post by: redwing on March 11, 2014, 09:23:34 PM
On further tests, it's taking focus from MB and its keys are working if I click on MB, not on the milkdrop, which I kept on doing before. If I click on any part of milkdrop, no keys are working for milkdrop either on mini player mode or compact mode of MB. Is this expected?
Title: Re: Improved Visualiser Support
Post by: Steven on March 11, 2014, 09:46:27 PM
i still dont really get what you are experiencing but i have made the following changes (not necessarily related to what you are saying):
- i have entirely disabled the Escape key from the musicbee side, so it no longer closes the desktop mode (this is so it doesnt close desktop mode when in a winamp dialog)
- you can no longer use the hotkey to open the visualiser from the compact or mini player
- when desktop mode is enabled and MB is focused, pressing a key only gets processed by MB so you dont end up with it being processed by MB and also by the visualiser
- otherwise i cant reproduce anything you are saying

edit:
ok, i can reproduce some incorrect behavior when toggling from desktop mode to full screen and back to normal size after that
Title: Re: Improved Visualiser Support
Post by: Steven on March 11, 2014, 10:54:01 PM
http://musicbee.niblseed.com/V2_4/MusicBee_Exe_Patched.zip
Title: Re: Improved Visualiser Support
Post by: redwing on March 11, 2014, 11:03:57 PM
Well, now the keys are not working even if I click on MB, not to mention clicking on milkdrop. Could you revert back to the previous one, which at least worked upon clicking on MB?

Another one is, not sure if only I am experiencing this, when switching to desktop mode after activating milkdrop, MB shows up in main player mode as if visualizer was closed down. Then I use a hotkey to switch to either mini or compact mode, then it gets placed over milkdrop. But according to your descriptions, it should be minimized when switching to desktop mode, right? But I never saw that even with this version.
Title: Re: Improved Visualiser Support
Post by: Steven on March 11, 2014, 11:16:54 PM
unless you can explain step by step what you are doing, and which keys you are pressing, and what action that key is expected to have i wont be able to do any more. Its all working fine for me.
Title: Re: Improved Visualiser Support
Post by: redwing on March 11, 2014, 11:27:49 PM
There's no problem with visualizer within MB mode and full-screen mode. All keys are working fine. Only desktop mode is not working correctly.

- Open visualizer. Press alt-D or right click and select desktop mode.
- Then MB in main player mode shows up. Switch to mini or compact mode. Then it's placed over milkdrop.
- Now no keys are working for milkdrop. With the previous version, the keys were working if I click on MB.
Title: Re: Improved Visualiser Support
Post by: redwing on March 12, 2014, 06:26:53 AM
To make sure, just tried with a fresh installation a 2.3 portable version and milkdrop plugin with a default settings file after applying the latest patch. Exactly same results. Windows 7 Pro 64-bit.
Title: Re: Improved Visualiser Support
Post by: Steven on March 12, 2014, 07:28:43 PM
if you have set the mini-player and compact-player to "always on top" then i can reproduce incorrect behavior with keyboard handling which should be fixed for the next update
Title: Re: Improved Visualiser Support
Post by: redwing on March 12, 2014, 07:59:08 PM
OK, that's the setting. Now I see what's going on.

As the way it worked before, I naturally expected MB will keep placed over milkdrop wherever I may click on because that's the point of having MB placed over milkdrop on desktop mode -- you're controlling both, navigating through songs and presets.

But if I try disabling "Always on top", nothing is exciting although all keys are working. It's just the same as switching to full-screen mode as there's no MB on the screen. So I hope with the setting enabled MB doesn't disappear from desktop wherever I click on.

Also I still don't get why MB shows up as main player mode when switching to desktop mode. It's the same regardless of the setting.
Title: Re: Improved Visualiser Support
Post by: Steven on March 12, 2014, 08:17:07 PM
Also I still don't get why MB shows up as main player mode when switching to desktop mode. It's the same regardless of the setting.
its either that or close down the visualiser - perhaps it makes more sense to close down the visualiser
edit:
actually thats what i intended and there is a case its not being applied correctly
Title: Re: Improved Visualiser Support
Post by: redwing on March 12, 2014, 08:25:15 PM
this version now separates musicbee from the visualiser in desktop mode (MB is minimised but can be restored)

Then what did you mean by this?
Title: Re: Improved Visualiser Support
Post by: redwing on March 12, 2014, 08:28:03 PM
OK, I thought only I am experiencing a bug.

That won't be a big deal. Users can easily switch to any player mode with hotkeys.
Title: Re: Improved Visualiser Support
Post by: Steven on March 12, 2014, 11:16:28 PM
this has the change:
http://musicbee.niblseed.com/V2_4/MusicBee_Exe_Patched.zip
Title: Re: Improved Visualiser Support
Post by: redwing on March 13, 2014, 03:25:07 AM
Now it's working perfect. Thanks!
Title: Re: Improved Visualiser Support
Post by: usraek on November 27, 2014, 05:55:41 PM
According to the information above, the hotkeys in Milkdrop should be supported, but they do not function at all for me. The 'info' button, and the 'F1' menu work, but the track skipping or anything else doesn't work.

As a work-around I've tried to implement global hotkeys for skipping tracks, but even those completely fail to function. I can't quite understand why.

Any ideas?
Title: Re: Improved Visualiser Support
Post by: Steven on December 10, 2014, 09:00:01 PM
this should address the issue of not being able to use keys in other applications.

http://musicbee.niblseed.com/V2_5/MusicBee_Exe_Patched.zip