getmusicbee.com

Support => Developers' Area => TheaterMode => Topic started by: redwing on October 21, 2013, 09:34:39 AM

Title: A few wishes for TM functionality
Post by: redwing on October 21, 2013, 09:34:39 AM
Here are some wishes to improve the current TM functionality:

1. Support "element name.Center" for widthDock and heightDock attributes too as it's supported for xAnchor and yAnchor. Currently up to two invisible blocks are needed for a workaround.
2. Alpha value support for fg of RatingLove (star rating is already supported for fg2).
3. "Progress" as a field just like "Duration" so that Progress Position can be split.
4. "Scroll" attribute for "Field" type that makes the field along with child fields  scroll when it's too long and cut just like main player display scroll.
5. Support toggling characters and images for onClick toggling funtions (PlayPause, VolumeToggleMute, etc.)
6. Support for onClick functions for SuffleToggle and RepeatToggle
7. Regarding AlbumTracks and NowPlaylingList type
   - support for fg2 to color playing track differently
   - support "Scroll" attribute for playing track only
   - support Rating and RatingLove as child elememts
   - make both total list and child elements respect widthDock settings

Let me know what you can support this time so that I can determine when to release rdio style view (all work is done except for these wishes)
Title: Re: A few wishes for TM functionality
Post by: Steven on October 21, 2013, 01:21:34 PM
i will have a look at this after the podcast handling improvements so probably not until the weekend at the earliest.
Title: Re: A few wishes for TM functionality
Post by: redwing on October 21, 2013, 01:23:59 PM
OK, then I'm gonna release it soon and will update it later when they're done. Thanks!
Title: Re: A few wishes for TM functionality
Post by: redwing on October 23, 2013, 09:29:01 AM
Added a few more to first post.
Title: Re: A few wishes for TM functionality
Post by: Steven on October 28, 2013, 05:17:29 PM
Quote from: redwing on October 21, 2013, 09:34:39 AM
1. Support "element name.Center" for widthDock and heightDock attributes too as it's supported for xAnchor and yAnchor. Currently up to two invisible blocks are needed for a workaround.
could you provide me an example from the Rdio skin so i can better understand what you want to achieve - i know what you have said, but it will help me to get it working as you want if i can see with an example
Title: Re: A few wishes for TM functionality
Post by: redwing on October 28, 2013, 05:26:04 PM
Just PMed current working version with those examples in the code. Thanks!
Title: Re: A few wishes for TM functionality
Post by: Steven on October 28, 2013, 06:39:19 PM
i have made the change to support
widthDock="X:target element name.Center"   ie. the width of the element is set to half the width of the target element
heightDock="Y:target element name.Center"
but i dont see any example of that in the file you sent
Title: Re: A few wishes for TM functionality
Post by: redwing on October 28, 2013, 06:45:51 PM
Thanks! That's exactly what I wished to have. For the examples, I meant invisible boxes, not the Center usage. Sorry!
Title: Re: A few wishes for TM functionality
Post by: Steven on October 28, 2013, 07:17:57 PM
http://www.mediafire.com/download/1hvx31h4o3buhxz/mb_TheaterModePlugin.zip

this has the following changes:
1. Support "element name.Center" for widthDock and heightDock attributes
3. "PlayPosition" and "PlayDuration"
6. Support for onClick functions for "ShuffleToggle" and "RepeatToggle"

i will have a look at 2, 5 and 7 minus the scroll bar request

edit:
for 1, i also added support for percentage values
e.g. heightDock="x:#Cover.70" would be 70% of the width of element #Cover

Title: Re: A few wishes for TM functionality
Post by: redwing on October 28, 2013, 07:39:47 PM
Working great so far, thanks!

(http://i.imgur.com/Fk8EycG.png)
Title: Re: A few wishes for TM functionality
Post by: redwing on October 28, 2013, 08:32:30 PM
Can you support percentage values for xAnchor and yAnchor too?

e.g. xAnchor="Panel.25" means 25% position from the left for the width of panel.
Title: Re: A few wishes for TM functionality
Post by: Steven on October 28, 2013, 09:20:32 PM
http://www.mediafire.com/?1hvx31h4o3buhxz

- percentages for anchors is now supported

- the following attribute is now supported for fields, blocks, child elements etc.
 visibleTrigger="XXXX"
when XXXX is true the element is displayed. So that means you would need to repeat the element but show it with a different image or text and the opposite trigger condition
Valid triggers are:
            Playing
            NotPlaying
            VolumeMute
            VolumeNotMute
            ShuffleOn
            ShuffleOff
            RepeatOn
            RepeatOff
            EqualiserOn
            EqualiserOff
            ScrobbleOn
            ScrobbleOff

eg.
Code
<element type="Text" x="81" yAnchor="Panel.Bottom" y="-52" width="50" font="Webdings" style="Bold" size="25" fg="255,255,255" mouseOverFg="0,150,250" onClick="PlayPause" visibleTrigger="Playing">4</element>
<element type="Text" x="81" yAnchor="Panel.Bottom" y="-52" width="50" font="Webdings" style="Bold" size="25" fg="255,255,255" mouseOverFg="0,150,250" onClick="PlayPause" visibleTrigger="NotPlaying">8</element>

Title: Re: A few wishes for TM functionality
Post by: redwing on October 28, 2013, 10:56:41 PM
Do ShuffleToggle and RepeatToggle onClick functions support image files? They don't seem to work with icon type image files though they work fine with text type. Icons are shown, but not clickable.
Title: Re: A few wishes for TM functionality
Post by: Steven on October 28, 2013, 11:18:06 PM
i dont have time to test this but hopefully it will work for clicking icons:
http://www.mediafire.com/?1hvx31h4o3buhxz
Title: Re: A few wishes for TM functionality
Post by: redwing on October 29, 2013, 01:28:47 AM
Now the icons are clickable, but has no effect on settings.

Also two images look overlapped like this

(http://i.imgur.com/4JcSnml.png)

Code
<element type="Icon" image="Images\Rdio_ShuffleOn.png" xAnchor="PlayPosition.Left" x="-25" yAnchor="Panel.Bottom" y="-30" width="30" height="20" onClick="ShuffleToggle" visibleTrigger="ShuffleOn"></element>
<element type="Icon" image="Images\Rdio_ShuffleOff.png" xAnchor="PlayPosition.Left" x="-25" yAnchor="Panel.Bottom" y="-30" width="30" height="20" onClick="ShuffleToggle" visibleTrigger="ShuffleOff"></element>

All onClick functions are working fine with text types when visibleTrigger is set, but none of them works with icons.
Title: Re: A few wishes for TM functionality
Post by: redwing on October 29, 2013, 02:00:47 PM
Quote from: Steven on October 28, 2013, 09:20:32 PM
- percentages for anchors is now supported

They don't seem to work though widthDock and heightDock attributes are working fine with percentages.

xAnchor="X:Panel.50" x="0"

returns simply x="0" with no differences between "X:Panel.10" and "X:Panel.90". All returns x="0".

Just to make sure, tried without "X:" too, but

xAnchor="Panel.50" x="0"

returns nothing.
Title: Re: A few wishes for TM functionality
Post by: Steven on October 29, 2013, 09:51:30 PM
this should fix both issues:
http://www.mediafire.com/download/1hvx31h4o3buhxz/mb_TheaterModePlugin.zip

the syntax for anchors is
xAnchor="Panel.30" x="0"

the visibility for the icons should work now as well
Title: Re: A few wishes for TM functionality
Post by: Steven on October 29, 2013, 11:00:29 PM
2. Alpha value support for fg of RatingLove (star rating is already supported for fg2).
   not sure exactly what you are looking to achieve but i have taken a guess at the issue so let me know if its how you expect

7. support for fg2 to color playing track differently

same link as above
this is probably all i will do for now unless you think any of the remaining items are really important
Title: Re: A few wishes for TM functionality
Post by: redwing on October 29, 2013, 11:13:22 PM
Everything is working fine now! And, yes, that's what I meant for RatingLove. Thanks a lot!

Could you check the TM view I PMed you yesterday? When you open artwork playing list, only the first album is visible. From the next track, all albums are shown now. Can you fix it so that all albums are visible when it's loaded first time?
Title: Re: A few wishes for TM functionality
Post by: Steven on October 29, 2013, 11:18:51 PM
i dont understand what you mean by "When you open artwork playing list"
you have the "AlbumTracks" element in your skin which only shows the tracks for the current playing album
Title: Re: A few wishes for TM functionality
Post by: redwing on October 29, 2013, 11:25:17 PM
You have three buttons on the right. I meant the middle one.
Title: Re: A few wishes for TM functionality
Post by: Steven on October 29, 2013, 11:30:44 PM
i still dont know what you mean - there are 2 buttons on the right.
Are you talking about the Now Playing Assistant? If thats what you mean, then i cant reproduce any incorrect behavior as you describe
Title: Re: A few wishes for TM functionality
Post by: redwing on October 29, 2013, 11:33:11 PM
The view's name should be "Rdio style_working" not just "Rdio style".
Title: Re: A few wishes for TM functionality
Post by: Steven on October 30, 2013, 08:12:34 AM
ok, i know what you mean now and can reproduce. I will try to address it
Title: Re: A few wishes for TM functionality
Post by: redwing on October 30, 2013, 10:24:37 AM
Thanks! Also when it's done please make the dll included to the latest patch so that I could post the updated version.
Title: Re: A few wishes for TM functionality
Post by: redwing on October 30, 2013, 12:01:06 PM
One more thing to fix. onClick OpenAutoHidePanel function does not work with icons. The icon is shown and clickable but not working.

Code
<element type="Icon" image="Images\Artwork List.png" xAnchor="Panel.Right" x="-89" yAnchor="Panel.Bottom" y="-44" width="20" height="20" onClick="OpenAutoHidePanel:#ArtworkNowPlayingList"></element>
Title: Re: A few wishes for TM functionality
Post by: Steven on October 30, 2013, 09:32:54 PM
Quote from: redwing on October 30, 2013, 12:01:06 PM
One more thing to fix. onClick OpenAutoHidePanel function does not work with icons. The icon is shown and clickable but not working.
that should be fixed - i will post a link later

for the background image, i have created a new element
<element type="BackgroundAlbumCover" brightness="0.2" refreshInterval="20"></element>

its basically the same as what you have done except its more optimised and picks a random location on the album cover. It always sizes to the panel size. Also the refreshInterval (seconds) will choose a new random location
Title: Re: A few wishes for TM functionality
Post by: Steven on October 30, 2013, 10:31:42 PM
this should fix both issues and has the new <BackgroundAlbumCover> element as described above:

http://www.mediafire.com/?1hvx31h4o3buhxz

edit:
i have also updated the version in
http://musicbee.niblseed.com/V2_2/MusicBee_Exe_Patched.zip
Title: Re: A few wishes for TM functionality
Post by: redwing on October 30, 2013, 10:45:40 PM
Yes, both issues were fixed and now everything is working fine. Thanks a lot!

Quote from: Steven on October 30, 2013, 09:32:54 PM
for the background image, i have created a new element
<element type="BackgroundAlbumCover" brightness="0.2" refreshInterval="20"></element>

its basically the same as what you have done except its more optimised and picks a random location on the album cover. It always sizes to the panel size. Also the refreshInterval (seconds) will choose a new random location

This is working great and much better than the previous way. One suggestion: how about adding another option of constant, slow changing of the color when refeshInterval is set to zero? It then scans artwork in a certain way (like from center to any diagonal direction, which could be random too) as opposed to abrupt color changes at intervals with random moving of the location.
Title: Re: A few wishes for TM functionality
Post by: Steven on October 30, 2013, 10:55:31 PM
i did experiment with what you have suggested but i dont think i have enough time to make it work well. Perhaps i will revisit later in the v2.3 release
Title: Re: A few wishes for TM functionality
Post by: redwing on October 30, 2013, 10:57:51 PM
Quote from: Steven on October 30, 2013, 10:55:31 PM
i did experiment with what you have suggested but i dont think i have enough time to make it work well. Perhaps i will revisit later in the v2.3 release

No problem. Thanks for the implementation of all the new features! This means quite an improvement for TM functionality!
Title: Re: A few wishes for TM functionality
Post by: Steven on October 31, 2013, 06:47:56 PM
i made a tweak to the BackgroundAlbumCover to zoom in a bit less - could you confirm you are still happy with it. I think it works better with the tests i did
Title: Re: A few wishes for TM functionality
Post by: redwing on October 31, 2013, 06:53:08 PM
I didn't notice much differences, but it's working great. Thanks!
Title: Re: A few wishes for TM functionality
Post by: redwing on November 01, 2013, 06:12:21 PM
Quote from: Steven on October 31, 2013, 06:47:56 PM
i made a tweak to the BackgroundAlbumCover to zoom in a bit less - could you confirm you are still happy with it. I think it works better with the tests i did

I did some more tests, and I think it needs to zoom in a little more. It happens with album covers with faces; when eyes and lips are magnified, it looks a little freaky. Maybe zoom in more than x10,000?
Title: Re: A few wishes for TM functionality
Post by: Steven on November 01, 2013, 06:31:43 PM
how big is the compact player you are using and how big are your album covers usually?
Title: Re: A few wishes for TM functionality
Post by: redwing on November 01, 2013, 06:35:47 PM
Embedded TM in full size, not compact player. Album covers are usually 1000x1000 or bigger for pop collection.
Title: Re: A few wishes for TM functionality
Post by: Steven on November 01, 2013, 06:53:19 PM
and how big is the panel?
Title: Re: A few wishes for TM functionality
Post by: redwing on November 01, 2013, 06:56:46 PM
Have a look: http://i.imgur.com/8rIXuGj.png
Title: Re: A few wishes for TM functionality
Post by: Steven on November 01, 2013, 08:01:50 PM
this should double the zooming in your case - it adjusts for the panel and picture size:
http://www.mediafire.com/?1hvx31h4o3buhxz
Title: Re: A few wishes for TM functionality
Post by: redwing on November 01, 2013, 08:07:59 PM
Thanks! I'll try with such albums and let you know.
Title: Re: A few wishes for TM functionality
Post by: redwing on November 01, 2013, 09:15:12 PM
Still this kind of thing happens: http://i.imgur.com/iVbfmgZ.png
But given the varied size of faces on all kinds of albums, there can't be an ultimate solution for this unless always zooming in an extreme level, which would in turn make the background color dull and unimpressive. I would say this version overall works fine and the chances for seeing such a picture would be very low.
Title: Re: A few wishes for TM functionality
Post by: Steven on November 01, 2013, 10:10:41 PM
i've made it zoom a bit more (about 20%) but as you say its not going to work in all cases
http://www.mediafire.com/?1hvx31h4o3buhxz
Title: Re: A few wishes for TM functionality
Post by: redwing on November 01, 2013, 10:43:44 PM
It's working great with many such albums. Thanks!
Title: Re: A few wishes for TM functionality
Post by: Bee-liever on November 09, 2013, 04:10:53 AM
Quote from: Steven on October 30, 2013, 09:32:54 PM
for the background image, i have created a new element
<element type="BackgroundAlbumCover" brightness="0.2" refreshInterval="20"></element>

its basically the same as what you have done except its more optimised and picks a random location on the album cover. It always sizes to the panel size. Also the refreshInterval (seconds) will choose a new random location

Quote from: Steven on October 30, 2013, 10:55:31 PM
Perhaps i will revisit later in the v2.3 release

If you do revisit this, maybe blending the old too new background at the refresh interval so there is not an abrupt change, could be an option to look at.
Title: Re: A few wishes for TM functionality
Post by: endeavour1934 on January 01, 2014, 10:56:22 PM
Is there any way to add transparency to text? and to a image using code?
Title: Re: A few wishes for TM functionality
Post by: redwing on January 02, 2014, 04:50:32 AM
Quote from: endeavour1934 on January 01, 2014, 10:56:22 PM
Is there any way to add transparency to text? and to a image using code?

I don't think it's supported except some bg colors for some elements.
Title: Re: A few wishes for TM functionality
Post by: redwing on February 20, 2014, 12:09:00 PM
Quote from: Steven on October 28, 2013, 07:17:57 PM
i also added support for percentage values
e.g. heightDock="x:#Cover.70" would be 70% of the width of element #Cover

Regarding percentage values for anchor and dock, can you make it support numbers with one decimal place?
I am updating some TM views to work better in variable window sizes. But all different kinds of elements, fonts, and sizes make it hard for them to keep the same distance between each other in variable window sizes with the current precision of two-digit number. Of course, x and y number help, but they are fixed numbers. Would be great if percentages like 70.4 or 37.4 can be used.
Title: Re: A few wishes for TM functionality
Post by: Steven on February 20, 2014, 06:23:20 PM
thats supported with the next v2.3 update
Title: Re: A few wishes for TM functionality
Post by: redwing on February 20, 2014, 11:16:37 PM
It's working for dock, but not for anchors as in "yAnchor=Panel.85.3".
Title: Re: A few wishes for TM functionality
Post by: redwing on February 22, 2014, 01:48:08 PM
Thanks! Working great.