getmusicbee.com

Support => Developers' Area => Skins => Topic started by: hiccup on October 18, 2024, 06:53:14 AM

Title: add elements for 'Background.Left' and 'Background.Right'
Post by: hiccup on October 18, 2024, 06:53:14 AM

edit: added three more requests


I'm running into a small issue that I can't figure out how to solve.
For some skins it is nice to have specific images for the far left, and the far right of the player panel.
But currently there is only the single 'background.png'.

I've 'broken some rules' with this skin:
https://getmusicbee.com/forum/index.php?topic=42025.msg228944#msg228944
trying to have such panel corners.

(https://i.imgur.com/4vZb58T.png)
But that 'creative hack' creates two issues elsewhere in the skin that I can not solve.

1.
So the request is to add something like 'Background.Left' and 'Background.Right'.

edit
Adding a request for something that has been on my mind for many years, but never asked for:
2.
The option to add custom images.
Like: Image1, image2, etc.
This would be very helpful for adding some 'personality' to skins.
3.
And what would make things even sweater, is if these images could be clickable links to existing MusicBee shortcut functions.

4
And finally, the option to position the wavebar vertically would be good to have.
If I am not mistaken it currently always takes the center of 'Panel'.
 

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: Steven on October 20, 2024, 08:49:13 AM

for item 1
https://getmusicbee.com/patches/MusicBee36_Patched.zip

use

Code

	<element id="Panel">
		<images stretchY1="1" stretchY2="1"
				default="background.svg"
				/>
		<images category="Panel.Left"
				default="panelleft.svg"
				/>
		<images category="Panel.Right"
				default="panelright.svg"
				/>
	</element>

for 2 & 3, there is no flexibility in the skin creator tool to do that and I cant see myself rewriting it

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: hiccup on October 20, 2024, 09:59:07 AM

Quote from: Steven on October 20, 2024, 08:49:13 AM

for item 1
https://getmusicbee.com/patches/MusicBee36_Patched.zip

Thanks, but there are two issues:
1. skincreator doesn't find these images in the 'images' folder, but they need to be in the root folder of the skin
    (so skincreator probably needs an update for this too)
2. the images do not show up
    (but that may be caused by issue no.1)

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: Steven on October 20, 2024, 10:13:17 AM

just use "images\background.svg"
i did test this and works fine here

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: hiccup on October 20, 2024, 10:18:16 AM

Quote from: Steven on October 20, 2024, 10:13:17 AM

just use "images\background.svg"
i did test this and works fine here

So it doesn't work for png's?
Most skins will be using those, not svg's.

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: Steven on October 20, 2024, 10:27:27 AM

then use "images\background.png"
nothing has changed in regards to the image handling in the skin creator. All you need to do is add two images in the Panel element, one for the left and the other for the right panel

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: hiccup on October 20, 2024, 10:35:28 AM

Quote from: Steven on October 20, 2024, 10:27:27 AM

then use "images\background.png"
nothing has changed in regards to the image handling in the skin creator. All you need to do is add two images in the Panel element, one for the left and the other for the right panel

I am already using background.png
So the problem is not that the background image is in the 'images' folder and the left and right images are outside of it?
Then I must be doing something wrong.
I will try it again at a later point.

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: Steven on October 20, 2024, 10:41:47 AM

i must be missing something here because i am struggling to see why the difficultly.
Here is an example with .png and all images are in a sub-folder. You probably already do something similar for the TrackInfoPanel element

Code

<element id="Panel">
		<images stretchY1="1" stretchY2="1"
				default="images\background.png"
				/>
		<images category="Panel.Left"
				default="images\panelleft.png"
				/>
		<images category="Panel.Right"
				default="images\panelright.png"
				/>
	</element>

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: hiccup on October 20, 2024, 05:31:00 PM

The folder issue is fixed.
The problem was that I had the image files named PanelLeft and PanelRight, while your example (which I copy/pasted) has panelleft and panelright.

But, the borders still do not show.
I carefully checked what I might be doing wrong, but I don't see it.

I've PMed you the concerning skin. Perhaps you could take a look at it.
(the left border should show when 'Show Last.fm Scrobble Button' is disabled)

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: Steven on October 21, 2024, 08:34:53 AM

I believe its working - do you not see this? you need to be using the latest patched MB 3.6 version
(https://i.imgur.com/3urlSC1.jpeg)

or were you expecting the panels to adjust if the scrobble button is disabled?
(https://i.imgur.com/U3jQzSc.jpeg)
in which thats not how that feature works - it simply removes the button from display and doesnt adjust other elements location

Title: Re: add elements for 'Background.Left' and 'Background.Right'
Post by: hiccup on October 21, 2024, 07:37:46 PM

Quote from: Steven on October 21, 2024, 08:34:53 AM

I believe its working - do you not see this? you need to be using the latest patched MB 3.6 version

DOH!

No, the background border still didn't show.
After yesterday having downloaded the patch update twice to make sure I was using the updated version.

And then today I gave it a fresh try, re-downloaded the patch update, and then it suddenly worked.
Damn.
So what happened was probably that my browser had a previous version of the patch in its cache, and didn't refresh it with the new version somehow.
This caused quite some unnecessary confusion and a waste of time. Sorry for that.

Something to remember for a next time something like this happens.