getmusicbee.com

Support => Developers' Area => Skins => Topic started by: hiccup on October 12, 2015, 04:50:40 PM

Title: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 04:50:40 PM
Seems like a good idea to assemble those in a separate topic.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 04:56:29 PM
1. A grey border introduced
2. The bright green dividing line at the bottom is now practically invisible
3. The help button is gone. (this might be intentional?)

v3 top, v2.5 bottom:

(http://i.imgur.com/Mfdd8xqs.jpg) (http://i.imgur.com/Mfdd8xq.png)

also:

(http://i.imgur.com/QZ2YbRBs.jpg) (http://i.imgur.com/QZ2YbRB.png)

This is not v3 related since 2.5 also has it, but if it is possible maybe improve on the sliders and its buttons while at it:

(http://i.imgur.com/cPi3k3Vs.jpg) (http://i.imgur.com/cPi3k3V.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 04:57:38 PM
Sometimes, when switched to full-screen the top of the header bar is cut-off a couple of pixels:
(not always, not sure how to replicate)

(http://i.imgur.com/lq5fF4zl.jpg) (http://i.imgur.com/lq5fF4z.png)

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 04:58:16 PM
When decreasing the MB window size horizontally, the Windows close/minimise etc. buttons don't remain 'on top'.

(http://i.imgur.com/c0C4ThLl.jpg) (http://i.imgur.com/c0C4ThL.png)

edit:
Probably better ignore this report for now.
I just saw this happens with my 2.5 version, v3 does this correctly.

Let me know if you want me to move this error to the bug report topic.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 04:59:10 PM
When I tried to shrink the MB panel by selecting and dragging a corner (to probably it's minimum) I got this:

(http://i.imgur.com/cfiqmMXs.jpg) (http://i.imgur.com/cfiqmMX.png)

Code
MusicBee v3.0.5763.12829 (Win10.0), 12 okt 2015 12:42:

System.ArgumentException: Rectangle '{X=236,Y=7,Width=0,Height=21}' cannot have a width or height equal to 0.
   at System.Drawing.Drawing2D.LinearGradientBrush..ctor(Rectangle rect, Color color1, Color color2, LinearGradientMode linearGradientMode)
   at #=qxEOP5jCIHc_uAnRVC0FoD9dsh3hSvoYj6419yULmt0w=.#=qX34wVewiWBqDYaWGpld6pg==(Graphics #=q2ygz1k5$227gpn2R6xXuaw==, Rectangle #=qRSbWTic0rvIPpas6aSe0HQ==)
   at MusicBee.MusicBeeMain.NavigationHeader.#=qpuyLUFDpZWBv9wrry$pnS7zrIxbMFG7jzZMil$Gu2EI=._Lambda$__0(Graphics #=q0ljqs42GzLQg2f8JB2Z8wQ==)
   at MusicBee.MusicBeeMain.NavigationHeader.#=qPiMgOEw8OMZkdihQ3jK7CQ==(PaintEventArgs #=qCBPoCZcv6U_5hOSYlTmJwg==)
   at MusicBee.MusicBeeMain.#=qUklv1I5f5QWCP6VFJYkw3YfOWpC5_Nbt1RE1_0pFV_c=._Lambda$__0(Graphics #=qlQtnBogZF0SBHuR8$kqKlg==)
   at #=qRsKdy3wfp_ebwfKRXeRV0Q==.#=q9OaIVBQ3qLyVdE_EmuNx0w==.#=qMH627WyiNncGTnXOcIsoxw==(Graphics #=qyDvNTa1TdktBhORRE0dY7A==, #=qmBEF3g6FMFrWYJ5QFbNn$KCePXquW$OJKBQpHUJ6zHY= #=qfVGlrhktYjEJzrlzDUt8Tw==, Rectangle #=qhXPrIOKyg82KZVQRbmpJBw==, Rectangle #=qxF_jl6hRRarBFatzfFfRaw==)
   at MusicBee.MusicBeeMain.OnPaint(PaintEventArgs #=qxWbw3rPJiOewbEmWOqHZDQ==)
   at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
   at System.Windows.Forms.Control.WmPaint(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.Form.WndProc(Message& m)
   at #=qNCiYcBakDQcFgDf6CqARg2LStbaK7WA8eJL1UADtvx8=.WndProc(Message& #=qCIgb6LmWjqPx7KVjH3Utjw==)
   at MusicBee.MusicBeeMain.WndProc(Message& #=qSB3Slp8o8AVbkYHFdJbc7w==)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 05:01:36 PM
I noticed you started addressing some skinning issues in the latest update.

The issue with TrackInfoLeft and TrackInfoRight is still there.
When opening MB, the right one sometimes displays, but the left one doesn't, and both disappear when re-sizing.

Bee-lievers Bee78 skin shows this most clearly.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 05:15:54 PM
Different element coloring in Tag Editor:

(http://i.imgur.com/XaoBbVDl.jpg) (http://i.imgur.com/XaoBbVD.png)

(similar when as a floating panel)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 05:16:21 PM
I also noticed the custom tag fields in tag inspector are greyed out. This is not or hardly noticeable with the default skin, but clearly in some others, such as Sportura Pinstripe:

(http://i.imgur.com/eOKclkVs.jpg) (http://i.imgur.com/eOKclkV.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on October 12, 2015, 05:18:01 PM
On my system, when I drag the corner of the compact player to enlarge it, I get lots of 'funny looking' borders and resize arrows. But they also disappear as soon as I release the mouse button.

(http://i.imgur.com/dq7Vcdwl.jpg) (http://i.imgur.com/dq7Vcdw.png)

One observation:
When I disable: Windows' Visual Effects > 'Show shadows under windows', there are no borders looking like curtains, but the grow/shrink cursor arrow still leaves a trail as described. (mouse 'cursor shadow' and 'cursor trails' are disabled)
Maybe it's something with my a bit older graphics card. (Ati Radeon HD4xxx)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on October 12, 2015, 07:36:31 PM
When I tried to shrink the MB panel by selecting and dragging a corner (to probably it's minimum) I got this:
i cant reproduce this but if you can, please send me your settings file
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on October 12, 2015, 07:38:32 PM
When decreasing the MB window size horizontally, the Windows close/minimise etc. buttons don't remain 'on top'.
it should be resizing the tabs are the application window narrows but it works fine for me. Same as before - please send the settings file if you can reproduce this
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on October 12, 2015, 09:25:08 PM
the resizing bug is fixed for the next update. Just FYI, if you want the library explorer to fill the entire panel height, just dock it in the left main panel and hide the left sidebar.
Also if i feel i have enough time i might change it so panels can be dragged into the header bar rather than stopping at just below
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: mless on October 26, 2015, 12:49:36 AM
When using most skins the auto-hide left sidebar does not appear when I move my cursor on the left of the screen. (ie: DarkRED Flat, iBee, AeroBee, etc.). When using MusicBee Classic or MusicBee 3 it works fine.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 01, 2015, 10:09:08 AM
its still probably a couple of weeks before i will focus on skinning, bur i want to put it out there now re: thoughts on how skinning should be changed because of the flexible way panels can be configured eg. before you might use a range of colors for the left sidebar because you could be sure the left navigator and library explorer could only be docked in the left sidebar and there was no "left main panel". Now many new elements can be docked in various panels.
My thoughts are simply to have an optional default that applies to any element docked in a panel (left sidebar, left-main panel, main panel, right-main panel etc) but to allow an override color scheme for each element as well. There would still be view specific settings for track details, artwork for the main panel as now.
I know some of you want a tab based layout for when elements are overlayed. I will probably make that available as a musicbee setting rather than a skin setting
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 01, 2015, 11:17:33 AM
My thoughts are simply to have an optional default that applies to any element docked in a panel (left sidebar, left-main panel, main panel, right-main panel etc) but to allow an override color scheme for each element as well. There would still be view specific settings for track details, artwork for the main panel as now.

I think the override option would be a good way to go.

I've had a look at the MusicBee3.xml, and armed with a few new elements I found there, I've taken skin of mine that doesn't work to well in MB3 and fixed it up.

Here (http://www.mediafire.com/download/4y3f8lb77z2ofox/B78_3.0.zip) is a link to B78_3.0Demo if anybody want's to try it out.

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 01, 2015, 01:44:58 PM
its still probably a couple of weeks before i will focus on skinning

I was wondering if there will be a new default icon set with the final v3.0, perhaps based on endeavor's concept?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 01, 2015, 05:32:32 PM
I was wondering if there will be a new default icon set with the final v3.0, perhaps based on endeavor's concept?

I suggested the same ( http://getmusicbee.com/forum/index.php?topic=16607.0 ) but got zero responses, so there doesn't seem to be much interest/support for this idea.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 01, 2015, 05:50:51 PM
- My thoughts are simply to have an optional default that applies to any element docked in a panel (left sidebar, left-main panel, main panel, right-main panel etc) but to allow an override color scheme for each element as well.

- I know some of you want a tab based layout for when elements are overlayed. I will probably make that available as a musicbee setting rather than a skin setting

A bit difficult to imagine well beforehand, but this seems like a good approach to me. I hope you can also put in the effort to explain through comments (as you usually do) in the xml which element might be overruled by what other element. Those comments are very useful.
Also hopefully for v3 we can start off with an as cleaned-up and complete xml as possible.

And +1000 for optionally showing tabs in the side panels. I really don't want to loose those.

And a thought: have you considered making it possible to set specific fonts by means of skinning?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 02, 2015, 09:10:41 PM
not being skinned in 3.0
(http://i.imgur.com/st1kxg4.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 03, 2015, 05:59:53 AM
I hope it's not too early, but I have a list of bugs/requests related to skinning;

(tabs bar) element id="TabsBar.TabInCaptionBarTop.Highlight" -- the foreground element is not taking effect.

(images) element id="PanelNewTab" -- code exists but not currently enabled.

element id="PlaylistManagerIcon" -- both new nodes require icon overrides.
element id="MusicExplorerIcon"

-- Support for fill/empty images for the volume level meter.
-- An option for square corners on tabs instead of round.
-- An override for the search icon in the search bar.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 04, 2015, 02:33:17 PM
A couple more bugs I came across;

(images) element id="FormCloseHighlightButton" -- there is a glitch associated with this element, when highlighted the image is partially distorted (I think it's being reduced in height). I tested this by using the exact same image as with "FormCloseButton".

(images) element id="TabsBar.TabInCaptionBar.Highlight" -- same issue as mentioned in my previous post.

With the tabs bar located below the caption bar there is a 1px gap directly underneath and to the left of the tabs bar.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 04, 2015, 08:40:05 PM
some of the bitmap skins are not being rendered quite right

Dark Matter Energy 2.5
(http://i.imgur.com/qZi7MBX.jpg) (http://imgur.com/qZi7MBX)

Dark Matter Energy 3.0
(http://i.imgur.com/6kt5nBk.jpg) (http://imgur.com/6kt5nBk)

Faded is another skin that has a similar problem
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 04, 2015, 09:39:03 PM
some of the bitmap skins are not being rendered quite right
the darkmatter skin i just downloaded from issac looks nothing like this, so can you confirm the skin name?
 and i dont see any obvious problems with the faded skin
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 04, 2015, 09:51:36 PM
Oops! Dark Energy not Dark Matter (knew it had Dark in it  ;D  )

EDIT:
and Faded has the same problem as in the screenshot. Bottom few pixels of the TrackInfo image is being cut off.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 07, 2015, 07:22:14 AM
re: thoughts on how skinning should be changed...
I know some of you want a tab based layout for when elements are overlayed.

for cohesion of the new design, could the tabs for overlayed elements and also in the tag editor be of the same design as the new tab bar?
and on option to have a icon and/or caption in the tab, as per endeavour1934's original mock-up, please,
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 15, 2015, 06:54:08 PM
some of the bitmap skins are not being rendered quite right
that should be fixed in the latest update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 15, 2015, 09:31:51 PM
some of the bitmap skins are not being rendered quite right
that should be fixed in the latest update

Not quite the same as in v2.5 but closer.
Unfortunately, the changes have caused errors with the placement of the progress bar in other skins (eg. Graffiti and Supernova)  :(
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 15, 2015, 10:30:54 PM
the v2.5 layout engine has some incorrect behavior which i guess some skins have worked around eg. v2.5 stretches images 2px higher than it should.
If its just those 2 skins then i am not prepared to spend time trying to accomodate the issues. If the issue is more wide spread then i guess i will need to but i would rather not as it will likely just cause problems elsewhere
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 15, 2015, 11:23:23 PM
There is a glitch when maximizing MusicBee with the tabs located in the caption bar, the top of the window appears to be cut off and a 1px colored border appears on top of the tabs.

To follow up a previous post, it seems that all of the titlebar buttons (minimise/maximise/close) have a mouseover effect. Is that intentional?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 16, 2015, 01:09:08 AM
the v2.5 layout engine has some incorrect behavior which i guess some skins have worked around eg. v2.5 stretches images 2px higher than it should.

Since 3.0 is going to fix that behaviour (I assume) then trying to retrofit the older skins to the new version is, IMHO, a bad idea.
As long as we're kept informed of erroneous behavior, it should be up the skin creators to maintain their skins for future releases.

BTW - Windows 10 version 1511 has introduced the coloured title bar, but it works the same way as the coloured 1px border. It's sourced as a highlight colour from the desktop picture.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 06:57:27 AM
There is a glitch when maximizing MusicBee with the tabs located in the caption bar, the top of the window appears to be cut off and a 1px colored border appears on top of the tabs.
that should have been addressed in the latest builds - is it still the case using the latest version?
edit:
just to be clear i am refering to the 1px line. The tabs will display using all the available height

To follow up a previous post, it seems that all of the titlebar buttons (minimise/maximise/close) have a mouseover effect. Is that intentional?
The buttons always have had a mouseover effect and why wouldnt you want that?
If you are refering to clicking on a skinned and maximised window caption bar, and showing the old windows 2000 buttons then that should have been addressed last week
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 11:13:05 AM
that should have been addressed in the latest builds - is it still the case using the latest version?
edit:
just to be clear i am refering to the 1px line. The tabs will display using all the available height

I'm running build 5794 (I think that's the most recent), here's a couple screenshots to show how the window looks when maximized.

(http://i.imgur.com/x3iZOj8s.jpg) (http://i.imgur.com/x3iZOj8.jpg) (http://i.imgur.com/0mnXZhSs.jpg) (http://i.imgur.com/0mnXZhS.jpg)


The buttons always have had a mouseover effect and why wouldnt you want that?
If you are refering to clicking on a skinned and maximised window caption bar, and showing the old windows 2000 buttons then that should have been addressed last week

These screenshots might help explain, the second image shows the mouseover effect. In my case the "highlight" element is exactly the same as the "default" element, but a closer look shows they don't match exactly.

(http://i.imgur.com/S2BDZ3k.jpg) (http://i.imgur.com/S2BDZ3k.jpg) (http://i.imgur.com/SEoSTWz.jpg) (http://i.imgur.com/SEoSTWz.jpg)


This is another small bug, where the tickbox image is not always centered properly for some reason.

(http://i.imgur.com/TWl4ICr.jpg) (http://i.imgur.com/TWl4ICr.jpg) (http://i.imgur.com/IPhOwjG.jpg) (http://i.imgur.com/IPhOwjG.jpg)

I was wondering if you could help with this glitch, I probably made a mistake in skin.xml but I'm not sure how to solve it.
Sometimes when I collapse the main window the progress bar extends too far to the right, although minimizing the app and restoring it refreshes the interface and it appears normal again.

(http://i.imgur.com/wy8imNYs.jpg) (http://i.imgur.com/wy8imNY.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 05:45:40 PM
I was wondering if you could help with this glitch, I probably made a mistake in skin.xml but I'm not sure how to solve it.
Sometimes when I collapse the main window the progress bar extends too far to the right, although minimizing the app and restoring it refreshes the interface and it appears normal again.
i have seen that myself with  the standard skins and thought it was fixed. Is the skin posted on the forum the one you are testing this problem with?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 05:54:48 PM
i have seen that myself with  the standard skins and thought it was fixed. Is the skin posted on the forum the one you are testing this problem with?

Yeah, it's this one: http://getmusicbee.com/forum/index.php?topic=16808.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 06:01:27 PM
Sometimes when I collapse the main window ...
can you explain that some more
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 06:09:11 PM
can you explain that some more

If the main window is maximized and then changed to windowed mode, after that is when see it, but it doesn't happen every time.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 06:25:44 PM
These screenshots might help explain, the second image shows the mouseover effect. In my case the "highlight" element is exactly the same as the "default" element, but a closer look shows they don't match exactly.
the reason is because you are using 16px height, but it needs to be 15px.

for the resizing of the progress bar, i cant reproduce. Would you mind sending me your latest settings again?

for the window maximised, the panel layout icon should be 28x20. However i will drop the controls down 1px when maximised
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 06:34:23 PM
the reason is because you are using 16px height, but it needs to be 15px.

Oh ok, I didn't know that.

for the resizing of the progress bar, i cant reproduce. Would you mind sending me your latest settings again?

Sent it to you.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 06:42:18 PM
i still cant reproduce any issue. You can trigger it by only toggling the maximised state by clicking the maximise/ restore button?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 06:44:23 PM
i still cant reproduce any issue. You can trigger it by only toggling the maximised state by clicking the maximise/ restore button?

Yep, but I've also had a hard time reproducing it.

By the way I just noticed something strange. I switched to the mini player and then back to the main player, and this is what I see:

(http://i.imgur.com/FJyCKHtl.jpg) (http://i.imgur.com/FJyCKHt.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 07:24:27 PM
i still cant reproduce any issue. You can trigger it by only toggling the maximised state by clicking the maximise/ restore button?
Yep, but I've also had a hard time reproducing it.
do you think the size of the progress bar is what it used to be ie, what it was when the window is maximised?
If will put in some more error checking as i suspect the code is failed before doing the resize of the progress bar. If what i say is true, the star rating panel would also not have been resized
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 07:31:28 PM
do you think the size of the progress bar is what it used to be ie, what it was when the window is maximised?
If will put in some more error checking as i suspect the code is failed before doing the resize of the progress bar. If what i say is true, the star rating panel would also not have been resized

I don't think so, the progress bar seems to be at different lengths each time it happens.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 07:41:28 PM
fixed for most of the issues reported by Alumni
http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip

for the progess bar, i dont have any more ideas and cant reproduce. It would be useful to know if it happened recently with any non-bitmap skins
also see my comment about the panel layout button size in case you missed it
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 16, 2015, 07:52:51 PM
Still some minor corruption at the top:

(http://i.imgur.com/tKzqgD7l.jpg) (http://i.imgur.com/tKzqgD7.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 07:57:40 PM
Still some minor corruption at the top:
i dont think i will be able to address that without losing the window shadow effect. I guess its only noticable on windows 10 because of the strong border colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 08:04:05 PM
@Alumni, redownload the same link as i found one thing that might cause the progress bar display issue
,
@hiccup, does it only happen after certain actions?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 08:08:02 PM
fixed for most of the issues reported by Alumni
http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip

for the progess bar, i dont have any more ideas and cant reproduce. It would be useful to know if it happened recently with any non-bitmap skins
also see my comment about the panel layout button size in case you missed it

Thanks for the fixes. Everything's sorted now except for that progress bar issue.
I'm almost certain it is related to bitmaps, I used the default skin up until recently without problems.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 16, 2015, 08:17:13 PM
@Alumni, redownload the same link as i found one thing that might cause the progress bar display issue

I was just about to say that patch fixed it, but after many tries it did pop up again.

Edit: I found a way to reproduce it with a better success rate.
When playing a song fast forward the progress to nearly the end of that track and then toggle the maximize/windowed modes.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 16, 2015, 08:25:10 PM
@hiccup, does it only happen after certain actions?

Win 10 indeed.
A Sophisticated Bee (at Night) skin.
It happens when switching from mini to full.
The 'shadow' sometimes changes color/brightness after having another windows panel full-screen covering MB, and then putting MB on top again.
Also a 'ghost' border after having selected 'search' before:

(http://i.imgur.com/4b09Mykl.jpg) (http://i.imgur.com/4b09Myk.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 16, 2015, 08:33:15 PM
version 3.0.5798.36030

I found that the progress bar fill image in the bitmap skins, is being truncated on the right.
Maybe this has something to do with the progress bar issue?


IMAGES REMOVED

EDIT:
Just read this

Edit: I found a way to reproduce it with a better success rate.
When playing a song fast forward the progress to nearly the end of that track and then toggle the maximize/windowed modes.

Maybe the progress bar fill is not being truncated, maybe it's a couple of pixels to the left?

Disregard this. Made some adjustments with the skin creator that allows the progress bar to work as expected in 2.5 and 3.0.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 16, 2015, 10:20:08 PM
Edit: I found a way to reproduce it with a better success rate.
When playing a song fast forward the progress to nearly the end of that track and then toggle the maximize/windowed modes.
yes i can reproduce this now. I sought of know whats going wrong but dont know how to fix it

edit:
its fixed now - same download link
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 17, 2015, 01:54:28 PM
its fixed now - same download link

Great, thanks for your efforts!

A quick question about the MusicBee 3 default skin, I was wondering why some lines of code repeats itself, for example:

Code
\\ --- PREFERENCES ---> SCROLLBARS
<!-- 124-->  <element id="Controls.ScrollBar.Default" bg="245,245,245" bg2="200,200,200" />
<!-- 125-->  <element id="Controls.ScrollBarThumb.Default" bg="245,245,245" bg2="200,200,200" fg="100,100,100" bdr="255,255,255" />
<!-- 126-->  <element id="Controls.ScrollBarBackground.Default" bg="215,215,215" bg2="255,255,255" />
  <element id="Controls.ScrollBar.Default" bg="200,200,200" bg2="180,180,180" />
  <element id="Controls.ScrollBarThumb.Default" bg="230,230,230" bg2="250,250,250" fg="180,180,180" bdr="0,0,0,0" />
  <element id="Controls.ScrollBarBackground.Default" bg="245,245,245" bg2="250,250,250" />

Code
\\MENUS
\\ --- PREFERENCES
<!-- 105-->  <element id="Controls.VerticalMenu.Highlight" bg="253,215,99" fg="60,60,60" />
<!-- 106-->  <element id="Controls.VerticalMenu.Lowlight" bg="253,215,99" fg="60,60,60" />
  <element id="Controls.VerticalMenu.Highlight" bg="160,160,160" fg="255,255,255" />
  <element id="Controls.VerticalMenu.Lowlight" bg="160,160,160" fg="240,240,240" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 17, 2015, 05:55:24 PM
no good reason - just me experimenting with different things and leaving the older attempt in
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 17, 2015, 06:18:09 PM
Well there be a complete list of functioning skin elements for 3.0 released?  Is the list in the MusicBee 3 skin complete?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 17, 2015, 06:24:43 PM
i still havent started creating the final list of new skin elements.
First i will do the 1px border (I am determined to get something working with that!), then there are still outstanding bugs reported above for the visual effects and then finally i will so the skin elements
I would say as long as no further problems with the 1px border (I have a hacky solution), i should start the skin elements on sunday
For the list of elements already done, somehow i have managed to misplace the list for the new and the removed elements
I think i was adding them to the top of the MusicBee3 skin so the new ones should be easy to figure out. For the removed ones, its most around the tab handling
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 18, 2015, 12:21:12 AM
Awesome!  I can be patient.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 18, 2015, 01:31:18 AM
I think i was adding them to the top of the MusicBee3 skin so the new ones should be easy to figure out.

Sounds good, that'll certainly make it easier for me.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 18, 2015, 10:48:47 PM
just an update on what i will probably do for the windows 10 look for a 1px border
for non-skinned borders:
- i finally found a good solution for doing the non-skinned borders that should completely conform to whatever accent border color/ or glass borders windows has been set to. That includes enabling resizing outside the window frame

- for skinned borders, its not really an option to do the reizing cursor inside the window frame as i was initially going to do. Thats because the auto-open left and right sidebar panels also use that area.
So the options are:
  - use the same solution as for unskinned border so there will be a 1px accent color around the edge (no good for most skins in my opinion) and even worse, when glass is enabled it would effectively not be skinned at all
  - use a hacky solution i have come up which allows full control by MB for how the window frame is rendered and allows resizing outside the window frame. So visually this would be the ideal solution but one downside is it slows the rendering down quite a bit when resizing and also involves me putting in special code in various places, so i am not so keen on this
  - just have a 1px resizing border (no good as it makes resizing difficult)
  - dont have a windows 10 look ie. just leave the 4px border as now

does anyone have any comment on this? At the moment i am leaning towards the last option for skinned borders

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 18, 2015, 11:27:16 PM
While I really detested the 1 pixel area that MB used to have in the past where you were allowed to grasp a panel to resize it, I think I wouldn't mind it so much if that was the case for the surrounding outside pane. Personally I don't use re-sizing the whole MB window by mouse dragging that often. So a 1px border would be o.k. by me.

Your 'hacky solution' sounds very interesting and maybe ideal for us mortal end-users, but considering how many growing pains Windows 10 seems to be experiencing, and having no certainty whatsoever about what MS might change next, it's probably not wise to invest much time and effort in such a solution at this moment. (unless you are willing to take that risk of course)

Conforming to 'a Windows 10 look' as a purpose would not be an important entry in my agenda.
I find the trend were many website and software developers are trying to use the same fonts, color schemes, icons, interfaces etc. quite unimaginative and boring to be honest.
Somebody once said: "dare to be different", and the next thing you know, everybody is trying to be different in the same way.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 19, 2015, 12:23:27 AM
 - use the same solution as for unskinned border so there will be a 1px accent color around the edge
1st choice
After using Windows 10 for a while, you tend not to notice the 1px highlight colour - only when it's missing: ie, when the window loses its focus and the border turns to grey.

 - dont have a windows 10 look ie. just leave the 4px border as now
2nd choice
but the 1px top border in compact player, that currently takes its colour from the windows header, would need to be fixed.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 19, 2015, 08:11:42 AM
i think what i will do for skinned borders is leave the default as now ie. 4px border but allow a skin override where you can say to use the windows 1px borders (not caption bar) as described in the first point. There are quite a few skins, especially the dark ones where the 4px border blends into the main panels so you dont even see a border.

but the 1px top border in compact player, that currently takes its colour from the windows header, would need to be fixed.
can you explain that some more?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 19, 2015, 09:19:26 AM
but the 1px top border in compact player, that currently takes its colour from the windows header, would need to be fixed.
can you explain that some more?

automatically selected accent colour on title bar
(http://i.imgur.com/Le9oSDj.jpg) (http://imgur.com/Le9oSDj)

same colour on top edge of compact player when it has focus
(http://i.imgur.com/YzG2EQ4.jpg) (http://imgur.com/YzG2EQ4)

and don't know if this is linked to using that title bar edge,  but occasionally get this error in compact player mode.

Code
19/11/2015 19:53:50 - 10.0.10586.0 - 3.0.5798.40648 - System.InvalidOperationException: Object is currently in use elsewhere.
   at System.Drawing.Graphics.CheckErrorStatus(Int32 status)
   at System.Drawing.Graphics.DrawImage(Image image, Int32 x, Int32 y)
   at System.Drawing.Graphics.DrawImage(Image image, Point point)
   at #=qC6rtIQpg_gaHAiRAozgL52$wE8vSt2sD$KNGIEV0BFs=.#=qITMGYCscnT$9_huMastspA==(Graphics #=q4KbX0YmnSPyULXqo14OixA==)
   at MusicBee.MusicBeeMain.#=q7z3RakNSUwtjm3sCwgInIA==.#=qtYrQpzOnfXzfROvcblsh8VoZM3eOmrs2RcOh_6Pf6D4=.#=qu2h0WJWJmULh6BCX6$zKfA==(PaintEventArgs #=qCc8Aw957z2dn_fF7Asta_g==)
   at MusicBee.MusicBeeMain.#=q7z3RakNSUwtjm3sCwgInIA==.#=qNwu68prOpKOwJEqXmbSQ02hXOkT4ddmQxe428qeS$6Y=(Object #=qBqWwZZLKT56TVwGA2$XQ1Q==, PaintEventArgs #=qpAO23tPyVAy7kvXm5F0EEw==)
   at System.Windows.Forms.Control.OnPaint(PaintEventArgs e)
   at #=ql8XViFYHQcTpK$2JkjETyBcHic$pzFOHWNipRHwYWQg=.#=q1ZIaB1D6jKBBZamlJDT5H80$iIb1M$dYjMYv1nq1qsI=(PaintEventArgs #=qCc8Aw957z2dn_fF7Asta_g==)
   at #=ql8XViFYHQcTpK$2JkjETyBcHic$pzFOHWNipRHwYWQg=.#=q8_TwPthCI3eafxApmnNdLj4Zoyg0WwYRxD2FOiiyhLo=._Lambda$__0(Graphics #=qVxINKg5wA5UBogzbgbRclg==)
   at #=qWKT6em25jUtEnFt5496whg==.#=q7gMl_ulI$I3w21Ur$AEDZA==.#=qOKunxVghfrJvv1lULlTKBQ==(Graphics #=qnYWARSPalCluY7aIvJIApw==, #=qKraHOboaCD996iyw3epfQ22c6d5uu_20V2Luwbhs4j4= #=qNYoS7atLzRzzuKkPtFwl1A==, Rectangle #=qpETwlaSZGEu_RGQcSHe_8Q==, Rectangle #=q2yZnlKBZVdWEPJ2zfL2HHA==)
   at #=ql8XViFYHQcTpK$2JkjETyBcHic$pzFOHWNipRHwYWQg=.OnPaint(PaintEventArgs #=qpTfZQdFoRViYJearsL82Lw==)
   at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer)
   at System.Windows.Forms.Control.WmPaint(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

all images and player controls are lost
right-clicking task bar icon> Switch to Main Player
fixes it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 19, 2015, 06:17:14 PM
and don't know if this is linked to using that title bar edge,  but occasionally get this error in compact player mode.
the error could be one of two things. Does it happen when a song starts/ ends or some action such as resizing? or is it completely random?
edit:
nevermind - its probably fixed for the next update, although i cant be completely sure
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 19, 2015, 08:31:18 PM
Still some minor corruption at the top:
that should be fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 21, 2015, 01:45:00 PM
http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip

for windows 10, i have changed the border handling so its now a single px border for skinned borders. For unskinned borders, the 8px opaque border now renders as a normal 1px border
I plan to look at the remaining skin issues reported above and then i will look at adding new skinning elements
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 22, 2015, 12:18:58 AM
for windows 10, i have changed the border handling so its now a single px border for skinned borders.

with the new border handling, which looks really good BTW, you need to move the buttons to the left a few px.

Faded skin shows why clearly.  Images are 28x15px as per specs.

2.5
(http://i.imgur.com/fR5C3y2.jpg)

3.0
(http://i.imgur.com/Ec8A26y.jpg)



I plan to look at the remaining skin issues reported above and then i will look at adding new skinning elements

not sure if element id="MainPanelMargin.Right and .Left not working on the header panel has been reported yet.
If it has, please disregard this extra bit
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 22, 2015, 09:28:48 PM
i have made a first pass through the reported issues. There are a lot reported so its possible i might have missed something.
I realise there are still some things that need addressing such as the new default icon for some skins.
I will also revisit the player custom bitmap skin not rendering to the same height as v2.5, although i think it is v2.5 thats wrong. But i will have a look and see if it makes sense to build in backward compatibility without risking causing new issues
Also I will look at adding support for tabs (as a MB option) for when panels are stacked

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 22, 2015, 10:15:51 PM
I will also revisit the player custom bitmap skin not rendering to the same height as v2.5, although i think it is v2.5 thats wrong. But i will have a look and see if it makes sense to build in backward compatibility without risking causing new issues

(http://www.freesmileys.org/smileys/smiley-sick004.gif) (http://www.freesmileys.org/smileys.php) and here I've been going through my bitmap skins and adjusting them for 3.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 22, 2015, 10:27:00 PM
as i mentioned earlier, i really dont want to change things but it was quite obvious testing against your faded skin that there is an issue.
If you have already made the changes then i will take that no further - plenty of other things to do!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 22, 2015, 10:42:11 PM
If you have already made the changes then i will take that no further - plenty of other things to do!

glad I could be of some small assistance in reducing the "to do" list  ;)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 23, 2015, 03:29:21 AM
In the default skin, there's a white bit at the top right (you may need to view the image on a dark background to see it):

(http://i.imgur.com/N3qhZZw.png) (http://imgur.com/N3qhZZw)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 23, 2015, 08:01:34 AM
(http://www.freesmileys.org/smileys/smiley-sick004.gif) (http://www.freesmileys.org/smileys.php) and here I've been going through my bitmap skins and adjusting them for 3.0

@Bee-liever,
I will also be looking to adjust and update my old (jistme) skins for v3.
Since you are already experienced in that area, could you please give the details where I should be looking exactly to make adjustments to the skin files and/or images to do that too?
Is the (by now very old) skincreator tool still of any use for that, or should that not be used at all for v3?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 23, 2015, 09:29:22 AM
In the default skin, there's a white bit at the top right (you may need to view the image on a dark background to see it):
there should not be any margin in the right at all when maximised, so it appears that MB is maximising correctly. To help diagnose that further can you temporarily move the tabs below the caption bar and include the search box in another screenshot?

edit:
dont worry - its fixed now
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 23, 2015, 10:28:57 AM
In the default skin, there's a white bit at the top right (you may need to view the image on a dark background to see it):
there should not be any margin in the right at all when maximised, so it appears that MB is maximising correctly.

It's 1px in the RH border when MB is maximised. 6px up from the bottom of the caption bar.
I have also experienced the whole caption bar being light blue (the colour 9ido keeps getting in the search box) when the default MB3 skin is first maximised.  Can't get it to consistently repeat though.

I will also be looking to adjust and update my old (jistme) skins for v3.
Since you are already experienced in that area, could you please give the details where I should be looking exactly to make adjustments to the skin files and/or images to do that too?
Is the (by now very old) skincreator tool still of any use for that, or should that not be used at all for v3?

Wouldn't say I was experienced, still early in the 'trial and error' stage.
The SkinCreator tool is fine to use, it was the 2.x exe that was overstretching the bitmap header by 2px.
Most skins you won't see a difference in. I found it's been the ones that have elements outside the TrackInfo area and/or items aligned to the bottom of it.

Just check out your skins in MB3 and if you notice any anomalies, check those elements first.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 23, 2015, 11:25:05 AM
The SkinCreator tool is fine to use, it was the 2.x exe that was overstretching the bitmap header by 2px.
Most skins you won't see a difference in. I found it's been the ones that have elements outside the TrackInfo area and/or items aligned to the bottom of it. Just check out your skins in MB3 and if you notice any anomalies, check those elements first.

thnx
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 23, 2015, 05:57:00 PM
The bottom tab divider is obscured for the selected entry:
 
(http://i.imgur.com/akTv8BEl.jpg) (http://i.imgur.com/akTv8BE.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 24, 2015, 09:42:41 AM
version 3.0.5805.39458

the windows buttons are back 1px too close to the RH edge, but highlight images are in the correct position (1px to the left)

(http://i.imgur.com/Cu0MWJT.jpg)

the bg colour of <element id="Player.Wavebar"/> is not being used in 3.0

with Windows 10, the top 1px edge in the compact player doesn't change colour when MB loses focus
(this isn't a biggie in the grand scheme of things, but I thought I should note it, just in case it's linked to something else)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 24, 2015, 02:24:44 PM
I am trying to get my Tron Punk skin pixel perfect for v3, but I am getting a little bit frustrated (again) since the outcome is not as I expect.

I have a track info element that is 43 pixels high.
Even with the smallest possible font for the player chosen, in MusicBee v3 it gets stretched to 45 pixels high.
How can that be? Is there something wrong with my skin.xml? :

Code
<?xml version="1.0" encoding="utf-8"?>
<!-- the "parent" attribute is used when pre-rendering elements that have the alpha colour channel set
     eg. parent="TrackInfoPanel" will pre-render the element using the track info panel colours -->
<!-- each images node can have up to 3 images - 1. default (required) 2. highlight (mouseover) 3. disabled.
     If highlight or disabled are not provided, the default image is used -->
<!-- for some elements, multiple sets of images are required, split into categories eg. the track info panel
     requires left, middle and right side images -->
<!-- MusicBee can resize the player panel depending on the font used, and whether 'enlarge progress bar' is enabled
     and as such MusicBee stretches certain images (panel background, track info panel, progress bar).
  The StetchY1 and StretchY2 attributes tell MusicBee which part of the image can be stretched
  eg. usually you want the border area of an image to remain "sharp" and not be stretched
eg. StretchY1="4" StretchY2="2" means stretch the area starting from 4px and height-2 of the image -->

<root sourceSkin="Tron Punk 3">
<element id="Panel">
  <images stretchY1="2" stretchY2="2"
    default="Images\Background.png"
  />
</element>

<element id="PrevTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-116" />
  <top relativeTo="Panel.Bottom" offset="-26" />
  <!-- musicbee draws the |<< icon in the centre of this image. The colours for the musicbee drawn icon are determined from the skin file -->
  <images drawPlayButton="false"
    default="Images\Previous.png"
    highlight="Images\PreviousHighlight.png"
disabled="Images\PreviousDisabled.png"
  />
</element>

<element id="PlayPauseButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-95" />
  <top relativeTo="Panel.Bottom" offset="-50" />
  <!-- musicbee draws the > or || icon in the centre of this image if drawPlayButton="True" -->
  <images category="Play" drawPlayButton="false"
    default="Images\Play.png"
    highlight="Images\PlayHighlight.png"
  />
  <images category="Pause" drawPlayButton="false"
    default="Images\Pause.png"
    highlight="Images\PauseHighlight.png"
  />
</element>

<element id="NextTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-46" />
  <top relativeTo="Panel.Bottom" offset="-26" />
  <!-- musicbee draws the >>| icon in the centre of this image if drawPlayButton="True" -->
  <images drawPlayButton="false"
    default="Images\Next.png"
    highlight="Images\NextHighlight.png"
disabled="Images\NextDisabled.png"
  />
</element>

<element id="StopTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-81" />
  <top relativeTo="Panel.Bottom" offset="-26" />
  <!-- musicbee draws the [] icon in the centre of this image if drawPlayButton="True" -->
  <images drawPlayButton="false"
    default="Images\Stop.png"
    highlight="Images\StopHighlight.png"
disabled="Images\StopDisabled.png"
  />
</element>

<element id="Speaker" parent="Panel">
  <left relativeTo="Panel.Left" offset="204" />
  <top relativeTo="Panel.Bottom" offset="-25" />
  <images category="MuteOff"
    default="Images\VolumeOn.png"
  />
  <images category="MuteOn"
    default="Images\VolumeOff.png"
  />
  </element>

<element id="VolumeSlidebar" parent="Panel">
  <left relativeTo="Panel.Left" offset="200" />
  <top relativeTo="Panel.Bottom" offset="-45" />
  <images category="Slidebar"
    default="Images\VolumeSlidebar.png"
  />
  <images category="Button"
    default="Images\VolumeButton.png"
  />
  </element>

<element id="TrackInfoPanel" parent="Panel">
  <left relativeTo="Panel.Left" offset="270" />
  <top relativeTo="Panel.Top" offset="18" />
  <right relativeTo="TrackLove.Left" offset="-17" />
  <bottom relativeTo="Panel.Bottom" offset="-2" />
  <images category="Left" stretchY1="5" stretchY2="30"
    default="Images\TrackInfoLeft.png"
  />
  <images category="Middle"
    default="Images\TrackInfoMiddle.png"
  />
  <images category="Right"
    default="Images\TrackInfoRight.png"
  />
</element>

<element id="Spectrum" parent="Panel">
  <left relativeTo="Panel.Right" offset="-40" />
  <top relativeTo="Panel.Bottom" offset="-48" />
  <!-- for now the spectrum area needs to be 32px wide -->
  <right relativeTo="Panel.Right" offset="-72" />
  <bottom relativeTo="Panel.Bottom" offset="-8" />
</element>

<element id="TrackText" parent="Panel">
  <left relativeTo="TrackInfoPanel.Left" offset="22" />
  <top relativeTo="Panel.VerticalCenter" offset="9" />
  <right relativeTo="TrackPosition.Left" offset="0" />
  <!-- bottom will be computed at runtime depending on the font used -->
</element>

<element id="TrackLove" parent="Panel">
  <left relativeTo="TrackRating.Left" offset="-29" />
  <top relativeTo="Panel.Bottom" offset="-32" />
  <images category="NotLoved"
    default="Images\LastFmNotLove.png"
    highlight="Images\LastFmNotLoveBright.png"
  />
  <images category="Loved"
    default="Images\LastFmLove.png"
  /> 
</element>

<element id="TrackRating" parent="Panel">
  <left relativeTo="PrevTrackButton.Right" offset="-66" />
  <top relativeTo="Panel.Bottom" offset="-18" />
</element>

<element id="TrackPosition" parent="TrackInfoPanel">
  <left relativeTo="TrackInfoPanel.Right" offset="-12" />
  <top relativeTo="Panel.VerticalCenter" offset="9" />
</element>

<element id="ProgressBar" parent="Panel">
  <left relativeTo="Panel.Left" offset="280" />
  <top relativeTo="Panel.Top" offset="1" />
  <right relativeTo="Panel.Right" offset="-344" />
  <bottom relativeTo="Panel.Top" offset="18" />
  <bufferingMargin top="10" bottom="7" left="12" right="12" />
  <images category="Background" stretchY1="1" stretchY2="1" stretchX1="2" stretchX2="0"
    default="Images\ProgressBar.png"
  />
  <images category="Filler"
    default="Images\ProgressBarFill.png"
  />
  <!-- remove this node if the progress bar will not have a button -->
   <images category="Button"
    default="Images\ProgressBarButton.png"
  />
</element>

<element id="EqualiserButton" parent="Panel">
  <left relativeTo="Spectrum.Left" offset="-40" />
  <top relativeTo="Panel.Bottom" offset="-36" />
  <images category="Off"
    default="Images\EqualiserOff.png"
    highlight="Images\EqualiserOffHighlight.png"
  />
  <images category="On"
    default="Images\EqualiserOn.png"
    highlight="Images\EqualiserOnHighlight.png"
  />
</element>

<element id="LastFmButton" parent="Panel">
  <left relativeTo="Panel.Left" offset="20" />
  <top relativeTo="Panel.Bottom" offset="-40" />
  <images category="Off"
    default="Images\LastFmOff.png"
    highlight="Images\LastFmOffHighlight.png"
  />
  <images category="On"
    default="Images\LastFmOn.png"
    highlight="Images\LastFmOnHighlight.png"
  />
  <images category="Error"
    default="Images\LastFmError.png"
    highlight="Images\LastFmErrorHighlight.png"
  />
</element>

<element id="RepeatButton" parent="Panel">
  <left relativeTo="Panel.Left" offset="76" />
  <top relativeTo="Panel.Bottom" offset="-40" />
  <images category="Off"
    default="Images\RepeatOff.png"
    highlight="Images\RepeatOffHighlight.png"
  />
  <images category="On"
    default="Images\RepeatOn.png"
    highlight="Images\RepeatOnHighlight.png"
  />
  <images category="One"
    default="Images\RepeatOne.png"
    highlight="Images\RepeatOneHighlight.png"
  />
</element>

<element id="ShuffleButton" parent="Panel">
  <left relativeTo="Panel.Left" offset="134" />
  <top relativeTo="Panel.Bottom" offset="-41" />
  <images category="Off"
    default="Images\ShuffleOff.png"
    highlight="Images\ShuffleOffHighlight.png"
  />
  <images category="On"
    default="Images\ShuffleOn.png"
    highlight="Images\ShuffleOnHighlight.png"
  />
  <images category="AutoDJ"
    default="Images\ShuffleAutoDj.png"
    highlight="Images\ShuffleAutoDjHighlight.png"
  />
 
</element>

<!-- spectrum, love and rating can be hidden by user preference
   - when an element is located relative to one of these (hidden) elements,
     the following rules specify which element should be used instead for the relative reference -->
<!-- the offsetAdjustment attribute enables you to tweak the offset of the dependee element
     eg. if TrackInfoButton depends of Spectrum with an offset of 15,
when Spectrum is hidden TrackInfoButton is placed relative to TrackInfoPanel.
Left with offset 8 (15-7)  using the rule below -->
<replacementElement id="Spectrum" replaceWith="Panel.Right" offsetAdjustment="0" />
<replacementElement id="TrackLove" replaceWith="TrackRating.Left" offsetAdjustment="0" />
<replacementElement id="TrackRating" replaceWith="PrevTrackButton.Left" offsetAdjustment="-15" />
</root>

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 24, 2015, 02:56:37 PM
the panel height is adjusted for large fonts - the effect would probably start happening around 11pt
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 24, 2015, 03:10:03 PM
It occurs already with segui light 9pt., so there's probably something going on.

I am sure you know best what is a wise font size value to have stretching initiated, but to me 11pt seems a bit low.
Wouldn't something like 14pt be doable? Or would that give problems with specific sort of fonts?
I could do some testing with that if you would like me to.

edit:

This what an un-stretched 43 px high info panel with Segui regular 20pt would look like in Tron Punk:
(not saying this is aesthetically desirable, but just showing it could be done)

(http://i.imgur.com/mm3x3Rol.jpg) (http://i.imgur.com/mm3x3Ro.png)

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 24, 2015, 03:43:49 PM
It occurs already with segui light 9pt., so there's probably something going on.

Ok, hold your horses, I think I know what is happening.
I have the bottom of the info panel relative to the bottom to the main panel, and the top of that same panel relative to the top of the main panel. I believe the values I have set there stretches the info panel to begin with.
I'll see if I can get it to work with both being relative to the bottom.
Or maybe better, I'll see if it works when I completely remove "<top relativeTo="Panel.Top"
To my understanding that entry serves no purpose here, just the starting point from the bottom should be enough.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 24, 2015, 09:40:46 PM
fixes for the above

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 24, 2015, 10:27:22 PM
This seems to be going quite well now.
I learned to do some fixes in my Tron Punk skin, and it is looking quite good now.
(I updated the tron punk skin topic with this new version b.t.w.)
Using all sorts of fonts and sizes now seem to work quite well. (this was a disaster in the past)

And I also noticed and enjoyed that restarts after changing fonts is not necessary anymore. Great!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 24, 2015, 10:55:59 PM
This seems to be going quite well now.

I agree. Everything is looking great with the latest update  :)

One thing I miss from 2.5 is the icons in the tabs, but think it would look too crowded with 3.0 design to have icon and text.
With the toolbar buttons you can have icon or text.
Maybe that could be done for the tabs.
 :o Not necessarily right now - something that could be kept in mind for later.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 24, 2015, 11:25:44 PM
I agree. Everything is looking great with the latest update  :)
One thing I miss from 2.5 is the icons in the tabs, but think it would look too crowded with 3.0 design to have icon and text. Maybe that could be done for the tabs.

I fully agree on the icons for the tabs.
It makes it very intuitive to pick the tab you want fast, without having to read the whole text.

They are also essential (exageration mode on) in such cases:

(http://i.imgur.com/Bj1sjjPl.jpg) (http://i.imgur.com/Bj1sjjP.png)


Maybe if we are good boys, for Christmas you get your icons in the tabs, and I get my tabs in the right side panel.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 10:05:56 AM
I noticed the vertical dividers in the column browser are not visible anymore.
Especially now that the columns are resizable, they can be very useful.

(http://i.imgur.com/fr0qbbol.jpg) (http://i.imgur.com/fr0qbbo.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 10:48:16 AM
I am assuming this panel shouldn't be resizable to begin with, but when I do, I get this:

(http://i.imgur.com/XkBqC8yl.jpg) (http://i.imgur.com/XkBqC8y.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 25, 2015, 10:49:40 AM
I noticed the vertical dividers in the column browser are not visible anymore.

from the colour-finder skin:
Code
<element id="Panel.Body.Default" bg="16,19,16" fg="127,132,133" bdr="0,200,251"/>
    <!--? 'bdr' can be used if 'MainPanelTopBorder' is true-->

it adds a border to the RH side (except the last RH one) of all panels in 3.0

EDIT:
also, if you don't want the top border to match the panel border, you can override it with:

<element id="MainPanelTopBorderColour" bdr="54,62,69" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 10:57:54 AM
For Tron Punk, in 2.5 I had a nice bright border surrounding the panel.
In v3 only a line at the top remains?

(http://i.imgur.com/RBRnSR9s.jpg) (http://i.imgur.com/RBRnSR9.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 11:02:07 AM
from the colour-finder skin:
Code
<element id="Panel.Body.Default" bg="16,19,16" fg="127,132,133" bdr="0,200,251"/>
    <!--? 'bdr' can be used if 'MainPanelTopBorder' is true-->
it adds a border to the RH side (except the last RH one) of all panels in 3.0

That entry is present and enabled.
(Otherwise it also wouldn't show up in 2.5 would it?)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 11:19:13 AM
EDIT:
also, if you don't want the top border to match the panel border, you can override it with:
<element id="MainPanelTopBorderColour" bdr="54,62,69" />

I believe that is this line, but that is not related to the issue I am raising? Or am I missing something?

(http://i.imgur.com/YVk7KExl.jpg) (http://i.imgur.com/YVk7KEx.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 25, 2015, 11:25:43 AM
That entry is present and enabled.
(Otherwise it also wouldn't show up in 2.5 would it?)

Just had a look at your updated skin in 3.0 and there is a faint divider line (colour:2,13,12) between the column browser columns.

EDIT:
also, if you don't want the top border to match the panel border, you can override it with:
<element id="MainPanelTopBorderColour" bdr="54,62,69" />

I believe that is this line, but that is not related to the issue I am raising? Or am I missing something?
so if you wanted that red line under the tabs but wanted the divider border to stay "2,13,12", you would need:

<element id="MainPanelTopBorder">true</element>
<element id="Panel.Body.Default" bg="16,19,16" fg="127,132,133" bdr="2,13,12"/>
<element id="MainPanelTopBorderColour" bdr="255,0,0" />

otherwise the red border would also be "2,13,12"

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 11:28:11 AM
Just had a look at your updated skin in 3.0 and there is a faint divider line (colour:2,13,12) between the column browser columns.

You have the eyes of a hawk ;-)

So v3 draws the color for that element from a different entry than 2.x did.
Some investigating to do....
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 25, 2015, 11:36:51 AM
You have the eyes of a hawk ;-)

no, just a good colour-picker app that has a magnifying viewer  ;D

also see my edited post above.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 12:20:28 PM
so if you wanted that red line under the tabs but wanted the divider border to stay "2,13,12", you would need:
<element id="MainPanelTopBorder">true</element>
<element id="Panel.Body.Default" bg="16,19,16" fg="127,132,133" bdr="2,13,12"/>
<element id="MainPanelTopBorderColour" bdr="255,0,0" />
otherwise the red border would also be "2,13,12"

I believe the horizontal line you are bringing up is not really related to this issue.
The exact same xml is acting differently in v2 vs v3 for these vertical dividers.

The issue is that in v2 these dividers in the column browser draw their color from:
<element id="Content[TrackDetail].Body.Default"  bdr=  />

but in v3 it now draws its color from:
<element id="Panel.Body.Default"   bdr=  />

If I change that value to the color I want for the vertical dividers for v3, as it looks in v2, all panel borders change to that color, which looks bad for this skin.
(and for most skins I presume)
All body panels then get 'compartmentalized'.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 25, 2015, 12:50:00 PM
i recommend you dont go changing things until i have had a chance to investigate. There will be some things which are not intentional that i wont have noticed because of the skin i predominately use
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 25, 2015, 07:26:41 PM
"TabsBar.Background" is an existing element thats the one used for the tabs background. I had made a change in v3 to use the border component to draw a line across the tabs bar. However testing this against a number of skins has poor results eg. red border line for some skins

So instead a i will add a new element in case you already made use of this - it will be: "TabsBar.BorderLine" bdr=XXXX

@hiccup, i have corrected the column browser and also a few other items such as the section headers in the left navigator, expander icon colours in the same panel and the thumbnail browser color override used by other skins.
I will post an updated version later
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 25, 2015, 08:00:31 PM
I have corrected the column browser and also a few other items...

would that include making v3 follow the existing protocol of
<element id="MainPanelTopBorder">true/false</element>
turns the "bdr" attribute of
<element id="Panel.Body.Default" bg="xxxx" fg="xxxx" bdr="xxxx"/>
on/off?


my mistake  -  it doesn't.  wrong info in the colourfinder dummy skin :o
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 25, 2015, 08:34:06 PM
fixes for the above

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 09:09:55 PM
fixes for the above

Thnx, looking good. The new element is also very nice.

A question: With v2 I could have vertical separators (A). But now with this v3 also some horizontal lines B and C show up with that color.
Is that avoidable in some manner?
Also thinking about other skins, it certainly would be good to have the option for a new dedicated element for C.

(http://i.imgur.com/Xvi1yCqs.jpg) (http://i.imgur.com/Xvi1yCq.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 25, 2015, 10:02:21 PM
I am editing a bitmapped skin with not much fancy stuff going on. The player control buttons are to be drawn by MusicBee itself.
In v2 they are nicely in place, but with exactly the same skin xmlc, in v3 the previous and next buttons don't line up horizontally.

Is it me doing something wrong, or is it MB v3?

(http://i.imgur.com/kWI8DD5l.jpg) (http://i.imgur.com/kWI8DD5.png)

Code
<element id="PrevTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-122" />
  <top relativeTo="Panel.VerticalCenter" offset="5" />
  <!-- musicbee draws the |<< icon in the centre of this image. The colours for the musicbee drawn icon are determined from the skin file -->
  <images drawPlayButton="true"
    default="Images\ButtonSmall.png"
    highlight="Images\ButtonSmallHighlight.png"
  />
</element>


<element id="NextTrackButton" parent="Panel">
  <left relativeTo="EqualiserButton.Left" offset="-49" />
  <top relativeTo="Panel.VerticalCenter" offset="5" />
  <!-- musicbee draws the >>| icon in the centre of this image if drawPlayButton="True" -->
  <images drawPlayButton="true"
    default="Images\ButtonSmall.png"
    highlight="Images\ButtonSmallHighlight.png"
  />
</element>
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on November 26, 2015, 04:46:21 AM
A couple of versions ago, MB can be closed simply by moving the cursor to the upper right corner, now need to aim at the close button (This is very uncomfortable). This new behavior, or it can be changed at the level of the skin?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 26, 2015, 04:55:52 AM
A couple of versions ago, MB can be closed simply by moving the cursor to the upper right corner, now need to aim at the close button (This is very uncomfortable). This new behavior, or it can be changed at the level of the skin?

Not sure what you mean - I've always been able to click those buttons easily, even without carefully aiming.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on November 26, 2015, 06:02:51 AM
Quote
Not sure what you mean - I've always been able to click those buttons easily, even without carefully aiming.

The latest versions of Steven obviously added a few pixels above the buttons (such behavior has already been to the menu button in v3, is also inconvenient).

V3                                                                               V2.5
(http://s17.postimg.org/6q02cxw27/image.gif)               (http://s13.postimg.org/aax6jh3k7/image.gif)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 26, 2015, 06:34:29 AM
This might not be worth mentioning, but on my Windows 7 PC I noticed when the right sidebar is disabled, the main panel header bar extends all the way to the outermost border, which creates a gap in the bitmap window border.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 26, 2015, 08:08:33 AM
A question: With v2 I could have vertical separators (A). But now with this v3 also some horizontal lines B and C show up with that color.
Is that avoidable in some manner?
Also thinking about other skins, it certainly would be good to have the option for a new dedicated element for C.
B is controlled by element "HeaderBar" and defaults to "Panel.ChildHeader.Default" if not provided
i dont have time to check but would guess C is controlled by "Panel.ChildHeader.Default"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 26, 2015, 08:10:12 AM
This might not be worth mentioning, but on my Windows 7 PC I noticed when the right sidebar is disabled, the main panel header bar extends all the way to the outermost border, which creates a gap in the bitmap window border.
trying now i cant reproduce. Can you provide a screenshot?
Does it happen on startup or only after some action beforehand?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 26, 2015, 08:46:55 AM
trying now i cant reproduce. Can you provide a screenshot?
Does it happen on startup or only after some action beforehand?

From my testing it seems to be caused by the Now Playing node (in my case docked in its own tab and using large album cover view).
First of all I disabled the right panel by removing all elements from it, rather than simply hiding it. I then tried to enable the right hand panel in the Now Playing node, assuming it was independent from the right sidebar, but it looks like they are the same thing. As you can see from these screenshots, that's where the visual glitch comes in.


Now Playing screen (notice the right hand border)

(http://i.imgur.com/TEYjevEt.jpg) (http://i.imgur.com/TEYjevE.jpg)

Main Library screen (notice the header bar border)

(http://i.imgur.com/BGIsSUat.jpg) (http://i.imgur.com/BGIsSUa.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 26, 2015, 08:55:32 AM
in that case i think i will need your settings file again
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 26, 2015, 09:32:52 AM
B is controlled by element "HeaderBar" and defaults to "Panel.ChildHeader.Default" if not provided
i dont have time to check but would guess C is controlled by "Panel.ChildHeader.Default"

Ok, I hope I got all this right:

1:

When ignoring any overules I believe that:

A and C are both controlled by:
id="Content[TrackDetail].Body.Default" bdr=

B and D are both controled by:
id="Panel.ChildHeader.Default" bdr=

I can't oversee possible other implications, but looking at the screenshot for this skin, I feel it would make more sense to have C follow B and D.

(http://i.imgur.com/i7Bg5Ros.jpg) (http://i.imgur.com/i7Bg5Ro.png)


2:

Two observations about the "HeaderBar" element:
fg= doesn't do anything?
And a visual error:
When I set the element, the title bar looses it's bitmap color and becomes plain white:
(http://i.imgur.com/UnPM6avs.jpg) (http://i.imgur.com/UnPM6av.png)


3:

I believe I might also succeed in what I am trying to achieve with using the existing id="FilterPanel. elements.
But they currently don't seem to work at all for v3?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 26, 2015, 09:49:29 AM
I am editing a bitmapped skin with not much fancy stuff going on. The player control buttons are to be drawn by MusicBee itself.
In v2 they are nicely in place, but with exactly the same skin xmlc, in v3 the previous and next buttons don't line up horizontally.
which skin is it?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 26, 2015, 10:02:12 AM
which skin is it?

http://1drv.ms/1MCY0pT
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 26, 2015, 12:35:11 PM
I believe I know what causes this.

The culprit seems to be how v3 renders and centers its player control images on a background image that has an uneven vertical pixel count.

The transparent ButtonSmall.png's which serve as a background for the controls, in this skin had a size of 35x17
I lowered that to 35x16, and now 'previous' and 'next' are identically aligned.

So it seems v2 centered it's drawn player control images (which probably have an even vertical pixel count) identical for 'previous' and 'next', but v3 strangely enough does that differently between 'previous' and 'next' when the background image is 'uneven'.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 26, 2015, 12:38:06 PM
@hiccup, i am not planning to change the defaults behavior. If i was to start from scratch with non existing skins out there it would make sense to build it better but given where its at now, i will add overrides
for 2, the MusicBee3 skin uses this element. I would think you have probably made an error somewhere eg. colour > 255 that is causing the skin to not load properly. If the fg component is not setting the header bar text colours then that is a bug and i will fix it
for 3, the filter panel elements work for the thumbnail browser and the podcast subscriptions list. I was looking at this last night and i cant remember if its included in the latest version. If not, it will be in the next

for the centering, i recall i did something new for v3 with the play next controls so it scales better with high dpi machines. Its probably something to do with the size allocated to the entire button but i will look at it and address it tonight
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 26, 2015, 12:52:04 PM
Great, that all makes perfect sense.
Indeed, for (2) the mistake was mine. I had made a minor syntax error in the entry (which np++ didn't alert me to)
But fg is indeed not working for that element (unless it is currently overruled by some other element of course)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 26, 2015, 07:36:42 PM
With the same skin from post #111 I noticed some other differences.

1. The volume button, and the 'Stop' button (disabled) get different colors. Also on mouse hoover-over the 'previous' and 'next' controls get another color in v3 than in v2.

2. In v3 the volume bar looks very bland. It has lost its secondary contrasting bordering color. The same for the volume button.

(http://i.imgur.com/9Y6PHlds.jpg) (http://i.imgur.com/9Y6PHld.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 26, 2015, 08:57:26 PM
fixes for the above

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe

also i have now enabled tab-style panel stacking which is set in the Panel Layout dialog.
Unless i am proven wrong and it is a popular option, i dont want to spend time on it making the tabs fancy. But if enough of you say otherwise i will reconsider.

i have added the following icon overrides:
NowPlayingIcon
MusicExplorerIcon
PlaylistDirectoryIcon


I guess i am at the point now where i can consider new skinning requests. At one stage i was thinking there might need to be panel location (left sidebar, left main panel, etc overrides) but looking at the various skins i am not sure its really needed so for now i am not planning any further enhancements myself.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 26, 2015, 10:00:42 PM
also i have now enabled tab-style panel stacking which is set in the Panel Layout dialog.
Unless i am proven wrong and it is a popular option, i dont want to spend time on it making the tabs fancy. But if enough of you say otherwise i will reconsider.

Thanks for doing this! I don't need fancy either. Simple and practical is great.
Now when in tab-style, the drop down arrow in the tab headers can be removed, since there is now a button to quickly select 'selected' vs. 'playing'. That would clean it up a bit more.

And I have another suggestion to have an even cleaner look with these tabs.
Make the tab switch between playing vs. selected by simply clicking on the header once.
When in playing mode, the word 'playing' would probably not even have to be displayed, and when in 'selected' mode, have the word 'selected' appended.

Something like this:

(http://i.imgur.com/JkeuSOVl.jpg) (http://i.imgur.com/JkeuSOV.png)




Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 27, 2015, 01:15:37 AM
i have added the following icon overrides:
NowPlayingIcon
MusicExplorerIcon
PlaylistDirectoryIcon

I'm glad to see those overrides introduced.

By the way, are there currently overrides for "Recommendations" and "Upcoming Concerts"?

I was also wondering if there's a way to override the "Devices" icon, or if not could that option be added?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 27, 2015, 01:34:23 AM
Trying to update Mellon Remix now.  Is this offset spot at the Track Information a bug or something I can fix?

(http://i.imgur.com/oDdsTu7.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on November 27, 2015, 05:39:53 AM
The menu button fixed thanks. The other buttons still have borders:
(http://s8.postimg.org/kqjhg0vth/image.gif)
Request theme tabs:
(http://s18.postimg.org/qsealuc09/2015_11_27_081635.jpg)
By implementing possible completely get rid of the "status bar."
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 27, 2015, 10:28:48 AM
I was also wondering if there's a way to override the "Devices" icon, or if not could that option be added?

you just add an autorun.inf file with the icon you want into the root folder of the device.
MB (and Windows) will show that icon.
see here (http://www.online-tech-tips.com/computer-tips/how-to-create-custom-icons-for-flash-drives-or-usb-drives/) or search web for "add icon to usb"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 27, 2015, 01:46:53 PM
I guess i am at the point now where i can consider new skinning requests. At one stage i was thinking there might need to be panel location (left sidebar, left main panel, etc overrides) but looking at the various skins i am not sure its really needed so for now i am not planning any further enhancements myself.

One thing I remembered what was a challenge when creating bitmap skins, is that sometimes when the player panel was looking good when positioned at the bottom, it was not looking so good when located at the top.
Probably the option to have separate background and trackinfo images for the player being located at the bottom or the top could be helpful for that.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 27, 2015, 02:09:25 PM
Trying to update Mellon Remix now.  Is this offset spot at the Track Information a bug or something I can fix?
i havent been able to reproduce this. Is it anything to do with the right panel being collapsed and opening it?
Maybe your current settings file might help me with this

edit:
i have fixed the bug with the spectrum visualiser causing an error when opening a collapsed panel after startup and thinking about it, i realise this type of drawing error could easily result from that. So i suggest you try with the new version when i post it
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 27, 2015, 06:23:36 PM
Allow me to refresh an earlier suggestion/wish:

http://getmusicbee.com/forum/index.php?topic=15050.msg95744#msg95744

If this is not doable for any reason, a simpler implementation could be to have the option to have indicators in the player panel, which indicate the current status. (playing, paused, stopped)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 27, 2015, 07:03:54 PM
While re-sizing compact player:

(http://i.imgur.com/YvNPoUls.jpg) (http://i.imgur.com/YvNPoUl.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 27, 2015, 08:34:12 PM
I noticed 'enlarge progress bar' is enabled for bitmapped skin also.
While it works out (accidentally) for a few, I suppose it should be disabled for bitmapped skins.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 27, 2015, 09:22:31 PM
While re-sizing compact player:
i cant reproduce this. When you took the screenshot had you released the mouse button?
the resizing is only done at that point
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 27, 2015, 09:43:23 PM
While re-sizing compact player:
i cant reproduce this. When you took the screenshot had you released the mouse button?
the resizing is only done at that point

No, this is only during dragging to resize. When the mouse button is released it corrects itself fine.
It's just that it is looking a bit ugly while re-sizing, the player bar and caption bar disappearing, and the artifarcts at the bottom half of the panel.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on November 27, 2015, 10:31:16 PM
The buttons are fixed on top but not right:
(http://s27.postimg.org/a54iwwij7/image.gif)


And 2 request on the theme:

1. To make the clickable area to the left of the menu button:
(http://s27.postimg.org/6getxf8ib/image.gif)

2. To do option (at least at the level of the skin) to remove the border between the tabs and the edge of the monitor:
(http://s2.postimg.org/ajgkwvwy1/image.gif)

 All this In order not to taking aim!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 28, 2015, 01:28:35 AM
Is this thing with the icons and search box being pushed right up to the top of the screen going to be changed?  With a graphic caption bar, it really changes the look between maximized and windowed.

Also, is the change to the borders only for Windows 10, or will it show up in Win 7 & 8, too?  In other words, can I safely remove the right/left/bottom border graphics?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on November 28, 2015, 02:21:47 AM
Also, is the change to the borders only for Windows 10, or will it show up in Win 7 & 8, too?  In other words, can I safely remove the right/left/bottom border graphics?

Only Windows 10 supports the thin borders. It's safe to leave the bitmaps as they are for other versions of Windows.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 28, 2015, 05:33:35 AM
i havent been able to reproduce this. Is it anything to do with the right panel being collapsed and opening it?
Maybe your current settings file might help me with this

edit:
i have fixed the bug with the spectrum visualiser causing an error when opening a collapsed panel after startup and thinking about it, i realise this type of drawing error could easily result from that. So i suggest you try with the new version when i post it

The error message is fixed, but the graphical issue is still there.  I'll send the settings file.

Update: The issue is with Panel.ChildHeader.Default bdr value.  It shows up on bottom in the main panel and on top in the right.

(http://i.imgur.com/Ug8nNHy.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on November 28, 2015, 05:56:12 AM
Is this thing with the icons and search box being pushed right up to the top of the screen going to be changed?
The main switching tabs, but if all the elements will be at the top even better (improves usability).

Also, is the change to the borders only for Windows 10, or will it show up in Win 7 & 8, too?
The possibility of such behavior is implemented starting from Win XP, (by the way this mode is supported by almost any modern browser, it is very convenient)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 28, 2015, 04:35:39 PM
Is this thing with the icons and search box being pushed right up to the top of the screen going to be changed?  With a graphic caption bar, it really changes the look between maximized and windowed.
personally i agree with you, its just that i recall comments about the search box being better placed where it is now. I dont want to add an option for this. Before i go and change anything does anyone else have any comments on this

Also, is the change to the borders only for Windows 10, or will it show up in Win 7 & 8, too?  In other words, can I safely remove the right/left/bottom border graphics?
the single border change only applies to windows 10. You need to keep those bitmaps in the skin
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 28, 2015, 04:52:13 PM
personally i agree with you, its just that i recall comments about the search box being better placed where it is now. I dont want to add an option for this. Before i go and change anything does anyone else have any comments on this

If I understand correctly, and this is about the search field and the toolbar icons being pushed up all the way flush to the top without a 'buffering'pixel:

I would like to have the 'buffering pixel' too.
Both for 'looks', but also because when in full-screen mode, it is now not possible to drag the top border to resize the whole MusicBee window at locations where the search box or toolbar icons are.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 28, 2015, 05:30:16 PM
the search box only has 1px it can be pushed down
The problem is in v2.5 the way window is done is quite different to v3 and didnt need to follow some of the windows standard behaviors. So when MB was maximised MB could maintain the full header height. In v3, the caption bar is actually set 8px off the screen (by windows) so it leaves less space available (check with any standard windows application such as notepad and you will see 8px removed from the header height).
So can you confirm thats really what the issue is ie. less vertical height making it look different.
For skinned borders i could probably do something about it but it would be a non-trivial exercise
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 28, 2015, 05:44:43 PM
the search box only has 1px it can be pushed down
The problem is in v2.5 the way window is done is quite different to v3 and didnt need to follow some of the windows standard behaviors. So when MB was maximised MB could maintain the full header height. In v3, the caption bar is actually set 8px off the screen (by windows) so it leaves less space available (check with any standard windows application such as notepad and you will see 8px removed from the header height).
So can you confirm thats really what the issue is ie. less vertical height making it look different.
For skinned borders i could probably do something about it but it would be a non-trivial exercise

I see.  I think even that 1 pixel would help cosmetically, just to make it a little less crowded.

The reason it looks different is the gradient I'm using, but I can adapt the gradient to the space available.  However, if I adapt the top border for Win 10, it will no longer match the other borders in Win 7.  I can make different versions, but then that becomes a bit confusing for the user.  And what about people creating new skins on Windows 10?  They won't be able to see how it would look on Windows 7.  So I think for the sake of both skinners and users, if you can make the borders consistent across all versions of Windows, it would be worth the effort.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 28, 2015, 05:56:55 PM
i will have a look at it and if i think its too hard i will just do the 1px adjustment - but it will probably be ok
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 28, 2015, 06:02:02 PM
Update: The issue is with Panel.ChildHeader.Default bdr value.  It shows up on bottom in the main panel and on top in the right.
can you send me your settings file as i still cant reproduce any incorrect behavior and could you also confirm the corruption happens on startup or do you need to do some action for it to happen?

edit:
nevermind - its when you have the spectrum visualiser at the top
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 28, 2015, 06:04:30 PM
the search box only has 1px it can be pushed down

Not on my screen:
(http://i.imgur.com/LtSb08Rl.jpg) (http://i.imgur.com/LtSb08R.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 28, 2015, 08:25:19 PM
I'd like to be able to put a border here, connected to the tab border (in other words, I'd like to have one both above and below panel.childheader.default):

(http://i.imgur.com/xAtGoQE.png)

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 29, 2015, 08:40:05 AM
I'd like to be able to put a border here, connected to the tab border (in other words, I'd like to have one both above and below panel.childheader.default):
(http://i.imgur.com/xAtGoQE.png)


Steven created a new element for that last week:
<element id="TabsBar.BorderLine" bdr="xxx,xxx,xxx" />

But that one is not working when the tabs are in the caption bar, so for that we would need another new one:
<element id="TabsBar.TabInCaptionBar.BorderLine" bdr="xxx,xxx,xxx" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 29, 2015, 10:59:38 AM
for the next update i have added 4px to skinned caption bar when maximised for skinned window borders (thats still 4px less than in normal state)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on November 29, 2015, 12:31:51 PM
Hope this can be achieved as the maroon colour doesn't work with all skins:
yes i will add a new skin element but i am leaving that sort of thing until the new GUI is mostly done

don't forget this one.
It's the maroon rectangle in the Now Playing Tab and compact player, with the Title, Artist and Album (YYYY) info on it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 29, 2015, 03:56:45 PM
this has the extra caption bar area. I will look at the requests but still not really in a position to do so in earnest yet

http://www.mediafire.com/download/hwh28nm8k6ahp2s/MusicBeeDemo.zip
unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 29, 2015, 04:34:02 PM
this has the extra caption bar area

That's looking good.
not an issue at all, but I noticed the area where you cannot grab the caption bar to move/resize is rather large. (yellow area)
And after some erratic fiddling, enlarging and minimalizing the whole window, sometimes a 'close' button appears at a strange location in the caption bar.

(http://i.imgur.com/dwR7VS0l.jpg) (http://i.imgur.com/dwR7VS0.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 29, 2015, 04:59:36 PM
When maximizing, the tabs in the caption bar get a duplicate top border line

(http://i.imgur.com/BvICVasl.jpg) (http://i.imgur.com/BvICVas.png)

maximized:

(http://i.imgur.com/a8CLeCcl.jpg) (http://i.imgur.com/a8CLeCc.png)

('jistme on the outlook' skin)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 29, 2015, 05:24:37 PM
When maximizing, the tabs in the caption bar get a duplicate top border line
a fix has been uploaded for that
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on November 29, 2015, 05:29:11 PM
When maximizing, the tabs in the caption bar get a duplicate top border line
a fix has been uploaded for that
Confirmed, fixed.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 29, 2015, 07:13:54 PM
That extra space in the caption bar is very nice!

These areas really need separate elements:

(http://i.imgur.com/Ypdy9Mzl.png) (http://imgur.com/Ypdy9Mz)

If it's hard to see in the picture, it's three areas: The AZ jump bar/left panel header, the extension into the right panel, and the headers for the lower positions in the left and right panels.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 29, 2015, 08:01:07 PM
you can already use this to override the top header bar:
<element id="HeaderBar" bg="235,235,235" fg="60,60,60" bdr="230,230,230" />

so only one new element would be needed for the header bar in the right sidebar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on November 29, 2015, 08:14:21 PM
And after some erratic fiddling, enlarging and minimalizing the whole window, sometimes a 'close' button appears at a strange location in the caption bar.
if that happens again after the next update then please let me know
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on November 30, 2015, 02:40:20 AM
you can already use this to override the top header bar:
<element id="HeaderBar" bg="235,235,235" fg="60,60,60" bdr="230,230,230" />

so only one new element would be needed for the header bar in the right sidebar

Great, thanks!  For now I like the right sidebar the same at the top, but I can imagine that some would prefer it different.

Edit: after fiddling with possible layouts, I may be changing my mind.

Meanwhile, is it intended that the Now Playing List (and Column Browser) overrides no longer work?

Also the "search" placeholder text in the search box no longer uses the skin color.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 01, 2015, 09:51:38 AM
When you click on the volume arrow in the mini player, the volume adjustment bar is drawn underneath the panel - not on top.
The only way you can access it, is to move the player from on top of it.
that should have been addressed in the last update

Thank you. now working even when using the pop-up volume.
But, can you tell me where the volume indicator is drawing its colour from?
It shows in some skins, but not others.

shows in MusicBee3
(http://i.imgur.com/1ln8LXf.jpg)

but not in AeroBee
(http://i.imgur.com/NCG1ZPK.jpg)



with the removal of the internal web browser and the increased need for the web plugin, an override for the "Web Browser" node icon would be appreciated.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 01, 2015, 02:44:15 PM
This is about:
(quote from skin.xml:)

Quote
<!-- spectrum, love and rating can be hidden by user preference
   - when an element is located relative to one of these (hidden) elements,
     the following rules specify which element should be used instead for the relative reference -->"

For v3, the image TrackInfoRight.png is not changing it's position set relative to other elements.

Checked with A Sophisticated Bee. It works o.k. in v2.x, not in v3.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 01, 2015, 07:00:43 PM
This is about:
(quote from skin.xml:)

Quote
<!-- spectrum, love and rating can be hidden by user preference
   - when an element is located relative to one of these (hidden) elements,
     the following rules specify which element should be used instead for the relative reference -->"

For v3, the image TrackInfoRight.png is not changing it's position set relative to other elements.

Checked with A Sophisticated Bee. It works o.k. in v2.x, not in v3.
i am not seeing any difference in behavior when those elements are hidden. In both versions the track info panel stays the same width for this skin. Unless of course you have made new changes in which case can you post a link
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 01, 2015, 07:04:36 PM
This is about:
(quote from skin.xml:)

Quote
<!-- spectrum, love and rating can be hidden by user preference
   - when an element is located relative to one of these (hidden) elements,
     the following rules specify which element should be used instead for the relative reference -->"

For v3, the image TrackInfoRight.png is not changing it's position set relative to other elements.

Checked with A Sophisticated Bee. It works o.k. in v2.x, not in v3.
i am not seeing any difference in behavior when those elements are hidden. In both versions the track info panel stays the same width for this skin. Unless of course you have made new changes in which case can you post a link

Could you please check again with Tron Punk skin?
It is very noticeable there.
If not, I am really confused, and will have an even more thorough look at it than I already have.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 01, 2015, 07:08:03 PM
This is about:
(quote from skin.xml:)

Quote
<!-- spectrum, love and rating can be hidden by user preference
   - when an element is located relative to one of these (hidden) elements,
     the following rules specify which element should be used instead for the relative reference -->"

For v3, the image TrackInfoRight.png is not changing it's position set relative to other elements.

Checked with A Sophisticated Bee. It works o.k. in v2.x, not in v3.
i am not seeing any difference in behavior when those elements are hidden. In both versions the track info panel stays the same width for this skin. Unless of course you have made new changes in which case can you post a link

Could you please check again with Tron Punk skin?
It is very noticeable there.
If not, I am really confused, and will have an even more thorough look at it than I already have.

PS,
Be sure to download the recent versions that are on the first post of the respective skin topics:
http://getmusicbee.com/forum/index.php?topic=8164.0
http://getmusicbee.com/forum/index.php?topic=7871.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 01, 2015, 08:12:05 PM
yes i can see the behavior with the Tron Punk skin and it should be fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 01, 2015, 09:17:53 PM
with the removal of the internal web browser and the increased need for the web plugin, an override for the "Web Browser" node icon would be appreciated.
i have added "WebBrowserIcon"


just a note while i remember
PlayerFlat.DisplayPanel is now used to set the override color in standard skins to set the centered display panel when "Progress Bar in Middle" is selected
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 02, 2015, 06:09:30 AM
i have added "WebBrowserIcon"

Hi Steven, can you confirm if all overrides are available, or are some yet to be added?
I asked earlier but you may have missed it: http://getmusicbee.com/forum/index.php?topic=16643.msg99005#msg99005
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 02, 2015, 07:16:26 AM
RecommendationsIcon
UpcomingConcertsIcon
are in the last update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 02, 2015, 08:40:04 AM
RecommendationsIcon
UpcomingConcertsIcon
are in the last update

Great, thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 02, 2015, 07:38:27 PM
Thank you. now working even when using the pop-up volume.
But, can you tell me where the volume indicator is drawing its colour from?
It shows in some skins, but not others.
PlayerMini.Control.Default
but if that or the PlayerMini.Background element is not defined, then the colors are retrieved from the sidebar player
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 02, 2015, 07:50:06 PM
Meanwhile, is it intended that the Now Playing List (and Column Browser) overrides no longer work?
Also the "search" placeholder text in the search box no longer uses the skin color.
the column browser should apply the filter panel override for the next update. The last update should have correctly set the "search" text which should have only not applied the override when in the caption bar.
However i am not sure for the Now Playing list what override you are refering to, Can you give me an example of a skin where this override is being used and do you know the element name? (I have looked in the code and cant find anything but it might be done in a non-obvious way for me to find easily)
edit:
found the Now Playing list. I will include it in the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 02, 2015, 08:38:18 PM
Thank you. now working even when using the pop-up volume.
But, can you tell me where the volume indicator is drawing its colour from?
It shows in some skins, but not others.
PlayerMini.Control.Default
but if that or the PlayerMini.Background element is not defined, then the colors are retrieved from the sidebar player

Thanks for that, but when I said it was working, I got it a little bit wrong.  :o

When the mini player is small enough to have to use the pop-up volume, everything now shows on top of the player - except the volume slider button.

Oh, and were you aware that you can't re-size the mini player from the LH side?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on December 02, 2015, 09:10:43 PM
Meanwhile, is it intended that the Now Playing List (and Column Browser) overrides no longer work?
Also the "search" placeholder text in the search box no longer uses the skin color.
the column browser should apply the filter panel override for the next update. The last update should have correctly set the "search" text which should have only not applied the override when in the caption bar.
However i am not sure for the Now Playing list what override you are refering to, Can you give me an example of a skin where this override is being used and do you know the element name? (I have looked in the code and cant find anything but it might be done in a non-obvious way for me to find easily)
edit:
found the Now Playing list. I will include it in the next update
I'm not sure if this relates to psychoadept's comment and Steven's fix.  And understand that my comment is coming from the standpoint of I really don't know what I'm doing when working with skins.  If ever there was a trial and error guy, that's me.  I've taken hiccup's Jistme on the Outlook skin (xml) and have been trying to add alternating bars of color in the Track Details view of the Main Panel.  For whatever reason, the bars are extending to the Column Browser.  And what I'd like in the Column browser is just a background color without the bars. 

I'm getting close, but I'm finding that v3 exhibits different results than v2.5.
This is 2.5:
(http://i.imgur.com/BIKf3dpl.jpg) (http://i.imgur.com/BIKf3dp.jpg)

And this is 3.x:
(http://i.imgur.com/oTYWLZJl.jpg) (http://i.imgur.com/oTYWLZJ.jpg)

In the 2.5 version note the blank space under "2014" and under "A-Z."  And in the 3.x version there are bars in those spaces.  This is the same skin that shows differently in the two versions of MB.

So as an aside, what element do I need to change in order to have a plain solid background in the Column Browser? At this point I'd be very content to have it working as I want in 2.5.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 02, 2015, 09:23:02 PM
the change was intentional so rows are rendered in a consistent manner with the main panel. I dont have a strong opinion about that so if people dont like it then it should be easy to change
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 02, 2015, 09:41:26 PM
I'd like to be able to put a border here, connected to the tab border (in other words, I'd like to have one both above and below panel.childheader.default):

(http://i.imgur.com/xAtGoQE.png)
thats done for the next update as:
TabsBar.TabInCaptionBar.BorderLine bdr="xxx"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 02, 2015, 09:54:12 PM
changes as described above:
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 02, 2015, 10:19:09 PM
thats done for the next update as:
TabsBar.TabInCaptionBar.BorderLine bdr="xxx"

Is it just me or does the border line look strange that it doesn't run under the inactive tabs?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on December 03, 2015, 07:15:29 AM
Steven will be Back the opportunity highlight?:
V 2.5
(http://s8.postimg.org/cyj556tdh/image.gif)

Request.
To make the highlight color is dependent on Skin:
Aimp 4
(http://s1.postimg.org/ba75ij7wv/image.gif)(http://s11.postimg.org/7r3fiqgmb/image.gif)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on December 03, 2015, 12:50:52 PM
changes as described above:
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe
This update has fixed the erroneous left-hand close button I reported.  Thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 03, 2015, 06:11:04 PM
Steven will be Back the opportunity highlight?:
V 2.5
(http://s8.postimg.org/cyj556tdh/image.gif)
i dont understand what you want or how the picture relates to the question

for the 2nd part, skin developers already have control over the colours for file selection
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 03, 2015, 07:37:13 PM
Is it just me or does the border line look strange that it doesn't run under the inactive tabs?
i have changed it so the line is drawn under inactive tabs as well so its consistent with when tabs are not docked in the caption bar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 03, 2015, 07:59:19 PM
Is it just me or does the border line look strange that it doesn't run under the inactive tabs?
i have changed it so the line is drawn under inactive tabs as well so its consistent with when tabs are not docked in the caption bar

Thanks for doing that.  I think it will look better that way.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on December 03, 2015, 08:11:15 PM
i dont understand what you want or how the picture relates to the question

for the 2nd part, skin developers already have control over the colours for file selection
Sorry. I meant the selection frame:
(http://s9.postimg.org/chpj194f3/image.gif)

In version 3 there is no selection frame:
(http://s14.postimg.org/glp7ipakx/image.gif)

This has already been reported:
I am unable to make a selection of tracks in any panel by dragging a rectangle over them with my mouse.

To clarify what I mean, selecting like this,

(http://www.computerhope.com/issues/pictures/drag-and-select.gif)

for the 2nd part, skin developers already have control over the colours for file selection
I meant the control over the colours for "selection frame".
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 03, 2015, 08:14:24 PM
yes i did implement that in v3 and was enabled in the early builds. But i really hated that feature and its mostly disabled, except it is still possible in the track details layout by selecting using the very left status column
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 03, 2015, 08:40:59 PM
While re-sizing compact player:
(http://i.imgur.com/YvNPoUls.jpg) (http://i.imgur.com/YvNPoUl.png)
do you still get the visual artifacts? the resized area should stay entirly black while resizing is being done

edit:
no need to answer - i can sort of reproduce this still
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 03, 2015, 09:03:20 PM
I'll just slip this link in here...
for when skinning items are on the go again:

you were once able to override the 'Cancel' and 'Wait Indicator' elements with
Code
<element id="Delete">CODE</element>
and
Code
<element id="Wait Indicator">CODE</element>

Could they please be re-activated.

in the hope they might be considered for MB3.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 03, 2015, 09:07:23 PM
the wait indicator is no longer included. I can do something with the cancel icon
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 03, 2015, 09:14:56 PM
the wait indicator is no longer included.

I've synced a couple of devices with MB3 and never noticed that.
Too subtle a change for me?  :D
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Sofocl on December 04, 2015, 03:54:04 AM
yes i did implement that in v3 and was enabled in the early builds. But i really hated that feature and its mostly disabled, except it is still possible in the track details layout by selecting using the very left status column
Sadly. Is there any chance that this feature will return? Does it make sense to post in the wishlist?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 04, 2015, 08:20:41 AM
do you still get the visual artifacts? the resized area should stay entirly black while resizing is being done
edit:
no need to answer - i can sort of reproduce this still

I already made the screenshots before I read your 'edit:', so I'll just post them anyway, maybe it's still helpful.

while enlarging:
(http://i.imgur.com/rXIbDNps.jpg) (http://i.imgur.com/rXIbDNp.png)

while reducing:
(http://i.imgur.com/ZoHeD7Is.jpg) (http://i.imgur.com/ZoHeD7I.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 04, 2015, 10:14:02 PM
I've noticed that the scroll bars in Preferences
General
Hotkeys
Library

are using the "Panel.ScrollBar." attributes, not the "Controls.ScrollBar." ones.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 05, 2015, 09:33:17 AM
there is one issue with several of the skins, which are showing red or sometimes other colours on the top left and top right borders. This is apparent only in MB 3. Iin earlier MB versions, that area was trimmed when displayed so the borders were curved. I cant do that anymore without causing other issues. If you are using windows 10 you wont see this because MB is adjusting the bitmap for the window borders to 1px and renders the window as a rectangle.
I can put in some handling that will cover most of the skins so the issue isnt to glaring (its still not ideal)
Going forward can the top left and right borders be designed on the assumption it will be square
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 05, 2015, 04:27:58 PM
you were once able to override the 'Cancel' and 'Wait Indicator' elements with
Code
<element id="Delete">CODE</element>
and
Code
<element id="Wait Indicator">CODE</element>

Could they please be re-activated.
i cant find any prior support for the delete icon but i have added an override for it:
<element id="DeleteIcon">...

I've noticed that the scroll bars in Preferences
General
Hotkeys
Library
are using the "Panel.ScrollBar." attributes, not the "Controls.ScrollBar." ones.
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mephisto on December 05, 2015, 05:18:39 PM
I'm using the tab diplay for lyrics, track info and artist biography.
Is there a way to rearrange the 'playing'/'selected' field in 3.0 to look like 2.5 (or at least have a better look) through a skin command, or is it defined by the program and cannot be changed?
current 3.0
(http://i.imgur.com/NvxCYK9.png)
2.5 version
(http://i.imgur.com/yXJpgkl.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 05, 2015, 06:28:52 PM
Just to let you know:
The biggest 'uglies' when enlarging/decreasing the compact player are now gone after the last update.
It's not completely elegant, and a little bit shaky, but nothing to complain about.

Only to give you an impression how it now looks on my system:

(http://i.imgur.com/Am4ekSGs.jpg) (http://i.imgur.com/Am4ekSG.gif)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 06, 2015, 02:34:49 AM
With progress bar in the middle:
If using the bg attribute of "PlayerTopFlat.DisplayPanel" so that it's different from "PlayerFlat.DisplayPanel" bg="xxx,xxx,xxx"
when moving the 'player controls' from the top panel to bottom panel, the bottom panel doesn't get repainted and keeps the PlayerTopFlat.DisplayPanel bg colour.

Moving bottom to top is the same.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 06, 2015, 08:21:09 AM
Could the currently existing <element id="DownloadsIcon"> override be used on the new download icon on the header bar, please?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 06, 2015, 09:02:00 AM
Could the currently existing <element id="DownloadsIcon"> override be used on the new download icon on the header bar, please?
i have added "DownloadIndicatorIcon" and "NotificationIcon"
however icons in the header bar are automatically re-coloured depending on whether the bar in docked in the caption bar or not
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 06, 2015, 12:59:03 PM
i have uploaded the changes
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 06, 2015, 01:08:59 PM
With bitmap skins, thinking in layers, when 'shuffle' and 'repeat' buttons are placed somewhere in the trackinfopanel, they will function.
But playing control buttons will not be responsive anymore when located somewhere where the trackinfopanel is also present.
Could the playing control buttons be pushed-up a layer so they are above the trackinfopanel?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 06, 2015, 09:52:11 PM
i have added "DownloadIndicatorIcon" and "NotificationIcon"

would it be possible to allow these items to also be .gif's
as they are not shown all the time, I thought a little movement would draw your eye to them when they are displayed

well the download indicator at least - I think the notification one already flashes when first displayed
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 07, 2015, 07:22:44 AM
When the menu bar is docked below the caption bar there is a small gap between the parent menu items and the drop down menus.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 07, 2015, 07:56:47 AM
These elements appear to be working now:

  <element id="NowPlayingList[TrackDetail].Default" bg="153,213,241" fg="0,0,0" />
  <element id="NowPlayingList[TrackDetail].Highlight" bg="82,83,176" fg="255,255,255" />
  <element id="NowPlayingList[TrackDetail].Lowlight" bg="27,160,225" fg="205,235,255" />
  <element id="NowPlayingList[TrackDetail].Disabled" fg="27,160,225" />
  <element id="NowPlayingList[TrackDetail].ListAlternating.Default" bg="153,213,241" fg="0,0,0" />
  <element id="NowPlayingList[TrackDetail].ListAlternating.Disabled" fg="27,160,225" />

These do not:

  <element id="NowPlayingList[TrackDetail].ListHeader" bg="27,160,225" fg="255,255,255" bdr="153,213,241" />
  <element id="NowPlayingList.ScrollBar" bg="27,160,225" />
  <element id="NowPlayingList.ScrollBarBackground" bg="153,213,241" bg2="177,222,243" /> 
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 07, 2015, 08:07:00 AM
A small request regarding tabs...

Tabs in the caption bar has its font set to a regular typeface when inactive, and bold when active. This is helpful because sometimes you might not want a highlight color, but you can still identify which tab is selected. With the regular tabs bar (below caption) however, all the tab headers are bold by default. I would appreciate a setting added to the skin xml to be able to change this behavior.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 09, 2015, 01:34:08 AM
The elements

<element id="Content[TrackDetail].ItemSeparatorLine" fg="xxx,xxx,xxx"/>
<element id="Content[AlbumAndTracks].ItemSeparatorLine" fg="xxx,xxx,xxx"/>

are not working in 3.0.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 09, 2015, 09:56:32 AM
Is this a bug? The formborder at the top of the window (titlebar) appears to be changing colors in some way.
I created a bitmap with a solid color (20,20,20), but after compiling the skin my eyedropper tool shows the color is actually 21,21,21.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 09, 2015, 11:46:32 AM
Is this a bug? The formborder at the top of the window (titlebar) appears to be changing colors in some way.
I created a bitmap with a solid color (20,20,20), but after compiling the skin my eyedropper tool shows the color is actually 21,21,21.
the caption bar can be stretched depending on your font and i guess that might cause a slight change in colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 10, 2015, 08:20:35 AM
A couple visual glitches I noticed recently. No idea what causes them, hopefully this screenshot will help.

(http://i.imgur.com/vjVz4c9m.jpg) (http://i.imgur.com/vjVz4c9.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 10, 2015, 08:22:49 AM
which skin is it, and if its your own could you upload it somewhere?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 10, 2015, 08:25:59 AM
which skin is it, and if its your own could you upload it somewhere?

A new skin I'm working on, it uses the default skin as a base. https://app.box.com/s/nmgkb3vixtohaeqehekqcoe6mgwcnfo8
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 10, 2015, 02:47:08 PM
This looks like it might also be a glitch.

Restarting MusicBee with the following configuration; menu set as a button and tabs located in the caption bar - results in this selection box being visible (highlighted items in the drop down menu), although it wasn't present before restarting (after the layout was configured).

Before restart:

(http://i.imgur.com/IhPjMsFm.jpg) (http://i.imgur.com/IhPjMsF.jpg)

After restart:

(http://i.imgur.com/4BJVh3Cm.jpg) (http://i.imgur.com/4BJVh3C.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 10, 2015, 03:10:06 PM
these glitches you are reporting sound very much like you are using 0 alpha for your colours. Can you check that?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 10, 2015, 04:32:15 PM
these glitches you are reporting sound very much like you are using 0 alpha for your colours. Can you check that?

Do you mean blank color values in the xml file? I checked and filled those in, but I am still seeing random pixels directly above the column browser, or at least it shows up when I switch tabs.

About my previous post - I'm really confused as to where these drop down menu highlight borders are coming from, I could use help.

Updated skin link: https://app.box.com/s/nmgkb3vixtohaeqehekqcoe6mgwcnfo8
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 10, 2015, 04:37:10 PM
Do you mean blank color values in the xml file? I checked and filled those in, but I am still seeing random pixels

Steven means elements that have an additional transparency value for that element. So e.g. "100,100,100,100" instead of "100,100,100"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 10, 2015, 04:41:40 PM
Steven means elements that have an additional transparency value for that element. So e.g. "100,100,100,100" instead of "100,100,100"

Oh. I didn't know it was possible to do that in the xml, I haven't done it for this skin.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 10, 2015, 04:45:44 PM
Well, not on purpose then. But could it perhaps be that there is either a typo, or a remaining transparency value from the skin that your skin might be based upon?

edit,

If you are using notepad++, you can find those easily doing a regex search.
Just enter: "\d+,\d+,\d+,\d+" in the search field.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 10, 2015, 06:01:53 PM
at least "Menu.DropDown.Highlight" has 0 alpha for the colour
its possible other elements are the same
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 10, 2015, 06:28:26 PM
id="Content[TrackDetail].ItemSeparatorLine" doesn't seem to work anymore in v3

And a minor issue that I remember also once showed up in v2 in the past.
When opening the configuration panel on a (very) dark skin, it opens with a short white 'flash'.

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 10, 2015, 06:31:22 PM
This looks like it might also be a glitch.

There seems to be something very wrong with that skin. When I open it with MB v2, MB crashes, and notepad opens with a very long error text.
Could there be something wrong with the images in it?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 10, 2015, 06:46:51 PM
id="Content[TrackDetail].ItemSeparatorLine" doesn't seem to work anymore in v3

And a minor issue that I remember also once showed up in v2 in the past.
When opening the configuration panel on a (very) dark skin, it opens with a short white 'flash'.
the first was reported the other day and should be fixed for the next update
for the 2nd i dont see it. Which dialog window does it happen in?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 10, 2015, 10:16:24 PM
<element id="Content[TrackDetail].ItemSeparatorLine" fg="xxx,xxx,xxx"/>
<element id="Content[AlbumAndTracks].ItemSeparatorLine" fg="xxx,xxx,xxx"/>
should be working now
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 10, 2015, 10:40:36 PM
should be working now

Yep. All fine.

Would it be possible to have on override for the line that also appears when using a grouping header in Track Detail view.
It's currently auto-generated by MB

EDIT
or auto-generate a much darker line higher contrast line rather than the slightly darker lightly contrasting line it currently does, please
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 11, 2015, 04:09:48 AM
If you are using notepad++, you can find those easily doing a regex search.
Just enter: "\d+,\d+,\d+,\d+" in the search field.

Thanks for the tip! I am using Notepad++.
I did the search exactly as you said, with no results. So I can say for sure my code has no 0 alpha colors.

at least "Menu.DropDown.Highlight" has 0 alpha for the colour
its possible other elements are the same


Here's what I have for that element:

Code
<element id="Menu.DropDown.Highlight" bg="20,20,20" bdr="20,20,20" />



There seems to be something very wrong with that skin. When I open it with MB v2, MB crashes, and notepad opens with a very long error text.
Could there be something wrong with the images in it?

No idea what the problem could be... I have only tested it in v3.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 11, 2015, 04:33:22 AM
Now Playing List overrides appear to be working now!

These elements don't show up:

<element id="UseArtworkBorders">true</element>
<element id="Controls.FaintLine" bg="143,189,39" />


I notice that in 3.0 some buttons appear to be active which aren't, such as the Configure buttons in Player Preferences.

And can we get rid of this line in Preferences that seems to be the wrong color?

(http://i.imgur.com/5rOA1eU.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 11, 2015, 07:47:30 AM
Here's what I have for that element:
Code
<element id="Menu.DropDown.Highlight" bg="20,20,20" bdr="20,20,20" />
can you send me the source xml file (i already have the xmlc file). Its defenitely reading that element with 0 alpha
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 11, 2015, 07:55:42 AM
can you send me the source xml file (i already have the xmlc file). Its defenitely reading that element with 0 alpha


Sure, sent to you.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 11, 2015, 08:13:03 AM
When opening the configuration panel on a (very) dark skin, it opens with a short white 'flash'.
for the 2nd i dont see it. Which dialog window does it happen in?

When opening the configuration panel.
But also when opening MB for a first time.
With e.g. the 'Sportura Pinstripe' skin it's very obvious here.
It's not happening always, but often enough to experience regularly.

edit:
This is the thread about the same happening on v2 before, which you were able to fix then:
http://getmusicbee.com/forum/index.php?topic=14746.msg87904#msg87904
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 11, 2015, 10:09:02 AM
When opening the configuration panel.
well thats what i tested a number of times and didnt see it. Of course machines/ windows setups can differ so produce different results but unless i can reproduce it then i cant fix it. Can anyone else confirm this "white flashing" when opening dialog windows on dark skins?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 11, 2015, 10:11:57 AM
Here's what I have for that element:
Code
<element id="Menu.DropDown.Highlight" bg="20,20,20" bdr="20,20,20" />
can you send me the source xml file (i already have the xmlc file). Its defenitely reading that element with 0 alpha
i had a look at the source file you sent, and compiled it. The menu element was fine with that one and couldnt reproduce the glitching i was able to reproduce before
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 11, 2015, 10:37:22 AM
i had a look at the source file you sent, and compiled it. The menu element was fine with that one and couldnt reproduce the glitching i was able to reproduce before

Edit: Ok I think this might clear things up.

Code
<element id="Menu.DropDown.Highlight" bg="20,20,20" bdr="0,0,0" />

This line of code creates a border with the intended color: 0,0,0.

Code
<element id="Menu.DropDown.Highlight" bg="20,20,20" bdr="20,20,20" />

This line of code creates a border with an unintentional color: 120,120,120.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 11, 2015, 11:28:25 AM
the border colour needs to be different. There is some backwards compatibility where if its the same as the background color then the border colour is set elsewhere
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 11, 2015, 11:57:53 AM
the border colour needs to be different. There is some backwards compatibility where if its the same as the background color then the border colour is set elsewhere

Oh I see. Is there an override available, or should I just pick a different color?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 11, 2015, 12:27:38 PM
<element id="UseArtworkBorders">true</element>
thats working for me (checked in the artwork layout), including with the released version of your mellon remix skin. In what context do you find it not working?
the other items are fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 11, 2015, 06:55:10 PM
fixes for the above issues
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on December 12, 2015, 12:44:28 PM
With the full release of 3.0 coming soon, I wonder what will happen with the skins bundled with the installer?
It's possible some of the older skins might be incompatible with the new version, and there's also several new skins that could be included.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 12, 2015, 03:01:13 PM
its definitely the case that some skins dont work so well with the new version. I have contacted a couple of the people who developed the skins that havent been active but no reply so far. I think we should give it a month or so because MB3 will be in beta for a while anyway
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 14, 2015, 05:43:25 AM
Would it be possible to have on override for the line that also appears when using a grouping header in Track Detail view.
It's currently auto-generated by MB

EDIT
or auto-generate a much darker line higher contrast line rather than the slightly darker lightly contrasting line it currently does, please

thinking more on this, I think the override element would be the better way to go
maybe:
<element id="Content[TrackDetail].HeaderLine" fg="xxx,xxx,xxx" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 14, 2015, 06:45:46 AM
thinking more on this, I think the override element would be the better way to go
maybe:
<element id="Content[TrackDetail].HeaderLine" fg="xxx,xxx,xxx" />
yes i will add that
edit:
its done for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 14, 2015, 03:17:19 PM
Now Playing List overrides appear to be working now!

These elements don't show up:

<element id="UseArtworkBorders">true</element>
<element id="Controls.FaintLine" bg="143,189,39" />


I notice that in 3.0 some buttons appear to be active which aren't, such as the Configure buttons in Player Preferences.

And can we get rid of this line in Preferences that seems to be the wrong color?

All of these are resolved now except the Artwork Borders.  I can get your screenshots later, but they're not showing up anywhere for me: Artwork, Album & Tracks, Track Info panel, etc.  Do you want my updated skin file?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 14, 2015, 06:38:49 PM
Do you want my updated skin file?
yes thanks. As mentioned i believe it should be working so a screenshot showing it missing might help

edit:
okay, it is missing from the album and tracks layout so i will do that. For the artwork in track details; for artwork in the now playing list using the Thumbnail layout; and artwork in the thumb browser, that border wasnt used in v2.5 - it was done using a auto-generated light colour as in v3
also the actual colour used is:  Controls.ArtworkFrame cdr=xxxx
(i cant remember why i put the extra UseArtworkBorders = true as a requirement)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 14, 2015, 08:51:50 PM
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe

changes as described above
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 14, 2015, 10:25:19 PM
okay, it is missing from the album and tracks layout so i will do that

It was also used on the artwork in the RH Track Information/Now Playing panel when it was displayed
Not fixed for that scenario.



<element id="Content[TrackDetail].HeaderLine" bg="xxx,xxx,xxx" />
is working fine.  Thank you very much :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 15, 2015, 07:52:45 PM
the border attribute of
<element id="CaptionBar.SearchBox.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
is not being recognised in 3.0

could a bg attribute be added to
<element id="Controls.SearchBox.Lowlight" />
and
<element id="CaptionBar.SearchBox.Lowlight" />

and then I wouldn't need the bdr attribute of the first element :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 17, 2015, 04:55:09 AM
The artwork border is showing up in Album & Tracks now. (Sorry for the delay, life has been very distracting lately...)

In the track info panel, it shows up at the top and left, but not at the bottom and right:

(http://i.imgur.com/oFDfIBm.png)

You probably don't need it anymore, but here's the skin file: https://app.box.com/s/fca2dsy99q7uw1zdosgqhmizhh2w2fk3
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 17, 2015, 06:49:30 AM
Are there/will there be overrides for the header bars in Music Explorer?

The "search" hint still shows as plain black text in the caption bar, it doesn't take the skin colors.  It's okay below the caption bar.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 17, 2015, 10:07:30 PM
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe

- fixes for the above
- for the music explorer there are quite a few colours involved even though it all looks the similar. How strongly do you feel about it?
- <element id="Controls.SearchBox.Lowlight" />and <element id="CaptionBar.SearchBox.Lowlight" /> - i dont really understand what you are looking to acheive and lowlight attribute only affects the text and not the remaining textbox area
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 17, 2015, 11:59:45 PM
<element id="Controls.SearchBox.Lowlight" />and <element id="CaptionBar.SearchBox.Lowlight" /> - i dont really understand what you are looking to acheive and lowlight attribute only affects the text and not the remaining textbox area

I'm trying to get a way to delineate the search box when it's in use.

With the border attribute of <element id="CaptionBar.SearchBox.Default"/> working again (thank you very much for that BTW) I can get this:

Lowlight
(http://i.imgur.com/bqlfgUJ.jpg)

Default
(http://i.imgur.com/p1AfeCf.jpg)

but I think the border doesn't work very well with the MB3 design.

So, with a bg attribute for <element id="Controls.SearchBox.Lowlight" /> and <element id="CaptionBar.SearchBox.Lowlight" /> I could achieve this:

Lowlight
(http://i.imgur.com/rQzvmjN.jpg)

Default
(http://i.imgur.com/34Jyn21.jpg)

Something that fits in with MB3 style.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 19, 2015, 01:10:55 PM
http://www.mediafire.com/download/yg2iu46j3binune/MusicBeeDemo.zip

unzip into the musicbee application folder and run MusicBee3.exe

i have added
  <element id="CaptionBar.SearchBox.NotActivated" bg="10,245,0" bdr="255,0,0" />
  <element id="Panel.SearchBox.NotActivated" bg="240,0,0" bdr="0,0,255" />
and also a column browser override. If not provided it falls back to the FilterPanel... elements, and if that is not provided then the main panel elements (as with v2.5)
  <element id="ColumnBrowser.ListHeader" bg="252,252,252" bg2="248,248,248" fg="0,0,0" bdr="225,225,225" />
  <element id="ColumnBrowser.Default" bg="253,253,253" fg="0,0,0" />
  <element id="ColumnBrowser.ListAlternating.Default" bg="253,253,253" fg="0,0,0" />
  <element id="ColumnBrowser.Highlight" bg="245,236,172" bdr="227,216,152" fg="0,0,0" />
  <element id="ColumnBrowser.Lowlight" bg="232,232,232" fg="0,0,0" bdr="225,225,225" />
  <element id="ColumnBrowser.ScrollBar" bg="150,150,150" bg2="130,130,130" bdr="0,0,0" />
  <element id="ColumnBrowser.ScrollBarBackground" bg="253,253,253" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 19, 2015, 06:47:01 PM
i have added
  <element id="CaptionBar.SearchBox.NotActivated" bg="10,245,0" bdr="255,0,0" />
  <element id="Panel.SearchBox.NotActivated" bg="240,0,0" bdr="0,0,255" />

just had a quick trial of these - looks good!
greatly appreciated. :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 20, 2015, 01:17:36 AM
i have added
  <element id="CaptionBar.SearchBox.NotActivated" bg="10,245,0" bdr="255,0,0" />
  <element id="Panel.SearchBox.NotActivated" bg="240,0,0" bdr="0,0,255" />

just had a quick trial of these - looks good!
greatly appreciated. :)

think this looks even better than I thought it would
just a few minor teething troubles:

- when in caption bar, search close/clear button is not using CaptionBar.SearchBox.Default attributes
  still using .NotActivated colours
  works fine when below caption bar

- after close/clear search button is used,  active colours are still shown
  new .NotActivated colours are not repainted on area
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 20, 2015, 01:36:12 PM
The border elements in the column browser don't seem to respect the id="FilterPanel.Disabled" settings.

Sportura Pinstripe skin in v2:

(http://i.imgur.com/f7Lpe9cl.jpg) (http://i.imgur.com/f7Lpe9c.png)

and in v3:

(http://i.imgur.com/wCPaqn3l.jpg) (http://i.imgur.com/wCPaqn3.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 20, 2015, 03:00:19 PM
The border elements in the column browser don't seem to respect the id="FilterPanel.Disabled" settings.
using the skin you posted on nov 29, it works fine for me. Can you confirm you are using the lastest MB version and the same skin?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 20, 2015, 03:15:11 PM
Apologies, it seems I was a few versions behind. It's fine indeed with the latest version.
(you are working too fast!)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 20, 2015, 03:58:29 PM
- when in caption bar, search close/clear button is not using CaptionBar.SearchBox.Default attributes
  still using .NotActivated colours
  works fine when below caption bar

- after close/clear search button is used,  active colours are still shown
  new .NotActivated colours are not repainted on area
the search reset button is fixed
for the 2nd point, the colours are only used when the "search" prompt is showing. Once the search box is used, it stays with the activated colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 20, 2015, 09:19:09 PM
the search reset button is fixed

thank you

for the 2nd point, the colours are only used when the "search" prompt is showing. Once the search box is used, it stays with the activated colours

OK. Thanks for the clarification.
 I thought it would be like the search box on Library Explorer and close completely, returning to the .NotActivated colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 21, 2015, 10:35:14 AM
Have found with some skins it's hard to pick a fg colour that works on the player progress bar when used bottom/top and middle.
Perhaps a fg attribute for <element id="PlayerFlat.ProgressBarMiddle" /> ?

There is also no PlayerTopFlat. equivalents for:
<element id="PlayerFlat.ProgressBarMiddle" bg="xxx,xxx,xxx" />
<element id="PlayerFlat.NotLovedIcon" fg="xxx,xxx,xxx" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 21, 2015, 02:50:09 PM
@Steven,

If I recall correct, you mentioned a while back that for new skins it is preferred not to use transparency for the top border elements anymore.

Since you had quite some challenges with borders in W10, are there other aspects relating to creating border elements for new skins to be taken into account?
For example, should the sizes of the border elements be different than before? Is there an effect on these elements between them displaying differently between full-screen vs minimized?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 22, 2015, 06:09:39 PM
Since you had quite some challenges with borders in W10, are there other aspects relating to creating border elements for new skins to be taken into account?
For example, should the sizes of the border elements be different than before? Is there an effect on these elements between them displaying differently between full-screen vs minimized?
transparency should be handled - i made some changes a while ago.
For the win10 borders, just be aware the way its handled is MB uses the outer-most pixel for the frame bitmaps. However they should still be set to the current sizes because windows 7-8 still need to be handled.
Maximisation should need no special consideration
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 22, 2015, 06:20:51 PM
Have found with some skins it's hard to pick a fg colour that works on the player progress bar when used bottom/top and middle.
Perhaps a fg attribute for <element id="PlayerFlat.ProgressBarMiddle" /> ?

There is also no PlayerTopFlat. equivalents for:
<element id="PlayerFlat.ProgressBarMiddle" bg="xxx,xxx,xxx" />
<element id="PlayerFlat.NotLovedIcon" fg="xxx,xxx,xxx" />
i have put in PlayerFlat.ProgressBarMiddle and PlayerFlat.NotLovedIcon (not tested)
for the progress bar, hopefully it will work without the extra element
the way it works is if that element is not supplied (which would have been the case before this change for docked at top) then MB defaults to an automatically generated colour
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 23, 2015, 01:08:35 AM
Player(Top)Flat.NotLovedIcon (not tested)

Yep. Not working yet :(

PlayerTopFlat.ProgressBarMiddle, on the other hand, is working fine :)

for the progress bar, hopefully it will work without the extra element

I personally think a FG attribute is needed for both
<element id="PlayerFlat.ProgressBarMiddle" />
<element id="PlayerTopFlat.ProgressBarMiddle" />
for some of the more difficult skin colour combos, but I can live without it.
I'm trying not to add too much to the 3.0 workload.

Also found that the thumbnail browser is not using the .ScrollBarBackground attributes from Panel settings or from FilterPanel overrides (when used)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 23, 2015, 07:20:04 AM
Also found that the thumbnail browser is not using the .ScrollBarBackground attributes from Panel settings or from FilterPanel overrides (when used)
yes i am aware of this one and still trying to get it right with the metro skins which are using transparency on the colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 23, 2015, 08:52:10 PM
this issue should be addressed in the latest update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 26, 2015, 03:55:15 PM
for scrollbars i have added support for lowlighting inactive scrollbar sliders ie. the lowlight colours will show unless you click on the slider and drag it
Panel.ScrollBar.Lowlight
LeftNavigator.ScrollBar.Lowlight
Panel.ChildBody.ScrollBar.Lowlight
FilterPanel.ScrollBar.Lowlight
ColumnBrowser.ScrollBar.Lowlight
Content[Artwork].ScrollBar.Lowlight

if you only want the lowlight colours to apply to narrow scrollbars eg. you only want the narrow scrollbars to be more blended into the background
  <element id="ScrollBarLowlightNarrowOnly">true</element>

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

unzip into the musicbee application folder and run MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 03:38:47 PM
For v3, the fg value of  id="Controls.Button.Disabled" is ignored.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 27, 2015, 05:04:09 PM
For v3, the fg value of  id="Controls.Button.Disabled" is ignored.
its working ok in the places i check eg. auto-dj panel
where are you looking?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 05:04:30 PM
A request for an element for the check-marks in the drop-down menu.

(http://i.imgur.com/nGY13t0l.jpg) (http://i.imgur.com/nGY13t0.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 05:08:04 PM
For v3, the fg value of  id="Controls.Button.Disabled" is ignored.
its working ok in the places i check eg. auto-dj panel
where are you looking?

At this location 'Configure' should have the color for disabled:
(http://i.imgur.com/XRkjwWns.jpg) (http://i.imgur.com/XRkjwWn.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 27, 2015, 05:29:41 PM
At this location 'Configure' should have the color for disabled:
thats also fine for me. If thats the only one then there is more likely to be some issue with it being incorrectly enabled rather than the skin

for the tick image colour skin request, for the next update i have added:
<element id="Menu.DropDownCheckBoxImage" fg="210,10,120" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 27, 2015, 05:47:32 PM
I'm seeing this little glitch on all my pop-up windows:

(http://i.imgur.com/8OkyYuR.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 05:50:15 PM
A request for an element for these 'disabled' texts:

(http://i.imgur.com/rsM6wNqs.jpg) (http://i.imgur.com/rsM6wNq.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 05:55:25 PM
thats also fine for me. If thats the only one then there is more likely to be some issue with it being incorrectly enabled rather than the skin

Then it's indeed probably a funny little glitch from having tried out a Winamp plugin shortly in the past.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 06:11:53 PM
A request for an element for these arrows showing in the Album auto-tagger panel:

(http://i.imgur.com/v8hDsRHl.jpg) (http://i.imgur.com/v8hDsRH.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 27, 2015, 06:30:55 PM
I'm seeing this little glitch on all my pop-up windows:
its ok for me using you v3 skin from dec 17
as a guess for the issue, make sure the control box images are 15px high
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 27, 2015, 06:32:20 PM
By control box do you mean the border images?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 27, 2015, 06:41:00 PM
min/ max/ close
also i suggest you use transparent colours to fill those images so there arent minor discrepancies with the rest of the caption bar as is the case now
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 06:43:38 PM
By control box do you mean the border images?

I believe your images are at 72dpi, while they should be at 96dpi.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 27, 2015, 06:51:22 PM
By control box do you mean the border images?

I believe your images are at 72dpi, while they should be at 96dpi.

That's probably it.  I'll fiddle with them later, thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 27, 2015, 06:52:01 PM
In the configuration screen for album and tracks (if it matters, I'm running at 125% scaling):

(http://i.imgur.com/Ie94BZm.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 08:36:43 PM
From a skinning perspective, I always assumed 'filterpanel' was the same as the 'column browser panel', since the settings made there were reflected in the column browser.
Looking at some new elements I now understand there is actually also a panel named 'filter panel'.

I'm probably in a Homer Simpson state of mind, but where do I find this filter panel?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 08:48:00 PM
for scrollbars i have added support for lowlighting inactive scrollbar sliders ie. the lowlight colours will show unless you click on the slider and drag it

With all due respect, testing this out, I don't see a big use for this in the current state.
The lowlight color determines the visibility of the scrollbar and where you can 'grab' it.
Only after you 'managed' that, the color changes to highlight. I honestly don't see a big advantage in that.

An idea coming up, is that this could be a lot more useful if the state would go from lowlight to highlight, as soon as your mouse enters the corresponding pane.
Then by default the scrollbars could be unobtrusive lowlight (or theoretically even invisible), and become clearly visible and grabbable at hover-over.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 27, 2015, 09:02:57 PM
the scrollbars are done in the way iTunes does. Personally i cant stand the way windows flashes the scrollbars when you mouse over and much prefer the iTunes approach.
Even if you dont agree with that, the lowlight in combnation with the new scrollbar ScrollBarLowlightNarrowOnly setting is still useful if you only want to blend scrollbars more into the panel when configured using narrow scrollbars
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 27, 2015, 09:12:17 PM
the scrollbars are done in the way iTunes does. Personally i cant stand the way windows flashes the scrollbars when you mouse over and much prefer the iTunes approach.

I believe I am familiar with neither of those.
When installing Windows, one of the very first things I always do is disabling almost all 'visual effects'.

I was honestly wondering what the possible benefit was of having the scrollbar lit up, after you had already grabbed it.
No discussion here. Different folks, different strokes.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 27, 2015, 09:19:15 PM
when the scrollbar is dimmed and blended into the background then restoring it to a stronger colour while dragging is helpful for positioning
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 28, 2015, 05:52:33 AM
unless you provide an override with the id="FilterPanel. elements,
the Thumbnail browser still uses the panel background colours for the scrollbar background
rather than
<element id="Panel.ScrollBarBackground.Default" bg="xxx,xxx,xxx" bg2="xxx,xxx,xxx"/>
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 28, 2015, 08:29:49 AM
unless you provide an override with the id="FilterPanel. elements,
the Thumbnail browser still uses the panel background colours for the scrollbar background
rather than
<element id="Panel.ScrollBarBackground.Default" bg="xxx,xxx,xxx" bg2="xxx,xxx,xxx"/>
while i agree the logic is flawed, can you give me a skin which behaves differently to that for v2.5 so i can check what is going on?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 28, 2015, 09:15:16 AM
while i agree the logic is flawed, can you give me a skin which behaves differently to that for v2.5 so i can check what is going on?

Have a look at AeroBee
in 2.5 the thumbnail browser [TB] can only be placed in the main panel, and uses the same scrollbar background as the rest of the panels scrollbars

in 3.0 the TB can be in the left sidebar or left main panel.
in both cases, the TB uses the bg colour from
<element id="Content[TrackDetail].ListAlternating.Default" bg="45,68,91" fg="255,255,255" />
as the scrollbar bg
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 28, 2015, 01:02:57 PM
yep, seems i still didnt have it quite right. It should be working consistently with v2.5 for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 28, 2015, 07:44:29 PM
A request for an element for these 'disabled' texts:

(http://i.imgur.com/rsM6wNqs.jpg) (http://i.imgur.com/rsM6wNq.png)
these are the standard text box colours
Controls.InputControl.Default
Controls.InputControl.Disabled

i would rather not create exceptions unless there is a very good reason
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 28, 2015, 08:22:56 PM
A request for an element for these arrows showing in the Album auto-tagger panel:

(http://i.imgur.com/v8hDsRHl.jpg) (http://i.imgur.com/v8hDsRH.png)
this is now supported for enabled arrows. However when disabled, its coloured gray by windows

Controls.Arrow.Default fg=XXXX
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 28, 2015, 09:06:09 PM
A request for an element for these 'disabled' texts:

(http://i.imgur.com/rsM6wNqs.jpg) (http://i.imgur.com/rsM6wNq.png)
these are the standard text box colours
Controls.InputControl.Default
Controls.InputControl.Disabled

i would rather not create exceptions unless there is a very good reason

In that case there is something wrong there. I tried several skins, both under v2 and v3, and all display these fields in "109,109,109". The elements you mention don't seem to have control over this.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 28, 2015, 09:26:09 PM
it looks like windows is overriding the disabled colours but this works around that:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 28, 2015, 09:28:07 PM
yep, seems i still didnt have it quite right. It should be working consistently with v2.5 for the next update

working perfectly! Thanks for the hard work :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 28, 2015, 09:53:29 PM
it looks like windows is overriding the disabled colours but this works around that:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

That indeed seems to fix it for v3. (v2 still has it)
How dare Windows interfere with our beautiful coloring schemes.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 03:46:42 PM
it looks like windows is overriding the disabled colours but this works around that:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

Probably a similar issue. In all skins these texts are now "0,0,0"

(http://i.imgur.com/P0wy4tKl.jpg) (http://i.imgur.com/P0wy4tK.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 05:13:50 PM
The highlight border in track details shows only on top of the line, not on the bottom.

(http://i.imgur.com/S5JEwV0l.jpg) (http://i.imgur.com/S5JEwV0.png)


edit:
This is in Album and Tracks view. In Track Details view it's o.k.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 05:51:17 PM
Request: an override for the 'missing album art' image in the thumbnail browser.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 06:14:18 PM
The bdr element for id="Controls.Button.Highlight" doesn't work.

I believe this was the same with v2.
If it's by design, please add it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 29, 2015, 07:41:56 PM
The highlight border in track details shows only on top of the line, not on the bottom.
would you mind sending the skin so far
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 29, 2015, 07:53:46 PM
The bdr element for id="Controls.Button.Highlight" doesn't work.
where are you checking this? its working fine for me
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 08:09:35 PM
would you mind sending the skin so far

pm send
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 08:11:55 PM
In the Preferences panel.
(in the skin I send you) 'Apply, save, close' don't seem to respect the bdr value of:  id="Controls.Button.Highlight"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 29, 2015, 08:28:07 PM
In the Preferences panel.
(in the skin I send you) 'Apply, save, close' don't seem to respect the bdr value of:  id="Controls.Button.Highlight"
yes you are right - i missed the bit about the bdr attribute
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on December 29, 2015, 08:37:57 PM
Should the Apply button in the tag editor have a "lowlight" cover with there's nothing to apply?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 29, 2015, 08:51:16 PM
Should the Apply button in the tag editor have a "lowlight" cover with there's nothing to apply?
thats a good idea but not a trivial change as it would require recording any change made (the Close button should also change to Cancel), so i doubt i will do it at least for now
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 29, 2015, 08:59:57 PM
fixes for the above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 09:12:47 PM
The highlight border in track details shows only on top of the line, not on the bottom.

(http://i.imgur.com/S5JEwV0l.jpg) (http://i.imgur.com/S5JEwV0.png)

edit:
This is in Album and Tracks view. In Track Details view it's o.k.

Confirming that it's now fixed for 'Highlight', but not yet for 'Lowlight'.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 09:33:02 PM
Is there an overrule for these alert icons?
If not, this is a request for it.

(http://i.imgur.com/txOd1ecl.jpg) (http://i.imgur.com/txOd1ec.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 09:52:23 PM
this is now supported for enabled arrows. However when disabled, its coloured gray by windows

Confirming that it's working.
A pity 'disabled' is 'windows grey'.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 29, 2015, 10:09:22 PM
Not a request, nor a complaint, only an observation:
<element id="FullNodeSelect">true</element> doesn't seem to do anything in v3.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 30, 2015, 09:13:42 AM
i added "AlertIcon" to override the alert icon image
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 30, 2015, 10:26:44 AM
with regards to the scrollbar default/lowlight elements
if it's not too difficult could you please implement
<element id="ScrollBarBorderNarrowOnly">true</element>
so if you have
<element id="ScrollbarNoArrows">true</element> active
the border attribute will only show when narrow scrollbars are used



for podcasts you have already added
<element id="Controls.SubscriptionCounter" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="Controls.EpisodeNotPlayed bg="xxx,xxx,xxx" />

would <element id="Controls.EpisodeDownloading" bg="xxx,xxx,xxx" />
be possible for the little blue arrow in front of the episode/s that is downloading
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 30, 2015, 12:07:35 PM
i added "AlertIcon" to override the alert icon image

Would it be possible to have alert icons at other locations using that image too?

(http://i.imgur.com/z3Y7318l.jpg) (http://i.imgur.com/z3Y7318.png)

(http://i.imgur.com/tSGmmtil.jpg) (http://i.imgur.com/tSGmmti.png)

And there are probable a few more.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 30, 2015, 06:39:55 PM
If I am correct:  <element id="PlaylistManagerIcon">  was added recently.
But I can't get it showing up.
Is 16x16 correct? Do I have the name right?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on December 30, 2015, 06:43:40 PM
Would it be possible to have alert icons at other locations using that image too?
no - these are different and i have used the windows implementation

If I am correct:  <element id="PlaylistManagerIcon">  was added recently.
its "PlaylistDirectoryIcon"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 30, 2015, 06:49:16 PM
its "PlaylistDirectoryIcon"

Great, thnx.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on December 30, 2015, 07:36:43 PM
A tiny overlap over the text here:
(album auto-tagger)

(http://i.imgur.com/TWnDiYml.jpg) (http://i.imgur.com/TWnDiYm.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on December 30, 2015, 08:46:03 PM
At the bottom of the Tag Editor there are left and right arrows in the lower left corner and "save" and "close" buttons in the lower right.
I have determined that they are both the same element (Controls.Button.Highlight) but changing the highlight fg and bdr only changes the text and border in the save and close buttons.  While the bdr does indeed change for the left and right arrows, the fg color doesn't.  Is this intentional?  Can we get an override?  Or a new element?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on December 31, 2015, 08:28:09 AM
in compact player
when using the standard progress bar and "Draw Controls on Picture" is activated I can see that MB now uses only the fg attribute from "Compact.Player.ProgressBar" and creates a translucent colour from the bg attribute.  This looks good.

but
when "Draw Controls on Picture" is not being used the bg colour is not being restored and the translucent effect is still active.
wouldn't be too bad if Compact.Player.ProgressButton could be used
but that override is currently being ignored :(
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 01, 2016, 06:31:12 AM
with preferences panel:

fg attribute of <element id="Controls.Button.Disabled" is not working in 3.0;

when using of the dropdown menus the "Controls.InputControl.Lowlight" colours are used to highlight an item on mouse-over
"Controls.InputControl.Highlight" colours are only used when an item is selected.

Is this an intentional change from 2.5 where highlight colour is used for mouse-over and selection?
If so, could you change it so highlight is used for mouse-over and selection and lowlight persists on an item after it is selected.
Same way as the Hotkeys panel works.


Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 01, 2016, 09:43:24 AM
when using of the dropdown menus the "Controls.InputControl.Lowlight" colours are used to highlight an item on mouse-over
"Controls.InputControl.Highlight" colours are only used when an item is selected.

Is this an intentional change from 2.5 where highlight colour is used for mouse-over and selection?
If so, could you change it so highlight is used for mouse-over and selection and lowlight persists on an item after it is selected.
Same way as the Hotkeys panel works.
would you mind posting a screenshot for both of these and let me know the skin you are using as i am not sure what you mean with these
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 01, 2016, 10:15:05 AM
Where do these header titles and check ticks get there color from?
(In all skins I checked they are a variation of grey)
If there are no elements for them, can they be added?

(http://i.imgur.com/MEt3Bwil.jpg) (http://i.imgur.com/MEt3Bwi.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 01, 2016, 10:16:04 AM
This panel has blue Windows borders on the right and at the bottom.

(http://i.imgur.com/rGie3YZl.jpg) (http://i.imgur.com/rGie3YZ.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 01, 2016, 10:17:31 AM
The Tag Editor panel has 'up' and 'down' buttons.
I don't understand what their function is. You can select a tag, and then position it up or down with these buttons. But why? Also any re-ordering is not saved.
Am I missing something here?

Also, the panel has maximize and minimize buttons.
While I would love it if it was possible to increase the height of the Tag Editor panel, these buttons are probably not intended to be there.

And third, this panel, and others get a thin blue border when in focus, which dissapears when focus is lost.
That's probably a Windows 10 thing, but if possible it would be nice to get rid of that.

(http://i.imgur.com/TdFZaoFl.jpg) (http://i.imgur.com/TdFZaoF.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 01, 2016, 10:18:08 AM
"MiniPlayerLastFmLoveBright"
"LastFmLoveBright"
"PlayerLastFmLoveBright"

Don't seem to work anymore.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 01, 2016, 11:07:10 AM
would you mind posting a screenshot for both of these and let me know the skin you are using as i am not sure what you mean with these

using AeroBee for demonstration:

2.5
(http://i.imgur.com/e1aeNmB.gif) (http://imgur.com/e1aeNmB)
highlight colours appear on mouse-over and selection
lowlight colours shown on Hotkeys tab

3.0
(http://i.imgur.com/WnKr9KR.gif) (http://imgur.com/WnKr9KR)
lowlight colours appear on mouse-over
highlight colours appear and persist on selection

with both versions on Hotkeys tab:
the lowlight colours persist for last selection and highlight only shows on left-click of selection
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on January 01, 2016, 01:31:16 PM
The Tag Editor panel has 'up' and 'down' buttons.
I don't understand what their function is. You can select a tag, and then position it up or down with these buttons. But why? Also any re-ordering is not saved.
Am I missing something here?
I think you're referring to the up/down arrows in the Tag Inspector as the Tag Editor arrows are left/right.
Their function, as far as I can tell, is similar to the left/right arrows in the Tag Editor.  That is to move from one tag to the next when in the Inspector.  Select a tag, click the down arrow and the selection moves down one line.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 01, 2016, 02:07:21 PM
The Tag Editor panel has 'up' and 'down' buttons.
I don't understand what their function is. You can select a tag, and then position it up or down with these buttons. But why? Also any re-ordering is not saved.
Am I missing something here?
I think you're referring to the up/down arrows in the Tag Inspector as the Tag Editor arrows are left/right.
Their function, as far as I can tell, is similar to the left/right arrows in the Tag Editor.  That is to move from one tag to the next when in the Inspector.  Select a tag, click the down arrow and the selection moves down one line.

Yes you are right, I meant the Tag Editor.

If it would work as you describe, I could see some use for that.
But it currently relocates the line itself up or down.
That's probably a bug then?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on January 01, 2016, 02:41:46 PM
Yes you are right, I meant the Tag Editor.
You did it again.
You mean the Tag Inspector. 
(Still recovering from last night, perhaps?)

Quote
If it would work as you describe, I could see some use for that.
But it currently relocates the line itself up or down.
That's probably a bug then?
Hmmm ... I didn't even notice that behavior.  And it currently behaves like that in 2.5 also.
Yes, I would agree that the behavior is probably not what's intended and therefore a bug.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on January 01, 2016, 02:57:05 PM
The Tag Editor panel has 'up' and 'down' buttons.
I don't understand what their function is. You can select a tag, and then position it up or down with these buttons. But why? Also any re-ordering is not saved.
Am I missing something here?

That was a change I requested a long time ago to try to deal with inconsistent order of tags with multiple values.  But it only works for one file at a time, using it on multiple files doesn't work. So it's never been add helpful as I had hoped.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 01, 2016, 03:08:37 PM
You did it again.
You mean the Tag Inspector. 
(Still recovering from last night, perhaps?)

The recovering will hopefully occur tomorrow ;-)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 01, 2016, 08:02:54 PM
still on the Preferences panel

when using narrow scrollbars option, the scrollbar background is coming from
"Panel.Body.Default"
not from the bg attribute of
"Controls.InputControl.Default"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 02, 2016, 04:23:15 AM
the elements
"Controls.LockedInputControl.Default"
"Controls.LockedInputControl.Disabled"
aren't having any effect in 3.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 02, 2016, 02:31:10 PM
2.5
highlight colours appear on mouse-over and selection
lowlight colours shown on Hotkeys tab

3.0
lowlight colours appear on mouse-over
highlight colours appear and persist on selection

with both versions on Hotkeys tab:
the lowlight colours persist for last selection and highlight only shows on left-click of selection
i have made the combo box highlight the same as v2.5
For the hotkeys panel, in both versions the hotkeys grid (should) always lose focus to the key input box and not be active
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 02, 2016, 03:16:49 PM
From a skinning perspective, I always assumed 'filterpanel' was the same as the 'column browser panel', since the settings made there were reflected in the column browser.
Looking at some new elements I now understand there is actually also a panel named 'filter panel'.

I'm probably in a Homer Simpson state of mind, but where do I find this filter panel?

Bump

I am still wondering where filterpanel differs from column browser.
In what other location than the column browser panel does this have effect?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 02, 2016, 03:42:32 PM
filterpanel covers both the thumb browser and column browser.
Recently i added an override just for column browser which will get used for the column browser as first preference. If its missing then filter panel is used. And if thats missing then child panel will be used
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 02, 2016, 03:57:20 PM
filterpanel covers both the thumb browser and column browser.
Recently i added an override just for column browser which will get used for the column browser as first preference. If its missing then filter panel is used. And if thats missing then child panel will be used

Ah thnx. The thumb browser kinda ducked my radar.
I couldn't just now even figure out why the thumbnail browser didn't show at all in my setup, even while it was placed correctly in the config panel.
After some investigating I noticed it was disabled for the current tab.

That setting is kind off hidden by the way.
Maybe it would be a better option to instead of collapsing those settings out of view as it is now, to have them showing always, but in some 'disabled' coloring when inactive?

(http://i.imgur.com/rgBKIpul.jpg) (http://i.imgur.com/rgBKIpu.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 02, 2016, 04:27:25 PM
Request:
Overrides for these two:

(http://i.imgur.com/9LUjFM7l.jpg) (http://i.imgur.com/9LUjFM7.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 02, 2016, 04:54:10 PM
Where do these header titles and check ticks get there color from?
(In all skins I checked they are a variation of grey)
If there are no elements for them, can they be added?
the header is auto-generated
i have added::
Menu.Header bg= fg=
for the tick box, i will change it to use the recently included "Menu.DropDownCheckBoxImage" value
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 02, 2016, 05:02:58 PM
This panel has blue Windows borders on the right and at the bottom.
that should be fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 02, 2016, 06:34:49 PM
I couldn't just now even figure out why the thumbnail browser didn't show at all in my setup, even while it was placed correctly in the config panel.
After some investigating I noticed it was disabled for the current tab.
the expected behavior is when the thumb or column browser are hidden for a tab, that panel of settings should show, so i am not sure why it wouldnt have shown in your case
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 02, 2016, 07:01:56 PM
the expected behavior is when the thumb or column browser are hidden for a tab, that panel of settings should show, so i am not sure why it wouldnt have shown in your case

I'll try to keep an eye on it, and see if I can perhaps replicate it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 02, 2016, 08:18:49 PM
Request:
Overrides for these two:

(http://i.imgur.com/9LUjFM7l.jpg) (http://i.imgur.com/9LUjFM7.png)

The Artist one can already be replaced by
<element id="UnknownArtist">
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on January 02, 2016, 08:35:48 PM
Did this get overlooked? 

At the bottom of the Tag Editor there are left and right arrows in the lower left corner and "save" and "close" buttons in the lower right.
I have determined that they are both the same element (Controls.Button.Highlight) but changing the highlight fg and bdr only changes the text and border in the save and close buttons.  While the bdr does indeed change for the left and right arrows, the fg color doesn't.  Is this intentional?  Can we get an override?  Or a new element?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 09:41:27 AM
Request:
Overrides for these two:
(http://i.imgur.com/9LUjFM7l.jpg) (http://i.imgur.com/9LUjFM7.png)
The Artist one can already be replaced by
<element id="UnknownArtist">

Thnx, do you also happen to know the required pixel size?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 03, 2016, 10:02:58 AM
Thnx, do you also happen to know the required pixel size?

I don't think there is any preferred size. MB scales the picture up and down to suit various size thumbnails.

I've found that 200 to 250 px square gives good definition for all the situations.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 10:17:49 AM
Thnx, do you also happen to know the required pixel size?
I don't think there is any preferred size. MB scales the picture up and down to suit various size thumbnails.
I've found that 200 to 250 px square gives good definition for all the situations.

Ok, thnx.
The request for the 'unknown album' is still open.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 03, 2016, 11:56:22 AM
I would like to request overrides for the synchronization node.
Currently the vertical menu gets its values from preferences, but it would be nice if it could be configured separately.
Also would be good to have alternating row colors for the sync progress section.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 03, 2016, 12:52:17 PM
(http://i.imgur.com/nua2tzK.jpg) (http://i.imgur.com/nua2tzK.jpg)

A possible bug with the left panel foreground highlight or lowlight color (Panel.Body.Highlight or Panel.Body.Lowlight).

When I drag and drop tracks to a playlist in the left panel, that particular playlist node becomes stuck on the highlight foreground color, even if I navigate away from it. Since I'm trying to only use foreground colors to show the currently selected node, this makes it confusing to tell which node is the active one. In the above screenshot you can see "Podcasts" is open, but the "Favorites" playlist is still highlighted.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 03:31:22 PM
A possible bug with the left panel foreground highlight or lowlight color (Panel.Body.Highlight or Panel.Body.Lowlight).

When I drag and drop tracks to a playlist in the left panel, that particular playlist node becomes stuck on the highlight foreground color, even if I navigate away from it. Since I'm trying to only use foreground colors to show the currently selected node, this makes it confusing to tell which node is the active one. In the above screenshot you can see "Podcasts" is open, but the "Favorites" playlist is still highlighted.
i cant believe i didnt notice that. Its fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 04:04:40 PM
The request for the 'unknown album' is still open.
i am happy to do a colour override, so let me know if thats useful
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 04:30:19 PM
The request for the 'unknown album' is still open.
i am happy to do a colour override, so let me know if thats useful

Sure, that would be useful for some skins.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 07:49:11 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i have added:
album thumbnail:
Controls.AlbumThumb fg=XXX
genre thumbnail:
Controls.GenreThumb fg=XXX
podcast episode downloading:
Controls.EpisodeDownloading fg=XXX
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 08:26:37 PM
genre thumbnail:
Controls.GenreThumb fg=XXX

Perhaps I am looking at the wrong location, but if this element is supposed to work here, it doesn't.

(http://i.imgur.com/MZbN2UTl.jpg) (http://i.imgur.com/MZbN2UT.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 08:57:26 PM
you must be doing something wrong. This works for me
  <element id="Controls.GenreThumb" fg="225,5,5" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 09:06:26 PM
you must be doing something wrong. This works for me
  <element id="Controls.GenreThumb" fg="225,5,5" />

Strange. It won't work in my Zen Hive skin, but I see it does work in my other skins.
Looks like I'll have some investigating to do...
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 09:12:13 PM
Strange. It won't work in my Zen Hive skin, but I see it does work in my other skins.
Looks like I'll have some investigating to do...
i can see why and will post a fix later
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 09:17:07 PM
a fix has been uploaded
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 09:23:47 PM
Great, fixed it.

Btw, probably not important, but the time on niblseed seems to be a couple of hours off.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on January 03, 2016, 09:25:58 PM
a fix has been uploaded
Thanks for fixing the Tag Editor left/right arrows.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 03, 2016, 09:40:39 PM
the elements
"Controls.LockedInputControl.Default"
"Controls.LockedInputControl.Disabled"
aren't having any effect in 3.0

missed these ones or still working on them?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 09:47:38 PM
the elements
"Controls.LockedInputControl.Default"
"Controls.LockedInputControl.Disabled"
aren't having any effect in 3.0

missed these ones or still working on them?
they are not supported any more - MB should just use the input control disabled colours. sf there is somewhere the effect is missing?


also,
i added for the next update
Controls.WebLink fg=XXXX
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 03, 2016, 09:57:09 PM
they are not supported any more - MB should just use the input control disabled colours. sf there is somewhere the effect is missing?

OK. some of my skins use quite different colours between the panel and controls sections. They were handy to override that difference sometimes.
Guess I can live without them.



I now it's been asked about before but I can't remember if we ever got a definitive answer.

Can the blue arrows in the equaliser be overridden?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 03, 2016, 09:58:49 PM
I now it's been asked about before but I can't remember if we ever got a definitive answer.
Can the blue arrows in the equaliser be overridden?
no - they are controlled by windows
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 03, 2016, 10:05:04 PM
no

Can't be more definitive than that :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 03, 2016, 10:08:48 PM
two requests:

1. An icon override for these white/blue arrows:

(http://i.imgur.com/znPmgd5l.jpg) (http://i.imgur.com/znPmgd5.jpg)

2. The hard to read credits draws it's color from: "Controls.InputControl.Disabled"
That is problematic for several dark skins. It would probably be good to change the sourcing of that color.

(http://i.imgur.com/CxuDPqsl.jpg) (http://i.imgur.com/CxuDPqs.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 04, 2016, 06:32:09 AM
in Tag Editor panel:

tab selection highlight controlled by
<element id="Controls.TabHeader.Lowlight" bg="242,246,231" />
no longer works.

By design?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 04, 2016, 12:35:34 PM
2. The hard to read credits draws it's color from: "Controls.InputControl.Disabled"
That is problematic for several dark skins. It would probably be good to change the sourcing of that color.
(http://i.imgur.com/CxuDPqsl.jpg) (http://i.imgur.com/CxuDPqs.jpg)

Related to that:
The hard to read text from Album auto-tagger also draws it's color from "Controls.InputControl.Disabled".
For actually disabled items that coloring and description is suited.
But for these two locations they don't always turn out right.

Maybe have a new element for this, such as maybe Controls.InputControl.Secondary ?

(http://i.imgur.com/L4nMQ2Wl.jpg) (http://i.imgur.com/L4nMQ2W.png)
 
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 04, 2016, 01:26:02 PM
i cant believe i didnt notice that. Its fixed for the next update

Thanks for the fix!

By the way - I noticed when dragging and dropping tracks to a playlist the foreground color flashes red for a moment.
Not a big deal, but is there a way to override this color?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 04, 2016, 06:58:39 PM
1. An icon override for these white/blue arrows:
that was included in the last update or it wasnt then its in the next
Controls.WebLink fg=XXXX

2. The hard to read credits draws it's color from: "Controls.InputControl.Disabled"
That is problematic for several dark skins. It would probably be good to change the sourcing of that color.
i will make some adjustments on the MB side to use the default colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 04, 2016, 07:00:27 PM
By the way - I noticed when dragging and dropping tracks to a playlist the foreground color flashes red for a moment.
Not a big deal, but is there a way to override this color?
i thought there was an override but it seems not (its the same behavior as v2.5)
I might change it to flash bold instead but if not i will add an override
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 05, 2016, 02:13:38 AM
The override
<element id="Controls.TicketsButton.Default" />
no longer works in 3.0

Could it please be restored and a bdr attribute added.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 05, 2016, 10:15:27 AM
Related to that:
The hard to read text from Album auto-tagger also draws it's color from "Controls.InputControl.Disabled".
For actually disabled items that coloring and description is suited.
But for these two locations they don't always turn out right.

Maybe have a new element for this, such as maybe Controls.InputControl.Secondary ?

The credits panel is now fine. But the auto-tagger panel still uses 'disabled'.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 11:16:46 AM
in Tag Editor panel:

tab selection highlight controlled by
<element id="Controls.TabHeader.Lowlight" bg="242,246,231" />
no longer works.
i forgot to mention, i did have a look at that and didnt see any evidence it was being used in v2.5
I guess its possible it used to be a long time ago but i dont want to change anything that will cause issues for newer skins
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 05, 2016, 11:33:35 AM
i forgot to mention, i did have a look at that and didnt see any evidence it was being used in v2.5

It was working up to and including 2.5.
See my included skins Bee78 and Wing-ated
It's there and working in older skins too - see AeroBee
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 11:53:23 AM
bee-78 was the skin i checked and didnt see any difference between v2.5 and 3
I cant check now but if you post a screenshot showing the differences i will investigate

edit:
its just occured to me you might be refering to hot-tracking when the mouse goes over a tab. I removed support for that (to simplfy things for me). Is that what you are refering to?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 05, 2016, 12:18:46 PM
bee-78 was the skin i checked and didnt see any difference between v2.5 and 3
I cant check now but if you post a screenshot showing the differences i will investigate

Bee78 2.5 - black highlight on tab mouse-over
(http://i.imgur.com/XKFGKAr.gif)

Bee78 3.0 - no highlight on mouse-over
(http://i.imgur.com/l2wbkTc.gif)

It's not a big deal and, going forward, if the tabs are intended to be replaced with a header bar (as per the main panel), then I could see no good reason to waste time on fixing this for 3.0.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 05:46:12 PM
bee-78 was the skin i checked and didnt see any difference between v2.5 and 3
I cant check now but if you post a screenshot showing the differences i will investigate

Bee78 2.5 - black highlight on tab mouse-over

Bee78 3.0 - no highlight on mouse-over

It's not a big deal and, going forward, if the tabs are intended to be replaced with a header bar (as per the main panel), then I could see no good reason to waste time on fixing this for 3.0.
you probably missed my edit. However i am not planning on making any changes to the style of tabs for the tag editor
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 06:08:01 PM
I would like to request overrides for the synchronization node.
Currently the vertical menu gets its values from preferences, but it would be nice if it could be configured separately.
Also would be good to have alternating row colors for the sync progress section.
i have added for the next update:
DeviceSettings.VerticalMenu.Default
DeviceSettings.VerticalMenu.Highlight
DeviceSettings.VerticalMenu.Lowlight
but wont make any overrides for the alternating row colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 06:45:27 PM
The override
<element id="Controls.TicketsButton.Default" />
no longer works in 3.0

Could it please be restored and a bdr attribute added.
thats fixed for the next v3 update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 07:28:23 PM
i have added an override for the track information section (currently maroon coloured) in the Now Playing panel
NowPlayingTrackInfo bg=XXXX fg=XXXX
it is alpha blended with the background image depending on the panel configuraton used
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 05, 2016, 10:14:04 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

unzip into the musicbee application folder and run MusicBee3.exe

- changes as described above
- i am pretty much finished what i plan to do for now, apart from the tweaks for an iTunes style progress bar requested by cartman005
let me know if i have forgotten something major but i do want to move on now
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 05, 2016, 10:20:08 PM
However i am not planning on making any changes to the style of tabs for the tag editor

I suppose making them like the tabs at the bottom of the 'Radio' panel (2.5 Library Explorer style) is also not possible?

I just think those angled tabs look off with the rest of the styling of 3.0.
Especially so when the tag editor is docked in the main panel.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 06, 2016, 05:16:33 AM
i have added an override for the track information section (currently maroon coloured) in the Now Playing panel
NowPlayingTrackInfo bg=XXXX fg=XXXX
it is alpha blended with the background image depending on the panel configuraton used

A small issue I've noticed with this new override.
When in large album cover mode, NowPlayingTrackInfo is ignoring the element I defined and is displaying its own color.

Here's some screenshots, the second picture is how I intended for it to look:

(http://i.imgur.com/13ccSlkm.jpg) (http://i.imgur.com/13ccSlk.jpg) (http://i.imgur.com/IRQQkVtm.jpg) (http://i.imgur.com/IRQQkVt.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 06, 2016, 06:47:23 AM
i have added an override for the track information section (currently maroon coloured) in the Now Playing panel
NowPlayingTrackInfo bg=XXXX fg=XXXX
it is alpha blended with the background image depending on the panel configuraton used

A small issue I've noticed with this new override.
When in large album cover mode, NowPlayingTrackInfo is ignoring the element I defined and is displaying its own color.
yes you are right and i will add one more pverride
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 06, 2016, 07:50:00 AM
i have added for the next update:
DeviceSettings.VerticalMenu.Default
DeviceSettings.VerticalMenu.Highlight
DeviceSettings.VerticalMenu.Lowlight
but wont make any overrides for the alternating row colours

Thanks, I appreciate those additions.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 06, 2016, 08:25:14 PM
i have added an override for the track information section (currently maroon coloured) in the Now Playing panel
NowPlayingTrackInfo bg=XXXX fg=XXXX
it is alpha blended with the background image depending on the panel configuraton used
A small issue I've noticed with this new override.
When in large album cover mode, NowPlayingTrackInfo is ignoring the element I defined and is displaying its own color.
i have changed the default handling to have less contrast for dark skins and this is the new override. Its in the next update

<element id="NowPlayingLargeAlbumTrackInfo" bg="235,5,5" fg="60,250,160"  />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 06, 2016, 08:32:19 PM
However i am not planning on making any changes to the style of tabs for the tag editor

I suppose making them like the tabs at the bottom of the 'Radio' panel (2.5 Library Explorer style) is also not possible?

I just think those angled tabs look off with the rest of the styling of 3.0.
Especially so when the tag editor is docked in the main panel.
i do agree with you and will probably do this but not promising
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 06, 2016, 09:45:11 PM
for the changes described above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 06, 2016, 11:13:56 PM
I just think those angled tabs look off with the rest of the styling of 3.0.
Especially so when the tag editor is docked in the main panel.
i do agree with you and will probably do this but not promising

Will keep my fingers crossed and wait in hope :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 08, 2016, 05:46:24 AM
This is an old problem that I never bothered reporting before but, I thought I'd give it a mention in hopes that it gets fixed for 3.0 :)

Using the artwork downloader, the highlighter for the image selection uses an auto-generated colour and works fine

(http://i.cubeupload.com/MEObTI.jpg)

unless you are using <element id="UseArtworkBorders">true</element> and
<element id="Controls.ArtworkFrame" bdr="xxx,xxx,xxx,xxx"/>
then the selection bar colour is overridden by the bdr colour.
Sometimes the bg colour of the panel and the bdr colour are very hard to tell apart.

On that downloader panel, MB is also generating a border colour for the artwork images.
This colour is not effected by "Controls.ArtworkFrame"

Could MB be changed so that is uses that colour for both the border and the selection highlight as well?

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 08, 2016, 02:28:56 PM
It looks like  <bufferingMargin for the progress bar is not functioning in v3.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 08, 2016, 05:57:48 PM
It looks like  <bufferingMargin for the progress bar is not functioning in v3.
support for that was not included in v3 as i felt it didnt add much value. However as i write this i am thinking it would probably be needed for a bitmap skin. Is that where you are comng from with this?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 08, 2016, 06:06:58 PM
It looks like  <bufferingMargin for the progress bar is not functioning in v3.
support for that was not included in v3 as i felt it didnt add much value. However as i write this i am thinking it would probably be needed for a bitmap skin. Is that where you are comng from with this?

I noticed a slight difference with my 'A Sophisticated Bee' skin.
If you wouldn't know it, you wouldn't notice it, and there is no image corruption.
So I believe it would be safe just to leave it as it is.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 08, 2016, 11:50:44 PM
This is an old problem that I never bothered reporting before but, I thought I'd give it a mention in hopes that it gets fixed for 3.0 :)
Using the artwork downloader, the highlighter for the image selection uses an auto-generated colour and works fine
unless you are using <element id="UseArtworkBorders">true</element> and
<element id="Controls.ArtworkFrame" bdr="xxx,xxx,xxx,xxx"/>
then the selection bar colour is overridden by the bdr colour.
Sometimes the bg colour of the panel and the bdr colour are very hard to tell apart.
On that downloader panel, MB is also generating a border colour for the artwork images.
This colour is not effected by "Controls.ArtworkFrame"
Could MB be changed so that is uses that colour for both the border and the selection highlight as well?

You probably can forget about this.

Because you can use an alpha value in "Controls.ArtworkFrame", you can set a darker colour for the selection bar and then tone it back with a low alpha value on the artwork border.
A perfect work-around.  :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 09, 2016, 10:47:45 AM
unless you are using <element id="UseArtworkBorders">true</element> and
<element id="Controls.ArtworkFrame" bdr="xxx,xxx,xxx,xxx"/>
then the selection bar colour is overridden by the bdr colour.
Sometimes the bg colour of the panel and the bdr colour are very hard to tell apart.
the use of ArtworkFrame is not the best and for the next update i have changed it to auto-generate based on the panel colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 10, 2016, 09:14:41 AM
Request:

fg and bg element for the Lyrics panel.
Especially with dark skins the white panel is a bit like staring into in a lamp.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 10, 2016, 12:05:56 PM
fg and bg element for the Lyrics panel.
Especially with dark skins the white panel is a bit like staring into in a lamp.
its already supported:
LyricsPanel
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 10, 2016, 12:35:44 PM
fg and bg element for the Lyrics panel.
Especially with dark skins the white panel is a bit like staring into in a lamp.
its already supported:
LyricsPanel

It's a bit weird.
That element doesn't do anything in my skins, and it never did.

But more important, the white lyrics panel that I had encountered in a dark skin, is gone, and I can't replicate it again.
The lyrics panel seems to use matching skin colors, so there is no issue with this anymore on my behalf.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 10, 2016, 12:44:36 PM
yes you are right. Looking at the code, it doesnt actually do anything any more and didnt in v2.5
I cant remember the history behind that
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 10, 2016, 09:29:35 PM
I just think those angled tabs look off with the rest of the styling of 3.0.
Especially so when the tag editor is docked in the main panel.
i do agree with you and will probably do this but not promising

Will keep my fingers crossed and wait in hope :)

nice work!
square tabs look great :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 11, 2016, 04:07:25 AM
<element id="Controls.ListHeader" />
doesn't appear to be working in 3.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 11, 2016, 10:39:57 AM
I've noticed that the Notification icon, either the included or overridden, is a little paler than the other icons. It's like it has a slight masking effect.

ie. on the default MB3 skin the 'Configure Layout' and 'DownloadIndicatorIcon' is "95,95,95" RBG
but the Notification one is "116,116,116"

EDIT:
Never mind. I figured it out. When it appears on the tab bar it's in highlight mode.
Duhhhhh!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 11, 2016, 06:24:07 PM
<element id="Controls.ListHeader" />
doesn't appear to be working in 3.0
thats done for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 12, 2016, 09:08:47 AM
since last update (3.0.5854) add tab and first toolbar button are overlapping

(http://i.cubeupload.com/CUlWDt.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 12, 2016, 10:01:48 AM
since last update (3.0.5854) add tab and first toolbar button are overlapping
nothing has been changed for the tabs handling so its probably an existing bug. Could you send me your settings file?
Also would it be when the notifications icon is displaying?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 12, 2016, 10:35:18 AM
Could you send me your settings file?
Also would it be when the notifications icon is displaying?

PM sent
Yes. notification icon is displayed.

If I click on the new tab icon, then close the empty tab, correct spacing happens.
But only till next re-start



<element id="Controls.ListHeader" />
doesn't appear to be working in 3.0
thats done for the next update

Was that fix in 3.0.5854.38953?
If it was - still not working.
If it wasn't - disregard this part of the post :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 12, 2016, 07:22:58 PM
Was that fix in 3.0.5854.38953?
If it was - still not working.
If it wasn't - disregard this part of the post :)
its there now for the next update and also a fix for the overlapping icons
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 14, 2016, 05:39:14 AM
its there now for the next update and also a fix for the overlapping icons

yes, all working now :)



I'd still like to see the return of the tab icons (but with the ability to have text or icon as per toolbar icons)
but I'd much rather see 3.0 reach the beta stage, so won't worry about this now
will add to the wish list at a later stage of 3.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: mikebo on January 15, 2016, 05:06:39 PM
Hey
Is there a list of added and removed elements for v3 skins or a reference skin that has all of the supported elements?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 15, 2016, 06:06:14 PM
Is there a list of added and removed elements for v3 skins or a reference skin that has all of the supported elements?
i am planning to consolidate the new ones on one post some time this weekend. I doubt i will have time to figure out what has been removed - unforunately i misplaced the list where i was keeping track of that
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 15, 2016, 08:35:04 PM
Is there a list of added and removed elements for v3 skins or a reference skin that has all of the supported elements?
i am planning to consolidate the new ones on one post some time this weekend. I doubt i will have time to figure out what has been removed - unforunately i misplaced the list where i was keeping track of that

in the interim, here is a copy of the list I've been keeping of new items added on the forum



<element id="Menu.DropDownCheckBoxImage" fg="xxx,xxx,xxx" />
<element id="Menu.Header" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />

<element id="Panel.SearchBox.NotActivated" bg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
<element id="CaptionBar.SearchBox.NotActivated" bg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />

<element id="TabsBar.BorderLine" bdr="xxx,xxx,xxx" />
<element id="TabsBar.TabInCaptionBar.BorderLine" bdr="xxx,xxx,xxx" />

<element id="Content[TrackDetail].HeaderLine" bg="xxx,xxx,xxx" />

<element id="NowPlayingTrackInfo" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="NowPlayingLargeAlbumTrackInfo" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx"  />

<element id="PlayerFlat.ProgressBarMiddle" bg="xxx,xxx,xxx" />
<element id="PlayerFlat.NotLovedIcon" fg="xxx,xxx,xxx" />

<element id="Controls.Arrow.Default" fg="xxx,xxx,xxx" />
<element id="Controls.AlbumThumb" fg="xxx,xxx,xxx" />
<element id="Controls.GenreThumb" fg="xxx,xxx,xxx" />
<element id="Controls.FindButton.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="Controls.SubscriptionCounter" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="Controls.EpisodeNotPlayed" bg="xxx,xxx,xxx" />
<element id="Controls.EpisodeDownloading" fg="xxx,xxx,xxx" />
<element id="Controls.WebLink" fg="xxx,xxx,xxx" />

<element id="DeviceSettings.VerticalMenu.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="DeviceSettings.VerticalMenu.Highlight" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="DeviceSettings.VerticalMenu.Lowlight" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />

<element id="ColumnBrowser.ListHeader" bg="xxx,xxx,xxx" bg2="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
<element id="ColumnBrowser.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="ColumnBrowser.ListAlternating.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="ColumnBrowser.Highlight" bg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
<element id="ColumnBrowser.Lowlight" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
<element id="ColumnBrowser.ScrollBar" bg="xxx,xxx,xxx" bg2="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
<element id="ColumnBrowser.ScrollBarBackground" bg="xxx,xxx,xxx" />
 
for scrollbars i have added support for lowlighting inactive scrollbar sliders ie. the lowlight colours will show unless you click on the slider and drag it
Panel.ScrollBar.Lowlight
LeftNavigator.ScrollBar.Lowlight
Panel.ChildBody.ScrollBar.Lowlight
FilterPanel.ScrollBar.Lowlight
ColumnBrowser.ScrollBar.Lowlight
Content[Artwork].ScrollBar.Lowlight

if you only want the lowlight colours to apply to narrow scrollbars eg. you only want the narrow scrollbars to be more blended into the background
<element id="ScrollBarLowlightNarrowOnly">true</element>

<element id="AlertIcon">
<element id="DeleteIcon">
<element id="DownloadIndicatorIcon">
<element id="MusicExplorerIcon">
<element id="NotificationIcon">
<element id="NowPlayingIcon">
<element id="PlaylistDirectoryIcon">
<element id="RecommendationsIcon">
<element id="UpcomingConcertsIcon">
<element id="WebBrowserIcon">

<PlayerSplitProgressYOffset>Above</PlayerSplitProgressYOffset>


Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 15, 2016, 09:34:22 PM
thanks for that. Look good
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 16, 2016, 08:17:21 AM
lowlight override for 'playing tracks' panel

<element id="NowPlayingList.ScrollBar.Lowlight"

doesn't exist (yet :)  )
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 16, 2016, 09:19:56 AM
lowlight override for 'playing tracks' panel
<element id="NowPlayingList.ScrollBar.Lowlight"
doesn't exist (yet :)  )
its done for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 16, 2016, 11:45:29 AM
Hey
Is there a list of added and removed elements for v3 skins or a reference skin that has all of the supported elements?

If you have MS Excel, you could use this tool I created a while back that will show any differences and omissions of a skin that you insert in it.
It uses a 'master skin' file which I have updated and made as actual and complete as I could.

Any contributions or comments on it would be very welcome and helpful.
Maybe even Steven could run it, and see if he could point out all elements and attributes that by now are definitely obsolete, so that I can mark those as obsolete in this 'master file' too, so anybody knows not to waste time and effort on those anymore.

http://getmusicbee.com/forum/index.php?topic=10689.msg64268#msg64268
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 16, 2016, 04:06:41 PM
These two elements are behaving a bit erratic.

<element id="TabsBar.TabAddButton.Default" bg="0,252,6" fg="254,3,1" />
<element id="TabsBarBelow.TabAddButton.Default" bg="0,253,2" fg="121,121,121" />

bg doesn't seem to do anything, but if you remove it, fg won't work anymore.

Also in the skin I am currently testing this, the value set for "TabsBar.TabAddButton.Default" will not show up there, but in "TabsBarBelow.TabAddButton.Default" instead.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 16, 2016, 05:14:50 PM
Also in the skin I am currently testing this, the value set for "TabsBar.TabAddButton.Default" will not show up there, but in "TabsBarBelow.TabAddButton.Default" instead.
that no longer applies as the tab handling/ background panel has been changed in v3
these should suffice
TabsBar.TabAddButton.Default and
TabsBar.TabInCaptionBarAddButton.Default

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 16, 2016, 05:35:14 PM
these should suffice
TabsBar.TabAddButton.Default and
TabsBar.TabInCaptionBarAddButton.Default

Ok. I'll mark it as obsolete for v3.

But what's still weird is that if I have the other two like this:

<element id="TabsBar.TabAddButton.Default" bg="0,255,1" fg="255,1,0" />
<element id="TabsBar.TabInCaptionBarAddButton.Default" bg="0,255,2" fg="255,2,0" />

Both fg's are displaying correct. (while the bg's don't do anything)
But if I then remove the bg's, the fg's don't work anymore.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: mikebo on January 16, 2016, 07:37:22 PM
Ok. I'll mark it as obsolete for v3.

But what's still weird is that if I have the other two like this:

<element id="TabsBar.TabAddButton.Default" bg="0,255,1" fg="255,1,0" />
<element id="TabsBar.TabInCaptionBarAddButton.Default" bg="0,255,2" fg="255,2,0" />

Both fg's are displaying correct. (while the bg's don't do anything)
But if I then remove the bg's, the fg's don't work anymore.
Maybe it would make things easier if Steven maintained a reference skin.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 16, 2016, 09:49:56 PM
Maybe it would make things easier if Steven maintained a reference skin.

You can leave out 'maybe', but since that might be a bit difficult currently (as Steven also explained a bit already), and he has plenty on his plate already, the best we can do is share information and experiences.

To be honest, I am slightly disappointed how little (productive) feedback my excel effort gets from other skinners.
It has been available for more than two years now, and there has hardly been any contribution from other skinners to it.
Not to pat myself on the shoulders, but it still seems to be the only effort to try and create, and share an as complete and correct as possible overview of working elements.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 16, 2016, 10:25:18 PM
But what's still weird is that if I have the other two like this:

<element id="TabsBar.TabAddButton.Default" bg="0,255,1" fg="255,1,0" />
<element id="TabsBar.TabInCaptionBarAddButton.Default" bg="0,255,2" fg="255,2,0" />

Both fg's are displaying correct. (while the bg's don't do anything)
But if I then remove the bg's, the fg's don't work anymore.
its for backwards compatibility - MB loads a different set of background colors, if bg is not set. If i was to do the whole skinning thing again (which i am not!) then there are quite a few crappy things that i would get rid of
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 16, 2016, 10:32:38 PM
its for backwards compatibility - MB loads a different set of background colors, if bg is not set. If i was to do the whole skinning thing again (which i am not!) then there are quite a few crappy things that i would get rid of

Clear, I'll just leave them in.
Getting rid of crappy stuff can always be done for v4 ;-)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 17, 2016, 07:59:50 PM
Requests:

Increase header height
http://i.imgur.com/F6hesee.png


Add a new element for TabsBar colors when PlayerBar is on Top (very useful)
http://i.imgur.com/9XUP9vh.png


And finally, headerbar/panel overrides for each section/column

(http://i.imgur.com/XIZ7g09.png)








Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 17, 2016, 08:13:05 PM
Increase header height
thats already done for the next update along with the left navigator
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 17, 2016, 09:36:31 PM
Add a new element for TabsBar colors when PlayerBar is on Top (very useful)
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

these activate when the main player is displayed on top
<element id="TabsBarPTop.Tab.Highlight" bg="23,235,235" fg="80,80,80" bdr="10,170,170" />
<element id="TabsBarPTop.Tab.Default" bg="186,20,26" fg="20,20,20" bdr="170,10,170" />
<element id="TabsBarPTop.Background" bg="186,0,0" />
<element id="TabsBarPTop.Tab.Separator" bg="10,150,150" />
this one is optional:
<element id="TabsBarPTop.BorderLine" bg="10,150,250" />

i will do the panel header/section overrides but it might be a few days away
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 18, 2016, 01:10:12 AM
using a gradient on mini player produces all sorts of problems in MB3

(http://i.cubeupload.com/D5feoA.jpg)

Please, can this be fixed?

or should bg2 attribute on
<element id="PlayerMini.Background"
be made unavailable for MB3?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 18, 2016, 08:26:49 AM
<element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
to override the id="PreferencesPanel.Default" colours is not working for MB3
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 10:12:00 AM
We have these:

element id="Controls.SearchBox.Default"
element id="Controls.SearchBox.Lowlight"

Could you add overrides for these when the searchbox is located in the captionbar?


Never mind, such is already available.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 18, 2016, 10:24:34 AM
We have these:

element id="Controls.SearchBox.Default"
element id="Controls.SearchBox.Lowlight"

Could you add overrides for these when the searchbox is located in the captionbar?

<element id="CaptionBar.SearchBox.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
<element id="CaptionBar.SearchBox.Lowlight" fg="xxx,xxx,xxx" />

I would have sworn I saw those in your spreadsheet.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 10:28:14 AM
We have these:

element id="Controls.SearchBox.Default"
element id="Controls.SearchBox.Lowlight"

Could you add overrides for these when the searchbox is located in the captionbar?

<element id="CaptionBar.SearchBox.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" bdr="xxx,xxx,xxx" />
<element id="CaptionBar.SearchBox.Lowlight" fg="xxx,xxx,xxx" />

I would have sworn I saw those in your spreadsheet.

Haha. Thanks Bee-liever.

I should use my own tools a bit more often myself ;-)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 02:33:51 PM
When borders are set for track details, depending on the used colors, the coloring sometimes turns out awkward or fuzzy, because the bottom border of the default line above the highlighted line is not covered by the top border of the highlighted line.

(http://i.imgur.com/5y0gx4Nl.jpg) (http://i.imgur.com/5y0gx4N.png)

zoomed:

(http://i.imgur.com/Cd1GFsRl.jpg) (http://i.imgur.com/Cd1GFsR.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 03:01:55 PM
request:

Override elements for these two:

(http://i.imgur.com/MvvSQ2ql.jpg) (http://i.imgur.com/MvvSQ2q.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 18, 2016, 03:32:57 PM
request:

Override elements for these two:

(http://i.imgur.com/MvvSQ2ql.jpg) (http://i.imgur.com/MvvSQ2q.png)

+1, I was about to post the same thing, and to add to this request - an override for checkboxes also shown in the screenshot.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 04:35:48 PM
This one is about these vertical  divider lines:

(http://i.imgur.com/qAZRhFll.jpg) (http://i.imgur.com/qAZRhFl.png)

They are drawn depending on the element:
"Content[TrackDetail].Body.ListHeader"

From a functional point of view, these small vertical dividers are important (so you know where to grab the border), but the horizontal bottom line has no practical  function, other than an aesthetic one, and for some skins you don't want that horizontal border.

But it is impossible to 'remove' that horizontal line, without also removing the vertical divider lines.

My request is: either a separate element for the 'dividers', or perhaps make these dividers dependent on: id="Content[TrackDetail].Body.Default", which shares a similar and actual practical purpose:

(http://i.imgur.com/pe1l5Njl.jpg) (http://i.imgur.com/pe1l5Nj.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on January 18, 2016, 07:28:38 PM
Does an element exist for the line at the bottom of unopened tabs?  I'd like to use the bdr color from the opened tab and have that extend to a line beneath the other tabs.
(http://i.imgur.com/JqNJAOtl.jpg) (http://i.imgur.com/JqNJAOt.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 07:35:09 PM
I think those would be:

element id="TabsBar.BorderLine" bdr=
element id="TabsBar.TabInCaptionBar.BorderLine" bdr=
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 18, 2016, 08:04:04 PM
When borders are set for track details, depending on the used colors, the coloring sometimes turns out awkward or fuzzy, because the bottom border of the default line above the highlighted line is not covered by the top border of the highlighted line.
that wont be changed as drawing can only reliably be done within the height allocated to a row
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 18, 2016, 08:05:09 PM
using a gradient on mini player produces all sorts of problems in MB3
i actually didnt intend to support that but forgot to disable the bg2 via the skin settings. However it turns out to be straight-forward so its done for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 18, 2016, 08:06:12 PM
<element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
to override the id="PreferencesPanel.Default" colours is not working for MB3
the auto dj panel overrides are not supported in v3. This is to simplify the maintenance required
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on January 18, 2016, 08:06:40 PM
I think those would be:

element id="TabsBar.BorderLine" bdr=
element id="TabsBar.TabInCaptionBar.BorderLine" bdr=
Perfect!!
The first one is what I was looking for.  And what a difference it makes with the tab appearance.

Thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 18, 2016, 08:52:28 PM
<element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
to override the id="PreferencesPanel.Default" colours is not working for MB3
the auto dj panel overrides are not supported in v3. This is to simplify the maintenance required

Bummer :(
That panel can look a bit off if the main panel colours are radically different to the preferences panel ones

(http://i.cubeupload.com/jKJPcm.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 18, 2016, 08:58:12 PM
Override elements for these two:

(http://i.imgur.com/MvvSQ2ql.jpg) (http://i.imgur.com/MvvSQ2q.png)
i have added:
Controls.DropAreaIndicator fg=XXX
Controls.DropRowIndicator fg=XXX
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 18, 2016, 09:14:29 PM
My request is: either a separate element for the 'dividers', or perhaps make these dividers dependent on: id="Content[TrackDetail].Body.Default", which shares a similar and actual practical purpose:
i wont do this but i have made a small tweak so if the border color is the same as the bg2 color then an automatically generated color is used
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 18, 2016, 09:44:20 PM
for the changes as described above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 18, 2016, 09:56:01 PM
My request is: either a separate element for the 'dividers', or perhaps make these dividers dependent on: id="Content[TrackDetail].Body.Default", which shares a similar and actual practical purpose:
i wont do this but i have made a small tweak so if the border color is the same as the bg2 color then an automatically generated color is used

That solution seems to work for most semi-dark skins.
But for very dark skins it's still a bit problematic:

(http://i.imgur.com/QYoG3A8l.jpg) (http://i.imgur.com/QYoG3A8.png)
 
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 18, 2016, 10:51:33 PM
using a gradient on mini player produces all sorts of problems in MB3
i actually didnt intend to support that but forgot to disable the bg2 via the skin settings. However it turns out to be straight-forward so its done for the next update

thanks! looks brilliant :)



could we have overrides for the new Last.fm Recommendations and Statistics navigator icons, please



and I'll try to twist your arm :)
I'm begging you to reconsider just <element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
(or maybe a new MB3 override! huh!! huh!!)
Please, please, please...
(http://www.freesmileys.org/smileys/smiley-sad009.gif) (http://www.freesmileys.org/smileys.php)  (http://www.freesmileys.org/smileys/smiley-sad011.gif) (http://www.freesmileys.org/smileys.php)  (http://www.freesmileys.org/smileys/smiley-sad015.gif) (http://www.freesmileys.org/smileys.php)

(I'm grovelling now, in case you hadn't guessed) :D
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 19, 2016, 03:54:59 AM
One error and (very) small spacing requests:

http://i.imgur.com/aOUkyJG.png

PS: Hmmmmm, also I think the Tab icons are a bit misaligned (They are 1px too high Actually, i think the text is 1px too low —not aligned with custom command text buttons—). Same thing happens on the Playlist Manager left playlist browser.

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 19, 2016, 06:35:07 PM
could we have overrides for the new Last.fm Recommendations and Statistics navigator icons, please



and I'll try to twist your arm :)
I'm begging you to reconsider just <element id="AutoDjPanel.Default" bg="xxx,xxx,xxx" fg="xxx,xxx,xxx" />
(or maybe a new MB3 override! huh!! huh!!)
while i appreciate that a plugin icon may not work well with a skin, i dont have control over future plugins that are created. Given those two are mine and i am making changes to skin handling i will enable a last.fm icon override
for the 2nd i already answered that.

edit:
added "LastFmPluginIcon" for the two last.fm plugin icon overrides
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 19, 2016, 06:38:47 PM
With MB v2, the element id="ScrollBarMargin" makes it possible to have a (visually) thinner scroll bar, but it doesn't affect the background of the scroll bar which will keep the same width as it had before.
It would be nice for v3 that when the scroll bar is set to be thinner, it's background gets thinner too.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 19, 2016, 06:43:31 PM
One error and (very) small spacing requests:

http://i.imgur.com/aOUkyJG.png

PS: Hmmmmm, also I think the Tab icons are a bit misaligned (They are 1px too high Actually, i think the text is 1px too low —not aligned with custom command text buttons—). Same thing happens on the Playlist Manager left playlist browser.
i will do the tab icon adjustment so the icon offset is consistent and the missing overlay mask.
The thumbnail icon placement is something i attempted to address a while ago but is problematic to change. I probably wont have time to look at that again.
For the vertical spacing in the Playing Tracks layout, please keep in mind it needs to work alongside the main panel when the main panel is not in artwork layout. In my opinion having 2-3px doesnt work well when the main panel is in Track Details or Album and Tracks layout.
As a compromise i am happy to increase the spacing by 1px and that also makes it consistent with the navigator on the opposite side of the window.
Of course in the Now Playing window which is intended more for display than for functionality, the vertical spacing is already padded more.

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 19, 2016, 08:10:17 PM
With MB v2, the element id="ScrollBarMargin" makes it possible to have a (visually) thinner scroll bar, but it doesn't affect the background of the scroll bar which will keep the same width as it had before.
It would be nice for v3 that when the scroll bar is set to be thinner, it's background gets thinner too.
while that would be possible for v3, i feel its too much to do/ risky for introducing bugs at this point
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 19, 2016, 08:20:55 PM
With MB v2, the element id="ScrollBarMargin" makes it possible to have a (visually) thinner scroll bar, but it doesn't affect the background of the scroll bar which will keep the same width as it had before.
It would be nice for v3 that when the scroll bar is set to be thinner, it's background gets thinner too.
while that would be possible for v3, i feel its too much to do/ risky for introducing bugs at this point

Ok. Should I just forget about it, or maybe throw it up again in the future after v3 is an official release?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 19, 2016, 08:29:25 PM
for the 2nd i already answered that.

I know you did.  I was begging & grovelling to try and get you to change your mind or consider a new override just for the main autoDJ bg and fg colours.
Guess it didn't work.  The re-boot of my old Tundra series just wont be the same :D
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 19, 2016, 08:41:30 PM
Ok. Should I just forget about it, or maybe throw it up again in the future after v3 is an official release?
feel free to raise it again after the v3 release
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 19, 2016, 08:41:57 PM
changes as described above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 19, 2016, 08:58:55 PM
For the vertical spacing in the Playing Tracks layout, please keep in mind it needs to work alongside the main panel when the main panel is not in artwork layout. In my opinion having 2-3px doesnt work well when the main panel is in Track Details or Album and Tracks layout.
As a compromise i am happy to increase the spacing by 1px and that also makes it consistent with the navigator on the opposite side of the window.
Of course in the Now Playing window which is intended more for display than for functionality, the vertical spacing is already padded more.

Playing Tracks Panel/Element: I was talking about horizontal left margin, not the vertical spacing. The album cover in the Album & Tracks view is just 2px from the left border, compared to 4px on other panels like the thumbnail browser. Also, the current track icon (the one on the left of the track) is 3px from the border, compared to 4px on the Main Panel (Files module with Tracks view), whether the element is in a side panel or in the main panel.

Thumbnail/Filter Panel/Element: Here I was pointing to the vertical margin (not spacing) for the first thumbnail, which now is only 1px.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 19, 2016, 09:02:45 PM
Playing Tracks Panel/Element: I was talking about horizontal left margin, not the vertical spacing. The album cover in the Album & Tracks view is just 2px from the left border, compared to 4px on other panels like the thumbnail browser. Also, the current track icon (the one on the left of the track) is 3px from the border, compared to 4px on the Main Panel (Files module with Tracks view), whether the element is in a side panel or in the main panel.

Thumbnail/Filter Panel/Element: Here I was pointing to the vertical margin (not spacing) for the first thumbnail, which now is only 1px.
ok, i will make the change for the playing tracks element
for the thumbnail panel, thats what i understood you meant and my response is unchanged

edit:
same link is updated with the adjustments
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 19, 2016, 09:45:34 PM
with the narrower caption bar, the bottom border doesn't show from
<element id="InlineMenu.ParentItem.Highlight"

(http://i.cubeupload.com/XZ8uL9.jpg)

should the border attribute be made non-functional in MB3?

It does echo the look of the tabs - sort of.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 20, 2016, 07:04:34 PM
with the narrower caption bar, the bottom border doesn't show from
<element id="InlineMenu.ParentItem.Highlight"
i fixed that last night so the next update should include the fix
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 21, 2016, 12:08:43 AM
I'm going to ask for a few things more (sorry Steven :P)... the last ones before moving on to the spanish translation and doing some concepts for Music Explorer, Now Playing & Recomendations

Overrides for things marked in green (high priority) and yellow (low priority): http://i.imgur.com/I03IVKt.png
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 21, 2016, 12:22:25 AM
Also I just noticed this:

(http://i.imgur.com/pa5mZAi.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 07:50:43 AM
And finally, headerbar/panel overrides for each section/column

(http://i.imgur.com/XIZ7g09.png)
do you still think this is needed - its non-trivial so i only will do this if yourself or others feel there is a strong need for it
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 21, 2016, 07:56:10 AM
Just an idea - how about an inverted version of the 'native button theme' for use with dark skins?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 08:09:24 AM
native buttons are created by windows and MB doesnt control the colouring
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 21, 2016, 08:58:37 AM
And finally, headerbar/panel overrides for each section/column
do you still think this is needed - its non-trivial so i only will do this if yourself or others feel there is a strong need for it

I've been going through my skins to make a plan for upgrading them for 3.0, and while this would be useful for my Wing-ated skin, it certainly doesn't need to be done right now.
I've already had to adapt skins to the loss of a couple of overrides, so I think we should adopt a wait'n'see attitude on adding a host of new ones.

When MB3 is in the beta cycle and the active skinners have adjusted their skins for the new look,  the need to do these elements, and others, could be re-visited then.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 01:55:49 PM
Overrides for things marked in green (high priority) and yellow (low priority): http://i.imgur.com/I03IVKt.png
for the play/pause icons is it just the colours (prefered) or the entire image?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 21, 2016, 03:31:17 PM
Overrides for things marked in green (high priority) and yellow (low priority): http://i.imgur.com/I03IVKt.png
for the play/pause icons is it just the colours (prefered) or the entire image?
Entire image, but it's probably the less important one, so it can wait for a future release.

--

About the headers/columns colors... well, it's not really needed right now, but I think it makes a lot of sense:
- Unifies each column/panel color (looks better)
- You could assign, for example, alternating rows only to the main panel (it's the only place where they're functionally needed), so the playing tracks element could be in a narrow side panel without alt. rows but have them when you move it to the main panel. Right now you have to choose a specific look for it, whatever the panel it's going to be in.
- If a skin has 4 different colored side columns/panels and the user is only going to use 1 or 2 of them, they can choose between different colored panels to put their elements.
- Simplifies the skin making process (right now all the different settings mixed between elements and panels it's a bit of a mess - but they could work as overrides, if anyone wants to use them)

The cons are obvious, it's a lot of work for you to change all that right now. Maybe you should leave it for a future version.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 21, 2016, 03:41:27 PM
The last couple items on my wishlist;

16x16 icon override for the 'add new tab' button
Fill/empty bitmap support for the volume slider
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 05:50:35 PM
16x16 icon override for the 'add new tab' button
Fill/empty bitmap support for the volume slider
i will probably do the Add New tab button override.
You should be able to do a custom volume slider via a bitmap skin
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 21, 2016, 06:14:15 PM
i will probably do the Add New tab button override.

That would be great.

You should be able to do a custom volume slider via a bitmap skin

Yeah but I meant having a fill color for the volume slider, like the progress bar.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 21, 2016, 06:46:48 PM
As EffenBlue established here:

http://getmusicbee.com/forum/index.php?topic=6793.msg102427#msg102427
http://getmusicbee.com/forum/index.php?topic=10884.msg102428#msg102428

There is a graphical issue with 'disabled' entries in the Playing Tracks panel.
I checked with a few skins (DarkRed xml, Dem Ol Kozmic Blues, and my own Crimson Creme) and they all display this issue.

The default MusicBee3 skin doesn't have this problem, nor a few other skins I checked, but which have substantial less elements then the ones I just mentioned.

Removing or disabling the <element id="NowPlayingList[TrackDetail].Disabled" fg="1,250,7" /> doesn't solve it, so there probably is a dependency on other elements too.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 07:21:43 PM
<!-- 55-->  <element id="Content[TrackDetail].ListAlternating.Disabled" bg="225,225,225" fg="160,160,160" />
<element id="Content[TrackDetail].Body.Disabled" fg="160,160,160" />
the playing track overrides (NowPlayingList[TrackDetail].*) are only used if NowPlayingList[TrackDetail].Default bg is included

This setting is nothing new but i guess its possible in v2.5, if it wasnt provided then .Default is used so i will probably change that
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 07:29:59 PM
Also I just noticed this:

(http://i.imgur.com/pa5mZAi.png)
thats controlled by the .NET library but if you provide a bdr override then MB wiill handle the borders consistently
  <element id="Menu.DropDown.Highlight" bg="Highlight" bdr="0,255,0" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 21, 2016, 07:34:51 PM
<!-- 55-->  <element id="Content[TrackDetail].ListAlternating.Disabled" bg="225,225,225" fg="160,160,160" />
<element id="Content[TrackDetail].Body.Disabled" fg="160,160,160" />
the playing track overrides (NowPlayingList[TrackDetail].*) are only used if NowPlayingList[TrackDetail].Default bg is included

This setting is nothing new but i guess its possible in v2.5, if it wasnt provided then .Default is used so i will probably change that

The corruption is indeed gone when I remove the bg value from NowPlayingList[TrackDetail].Default
But it probably needs a fix from your side, since not all existing skins that have this bg value will be maintained by their creators.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 07:43:49 PM
@endeavour1934 and Alumni
i have added the following, but wont do the volume slider or selector button arrow changes for this iteration of MB3


left menu button:
MenuIcon fg=XXX

player on top overrides:
TabsBarPTop.InactiveTabIconMask bg=XXX
Controls.SearchBoxPTop.Default bg=XXX fg=XXX

icon overrides:
SearchMenuButton  (26x20px)
PlayingIcon.Default  (16x16px)
PausedIcon.Default  (16x16px)
PlayingIcon.Highlight  (16x16px)
PausedIcon.Highlight  (16x16px)
AddTabIcon  (16x16px)
AddTabIconInCaptionBar  (16x16px)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 07:50:14 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 21, 2016, 10:08:36 PM
@endeavour1934 and Alumni
i have added the following
Thanks!
However, there is no Controls.SearchBoxPTop.NotActivated (bg, bdr) element. BTW, after using the searchbox and clearing it, it never returns to the NotActivated state. I don't remember if this happened on previous versions. You can see in DarkRED why I'm asking for both these things: https://dl.dropboxusercontent.com/u/10773406/DarkREDFlat3.xml
(I chose to use a "highlight" bg for the activated searchbox because in some panels search is activated by default, and without the highlight sometimes I don't notice it, but I'd prefer if it returns to NotActivated when it loses the focus.)
Of course if this implies too much work I can go back to use a uniform background (but I will still need Controls.SearchBoxPTop.NotActivated bg, bdr).

The PlayingIcons look a bit blurry. Are you sure about the resolution? Also I think a bug was introduced: After opening Musicbee, if you start playing a different song from the current playlist, the PlayingIcon flashes on the last song played before closing the app. Again, if it's too complicated to solve you can roll back the changes made for these icons, because as I've said earlier they aren't a big priority.

PS: Sorry for being such a pain in the a**
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 21, 2016, 10:18:21 PM
The PlayingIcons look a bit blurry. Are you sure about the resolution? Also I think a bug was introduced: After opening Musicbee, if you start playing a different song from the current playlist, the PlayingIcon flashes on the last song played before closing the app.
the blur will be addressed for the next update. But what do you mean by "the PlayingIcon flashes on the last song played before closing the app. "?
playing another song causes MB to close?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 21, 2016, 10:58:17 PM
This is a bit weird, and before I dive into this further, maybe somebody can confirm this. (I checked this with a few skins)

I have set <element id="Panel.HeaderButtonOverride.Highlight" bg="2,254,6" />
But this doesn't have any effect at all when I click, or hoover over a self-created toolbar button (text button, no icon).

I also have created a toolbar button: "View: Toggle Show Thumbnail Browser" (with icon)
As soon as I click that button, suddenly for the other 'text' toolbar button the above highlight element coloring is activated.

To illustrate,
When I press the toolbar button (1) for 'show thumbnail browser', then toolbar button (2) gets the highlight color. (But the other button (3) doesn't)

(http://i.imgur.com/j5xOEkKl.jpg) (http://i.imgur.com/j5xOEkK.png)


edit:

And after the MB window loses focus after that, the button gets to look like this:

(http://i.imgur.com/6srrsHKl.jpg) (http://i.imgur.com/6srrsHK.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 21, 2016, 11:37:13 PM
The current Weblink colouring overrule element results in this rather vague image:

(http://i.imgur.com/43jtG3ql.jpg) (http://i.imgur.com/43jtG3q.png)

instead of this:

(http://i.imgur.com/fd2ajgWl.jpg) (http://i.imgur.com/fd2ajgW.png)

Therefor this is a request for an image overrule element for that.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 22, 2016, 02:47:19 AM
@Steven
Thanks for adding those new elements. It doesn't seem like MenuIcon fg=XXX is having any effect though.
PS: It would also be nice to have a bitmap override for the menu icon, but it's a low priority.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 22, 2016, 06:58:28 AM
Thanks for adding those new elements. It doesn't seem like MenuIcon fg=XXX is having any effect though.
PS: It would also be nice to have a bitmap override for the menu icon, but it's a low priority.
its working fine here so i wont be able to help you with that
<element id="MenuIcon" fg="250,10,70" />

i probably wont do a bitmap override because there is special handling for aligning to the fonts used and for dpi scaling that needs special treatment
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 22, 2016, 01:56:50 PM
But what do you mean by "the PlayingIcon flashes on the last song played before closing the app. "?
playing another song causes MB to close?
I just saw that the bug was in a previous beta too.

1. Load a few tracks (let's say 10) on the Playing Tracks list.
2. Start playing track #3.
3. Close MusicBee
4. Open MusicBee
5. Start playing track #7        ---> PlayingIcon.Default flashes on #3 before moving to #7.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 22, 2016, 05:30:22 PM
1. Load a few tracks (let's say 10) on the Playing Tracks list.
2. Start playing track #3.
3. Close MusicBee
4. Open MusicBee
5. Start playing track #7        ---> PlayingIcon.Default flashes on #3 before moving to #7.
would you mind sending me your settings file? (help/ support/ view settings)
also could you confirm you are selecting a new song from the Now Playing list in the right sidebar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 22, 2016, 07:07:19 PM
would you mind sending me your settings file? (help/ support/ view settings)
also could you confirm you are selecting a new song from the Now Playing list in the right sidebar
File: https://dl.dropboxusercontent.com/u/10773406/MusicBee3Settings.ini
yes, I'm using Playing Tracks element docked on the right panel, but also happens if it's docked in the main panel, left panel...

BTW, also noticed that if I move the Playing Tracks element from the right panel to the main panel it still uses the NowPlayingList[TrackDetail] appearance, but after reopening the app it switches to Content[TrackDetail] appearance.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 22, 2016, 07:20:12 PM
thanks - i can reproduce the flashing as you describe using your settings so i should be able to fix it
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 23, 2016, 06:24:16 AM
the NotificationIcon and DownloadIndicatorIcon are out of alignment with the other panel icons.

NotificationIcon is 1px up
DownloadIndicatorIcon is 1px down

(I'm not really nit-picking, I can't help it, my OCD is showing) :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 08:09:08 AM
i will try and look at the skinning issues raised before the end of the weekend
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 11:45:30 AM
However, there is no Controls.SearchBoxPTop.NotActivated (bg, bdr) element. BTW, after using the searchbox and clearing it, it never returns to the NotActivated state. I don't remember if this happened on previous versions. You can see in DarkRED why I'm asking for both these things: https://dl.dropboxusercontent.com/u/10773406/DarkREDFlat3.xml
(I chose to use a "highlight" bg for the activated searchbox because in some panels search is activated by default, and without the highlight sometimes I don't notice it, but I'd prefer if it returns to NotActivated when it loses the focus.)
Of course if this implies too much work I can go back to use a uniform background (but I will still need Controls.SearchBoxPTop.NotActivated bg, bdr).
for the next v3 update:
Controls.SearchBoxPTop.NotActivated bg=XXX bdr=XXX

i have also changed the search box behavior so that when its empty and loses focus it reverts to the not activated state
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 12:04:29 PM
Therefor this is a request for an image overrule element for that.
for the next v3 updated i have removed:
Controls.WebLink
and added:
Controls.WebLinkIcon (16x16px)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 12:20:20 PM
This is a bit weird, and before I dive into this further, maybe somebody can confirm this. (I checked this with a few skins)

I have set <element id="Panel.HeaderButtonOverride.Highlight" bg="2,254,6" />
But this doesn't have any effect at all when I click, or hoover over a self-created toolbar button (text button, no icon).
that should be fixed for the next v3 update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 12:45:36 PM
fixes and changes as described above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 23, 2016, 12:59:40 PM
@ Steven
Have been trying the new icon overrides, but I can't work out where PlayingIcon.Highlight & PausedIcon.Highlight appear.
Default ones show up fine in all the right places, but highlight ones don't show on mouse-over or anywhere I can see.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 01:21:58 PM
Highlight was probably not the best name. Its when the row the playing track icon displays is selected
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 23, 2016, 02:14:18 PM
its working fine here so i wont be able to help you with that
<element id="MenuIcon" fg="250,10,70" />

Figured it out - I was confused because the element doesn't give you a 'true color', maybe because of the gradient effect.

i probably wont do a bitmap override because there is special handling for aligning to the fonts used and for dpi scaling that needs special treatment

Oh ok, fair enough. I was hoping to give the menu icon a sharper appearance to match the rest of my layout, like this:

(http://i.imgur.com/an13G3Gh.jpg) (http://i.imgur.com/an13G3G.jpg)

PS: Can this missing element be added? It's a lowlight override for the preferences scrollbar.

Code
<element id="Controls.ScrollBar.Lowlight" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 23, 2016, 03:05:44 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i have added:
  <element id="MenuButtonSharp">true</element>
  the colour override will also be a true colour with this setting
and
Controls.ScrollBar.Lowlight (not tested)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 23, 2016, 03:43:07 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i have added:
  <element id="MenuButtonSharp">true</element>
  the colour override will also be a true colour with this setting
and
Controls.ScrollBar.Lowlight (not tested)

Thanks! Really happy with the way those look.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 23, 2016, 08:39:52 PM
Highlight was probably not the best name. Its when the row the playing track icon displays is selected

It only changes in Track Detail view. 
Bug or by design?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 23, 2016, 10:01:48 PM
As soon as I click that button, suddenly for the other 'text' toolbar button the above highlight element coloring is activated.

To illustrate,
When I press the toolbar button (1) for 'show thumbnail browser', then toolbar button (2) gets the highlight color. (But the other button (3) doesn't)
(http://i.imgur.com/j5xOEkKl.jpg) (http://i.imgur.com/j5xOEkK.png)

edit:

And after the MB window loses focus after that, the button gets to look like this:
(http://i.imgur.com/6srrsHKl.jpg) (http://i.imgur.com/6srrsHK.png)

The first issue seems to be fixed.
The second is still present:

To replicate:
Have a toolbar command button for "show artwork", and press it without having any files selected:

(http://i.imgur.com/ylsIZHjl.jpg) (http://i.imgur.com/ylsIZHj.png)




Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 24, 2016, 02:42:40 AM
Therefor this is a request for an image overrule element for that.
for the next v3 updated i have removed:
Controls.WebLink
and added:
Controls.WebLinkIcon (16x16px)
Thanks for this one.  Looks much better :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 24, 2016, 07:47:02 AM
Highlight was probably not the best name. Its when the row the playing track icon displays is selected
It only changes in Track Detail view. 
Bug or by design?
Fot the Album and Tracks layout in the main panel the icon should not be painted against a selected row background
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 24, 2016, 08:34:17 AM
I must be a bit thick today, I'll try with pictures :D

(http://i.imgur.com/Kqa9Dlh.jpg) (http://imgur.com/Kqa9Dlh)
that's on selection!

(http://i.imgur.com/a1gf3JN.jpg) (http://imgur.com/a1gf3JN)

Is this how it's supposed too be?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 24, 2016, 09:08:57 AM
there is a small bug in the right sidebar Track Thumbs layout where it doesnt use the selected track playing icon.
That icon is only used if the panel is in focus

edit:
looking at the picture i think you might not be understanding what the selected track icon is for.
Imagine you have a white background and black icon. If the selection bar is black then you need a different colour for the icon. That only is needed when the icon is covered by the selection bar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 24, 2016, 09:09:36 AM
The second is still present:

To replicate:
Have a toolbar command button for "show artwork", and press it without having any files selected:
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 24, 2016, 07:36:25 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 26, 2016, 09:30:04 PM
i have added "ConsolidateButtonsIcon" for the next MB3 update
it will be automatically recoloured to the same colour as the existing icon

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 26, 2016, 10:27:53 PM
edit:
looking at the picture i think you might not be understanding what the selected track icon is for.
Imagine you have a white background and black icon. If the selection bar is black then you need a different colour for the icon. That only is needed when the icon is covered by the selection bar

I'm aware of the intended use of the icon, I just chose to use it in a different way for that skin :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 28, 2016, 06:41:44 AM
a part of <element id="TabsBar.BorderLine" shows under the close button on the tag editor floating window
(http://i.cubeupload.com/oJtmML.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on January 28, 2016, 07:12:22 AM
a part of <element id="TabsBar.BorderLine" shows under the close button on the tag editor floating window

And TabsBar.TabInCaptionBar.BorderLine shows at the same place on preferences window.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 28, 2016, 02:56:01 PM
With version 3, when a track is started, a small gap is created in the left side of the progress bar fill element:

(http://i.imgur.com/lhgaxnxl.jpg) (http://i.imgur.com/lhgaxnx.png)

I tried a lot of things, and I can get rid of the gap when I make the progress button less wide, but that will affect, and cuts-off some pixels from the left side of the progress bar element, and this:

(http://i.imgur.com/2cRdDSol.jpg) (http://i.imgur.com/2cRdDSo.png)

becomes this:

(http://i.imgur.com/pZKzDgRl.jpg) (http://i.imgur.com/pZKzDgR.png)


Maybe it's something in the xml file, but I tried lots of things and can't figure this out by myself.
(pm send with all relevant skin files in case you could look into this)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on January 28, 2016, 03:36:19 PM
With version 3, when a track is started, a small gap is created in the left side of the progress bar fill element:

Maybe it's something in the xml file, but I tried lots of things and can't figure this out by myself.
(pm send with all relevant skin files in case you could look into this)
I noticed the same. Also noticed some distortion on the ProgressBarButton as it moves, but only if the visible part of the image reaches the image border (with transparent pixels on the border there is no distortion)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 28, 2016, 03:39:46 PM
I noticed the same. Also noticed some distortion on the ProgressBarButton as it moves, but only if the visible part of the image reaches the image border (with transparent pixels o the border there is no distortion)

Thnx for confirming, this stuff often makes you doubt yourself....
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 28, 2016, 06:19:25 PM
a part of <element id="TabsBar.BorderLine" shows under the close button on the tag editor floating window

And TabsBar.TabInCaptionBar.BorderLine shows at the same place on preferences window.
would either you mind sending the skin in question as i cant reproduce this by applying that element
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 28, 2016, 06:20:39 PM
Maybe it's something in the xml file, but I tried lots of things and can't figure this out by myself.
(pm send with all relevant skin files in case you could look into this)
i can reproduce using your skin and will attempt to address it
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on January 28, 2016, 06:33:52 PM
a part of <element id="TabsBar.BorderLine" shows under the close button on the tag editor floating window

And TabsBar.TabInCaptionBar.BorderLine shows at the same place on preferences window.
would either you mind sending the skin in question as i cant reproduce this by applying that element

You can test with any of my 2.5 skins, like Pastels. But I only saw the latter, not the former.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 28, 2016, 08:07:55 PM
a part of <element id="TabsBar.BorderLine" shows under the close button on the tag editor floating window

And TabsBar.TabInCaptionBar.BorderLine shows at the same place on preferences window.
would either you mind sending the skin in question as i cant reproduce this by applying that element

You can test with any of my 2.5 skins, like Pastels. But I only saw the latter, not the former.

My mistake - redwing is correct - it's the TabsBar.TabInCaptionBar.BorderLine in both cases
Can be seen in Bleached Bone
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 28, 2016, 08:53:33 PM
My mistake - redwing is correct - it's the TabsBar.TabInCaptionBar.BorderLine in both cases
Can be seen in Bleached Bone
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 28, 2016, 09:18:19 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on January 28, 2016, 09:56:35 PM
Yep, that's fixed.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 29, 2016, 08:15:58 AM
working on fixing Faded skin...

if toolbar is consolidated into one icon, when the icons/buttons are displayed the bg colour is taken from element id="Panel.Header.Default".
works fine if header bar and caption bar aren't to different, otherwise it's hard to find a bg colour that works fine for icons in caption/below caption bar.
even a problem in MusicBee3 default skin.
(http://i.cubeupload.com/FFt9a0.jpg)

a caption bar override element for that background would be most helpful, please

EDIT:
was looking at some of the old elements and wondered if
element id="Panel.HeaderControl.Default
could be used to provide the alternate bg colour?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 29, 2016, 04:33:02 PM
@Steven
Could you help me figure out this (small) problem?

I reported before about the caption bar on my skin being slightly discolored and you mentioned it might the result of "stretching" due to the font I'm using, however I just compared it to DarkRED which has the correct color and with the exact same font.

What else could I be missing?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 29, 2016, 05:46:24 PM
@Steven
Could you help me figure out this (small) problem?

I reported before about the caption bar on my skin being slightly discolored and you mentioned it might the result of "stretching" due to the font I'm using, however I just compared it to DarkRED which has the correct color and with the exact same font.

What else could I be missing?
you will need to post a screenshot
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 29, 2016, 07:34:30 PM
you will need to post a screenshot

Edit: Nevermind, I realized what I was doing wrong - turns out I saved the PNG with sRGB conversion and that changed the colors.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 29, 2016, 08:00:52 PM
for the caption bar source image (if you are refering to the Coherant skin), every pixel is 21,21,21 ie. stretching it would make no difference anyway.
for the player bar source image, every pixel is 20,20,20 so again stretching will make no difference.
I'm really busy with addressing bugs for v3 so i cant really spend time helping you with this
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 29, 2016, 10:11:07 PM
if toolbar is consolidated into one icon, when the icons/buttons are displayed the bg colour is taken from element id="Panel.Header.Default".
works fine if header bar and caption bar aren't to different, otherwise it's hard to find a bg colour that works fine for icons in caption/below caption bar.
even a problem in MusicBee3 default skin.
a caption bar override element for that background would be most helpful, please

EDIT:
was looking at some of the old elements and wondered if
element id="Panel.HeaderControl.Default
could be used to provide the alternate bg colour?

backwards compatibility?
don't think it's a problem as it was usually a contrasting colour and most new skins, going forward, will probably only be for MB3 and later.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on January 30, 2016, 10:57:30 AM
Has anyone else experienced difficulties with the back/forward and panel layout buttons?
It seems like MusicBee is adding a color mask to these buttons and I'm not sure how to override it.
With the light theme skin I'm working on they are barely visible - I circled them in these screenshots (they should be black).

(http://i.imgur.com/cCjBX5K.png) (http://i.imgur.com/cCjBX5K.png) (http://i.imgur.com/T6bS7ji.png) (http://i.imgur.com/T6bS7ji.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on January 30, 2016, 11:04:11 AM
When you mouse over the controls on the compact player when the wave bar is used the highlight uses the metro buttons highlight. Occurs when use metro button is both enabled and disabled. Version 3.0.5872. Windows 10.

(http://i.imgur.com/VRM7LW4.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 11:37:28 AM
Has anyone else experienced difficulties with the back/forward and panel layout buttons?
It seems like MusicBee is adding a color mask to these buttons and I'm not sure how to override it.
With the light theme skin I'm working on they are barely visible - I circled them in these screenshots (they should be black).

(http://i.imgur.com/cCjBX5K.png) (http://i.imgur.com/cCjBX5K.png) (http://i.imgur.com/T6bS7ji.png) (http://i.imgur.com/T6bS7ji.png)
PanelBackDisabled
PanelForwardDisabled
if those images are not supplied then MB gets the colours from:
Panel.HeaderButtonOverride.Disabled
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 11:37:57 AM
When you mouse over the controls on the compact player when the wave bar is used the highlight uses the metro buttons highlight. Occurs when use metro button is both enabled and disabled. Version 3.0.5872. Windows 10.
which skin is this
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on January 30, 2016, 11:39:59 AM
When you mouse over the controls on the compact player when the wave bar is used the highlight uses the metro buttons highlight. Occurs when use metro button is both enabled and disabled. Version 3.0.5872. Windows 10.
which skin is this

False alarm. I found an error in the skin which was causing it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 30, 2016, 11:43:38 AM
if those images are not supplied then MB gets the colours from:
Panel.HeaderButtonOverride.Disabled

or CaptionBar.HeaderControl.Disabled
when in the caption bar :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 12:06:21 PM
With version 3, when a track is started, a small gap is created in the left side of the progress bar fill element:

(http://i.imgur.com/lhgaxnxl.jpg) (http://i.imgur.com/lhgaxnx.png)

I tried a lot of things, and I can get rid of the gap when I make the progress button less wide, but that will affect, and cuts-off some pixels from the left side of the progress bar element, and this:

(http://i.imgur.com/2cRdDSol.jpg) (http://i.imgur.com/2cRdDSo.png)

becomes this:

(http://i.imgur.com/pZKzDgRl.jpg) (http://i.imgur.com/pZKzDgR.png)


Maybe it's something in the xml file, but I tried lots of things and can't figure this out by myself.
(pm send with all relevant skin files in case you could look into this)
i am looking at this now. If you want the left and right arrows preserved then you should use dedicated left and right of progress bar images for that. See the bee-tunes skin for an example of implenting that if you are not familar with what i am saying.
With the arrangement you have, the left and right progress bar images will get overwritten when playback starts. I will fix the bug where its not doing that correctly

edit:
the reported bug is fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 30, 2016, 12:07:59 PM
with the analyse volume panel, i know you can't change the blue pointer on the slider, but can the graduations on the scale be changed?
(http://i.cubeupload.com/ZiLArV.jpg)

they're 196,196,196 in all skins.
could that be blended with the panel fg text colour so we don't have to have another override?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 12:09:33 PM
with the analyse volume panel, i know you can't change the blue pointer on the slider, but can the graduations on the scale be changed?
no - these are all controlled by windows. I would need to create my own control for this purpose which i dont think is a priority for the time i have available
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on January 30, 2016, 12:20:26 PM
no - these are all controlled by windows. I would need to create my own control for this purpose which i dont think is a priority for the time i have available

That's OK.  Now I also know it's a windows issue I agree.  It only impacts a few paler skins, but the numbers popping-up on moving the slider compensate in those cases.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 30, 2016, 12:36:59 PM
If you want the left and right arrows preserved then you should use dedicated left and right of progress bar images for that. See the bee-tunes skin for an example of implenting that if you are not familar with what i am saying.

Maybe I misunderstand what you mean exactly, but I don't think there are dedicated left and right progress bar images? Both bee-tunes and my example skin have:

- 'progressbar'
- 'progressbarfill'
- 'progressbarbutton'

I haven't got the opportunity now to investigate why they behave differently between bee-tunes and my sample skin, but I suspect it has to do with the width of these three images somehow influencing each other.

I'll patiently await what you come up with, and see if I then can get an exact grasp of their behavior.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 01:15:26 PM
what i said wasnt quitre right and the change made negatively affects other skins, so i will need to do some more on this. I will make it so the left and right sections of the progress bar image are always preserved (as was the original intention when i first did this years ago).
edit:
nope, its not going to work well with some of the skins such as beetunes. I will have to make a compromise where once playback starts the left section image for the progress bar narrows to not exceed the button width
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 02:46:13 PM
@hiccup, the way MB works with bitmap skins for the progress bar is MB uses the left side of the image provided as the left side of the progress bar, the middle section of the provided image as the fill colour, and the right side as the right side of the progress bar. Thats fine with your skin.
When playback starts MB uses the "Filler" image. In your case you have set it to a different size to the first image. It needs to be the same size and has the same behavior as the first image, except it only displays when playback has started and only applies to the left side of the progress bar.
I suggest you just copy ProgressBar.png to ProgressBarFill.png and put the green fill colour in the middle. Or if you want the arrows wiped out on playback then fill the entire image with green.
I have made one improvement for the next update for handling the progress bar width being smaller than the left/right side of the progress bar image. So until that update is made available it still wont work optimally for you
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 30, 2016, 03:26:46 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on January 31, 2016, 05:09:29 PM
@hiccup, the way MB works with bitmap skins for the progress bar is MB uses the left side of the image provided as the left side of the progress bar, the middle section of the provided image as the fill colour, and the right side as the right side of the progress bar. Thats fine with your skin.
When playback starts MB uses the "Filler" image. In your case you have set it to a different size to the first image. It needs to be the same size and has the same behavior as the first image, except it only displays when playback has started and only applies to the left side of the progress bar.
I suggest you just copy ProgressBar.png to ProgressBarFill.png and put the green fill colour in the middle. Or if you want the arrows wiped out on playback then fill the entire image with green.
I have made one improvement for the next update for handling the progress bar width being smaller than the left/right side of the progress bar image. So until that update is made available it still wont work optimally for you

Perfect. Thank you for addressing this so quickly, and explaining the exact workings.
It's working very well and predictable now. Thnx!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on January 31, 2016, 07:46:01 PM
It seems that if I use transparent background for FormRestoreButton & FormRestoreHighlightButton, they overlap with FormMaximiseButton (but not FormMaximiseHighlightButton when highlighted). Can you confirm and fix this if that's the case? (All other buttons work properly)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 31, 2016, 09:02:21 PM
It seems that if I use transparent background for FormRestoreButton & FormRestoreHighlightButton, they overlap with FormMaximiseButton (but not FormMaximiseHighlightButton when highlighted). Can you confirm and fix this if that's the case? (All other buttons work properly)
yes that does appear to be the case. I will make the change untested and if it still has problems after the next update can you send me the skin you are working on
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 31, 2016, 09:16:24 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on January 31, 2016, 09:54:42 PM
That's fixed. Thanks!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 02, 2016, 05:15:11 AM
A possible bug;
With the native button theme the forward and back buttons are not centered properly (relative to each other) in the tag edit popup window.

(http://i.imgur.com/80RXPzi.jpg) (http://i.imgur.com/80RXPzi.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 02, 2016, 11:42:56 AM
Is there a way not showing that 1px border on the right like v2.5 on the left?

(http://i.imgur.com/O2HpA06.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 02, 2016, 12:20:49 PM
Is there a way not showing that 1px border on the right like v2.5 on the left?

(http://i.imgur.com/O2HpA06.png)

If I am correct, to draw those borders, v3 doesn't display the exact pixel borders as they are in the border images, but for the left and right ones it only looks at the most left pixels, and for the top it calculates some average from that image.
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 02, 2016, 12:26:08 PM
If I am correct, to draw those borders, v3 doesn't display the exact pixel borders as they are in the border images, but for the left and right ones it only looks at the most left pixels, and for the top it calculates some average from that image.
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

And I'm sure Steven said that rounded corners stuffs up Windows 10, so all borders now need to be square.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 02, 2016, 12:30:29 PM
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

And I'm sure Steven said that rounded corners stuffs up Windows 10, so all borders now need to be square.

Ah yes, true indeed.
The transparent corner pixels are being ignored anyway for v3, but it might be safe to color them accordingly now to prevent some possible unexpected colouring.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 02, 2016, 12:59:22 PM
If I am correct, to draw those borders, v3 doesn't display the exact pixel borders as they are in the border images, but for the left and right ones it only looks at the most left pixels, and for the top it calculates some average from that image.
Therefor you should be able to get the color you like by drawing the whole top border image in 1 color.

I don't understand what you mean. All skins I've been testing show the same 1px border surrounding any windows. I'm sure that's what Windows is doing but my question is whether it's possible to hide that border like v2.5 using some sort of override setting.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 02, 2016, 01:13:03 PM
I don't understand what you mean. All skins I've been testing show the same 1px border surrounding any windows. I'm sure that's what Windows is doing but my question is whether it's possible to hide that border like v2.5 using some sort of override setting.

I was assuming you were creating a skin, and had troubles with getting the correct border colours.
But I understand you are referring to the thin border line Windows 10 is adding. Steven has spent lots of time and effort on getting the behavior of borders right for v3, and explained he can't avoid this line showing up.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 02, 2016, 01:26:25 PM
I was assuming you were creating a skin, and had troubles with getting the correct border colours.
But I understand you are referring to the thin border line Windows 10 is adding. Steven has spent lots of time and effort on getting the behavior of borders right for v3, and explained he can't avoid this line showing up.

Thanks for the info! That's too bad. Most of my colored skins look as if something's broken when resized and with any popup window.
Steven, can't you provide an override setting that would handle border images just like v2.5?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 02, 2016, 02:21:38 PM
A missing element is needed for the compact player when viewed in artist picture mode, since the previous maroon color is still visible.

element id="NowPlayingArtistTrackInfo"

(http://i.imgur.com/xFGOixX.jpg) (http://i.imgur.com/xFGOixX.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 02, 2016, 05:34:42 PM
Can anyone confirm that the column/filter browser does not currently support alternating row colors?
Edit: I found an old post saying it was intentionally not supported, but it also mentioned an override might be added at a later date.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 02, 2016, 06:25:48 PM
Thanks for the info! That's too bad. Most of my colored skins look as if something's broken when resized and with any popup window.
Steven, can't you provide an override setting that would handle border images just like v2.5?
i wont answer the question right now but what do you mean by looking broken when resized?
The single px borders are drawn by windows with the exception of the top border line. When the window is active the top border line should match (maybe with a very slight variation) but when the window is inactive then MB sets the inactive colour to gray because the real colour is not made available via an API. It doesnt seem to match for your screenshot. Is this what you are refering to?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 02, 2016, 07:06:18 PM
A missing element is needed for the compact player when viewed in artist picture mode, since the previous maroon color is still visible.
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 02, 2016, 07:43:36 PM
Can anyone confirm that the column/filter browser does not currently support alternating row colors?
Edit: I found an old post saying it was intentionally not supported, but it also mentioned an override might be added at a later date.

It's possible. There have been elements added so you can separately set coloring (and alternating lines) for both  id="FilterPanel  and  id="ColumnBrowser.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 02, 2016, 09:02:06 PM
Thanks for the info! That's too bad. Most of my colored skins look as if something's broken when resized and with any popup window.
Steven, can't you provide an override setting that would handle border images just like v2.5?
i wont answer the question right now but what do you mean by looking broken when resized?
The single px borders are drawn by windows with the exception of the top border line. When the window is active the top border line should match (maybe with a very slight variation) but when the window is inactive then MB sets the inactive colour to gray because the real colour is not made available via an API. It doesnt seem to match for your screenshot. Is this what you are refering to?

I was referring to the top border line of the main window (inactive) and all border lines surrounding preferences panel (active) in my screenshot.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 02, 2016, 10:02:53 PM
It's possible. There have been elements added so you can separately set coloring (and alternating lines) for both  id="FilterPanel  and  id="ColumnBrowser.

I put the same code for both of those and it only works for the column browser.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 02, 2016, 10:06:12 PM
I was referring to the top border line of the main window (inactive) and all border lines surrounding preferences panel (active) in my screenshot.
i will check this out on my win10 machine tomorrow. The borders are (should be) controlled by windows, except the top border as described. So i dont know why your active preferences screen would show the wrong border colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 02, 2016, 10:22:17 PM
Can anyone confirm that the column/filter browser does not currently support alternating row colors?
Edit: I found an old post saying it was intentionally not supported, but it also mentioned an override might be added at a later date.
the thumb browser definitely (intentionally) doesnt support alternating rows but i could put it in the override now.
the column browser should support alternating rows. I wouldnt be surprised if the filter panels override doesnt. Are you also saying the column browser overiddes dont as well?
it might be best if you explicitly state the elements you are using so there is no confusion
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 02, 2016, 10:23:20 PM
i will check this out on my win10 machine tomorrow. The borders are (should be) controlled by windows, except the top border as described. So i dont know why your active preferences screen would show the wrong border colours

Here's a full screenshot. Preferences panel active (left) and main window active (right) with Windows' "auto pick accent color from background" option turned on.

http://i.imgur.com/ZP3mWn8.png
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 02, 2016, 10:27:07 PM
the thumb browser definitely (intentionally) doesnt support alternating rows but i could put it in the override now.
the column browser should support alternating rows. I wouldnt be surprised if the filter panels override doesnt. Are you also saying the column browser overiddes dont as well?
it might be best if you explicitly state the elements you are using so there is no confusion

Sorry for the confusion, the column browser does support alternating rows, it's just the filter/thumb browser that doesn't.
An override would be much appreciated.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 02, 2016, 10:31:02 PM
Here's a full screenshot. Preferences panel active (left) and main window active (right) with Windows' "auto pick accent color from background" option turned on.

http://i.imgur.com/ZP3mWn8.png
so its what i said then - the inactive top border is a guessed value. It is not working well because (a) the guessed value is quite different from the real value in your windows setup and (b) the skin itself highlights the inconsistency. I will see if it can be improved or if there is some way to get the correct value. And if thats not possible i will think about what can be done
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 02, 2016, 10:39:25 PM
so its what i said then - the inactive top border is a guessed value. It is not working well because (a) the guessed value is quite different from the real value in your windows setup and (b) the skin itself highlights the inconsistency. I will see if it can be improved or if there is some way to get the correct value. And if thats not possible i will think about what can be done

What about the surrounding border line of an active window? That's what makes a skin look broken whereas v2.5 works perfect on Windows 10 without showing that line both for active and inactive windows.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 03, 2016, 06:55:14 AM
What about the surrounding border line of an active window? That's what makes a skin look broken whereas v2.5 works perfect on Windows 10 without showing that line both for active and inactive windows.
those lines are drawn by windows. Are you saying that other application windows use a different single px colour?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 03, 2016, 08:06:25 AM
What about the surrounding border line of an active window? That's what makes a skin look broken whereas v2.5 works perfect on Windows 10 without showing that line both for active and inactive windows.
those lines are drawn by windows. Are you saying that other application windows use a different single px colour?

Of course other apps use the same accent color for that border except one app which doesn't show the border at all. Guess what that app is, reading what I said above again.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 03, 2016, 06:13:51 PM
Of course other apps use the same accent color for that border except one app which doesn't show the border at all. Guess what that app is, reading what I said above again.
no need for the snark - i need to be very clear on what people are saying before i spend valuable time investigating. I wont commit to the no borders until i know whats involved and it certainly isnt trivial as you might think or simply a case of doing it the same as v2.5 without other consequences.
I do have an idea for the inactive border colours which i will try later
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 03, 2016, 07:30:46 PM
Sorry, no offense meant.
Regarding Windows' accent color border for an active window, I don't really get their intention. Whatever color the user may pick it always won't match many apps. Also auto-pick background color option only makes sense when main window is not maximized. I think either the border itself should be able to be disabled or an app should be able to override the color. Hopefully you find some way to do that, but if not, don't worry too much. I will just accept the way Windows is designed.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 04, 2016, 03:49:26 AM
@Steven
Not to rush you, but I'm finishing up a new skin and was hoping to get the code ready regarding the thumb browser override.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 04, 2016, 10:30:12 AM
with a monochromatic skin like Arsenic, a bit more contrast between the auto generated colours for the check mark and the box infill is needed, please.

(http://i.cubeupload.com/TfbJTT.jpg)

or an override, if that's the easier of the two.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 04, 2016, 06:53:06 PM
@Steven
Not to rush you, but I'm finishing up a new skin and was hoping to get the code ready regarding the thumb browser override.
i have activated the alternating row colours if the FilterPanel override colours are set.
If it turns out its causing issues with some of the other skins, i will add a new setting so its activated
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 04, 2016, 07:44:31 PM
with a monochromatic skin like Arsenic, a bit more contrast between the auto generated colours for the check mark and the box infill is needed, please.
i dont think i can adjust the colours to suit so i have added this override:
Controls.LargeTickBoxFill bg=XXXX
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 04, 2016, 08:46:32 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 04, 2016, 09:57:56 PM
i have activated the alternating row colours if the FilterPanel override colours are set.
If it turns out its causing issues with some of the other skins, i will add a new setting so its activated

Great, thanks - can confirm its working.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 04, 2016, 10:32:16 PM
i dont think i can adjust the colours to suit so i have added this override:
Controls.LargeTickBoxFill bg=XXXX
working great!
Thank you :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 05, 2016, 10:59:27 AM
I've been thinking about how to further fine tune my skin and there is one area that could use more customization, the Now Playing node.

The playing tracks panel (right sidebar) in Now Playing currently takes its colors from "Content[TrackDetail]", but ideally I would rather it take colors from "NowPlayingList[TrackDetail]". If this were the case, the neighboring panel (main panel right side) would probably also take its colors from "NowPlayingList[TrackDetail].ListAlternating.Default".

Alternatively, maybe it would be best to have overrides specifically for the Now Playing node, both for the playing tracks panel and the lyrics/biography panel. For example; "NowPlayingNode.List[TrackDetail]" and "Panel.NowPlayingNode.ChildBody".

Here's a couple pictures to demonstrate my proposal (you may need to flip between the images to see the contrast).

First image, how it looks now: http://i.imgur.com/5HyAqOS.jpg
Second image, how I would like it to look: http://i.imgur.com/R6mOXkE.jpg
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 06, 2016, 03:35:59 PM
just while i remember to mention this:
For the next update I have added support for arranging the (vertically oriented) column browser to left of the thumb browser. In that case only, MB will use the thumb browser colours in place of any column browser override value you have ie. the column browser will blend in with the thumb browser in that config.
I dont think this will affect many skins, but if it wasnt done that way you can get darker/ lighter colour variation between the left sidebar - column browser - thumb browser - main panel
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 06, 2016, 03:49:10 PM
The playing tracks panel (right sidebar) in Now Playing currently takes its colors from "Content[TrackDetail]", but ideally I would rather it take colors from "NowPlayingList[TrackDetail]". If this were the case, the neighboring panel (main panel right side) would probably also take its colors from "NowPlayingList[TrackDetail].ListAlternating.Default".

Alternatively, maybe it would be best to have overrides specifically for the Now Playing node, both for the playing tracks panel and the lyrics/biography panel. For example; "NowPlayingNode.List[TrackDetail]" and "Panel.NowPlayingNode.ChildBody".
i agree the right panel should use any "NowPlayingList[TrackDetail]..." override and i have made that change (keep in mind that although most people will show the playing tracks in the right sidebar, you can configure the right panel to show lyrics or the artist bio and they would also use this override)
For the Large Album layout only, MB uses "Content[Artwork].Body.Default" as the colour base for the main panel area (not the right sidebar). I will add in an override

Content[NowPlaying].Body.Default bg=xxxx fg=xxxx
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 06, 2016, 04:03:43 PM
changes as described above
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 06, 2016, 04:12:19 PM
Regarding Windows' accent color border for an active window, I don't really get their intention. Whatever color the user may pick it always won't match many apps. Also auto-pick background color option only makes sense when main window is not maximized. I think either the border itself should be able to be disabled or an app should be able to override the color. Hopefully you find some way to do that, but if not, don't worry too much. I will just accept the way Windows is designed.
i have given up trying to get the inactive border line on the header bar the exact correct colour. For the past couple of days i changed it so it blends more with the header bar so its less obviously wrong.
I am going to attempt providing an option so that skins can disable the windows 10 border. It would mean the borders are painted and handled as 4px just like with windows 7
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 06, 2016, 05:12:27 PM
to disable the single px border on windows 10, and instead show the skinned 4px border that would have shown in earlier windows versions i have added this override

  <element id="DisableSinglePxBorder">true</element>
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 06, 2016, 05:36:21 PM
to disable the single px border on windows 10, and instead show the skinned 4px border that would have shown in earlier windows versions i have added this override

  <element id="DisableSinglePxBorder">true</element>

Thanks! Working great!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 06, 2016, 06:45:23 PM
@Steven
Thanks, I'm happy with those results.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 07, 2016, 12:45:32 PM
I have several skins with gradient style top border and currently it looks like this with <element id="MenuButton.Default" bg="0,3,0" fg="0,204,0" />

(http://i.imgur.com/PH22cIK.png)

I would like to have the menu button blended into caption bar without having its own bg and bdr. But currently it defaults to bg of Panel.Body.Default if bg is not set.
Can you provide a setting that would respect only fg of MenuButton.Default and make the rest transparent?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on February 07, 2016, 03:45:09 PM
For the Large Album layout only, MB uses "Content[Artwork].Body.Default" as the colour base for the main panel area (not the right sidebar). I will add in an override
Content[NowPlaying].Body.Default bg=xxxx fg=xxxx
I can't find this. I don't get where it's applied exactly... maybe I'm looking in the wrong place?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 07, 2016, 03:57:53 PM
click the "Now Playing" node, and then select "Large Album" from the "Now Playing" button
The colours should be applied to the main panel which usually show the album cover and lyrics ie. the lyrics should use the override colour in this case

"NowPlayingLargeAlbumTrackInfo" is used to override the track info section of that layout and if its not specified then that section is coloured as a brightness adjustment from the rest of the panel
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 08, 2016, 06:03:31 AM
I have several skins with gradient style top border and currently it looks like this with <element id="MenuButton.Default" bg="0,3,0" fg="0,204,0" />

(http://i.imgur.com/PH22cIK.png)

I would like to have the menu button blended into caption bar without having its own bg and bdr. But currently it defaults to bg of Panel.Body.Default if bg is not set.
Can you provide a setting that would respect only fg of MenuButton.Default and make the rest transparent?

If you add into the skin
<element id="UseModernMenuButton">true</element>
the menu button will be transparent, with text colour from
<element id="TitlebarActiveForeColour" bg="XXX" />
<element id="TitlebarInactiveForeColour" bg="XXX" />
and the menu icon from the new element
<element id="MenuIcon" fg="XXX" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 08, 2016, 06:17:13 AM
working on updating MetroTouch and TouchLite bitmap skins.
these are my most frequently downloaded skins (not sure if it's people using them on touch enabled screens or users with bad eye-sight like the big buttons :)  )

you probably know that touch screens can't show the highlight icons as they are only two state devices (on or off) and you don't have a hover option like with a mouse.
the repeat/shuffle/etc buttons are fine as they already have on/off states, but the player controls don't have this option.

could the skin creator be tweaked so that the player controls have on/off states please.

It's not an urgent priority but I thought I'd get it out there for sometime in the future.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 08, 2016, 03:34:55 PM
I will add in an override

Content[NowPlaying].Body.Default bg=xxxx fg=xxxx

Regarding this override element - I just realized the background color is not 100% accurate in MusicBee, for instance my code has bg="200,200,200" but the resulting color is actually "217,217,217", and the same disparity applies with other colors.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 08, 2016, 08:14:58 PM
For the next update I have added support for arranging the (vertically oriented) column browser to left of the thumb browser.

When the column browser is docked to the left of the thumb browser there is a visible dividing line between them, would it be possible to make an override for that? I took a screenshot and marked the area in red.

(http://i.imgur.com/3J07IeR.jpg) (http://i.imgur.com/3J07IeR.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 08, 2016, 08:23:56 PM
I would like to have the menu button blended into caption bar without having its own bg and bdr. But currently it defaults to bg of Panel.Body.Default if bg is not set.
Can you provide a setting that would respect only fg of MenuButton.Default and make the rest transparent?

If you add into the skin
<element id="UseModernMenuButton">true</element>

Thanks! The setting does exactly what I was looking for: ignore bg and only respect fg of MenuButton.Default
I found out with that setting MenuButton.Default must be present with a dummy bg and working fg, otherwise the button won't show.

the menu button will be transparent, with text colour from
<element id="TitlebarActiveForeColour" bg="XXX" />
<element id="TitlebarInactiveForeColour" bg="XXX" />
and the menu icon from the new element
<element id="MenuIcon" fg="XXX" />

I can't make this work. As long as fg of MenuButton.Default is set (it has to, otherwise the button won't show), bg of TitlebarActiveForeColour and TitlebarInactiveForeColour has no effect on menu button. In other words, with MenuButton.Default set, there's no way to display inactive forecolor for the button.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 08, 2016, 09:20:51 PM
the menu button will be transparent, with text colour from
<element id="TitlebarActiveForeColour" bg="XXX" />
<element id="TitlebarInactiveForeColour" bg="XXX" />
and the menu icon from the new element
<element id="MenuIcon" fg="XXX" />

I can't make this work. As long as fg of MenuButton.Default is set (it has to, otherwise the button won't show), bg of TitlebarActiveForeColour and TitlebarInactiveForeColour has no effect on menu button. In other words, with MenuButton.Default set, there's no way to display inactive forecolor for the button.

Have a look at my Aurora skin from the Tundra series.  It still has MenuButton.Default in it for backwards compatibility, but in MB3 its values are ignored and the ForeColours and MenuIcon values are used.

You can even delete the MenuButton.Default element completely and it still works fine.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 08, 2016, 09:45:00 PM
Have a look at my Aurora skin from the Tundra series.  It still has MenuButton.Default in it for backwards compatibility, but in MB3 its values are ignored and the ForeColours and MenuIcon values are used.

You can even delete the MenuButton.Default element completely and it still works fine.

Just tested Aurora. Are you sure you have set main menu option to "show as button"?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 08, 2016, 10:54:26 PM
Just tested Aurora. Are you sure you have set main menu option to "show as button"?

My mistake.
was working on another skin and had not reset "show as button"

In other words, with MenuButton.Default set, there's no way to display inactive forecolor for the button.

That is correct. I'd say it's to do with combining the top menu with the panel heading.
It only effects the main panel.  All the floating panels use the fore-colours.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 08, 2016, 11:46:44 PM
BTW how did you find out the setting? I can't find any posts mentioning it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 09, 2016, 12:27:40 AM
BTW how did you find out the setting? I can't find any posts mentioning it.

When it was still MB3Demo the .xml of the demo skin had
<element id="UseModernLayout">true</element>
<element id="UseModernMenuButton">true</element>
in it.

I thought that the "Modern" elements were defunct, so I removed them and discovered it effected the Menu Button.
I didn't put it in my MB3 elements list as I thought it was an old one that I was wrong about being defunct.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 09, 2016, 09:29:27 AM
Thanks. I'll add the latter to the new element list.
According to this, the former could be safely removed.

  <element id="ClassicNewTabButton">true</element>
  <element id="UseModernLayout">false</element>

Do these two still have a function?
They don't seem to have any effect anymore.
no - these elements no longer serve any purpose with the new functionality
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 11, 2016, 01:03:47 PM
could the little divider in the status bar coloured by the bdr attribute of
<element id="Panel.StatusBar.Default"
be removed please
(http://i.imgur.com/sAEqkzl.gif)

it is only seen under the main panel/right main panel divider when the right sidebar is set to show.
it doesn't stay in the same place if the sidebar is closed and I think the status bar looks better without it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 12, 2016, 01:32:43 PM
Could somebody confirm that the bdr element for id="NowPlayingList[TrackDetail].Default" is not working anymore?

That border seems to keep the color of <element id="Content[TrackDetail].ItemSeparatorLine".

tia
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 12, 2016, 02:08:19 PM
Could somebody confirm that the bdr element for id="NowPlayingList[TrackDetail].Default" is not working anymore?

That border seems to keep the color of <element id="Content[TrackDetail].ItemSeparatorLine".

As you said, fg of the latter seems to be doing what the former is supposed to do.
But the former is instead working as bdr of NowPlayingList[TrackDetail].Highlight.
The bdr of NowPlayingList[TrackDetail].Highlight seems to do nothing.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 12, 2016, 02:16:39 PM
Could somebody confirm that the bdr element for id="NowPlayingList[TrackDetail].Default" is not working anymore?

That border seems to keep the color of <element id="Content[TrackDetail].ItemSeparatorLine".

As you said, fg of the latter seems to be doing what the former is supposed to do.
But the former is instead working as bdr of NowPlayingList[TrackDetail].Highlight.
The bdr of NowPlayingList[TrackDetail].Highlight seems to do nothing.

Thnx redwing

@Steven, could you have a look at this?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 12, 2016, 02:39:06 PM
Well, I have to make a correction. Tried again, and saw bdr of NowPlayingList[TrackDetail].Highlight working fine.
As you said, the problem is with bdr of NowPlayingList[TrackDetail].Default, not with Highlight.
Sorry for the confusion.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 12, 2016, 05:47:57 PM
This short border line showed up in compact player.
(phred on the lookout skin)

(http://i.imgur.com/7M4QOmHl.jpg) (http://i.imgur.com/7M4QOmH.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on February 12, 2016, 07:10:08 PM
I didn't intentional remove it, nor did I intentionally place it there, but this is what it's looking like for me (after some changes earlier today)
(http://i.imgur.com/U480f89l.jpg) (http://i.imgur.com/U480f89.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 12, 2016, 07:37:26 PM
I didn't intentional remove it, nor did I intentionally place it there, but this is what it's looking like for me (after some changes earlier today)
(http://i.imgur.com/U480f89l.jpg) (http://i.imgur.com/U480f89.jpg)

It's probably not something with your skin. I am working on joto v3, and there it shows too, while in others skins it (currently) doesn't.
Never mind, nothing to lose sleep over.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 16, 2016, 08:01:02 PM
On a small hi-res tablet with Windows set to '150%', this corruption of the player panel occurs:

(http://i.imgur.com/Nm6i0ISl.jpg) (http://i.imgur.com/Nm6i0IS.png)

(http://i.imgur.com/UKMbWUhl.jpg) (http://i.imgur.com/UKMbWUh.png)

Mind you, with these two skins (Zen Hive and Crimson Creme) I knowingly misused the intended use of TrackInfoPanel, so this might not be a general issue at all.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 16, 2016, 08:27:58 PM
When using the mouse scroll wheel on the volume bar in the player panel, the side player panel gives distorted digits for volume:

(http://i.imgur.com/x7mv1dPl.jpg) (http://i.imgur.com/x7mv1dP.png)

(Zen Hive skin)

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on February 17, 2016, 09:13:33 AM
Why is the border element for highlight/lowlight track details open ended rather than enclosed (ie. no edges on either side)?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 17, 2016, 06:24:08 PM
In the Views Configuration panel, the bottom border line of the highlighted entry is not visible:

(http://i.imgur.com/khEEeELl.jpg) (http://i.imgur.com/khEEeEL.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 18, 2016, 06:44:33 PM
This short border line showed up in compact player.
(phred on the lookout skin)

(http://i.imgur.com/7M4QOmHl.jpg) (http://i.imgur.com/7M4QOmH.png)
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 18, 2016, 10:39:25 PM
<element id="DeleteIcon"> currently takes it's colour from
<element id="Panel.StatusBarControl.Default" fg="XXX"/>

given that it appears with the text coloured by
<element id="Panel.StatusBar.Default" bg="XXX" fg="XXX" bdr="XXX" />
wouldn't it be better if the icon was also coloured by that fg attribute?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 19, 2016, 07:30:20 PM
When using the mouse scroll wheel on the volume bar in the player panel, the side player panel gives distorted digits for volume:
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 20, 2016, 02:19:19 PM
For most panes you can set a distinguishing colour for the horizontal borders which you are able to grab and resize.
It's quite important to be able to do that from a user-interface point of view.
Also it helps a lot on smaller touch screens to be able to indicate clearly what borders can be grabbed, and where exactly.

One pane that (I believe) doesn't provide for such a distinguishing indication is the albumart pane.
It will follow the bdr element of body.default, which is not always needed to be so much discriminating colouring wise.

So this is a request for a new element for that border line.

And it would also help to be able to get some more consistency in looks:

(http://i.imgur.com/WPzvljvs.jpg) (http://i.imgur.com/WPzvljv.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on February 21, 2016, 12:04:47 PM
Can you support a skin setting that highlights (and lowlights) each filter instead of Music node?
This would be much easily discernible for selected filter compared with the current tick mark.

(http://i.imgur.com/3tEKvY0.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 21, 2016, 05:12:52 PM
Could somebody confirm that the bdr element for id="NowPlayingList[TrackDetail].Default" is not working anymore?

That border seems to keep the color of <element id="Content[TrackDetail].ItemSeparatorLine".
i am not sure that was ever implemented but it is now for the next v3 update.
However if it causes issues with some skins then i might need to implement it as a separate element
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 21, 2016, 05:19:55 PM
could the little divider in the status bar coloured by the bdr attribute of
<element id="Panel.StatusBar.Default"
be removed please
i have removed it for the next update

In the Views Configuration panel, the bottom border line of the highlighted entry is not visible:
i have made a change to address that
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 21, 2016, 05:24:29 PM
<element id="DeleteIcon"> currently takes it's colour from
<element id="Panel.StatusBarControl.Default" fg="XXX"/>

given that it appears with the text coloured by
<element id="Panel.StatusBar.Default" bg="XXX" fg="XXX" bdr="XXX" />
wouldn't it be better if the icon was also coloured by that fg attribute?
i think the reason was because it looks too strong if done that way and using Panel.StatusBarControl.Default
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 21, 2016, 05:29:32 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 21, 2016, 08:30:56 PM
Could somebody confirm that the bdr element for id="NowPlayingList[TrackDetail].Default" is not working anymore?

That border seems to keep the color of <element id="Content[TrackDetail].ItemSeparatorLine".
i am not sure that was ever implemented but it is now for the next v3 update.
However if it causes issues with some skins then i might need to implement it as a separate element

I think you are right it probably never worked before.
Looking at some of my own skins, they indeed look different now, so I will need to make some changes to them.
Not a problem, but this probably means other skins will be affected too.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 21, 2016, 08:34:03 PM
i am going to take it out for now and add a new element at a later date
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 22, 2016, 12:49:53 AM
could the little divider in the status bar coloured by the bdr attribute of
<element id="Panel.StatusBar.Default"
be removed please
i have removed it for the next update
Thank you :)

given that it appears with the text coloured by
<element id="Panel.StatusBar.Default" bg="XXX" fg="XXX" bdr="XXX" />
wouldn't it be better if the icon was also coloured by that fg attribute?
i think the reason was because it looks too strong if done that way and using Panel.StatusBarControl.Default
OK.  I thought if you have any action minimised to the status bar you would want that cancel icon to be fairly noticeable.

When using a highlight image for the volume slider button in a bitmap skin
<images category="Button"
    default="Images\RoundMidnight\volumebutton_RM.png"
    highlight="Images\RoundMidnight\volumebutton_RM_hi.png"
  />
</element>,
the highlight no longer appears in MB3
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on February 23, 2016, 09:19:15 PM
Thank you. now working even when using the pop-up volume.
But, can you tell me where the volume indicator is drawing its colour from?
It shows in some skins, but not others.
PlayerMini.Control.Default
but if that or the PlayerMini.Background element is not defined, then the colors are retrieved from the sidebar player

Thanks for that, but when I said it was working, I got it a little bit wrong.  :o

When the mini player is small enough to have to use the pop-up volume, everything now shows on top of the player - except the volume slider button.
this is probably fixed for the next update but if it still happens i would need to know the skin name
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on February 25, 2016, 07:39:36 PM
When the tag editor panel is docked to the main panel, then MB loses focus to another application, and then regains focus, some display corruption occurs at the location where the scroll bar might be. (if there was enough content to scroll...)

(http://i.imgur.com/AbBeFN6l.jpg) (http://i.imgur.com/AbBeFN6.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 26, 2016, 10:38:32 PM
when using the save artwork dialog, the background for 'link to an organised copy of the picture' still uses the disabled colours even when selected
(http://i.cubeupload.com/KCCosU.jpg)
I'm assuming that's because it's a non-editable window, but, to me anyway, it would make more sense to use Controls.InputControl.Lowlight to indicate that the tick in the check box has actually activated that selection
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on February 27, 2016, 08:05:13 PM
If <element id="UseModernMenuButton">true</element> is used in a skin it only overrides the default icon.
If you change the icon in Preferences (to use a different notification area icon) the modern menu button gets overridden as well.
Shouldn't the skin setting for the menu button have priority in all cases?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 05, 2016, 01:16:36 AM
Does anyone know what element controls the colors of expanded panel in album/artists view when auto-pick color option is disabled?
If that's auto-generated, please support overrides for bg & fg of the expanded panel.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 05, 2016, 12:24:20 PM
just while i remember - i am adding an optional bg2 to these so you can get a fade effect
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="235,25,25" bg2="245,245,245" />
and adding this for the new artwork grouping
<element id="Content[Artwork].SplitterLine" bg="235,25,25" bg2="245,245,245" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 05, 2016, 06:23:03 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 06, 2016, 03:56:14 AM
just while i remember - i am adding an optional bg2 to these so you can get a fade effect
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="235,25,25" bg2="245,245,245" />
and adding this for the new artwork grouping
<element id="Content[Artwork].SplitterLine" bg="235,25,25" bg2="245,245,245" />

Thanks, but the last element has no effect. The lines in album/artists view get the color from Content[AlbumAndTracks].ArtistSplitterLine element. Also support Content[Artwork].Header element.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on March 06, 2016, 09:43:00 AM
Does anyone know what element controls the colors of expanded panel in album/artists view when auto-pick color option is disabled?
If that's auto-generated, please support overrides for bg & fg of the expanded panel.

I'm pretty sure that panel isn't skinnable.

+1 for new skinning elements for it.

And if possible, have the option for a gradient for the background, and the option to choose separate colors/brightness for the larger vs the smaller fonts.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 06, 2016, 10:21:43 AM
Thanks, but the last element has no effect. The lines in album/artists view get the color from Content[AlbumAndTracks].ArtistSplitterLine element. Also support Content[Artwork].Header element.
thats fixed.
for the second point, because Content[Artwork].Header used to be used for something else i will add a new element: Content[Artwork].GroupingHeader
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 06, 2016, 12:00:08 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 06, 2016, 12:36:41 PM
Thanks, but the last element has no effect. The lines in album/artists view get the color from Content[AlbumAndTracks].ArtistSplitterLine element. Also support Content[Artwork].Header element.
thats fixed.
for the second point, because Content[Artwork].Header used to be used for something else i will add a new element: Content[Artwork].GroupingHeader

Working fine now (grouping header too). Thanks!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 06, 2016, 12:43:46 PM
When a pinned tab shows icon only, both TabsBar.InactiveTabIconMask and TabsBar.InactiveTabInCaptionIconMask are not working. For icon+text, they work fine.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 07, 2016, 12:21:30 AM
When a pinned tab shows icon only, both TabsBar.InactiveTabIconMask and TabsBar.InactiveTabInCaptionIconMask are not working. For icon+text, they work fine.

It's fixed. Thanks!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 10, 2016, 01:26:02 AM
just while i remember - i am adding an optional bg2 to these so you can get a fade effect
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="235,25,25" bg2="245,245,245" />
and adding this for the new artwork grouping
<element id="Content[Artwork].SplitterLine" bg="235,25,25" bg2="245,245,245" />
with these new elements (which I love BTW) the brighter of the 2 colours leaves 1px dot at end opposite to main part
(http://i.imgur.com/Yjpj6ss.jpg) (http://imgur.com/Yjpj6ss)

<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="9,20,37" bg2="58,113,207"/>

if you reverse the colour values the dot appears at the RH end
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 10, 2016, 05:51:27 PM
@bee-liever, i was going to remove support for the bg2 component when both left and right headers are used but instead i will add a new element
Content[AlbumAndTracks].ArtistSplitterLineLR
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 10, 2016, 08:51:43 PM
@bee-liever, i was going to remove support for the bg2 component when both left and right headers are used but instead i will add a new element
Content[AlbumAndTracks].ArtistSplitterLineLR
OK. thanks for that one, but the single pixel error also occurs with
<element id="Content[Artwork].SplitterLine" bg="235,25,25" bg2="245,245,245" />

the only one that it doesn't happen on is
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
and I think that's because the text is in line with the fading line
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 10, 2016, 09:03:10 PM
the only one that it doesn't happen on is
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
and I think that's because the text is in line with the fading line
Yep, as I thought, the text is covering the pixel when the brighter colour is bg2.
If you reverse the colours and bg is the brighter colour, the single pixel shows up on the RH side even in track detail
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 10, 2016, 09:13:17 PM
two separate issues - the dot is fixed for the next update and the different element used for when left & right headers is so you can control the fading if its just a left only header vs. a left & right header
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 10, 2016, 09:54:44 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 11, 2016, 05:32:02 AM
two separate issues - the dot is fixed for the next update and the different element used for when left & right headers is so you can control the fading if its just a left only header vs. a left & right header

all working fine
thank you :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 11, 2016, 08:22:12 AM
Can you support Controls.ArtistThumb element for thumbnail browser for consistency with genre and album color?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 11, 2016, 11:08:40 AM
Can you support Controls.ArtistThumb element for thumbnail browser for consistency with genre and album color?

Granted it's not as easy as a colour override, but you can use
<element id="UnknownArtist">
to supply a matching image.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 11, 2016, 11:20:09 AM
When using a highlight image for the volume slider button in a bitmap skin
<images category="Button"
    default="Images\RoundMidnight\volumebutton_RM.png"
    highlight="Images\RoundMidnight\volumebutton_RM_hi.png"
  />
</element>,
the highlight no longer appears in MB3
just bumping as this might have been missed (I originally tacked it on a reply about another issue)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 11, 2016, 12:07:19 PM
Can you support Controls.ArtistThumb element for thumbnail browser for consistency with genre and album color?

Granted it's not as easy as a colour override, but you can use
<element id="UnknownArtist">
to supply a matching image.

Yeah, that's what I've been doing, but this time I want to use default images.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 11, 2016, 06:46:01 PM
i have added:
AzBar.Default fg=xxx

that overrides the fg used for the az bar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 11, 2016, 10:19:36 PM
When using a highlight image for the volume slider button in a bitmap skin
<images category="Button"
    default="Images\RoundMidnight\volumebutton_RM.png"
    highlight="Images\RoundMidnight\volumebutton_RM_hi.png"
  />
</element>,
the highlight no longer appears in MB3
just bumping as this might have been missed (I originally tacked it on a reply about another issue)
i will definitely look at this as that sounds like a bug
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 12, 2016, 01:46:05 PM
sorry bee-liever but although this is a loss of functionality, its also a non-trivial change to implement it so i am going to leave things as they are ie. the highlight image for the volume button is no longer supported. I admit it was a neat effect you had there
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 12, 2016, 07:41:14 PM
in addition to:
AzBar.Default fg=xxx

i have also added:
AzBar.Lowlight fg=xxx

that overrides the year values that display between decades on the a-z bar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on March 13, 2016, 12:10:43 AM
sorry bee-liever but although this is a loss of functionality, its also a non-trivial change to implement it so i am going to leave things as they are ie. the highlight image for the volume button is no longer supported. I admit it was a neat effect you had there
Thanks anyway, I suppose.
I don't mean to sound ungrateful, it's just that I can't understand how all the other highlight image implementations can come over from 2.5 but not this one.
Not being a programmer, I can only assume the code has changed quite dramatically and that is why it has become "a non-trivial change to implement".
Oh well, it is what it is and I'll just have to deal. :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: KissCool on March 13, 2016, 11:29:00 AM
 - Dropdown Menu Checkbox
Since we have "Menu.DropDownCheckBoxImage", a highlight state would be usefull, imo. eg.:
"Menu.DropDownCheckBox.Default" bg="magenta"
"Menu.DropDownCheckBoxImage" fg="white"
"Menu.DropDownCheckBox.Highlight" bg="white"
"Menu.DropDownCheckBoxImage.Highlight" fg="black"

 - Could we get rid of most of the "automatic choice of color", plz?
The one that annoy me the most is the 2nd row of the Thumbnail Browser (eg.: the "albums count" row of the "Album Artist" filter). A fg element skin for this would be awesome.
This one has already been requested, so count it as a +1: please, allow us to skin the expanded panel when "auto-pick panel colors" is unticked. "PlayingIcon.Default" doesn't works here, is it intended?

 - Sidebar player bitmap skin
Since we can get rid of the top/bottom player, sidebar player becomes a nice alternative to save some precious vertical space.
A bitmap skin tool would be great (like the one we have for the top/bottom player).
But I guess it's a lot of work. So, in the meantime, could the sidebar player get the same options as the top/bottom player, please?
And/or having more settings would be nice too:
Progress Bar on Top/Middle/Bottom/Hidden
Text on Top/Middle/Bottom/Hidden
Controls on Top/Middle/Bottom/Hidden - Show all player controls
Using Metro buttons could use a different layout:
(http://i.imgur.com/Vn8uYmL.png)   ->   (http://i.imgur.com/GPSWzEJ.png)

1st picture: Relugar layout  with "show text, progress bar and all controls" ticked.
2nd picture: quick mockup using only existing MB buttons (player controls of the top player, menu button of the titlebar). Show text, progress bar and all controls unticked, volume control moved to the menu button.
I don't say that the 2nd picture look better. My point is just to give more layout options to the user.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 13, 2016, 11:55:06 AM
i am not planning to make any further skinning changes for v3 unless the request is trivial to do
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on March 14, 2016, 01:15:13 AM
This all-white editor in the tag inspector is happening in both DarkREDFlat3 and Mellon Remix 3.0, but not in the default skin:

(http://i.imgur.com/TdZDk45.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on March 15, 2016, 06:34:25 PM
This all-white editor in the tag inspector is happening in both DarkREDFlat3 and Mellon Remix 3.0, but not in the default skin:

(http://i.imgur.com/TdZDk45.png)
If you look at the XML I removed a lot of elements that I thought were no longer used (& reordered the rest), maybe I deleted something that was still used.
BTW: DarkRedFlat3 is not the latest version, this one is: https://dl.dropboxusercontent.com/u/10773406/DarkRED%20Flat.xml


EDIT: It also happens using my 2.5 skin in 3.0.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 15, 2016, 06:44:01 PM
i forgot to reply to this one this morning - it is a bug and is already addressed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 15, 2016, 09:10:15 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on March 16, 2016, 02:07:28 AM
i forgot to reply to this one this morning - it is a bug and is already addressed for the next update

Yep, fixed.  Thank you!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 16, 2016, 03:25:57 AM
Could we have overrides for tabs bar skinning elements when header bar is hidden?
If not for all, at least for three highlight elements: TabsBar.Tab.Highlight & TabsBar.TabInCaptionBar.Highlight & TabsBarPTop.Tab.Highlight
I'd also like to have overrides for those when "show icons" option is disabled.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on March 16, 2016, 03:41:09 PM
i am not planning to make any further skinning changes for v3 unless the request is trivial to do

I noticed some rather small skinning issues, involving the track layout with medium sized artwork (tracks with thumbnails).

- i'm not sure if this is intentional or not, but when selecting multiple files there is a visible gap between each highlighted track, I imagine it's just for padding but it might look neater if the highlighted area was extended vertically to hide any gaps.
- there is a visual glitch when deselecting a track that was previously selected from a stack, the topmost border of the track directly below that one disappears until the panel is refreshed.

This screenshot demonstrates both points;

(http://i.imgur.com/jR8zBZZm.jpg) (http://i.imgur.com/jR8zBZZ.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 16, 2016, 06:59:12 PM
I noticed some rather small skinning issues, involving the track layout with medium sized artwork (tracks with thumbnails).
the gap should just be the border line. Which skin is this or send me a link if its in development
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 16, 2016, 08:35:35 PM
- Could we get rid of most of the "automatic choice of color", plz?
The one that annoy me the most is the 2nd row of the Thumbnail Browser (eg.: the "albums count" row of the "Album Artist" filter). A fg element skin for this would be awesome.
for the thumbnail browser, there are several "FilterPanel..." overrides
i have enhanced it so if you provide a fg2 colour, that will be used
  <element id="FilterPanel.Default" bg="245,245,245" fg="0,0,0" fg2="255,0,0" />
  <element id="FilterPanel.ListAlternating.Default" bg="245,245,245" fg="0,0,0" fg2="255,0,0" />
  <element id="FilterPanel.Highlight" bg="245,236,172" bdr="227,216,152" fg="0,0,0" fg2="255,0,0" />
  <element id="FilterPanel.Lowlight" bg="232,232,232" fg="0,0,0" bdr="225,225,225" fg2="255,0,0" />

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Alumni on March 17, 2016, 07:12:48 AM
the gap should just be the border line. Which skin is this or send me a link if its in development

http://getmusicbee.com/forum/index.php?topic=17484.0
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: KissCool on March 17, 2016, 09:38:30 AM
i have enhanced it so if you provide a fg2 colour, that will be used
Awesome. Thank you very much!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 17, 2016, 08:09:35 PM
I noticed some rather small skinning issues, involving the track layout with medium sized artwork (tracks with thumbnails).

- i'm not sure if this is intentional or not, but when selecting multiple files there is a visible gap between each highlighted track, I imagine it's just for padding but it might look neater if the highlighted area was extended vertically to hide any gaps.
- there is a visual glitch when deselecting a track that was previously selected from a stack, the topmost border of the track directly below that one disappears until the panel is refreshed.
both are fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 17, 2016, 10:10:07 PM
for the upcoming tab enhancements i have added the following to enable and override the centered text tab layout (which should blend into the caption bar)

  <element id="TabsBar.TabInCaptionBarBlended.Default" bg="40,40,40" fg="170,170,170"  />
  <element id="TabsBar.TabInCaptionBarBlended.Separator" bg="130,130,130" />
  <element id="TabsBar.TabInCaptionBarBlended.Highlight" bg="40,40,40" fg="235,235,235" />
  <element id="TabsBar.TabInCaptionBarBlended.InactiveTabIconMask" bg="128,0,0,0" />

if your existing tab in caption bar colours are already suitable then just enable this flag instead.
  <element id="AllowCenteredTabInCaptionBar">true</element>

With neither of the above included in the skin, the centered text tab layout wont be supported
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 18, 2016, 07:23:59 PM
one more you might need to override the "+" button:

<element id="TabsBar.TabInCaptionBarBlended.AddButton" bg="40,40,40" fg="170,170,170"  />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 19, 2016, 12:24:45 PM
Can you support bg for TabsBar.TabInCaptionBarBlended.Highlight & TabsBar.TabBlended.Highlight?
For some skins (Pastels skin set of mine), different fg colors don't seem to be enough to make active tab standing out.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 19, 2016, 04:16:52 PM
i have added:
  <element id="TabsBar.TabBlended.Highlight" bg="240,40,40" fg="235,235,235" />
and this now uses the bg attribute
<element id="TabsBar.TabInCaptionBarBlended.Highlight" bg="40,40,40" fg="235,235,235" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 19, 2016, 04:18:41 PM
i have added:
  <element id="TabsBar.TabBlended.Highlight" bg="240,40,40" fg="235,235,235" />
and this now uses the bg attribute
<element id="TabsBar.TabInCaptionBarBlended.Highlight" bg="40,40,40" fg="235,235,235" />

Thanks a lot!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 20, 2016, 01:01:59 PM
I have many skins that use a gradient top border image. For those skins I can handle tabs in caption bar by not using bg value.
<element id="TabsBar.TabInCaptionBar.Default" fg="120,90,90" />
<element id="TabsBar.TabInCaptionBar.Highlight" fg="200,120,60" />
But a problem arises with iconmask elements since they require a specified bg value.

Can you support something like <element id="TabsBar.InactiveTabInCaptionIconMask" bg="230" /> for such cases?
(also for TabsBar.TabInCaptionBarBlended.InactiveTabIconMask)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 20, 2016, 01:03:07 PM
sorry redwing but i am finished with this now and even the small change i made yesterday is causing all sorts of complications which i am looking at now
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 20, 2016, 01:07:33 PM
OK, I understand. Also if that causes lots of complications you can remove those bg support you implemented yesterday. I can handle it.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 20, 2016, 03:34:19 PM
OK, I understand. Also if that causes lots of complications you can remove those bg support you implemented yesterday. I can handle it.
The change yesterday can remain as i think the issue it created should be resolved now
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on March 20, 2016, 09:52:58 PM
I think I missed a Tabs Bar change somewhere along the line quite recently.
Doesn't matter whether tabs are in, or below, the caption bar.  I'd love to have the old view back.  What changed?
In 3.0.5921 tabs look like this:
(http://i.imgur.com/11vc6zol.jpg) (http://i.imgur.com/11vc6zo.jpg)

In 3.0.5922+ they look like this:
(http://i.imgur.com/12LJ0Jsl.jpg) (http://i.imgur.com/12LJ0Js.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 20, 2016, 11:54:49 PM
I think I missed a Tabs Bar change somewhere along the line quite recently.
Doesn't matter whether tabs are in, or below, the caption bar.  I'd love to have the old view back.  What changed?
Preferences/ Layout(1) - set the menu type in the header bar section
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on March 21, 2016, 12:45:11 AM
Preferences/ Layout(1) - set the menu type in the header bar section
Yep, definitely missed that one.  Thanks Steven - all's well.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: KissCool on March 24, 2016, 07:27:44 PM
just while i remember - i am adding an optional bg2 to these so you can get a fade effect
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="235,25,25" bg2="245,245,245" />
and adding this for the new artwork grouping
<element id="Content[Artwork].SplitterLine" bg="235,25,25" bg2="245,245,245" />
with these new elements (which I love BTW) the brighter of the 2 colours leaves 1px dot at end opposite to main part
(http://i.imgur.com/Yjpj6ss.jpg) (http://imgur.com/Yjpj6ss)

<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="9,20,37" bg2="58,113,207"/>

if you reverse the colour values the dot appears at the RH end

two separate issues - the dot is fixed for the next update and the different element used for when left & right headers is so you can control the fading if its just a left only header vs. a left & right header
Works fine when the dot is on the left.
Doesn't work when the dot is on the right ("Album" and "Album & Tracks". "Tracks" is OK)
(http://i.imgur.com/Cax1Eca.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 24, 2016, 07:52:03 PM
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: KissCool on March 25, 2016, 03:24:06 PM
Fixed. Thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 26, 2016, 12:35:44 PM
Can you tell us at least which element the bg of expanded panel in artwork view is based on when auto-generated with auto-pick color option disabled?
I want to make it much darker for some of my dark skins, but cannot find a way.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 26, 2016, 02:11:23 PM
Can you tell us at least which element the bg of expanded panel in artwork view is based on when auto-generated with auto-pick color option disabled?
I want to make it much darker for some of my dark skins, but cannot find a way.
its based off the artwork panel background colour: Content[Artwork].Body.Default
and is made slightly brighter or dimmer depending on whether its a dark background

edit:
i will add in an override:
  <element id="Content[Artwork].Expanded" bg="210,210,210" fg="0,0,0" fg2="255,0,0" />
where fg2 is for the Album Text

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 26, 2016, 03:20:03 PM
i will add in an override:
  <element id="Content[Artwork].Expanded" bg="210,210,210" fg="0,0,0" fg2="255,0,0" />
where fg2 is for the Album Text

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

Thanks, but the new element is not working (no difference). Tested with multiple skins. Can you check please?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 26, 2016, 03:37:52 PM
if you are not using 3.0.5929 then redownload
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 26, 2016, 03:45:03 PM
Still not working with the latest patch. Can somebody else confirm if it's working?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 26, 2016, 03:56:48 PM
well i am using it in the default skin now so i am quite sure its working.
If the default skin is not showing a background of 225,225,225 then you dont have the correct version
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 26, 2016, 04:01:07 PM
It shows 226,226,226. Then it's not?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 26, 2016, 04:05:09 PM
i think i must have uploaded a slightly old version. Could you download again
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on March 26, 2016, 04:09:42 PM
Working now. Thanks!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: KissCool on March 30, 2016, 11:50:15 AM
"MainPanelSeparatorMargin" doesn't work anymore or am I doing something wrong?

Those elements seems broken too (or aren't supported anymore):
<element id="MainPanelMargin.Top">2</element>
<element id="MainPanelMargin.Bottom">2</element>
<element id="MainPanelMargin.Left">2</element>
<element id="MainPanelMargin.Right">2</element>
Whatever the value, there is no margin. If I remove them from the skin file, the margin appear.

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 30, 2016, 05:58:24 PM
"MainPanelSeparatorMargin" doesn't work anymore or am I doing something wrong?

Those elements seems broken too (or aren't supported anymore):
<element id="MainPanelMargin.Top">2</element>
<element id="MainPanelMargin.Bottom">2</element>
<element id="MainPanelMargin.Left">2</element>
<element id="MainPanelMargin.Right">2</element>
Whatever the value, there is no margin. If I remove them from the skin file, the margin appear.
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 30, 2016, 08:55:47 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: KissCool on March 30, 2016, 09:56:53 PM
This one still doesn't work:
<element id="MainPanelSeparatorMargin">7</element>

(the others are fixed, thanks)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 30, 2016, 10:00:22 PM
its no longer supported
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 03, 2016, 10:09:49 AM
while testing some of the older skins, i realised MB3 is setting an override by default that it shouldnt - you would see it on the browse back/forward buttons if you are using the default buttons). I have corrected that but there is a small chance it affects your skin if you used the defaults (I checked a number of the new skins and they were all fine)

use these elements if your skin is affected:
<element id="Panel.HeaderButtonOverride.Default" fg="225,5,5" />
<element id="Panel.HeaderButtonOverride.Disabled" fg="190,10,10" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 04, 2016, 08:52:40 PM
This is pretty minor, but I noticed that the window buttons for minimize, restore, and close are all stationary on highlight, but the maximize button shifts up very slightly.  I double checked that there wasn't anything different about my images except the background color.

(http://i.imgur.com/XCQW3WP.gif)


Also, this button loses its color once you move your mouse over the menu:

(http://i.imgur.com/83UvjyS.png)

One more thing, maybe not directly skin related but I noticed it because you can see the edge of the icons on this skin.  The edge is cut off when you tick or untick a track in the "tickmark" column.  (I had unticked the ones with the egde cut off here - all the rest were already unticked.)

(http://i.imgur.com/BtdE7IY.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 04, 2016, 09:08:36 PM
This is pretty minor, but I noticed that the window buttons for minimize, restore, and close are all stationary on highlight, but the maximize button shifts up very slightly.  I double checked that there wasn't anything different about my images except the background color.
are they all 15px high and 96 dpi?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 04, 2016, 09:48:43 PM
This is pretty minor, but I noticed that the window buttons for minimize, restore, and close are all stationary on highlight, but the maximize button shifts up very slightly.  I double checked that there wasn't anything different about my images except the background color.
are they all 15px high and 96 dpi?

I thought so, but it turns out GIMP was resetting them to 72 dpi on export.  I've fixed that now, and it seems to be fine.  Thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 04, 2016, 09:54:30 PM
for the 2nd issue, you need to set:
Menu.ParentItem.Pressed
for the 3rd, i have fixed that for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 05, 2016, 12:02:00 AM
Awesome, thanks.  :) 

meanwhile, I've discovered that if you put playing tracks in the main panel, it keeps its skin settings at first, but as soon as you restart mb, it takes the main panel settings instead.

And artists view is getting it's scroll bar colors from somewhere different than track detail.  In Mellon remix, they turn green & purple like column browser and some sidebar panels.

Maybe for a future version, could we have the window button highlight cover the whole height of the caption bar, like native Windows 10?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 05, 2016, 03:27:03 AM
And artists view is getting it's scroll bar colors from somewhere different than track detail.  In Mellon remix, they turn green & purple like column browser and some sidebar panels.
I finally had a chance to test it out: this is caused by the Panel.ChildBody.ScrollBar... elements, and affects both Artists and Album Covers views.


for the 2nd issue, you need to set:
Menu.ParentItem.Pressed
Actually, I have this set:

  <element id="Menu.ParentItem.Pressed" bg="82,83,176" fg="255,255,255" bdr="27,160,225" />

I tried moving it to the top, but that didn't help.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 07:19:54 AM
would you mind sending me a link to the skin so-far?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 03:59:37 PM
Is <element id="MiniPlayerLastFmNotLove"> not working or have I missed an override?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 05:32:17 PM
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 05:45:22 PM
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
No, the problem is it's using the default shape icon for Not Loved, and my custom shape & color icon for Loved.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 06:09:32 PM
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
No, the problem is it's using the default shape icon for Not Loved, and my custom shape & color icon for Loved.
could you PM me a link to the skin so i can check what is going on
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 06:13:37 PM
meanwhile, I've discovered that if you put playing tracks in the main panel, it keeps its skin settings at first, but as soon as you restart mb, it takes the main panel settings instead.
that was intentional that the override colours didnt apply when docked in the main panel (if poorly implemented) but i have changed it so the override colours are always used

And artists view is getting it's scroll bar colors from somewhere different than track detail.  In Mellon remix, they turn green & purple like column browser and some sidebar panels.
i have changed the default to come from the Panel rather than ChildPanel so it should work as you expect without adjustment. Keep in mind there are also overrides available:
Content[Artwork].ScrollBarThumb
Content[Artwork].ScrollBarBackground
Content[Artwork].ScrollBar
Content[Artwork].ScrollBar.Lowlight


for the menu pressed element, its working fine for me using your WIP skin
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 06:23:20 PM
@endeavour1934, dont worry - i found the issue and it will be fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 06:32:20 PM
i see that MB is re-colouring the icon which is neeed for the default icon but i will stop it doing that for a custom icon.
Is that what you meant - the icon is your custom one but is being re-coloured?
No, the problem is it's using the default shape icon for Not Loved, and my custom shape & color icon for Loved.
could you PM me a link to the skin so i can check what is going on
Sent. Right now I have...

LastFmLove (Panels. Uses shape and color)
LastFmLoveSelected
LastFmLoveBright
LastFmNotLove

PlayerLastFmLove (Player, Compact Player. Uses shape and color)
PlayerLastFmLoveBright
PlayerLastFmNotLove

MiniPlayerLastFmLove (Miniplayer. Uses shape and color)
MiniPlayerLastFmNotLove
MiniPlayerLastFmLoveBright

that's a lot of icons and I know some of them are not used. And some are only used for the shape, not the color. Anyone knows exactly which ones are used and where?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 07:10:10 PM
MiniPlayerLastFmLove (Miniplayer. Uses shape and color)
MiniPlayerLastFmNotLove
MiniPlayerLastFmLoveBright
for the mini-player i have corrected MiniPlayerLastFmNotLove and it wasnt loading MiniPlayerLastFmLoveBright. Thats also corrected for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 07:40:51 PM
While I was working on the Last.fm icons for the bitmap skinned player, I've noticed that upon start/play (with MusicBee window not maximized), the player displays correctly that the track is loved, but then if I maximize the window the Loved icon reverts to Not Loved.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 07:43:11 PM
PlayerLastFmNotLove was not being used for the Compact player.
PlayerLastFmNotLove was being recoloured in the main player
in case its not intentional, PlayerLastFmLove in your dark skins looks the same as PlayerLastFmNotLove
PlayerLastFmLoveBright is not implemented any more and wasnt in v2.5
Its going to take me some time to go though and figure out things so if you are able to point out the ones you think are not implemented then that will save me time
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on April 05, 2016, 07:53:21 PM
Am I correct in assuming that skins created for 2.5 will work in 3.x, but skins created exclusively for 3.x won't work in 2.5?  I did a few tests with old 2.5 skins in 3.x and didn't see any visual issues.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 07:57:05 PM
While I was working on the Last.fm icons for the bitmap skinned player, I've noticed that upon start/play (with MusicBee window not maximized), the player displays correctly that the track is loved, but then if I maximize the window the Loved icon reverts to Not Loved.
thanks for reporting that. Its fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 07:58:55 PM
Am I correct in assuming that skins created for 2.5 will work in 3.x, but skins created exclusively for 3.x won't work in 2.5?  I did a few tests with old 2.5 skins in 3.x and didn't see any visual issues.
while skins should work in either direction as long as all required bitmap images are supplied (for v3, the help button is no longer implemented so can be missing from a v3 skin but not a v2.5 skin), many wont work well with the changed tabs handling
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 08:10:58 PM
PANELS

LastFmLove
[Loved, track not selected] (Uses shape and color)
[Not loved, track selected & mouseover] (Only shape used. Color from Panel.NotLovedIcon.Highlight fg)

LastFmLoveSelected
[Loved, track selected] (Uses shape and color) 

LastFmLoveBright
[Not used]

LastFmNotLove
[Not loved, track selected] (Only shape used, color is automatically selected)

_________________________________________

MAIN PLAYER AND COMPACT PLAYER

PlayerLastFmLove
[Loved] (Uses shape and color)

PlayerLastFmLoveBright
[Not used]

PlayerLastFmNotLove
[Not Loved] (Uses shape and color) (If 'overlay controls' is active in Compact Player, color is automatically selected)

_________________________________________

MINI PLAYER

MiniPlayerLastFmLove
[Loved] (Uses shape and color)

MiniPlayerLastFmLoveBright
[Not Loved & mouseover] (Uses shape and color)
 
MiniPlayerLastFmNotLove
[Not Loved] (Uses shape and color)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: phred on April 05, 2016, 08:13:52 PM
Am I correct in assuming that skins created for 2.5 will work in 3.x, but skins created exclusively for 3.x won't work in 2.5?  I did a few tests with old 2.5 skins in 3.x and didn't see any visual issues.
while skins should work in either direction as long as all required bitmap images are supplied (for v3, the help button is no longer implemented so can be missing from a v3 skin but not a v2.5 skin), many wont work well with the changed tabs handling
Thanks for the clarification Steven.  I was mostly thinking about the two skins that I modified from 2.5 skins ("Dem Ol' Kozmic Blues" and "Phred on the Lookout".)  The first was done strictly with 2.5 elements (and tabs look okay) while the second incorporated a few of the new 3.x elements.  Both work fine in 3.x although Kozmic could use a few tweaks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 08:21:25 PM
i have uploaded a version that should address the player love icons
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i will probably leave the main panel love icon handling as-is. I think its probably the same as v2.5 but i dont have time just now to check
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 08:33:54 PM
i have uploaded a version that should address the player love icons
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

i will probably leave the main panel love icon handling as-is. I think its probably the same as v2.5 but i dont have time just now to check
A couple of posts above I've written all I could find about the love icons. Hope it helps.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 05, 2016, 09:23:10 PM
PlayerLastFmNotLove (Player, Compact Player. Uses only shape) Main player color from PlayerFlat.NotLovedIcon fg, Compact player color from ??

Red=being fixed
are you saying PlayerLastFmNotLove is not fixed for the main player? It should be. Are you sure about the images in your files as PlayerLastFmLove and PlayerLastFmNotLove look the same to me as read directly from your dark red flat files

i forgot to remind that the new version is MusicBee.exe and no longer MusicBee3.exe
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: endeavour1934 on April 05, 2016, 10:44:14 PM
Yes, it's all fixed. I've just updated the list.

Also, MiniPlayerLastFmLoveBright is used after all.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 06, 2016, 12:30:43 AM
3.0.5939: Scrollbars and Playing Tracks are fixed!  The Auto-Tag button in the Tag Editor still turns gray.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 06, 2016, 04:55:29 AM
Changing fg for this element changes the NON-highlight text color of the command buttons.

  <element id="Controls.Button.Highlight" bg="143,189,39" fg="255,255,255" />


And another request, maybe for later: could the search icon also be a different color when the search box is active, like the text?  Picking a color that works for both is hard if they're very different.


[Edit]: Does MainPanelTopBorder still do anything?  And I can't get this to appear:

<element id="TabsBar.TabInCaptionBarBlended.Separator" bg="xxx,xxx,xxx" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 06, 2016, 08:58:37 AM
Shouldn't these elements also affect the Podcast list?

<element id="Controls.AlbumThumb" fg="xxx,xxx,xxx" />
<element id="Controls.GenreThumb" fg="xxx,xxx,xxx" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 06, 2016, 07:07:49 PM
Changing fg for this element changes the NON-highlight text color of the command buttons.

  <element id="Controls.Button.Highlight" bg="143,189,39" fg="255,255,255" />
it seems its been that way since v2.5
Its corrected for the next v3 update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 06, 2016, 07:15:44 PM
[Edit]: Does MainPanelTopBorder still do anything?
not in v3. If you have something in mind (and the other requests) should go in a skin requests topic for v3.1
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 06, 2016, 07:38:05 PM
And I can't get this to appear:
<element id="TabsBar.TabInCaptionBarBlended.Separator" bg="xxx,xxx,xxx" />
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 06, 2016, 07:40:57 PM
Shouldn't these elements also affect the Podcast list?

<element id="Controls.AlbumThumb" fg="xxx,xxx,xxx" />
<element id="Controls.GenreThumb" fg="xxx,xxx,xxx" />
i am not sure i understand. Where does the podcast panel have album or genre thumbs?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 06, 2016, 09:06:17 PM
fixes for the above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 06, 2016, 10:00:25 PM
Shouldn't these elements also affect the Podcast list?

<element id="Controls.AlbumThumb" fg="xxx,xxx,xxx" />
<element id="Controls.GenreThumb" fg="xxx,xxx,xxx" />
i am not sure i understand. Where does the podcast panel have album or genre thumbs?

Well, it doesn't.  But it has generic thumbnails for recent episodes, etc, that should use the same color scheme.

Thanks for the fixes!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 07, 2016, 08:59:48 AM
(http://i.imgur.com/gog5CCF.png)

Anybody know what I screwed up here?  It's the icon for inbox and podcast stats.


Edit: Actually, I'm pretty sure this is a bug.

When I added this element, all of a sudden Skin Window Borders was disabled, but that icon was showing up correctly in the tabs bar; when I remove the element, I can skin window borders again but that icon is missing:  <element id="Panel.ScrollBar.Lowlight" bg="Blue" >

Steven, I've updated the file at the link I gave you earlier, if you need to look at it for more info.  Currently sans Lowlight element.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 07, 2016, 03:56:50 PM
When I added this element, all of a sudden Skin Window Borders was disabled, but that icon was showing up correctly in the tabs bar; when I remove the element, I can skin window borders again but that icon is missing:  <element id="Panel.ScrollBar.Lowlight" bg="Blue" >
its missing a closing bracket:
<element id="Panel.ScrollBar.Lowlight" bg="Blue" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 07, 2016, 04:11:37 PM
its missing a closing bracket:
<element id="Panel.ScrollBar.Lowlight" bg="Blue" />

Doh! That's probably it.

But what about the icon in the toolbar?  It showed up correctly when "skin window borders" was disabled.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 07, 2016, 05:40:42 PM
Without the closing brackets, the remaining elements of the skin would not have loaded.
MB is recolouring the notification icon and i will stop it doing that for a custom notification icon

edit:
thats fixed now. Just a suggestion with your skin - when the player controls are at the top or player controls are on the bottom but the status bar is underneath you can use different colours eg.
  <element id="Panel.StatusBarInPanel.Default" bg="Dark Stripe" bg2="Blue" fg="White" />
  <element id="Panel.StatusBar.Default" bg=XXX fg=XXX />
there is also
Panel.StatusBarControlInPanel.Default fg=XXX
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 07, 2016, 06:18:35 PM
Quote
Without the closing brackets, the remaining elements of the skin would not have loaded.
MB is recolouring the notification icon and i will stop it doing that for a custom notification icon

edit:
thats fixed now. Just a suggestion with your skin - when the player controls are at the top or player controls are on the bottom but the status bar is underneath you can use different colours eg.
  <element id="Panel.StatusBarInPanel.Default" bg="Dark Stripe" bg2="Blue" fg="White" />
  <element id="Panel.StatusBar.Default" bg=XXX fg=XXX />
there is also
Panel.StatusBarControlInPanel.Default fg=XXX

Awesome, thanks!  I'll give that a shot.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 07, 2016, 06:32:48 PM
usual link is updated with the fixes
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 08, 2016, 01:55:54 AM
I see what happened with that icon now; I didn't realize I'd overridden it with an image.  I've taken that out, because it's not what I thought I was doing.

Is there any way to make the default icon white?  It looks a little funny between two bright white icons on the toolbar:

(http://i.imgur.com/EUnYkXx.png)


Edit:

Quote
Panel.StatusBarControlInPanel.Default fg=XXX

This setting should also be applied when the main player panel isn't displayed at all.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 09, 2016, 01:34:40 AM
Have I missed the settings for the tabs with stacked panels, or do I need to add it to the 3.1 requests?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 09, 2016, 09:45:18 AM
the top headerbar is configurable using "HeaderBar" and anywhere else "Panel.ChildHeader.Default"
when not stacked, the separator bar that is displayed is auto-derived from those colours
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 10, 2016, 08:37:30 AM
trying to get those damned lowlight scrollbars to work for Wing-ated and have run across a bug.

with these setting for the right sidebar
(http://i.cubeupload.com/9QBnQV.jpg)

the stacked panels use the override settings from id="TrackInfoPanel.ScrollBar but the other panel only uses the default settings
(http://i.cubeupload.com/8gBTie.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 10, 2016, 09:05:39 AM
trying to get those damned lowlight scrollbars to work for Wing-ated and have run across a bug.
trying with your win-ated skin now it looks fine to me. If you have made some changes then can you send that to me
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 10, 2016, 09:32:13 AM
If you have made some changes then can you send that to me
PM sent
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 10, 2016, 11:10:02 AM
TrackInfoPanel.ScrollBar.Lowlight wasnt implemented. Its there for the next update

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 12, 2016, 04:12:46 PM
This happens to some of my Dark-Fine Tuned series skins (Dark Orange here)

(http://i.imgur.com/mrdjE39.png)

The problem is there's no such element as Menu.CommandButton.Pressed to specify button colors when pressed.
So can you make the fg of the button follow Menu.CommandButton.Selected when pressed?
I can't think of any side effects that change might cause.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 13, 2016, 01:58:09 PM
if colours are supplied for the override
<element id="Content[Artwork].Expanded" bg="23,23,20" fg="166,133,85" fg2="141,96,65" />
should the bg colour be used for the intermediate panel (when shown) and 'auto-pick panel colours' is also selected?

(http://i.cubeupload.com/futAcc.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 14, 2016, 09:28:27 PM
The problem is there's no such element as Menu.CommandButton.Pressed to specify button colors when pressed.
So can you make the fg of the button follow Menu.CommandButton.Selected when pressed?
I can't think of any side effects that change might cause.
i figured out how to better detect the state shown in your example and from the next update it will use the selected fg instead of the default fg colour
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 14, 2016, 09:50:11 PM
if colours are supplied for the override
<element id="Content[Artwork].Expanded" bg="23,23,20" fg="166,133,85" fg2="141,96,65" />
should the bg colour be used for the intermediate panel (when shown) and 'auto-pick panel colours' is also selected?
i think that is fair enough and i have made the change
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 14, 2016, 09:51:07 PM
The problem is there's no such element as Menu.CommandButton.Pressed to specify button colors when pressed.
So can you make the fg of the button follow Menu.CommandButton.Selected when pressed?
I can't think of any side effects that change might cause.
i figured out how to better detect the state shown in your example and from the next update it will use the selected fg instead of the default fg colour

Woot!  Thanks!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 14, 2016, 09:53:34 PM
for the above:
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 15, 2016, 03:55:56 AM
The problem is there's no such element as Menu.CommandButton.Pressed to specify button colors when pressed.
So can you make the fg of the button follow Menu.CommandButton.Selected when pressed?
I can't think of any side effects that change might cause.
i figured out how to better detect the state shown in your example and from the next update it will use the selected fg instead of the default fg colour

Thanks, that's fixed.
But there's another bug related to this, which took me quite a while to figure out what's going on:

(http://i.imgur.com/tvdlfxc.png)

The bg of the pressed button becomes invariably 180,180,180 if main menu is shown as a button (requires relaunching of MB). If it's shown as (inline) menu bar, it's working fine.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 15, 2016, 04:00:59 AM
But there's another bug related to this, which took me quite a while to figure out what's going on:

(http://i.imgur.com/tvdlfxc.png)

The bg of the pressed button becomes invariably 180,180,180 if main menu is shown as a button (requires relaunching of MB). If it's shown as (inline) menu bar, it's working fine.

Wow, nice investigation.  That's the one I'm still seeing; never would have occurred to me to try the main menu.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on April 15, 2016, 06:12:16 AM
With the new scrollbar lowlight elements, there is a point for both the main panel and the left sidebar where the scrollbar highlights but you actually still have the drag line selected.  It would be really helpful for not accidentally moving the side panels if that could be eliminated.

GIF:
(http://i.imgur.com/Wv8k8JX.gif)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 15, 2016, 07:17:27 AM
The bg of the pressed button becomes invariably 180,180,180 if main menu is shown as a button (requires relaunching of MB). If it's shown as (inline) menu bar, it's working fine.
mystery solved - thanks for figuring that out and its fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 15, 2016, 11:23:41 AM
just while i remember - i am adding an optional bg2 to these so you can get a fade effect
<element id="Content[TrackDetail].HeaderLine" bg="235,25,25" bg2="245,245,245" />
<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="235,25,25" bg2="245,245,245" />
and adding this for the new artwork grouping
<element id="Content[Artwork].SplitterLine" bg="235,25,25" bg2="245,245,245" />
with these new elements (which I love BTW) the brighter of the 2 colours leaves 1px dot at end opposite to main part
(http://i.imgur.com/Yjpj6ss.jpg) (http://imgur.com/Yjpj6ss)

<element id="Content[AlbumAndTracks].ArtistSplitterLine" bg="9,20,37" bg2="58,113,207"/>

if you reverse the colour values the dot appears at the RH end

two separate issues - the dot is fixed for the next update and the different element used for when left & right headers is so you can control the fading if its just a left only header vs. a left & right header
Works fine when the dot is on the left.
Doesn't work when the dot is on the right ("Album" and "Album & Tracks". "Tracks" is OK)
(http://i.imgur.com/Cax1Eca.jpg)


This bug is back with the latest patch. Version 3.0.5948
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 15, 2016, 01:02:20 PM
nothing has been changed for a long time with this, so i expect its something specific to your skin. Can you PM me a link to it
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 15, 2016, 06:48:54 PM
Wide layout mini player is working fine with mostly automated elements, but narrow layout has some issues if main player and sidebar player use different colors.   

(http://i.imgur.com/QCOKUXN.png)

Looks like it takes PlayerFlat elements for most elements except player controls and not loved icon which comes from sidebar player. Can you make it use all from PlayerFlat elements?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 16, 2016, 02:29:29 AM
nothing has been changed for a long time with this, so i expect its something specific to your skin. Can you PM me a link to it

PM sent. It only seems to occur in the inbox.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 16, 2016, 09:06:42 AM
@iasc, i cannot see the dot you describe using the skins you sent. Can you post a screenshot using Absolute Zero ?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 16, 2016, 11:47:24 AM
Looks like it takes PlayerFlat elements for most elements except player controls and not loved icon which comes from sidebar player. Can you make it use all from PlayerFlat elements?
although what you say is logical, i dont want to make a change at this point that may impact other skins. I can do this for v3.1 if you put it as a wish on the 3.1 skin requests topic
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 16, 2016, 11:51:01 AM
@iasc, i cannot see the dot you describe using the skins you sent. Can you post a screenshot using Absolute Zero ?

(http://i.imgur.com/FHQVBjx.png)

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 16, 2016, 12:04:18 PM
thanks. Its actually due to whether the width is even or odd numbered. Very strange. But i have put in handling for that for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 16, 2016, 03:16:24 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip

unzip into the folder MB is installed.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 17, 2016, 01:25:31 AM
thanks. Its actually due to whether the width is even or odd numbered. Very strange. But i have put in handling for that for the next update

Issue is fixed. Thanks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 17, 2016, 07:48:09 AM
Looks like it takes PlayerFlat elements for most elements except player controls and not loved icon which comes from sidebar player. Can you make it use all from PlayerFlat elements?
although what you say is logical, i dont want to make a change at this point that may impact other skins. I can do this for v3.1 if you put it as a wish on the 3.1 skin requests topic

Never mind. Found a way to sort this out.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 17, 2016, 11:35:23 AM
It appears that
<element id="Controls.SliderLine.Default" fg="XXX" />
<element id="Controls.SliderLine.Disabled" fg="XXX" />
have stopped working with recent updates.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 17, 2016, 12:02:23 PM
those overrides havent been supported for the entire time of MB3 and are now auto-generated from the InputPanel.Default colours.
If its causing a problem it will need to go on the v3.1 wishlist
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 17, 2016, 12:31:40 PM
those overrides havent been supported for the entire time of MB3.
Really, really?
The only reason I posted about it was I would have sworn that they were working earlier in 3.0 when I updated the Tundra series.
Just another example that my memory is not as good as I remember it being :)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 18, 2016, 12:57:07 PM
when tabs bar is in caption bar and toolbar buttons are shown in a separate bar both
TabsBar.BorderLine and
TabsBar.TabInCaptionBar.BorderLine
are shown
(http://i.imgur.com/dwMXYmu.jpg) (http://imgur.com/dwMXYmu)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 18, 2016, 09:35:47 PM
when tabs bar is in caption bar and toolbar buttons are shown in a separate bar both
TabsBar.BorderLine and
TabsBar.TabInCaptionBar.BorderLine
i can reproduce this exactly as shown using your Iconic skin. I am a little nervous about making this fix as the code is very explicit about doing this drawing in this configuration but it doesnt seem to make sense. I have made the change but may undo its reported as causing issues elsewhere

http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 20, 2016, 11:37:31 AM
A highlight element such as id="AddTabIcon.Highlight" would be nice for when you hover-over the new tab icon.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 21, 2016, 05:50:27 PM
I noticed that in the Auto-DJ panel, these two disabled items have different colouring.
I would expect both green pointed out items, and both yellow pointed out items to have identical colours.

(A Sophisticated Bee skin)

(http://i.imgur.com/bfsTw7q.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 23, 2016, 10:16:40 AM
I am not 100% sure, but I think in the past  element id="Controls.FaintLine"  allowed for a gradient line.
Now when you have a bg2, it will simply overrule the bg value.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 23, 2016, 10:21:20 AM
I am not 100% sure, but I think in the past  element id="Controls.FaintLine"  allowed for a gradient line.
Now when you have a bg2, it will simply overrule the bg value.
it used to but no longer supports that, and right now i cant think of anywhere the bg2 could apply anyway ie. i think its always 1px in height
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 23, 2016, 10:25:23 AM
It looks nice as available in ArtistSplitterLine
Isn't that also 1px high?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 23, 2016, 10:34:34 AM
Controls.FaintLine has never supported horizontal fading using bg2
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 24, 2016, 08:04:24 AM
When hovering over rating in playing track panel a black line appears.  Version: 3.0.5957



(http://i.imgur.com/GSVOvdp.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 24, 2016, 08:43:38 AM
When hovering over rating in playing track panel a black line appears.
thats fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 24, 2016, 11:16:59 AM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 24, 2016, 11:33:51 AM
Bug is still present after patch.

(http://i.imgur.com/Vco0eTG.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 24, 2016, 11:39:27 AM
what version does Help/ About say?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 24, 2016, 11:41:25 AM
3.0.5958
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 24, 2016, 11:49:33 AM
i dont think i am going to be able to help any further with this

edit:
i do notice if you click in a particular area some graphics corruption occurs so i will look at that
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 24, 2016, 12:19:06 PM
Whatever change you made did have some effect as it no longer happens on every track.

(http://i.imgur.com/K0FTiQv.png)

Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 24, 2016, 02:35:02 PM
it depends where you click and its different to the error you reported before. In any case it should be fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 24, 2016, 03:29:27 PM
http://musicbee.niblseed.com/V3_0/MusicBee3_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on April 25, 2016, 01:51:27 AM
it depends where you click and its different to the error you reported before. In any case it should be fixed for the next update

Problem solved. Thanks Steven.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 25, 2016, 03:22:42 PM
Is there an element, or an icon overrule for setting the check ticks in the Configure Layout panel?

(http://i.imgur.com/yj5Orvq.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 25, 2016, 03:37:32 PM
Not sure this could be an easy fix for v3.0. If not, I'll add it to v3.1 skin wishlist:
Currently if a skin is using a custom node icon override, all other default icons need to be supplied in skin files even though they will be available from MB.
Try any Pastels or Dark-Fine Tuned skin.
Would it be possible the skin doesn't have to supply the same default icons for Bookmark, Podcast, Audiobooks, Radio, inbox, Video, History, Upcoming Release nodes?
If it doesn't supply those, playlist, auto-dj, now playing icons won't respect their icon overrides. I found that podcast icon needs to be added to make them work. But then all other nodes don't show any icons.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 25, 2016, 03:45:11 PM
The playing/selected button draws it background colour automated. (I think)
When the childheader bar has a subtle gradient, that results in a strange differentiating gradient for that button.

Therefor this is a request for an overrule element for it.

(http://i.imgur.com/OB4AxAh.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: sleepless on April 25, 2016, 04:06:03 PM
"Controls.SliderButton.Default" no longer works. Specifically, the button for the artwork size slider used to display the bg color, but no longer does. I don't know of other areas this element was used.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 25, 2016, 04:14:49 PM
"Controls.SliderButton.Default" no longer works. Specifically, the button for the artwork size slider used to display the bg color, but no longer does. I don't know of other areas this element was used.

I happen to be doing some skinning right now, and this one works for that:
id="Content[Artwork].HeaderControl.Default"
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 25, 2016, 06:28:17 PM
Not sure this could be an easy fix for v3.0. If not, I'll add it to v3.1 skin wishlist:
Currently if a skin is using a custom node icon override, all other default icons need to be supplied in skin files even though they will be available from MB.
Try any Pastels or Dark-Fine Tuned skin.
Would it be possible the skin doesn't have to supply the same default icons for Bookmark, Podcast, Audiobooks, Radio, inbox, Video, History, Upcoming Release nodes?
If it doesn't supply those, playlist, auto-dj, now playing icons won't respect their icon overrides. I found that podcast icon needs to be added to make them work. But then all other nodes don't show any icons.
i am a bit surprised that you are finding this to be the case and they should all be indendent ie. if not supplied then the default is used. I am not sure of the point you are making with this: "Try any Pastels or Dark-Fine Tuned skin." They all look fine to me.
Perhaps your test skin had an error in one of the elements that caused the skin load to abort and the remaining icons not load (check the error log)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 25, 2016, 06:36:40 PM
"Controls.SliderButton.Default" no longer works. Specifically, the button for the artwork size slider used to display the bg color, but no longer does. I don't know of other areas this element was used.
the artwork slider button now uses an auto-generated colours because its in a context menu
looking at the code its using:
Content[Artwork].HeaderControl.Default
not sure if i advertised that

Controls.SliderButton.Default is still used in panels such as the auto-dj


edit:
i see hiccup already answered this!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 25, 2016, 06:38:28 PM
The playing/selected button draws it background colour automated. (I think)
When the childheader bar has a subtle gradient, that results in a strange differentiating gradient for that button.

Therefor this is a request for an overrule element for it.
this should be added to the 3.1 skinning requests topic
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 25, 2016, 07:54:10 PM
Is there an element, or an icon overrule for setting the check ticks in the Configure Layout panel?
no its auto-generated. Please add to the 3.1 skinning requests if you need this
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 25, 2016, 10:28:14 PM
i am a bit surprised that you are finding this to be the case and they should all be indendent ie. if not supplied then the default is used. I am not sure of the point you are making with this: "Try any Pastels or Dark-Fine Tuned skin." They all look fine to me.
Perhaps your test skin had an error in one of the elements that caused the skin load to abort and the remaining icons not load (check the error log)

Not sure how you tested it but they currently look fine because they have all the default icons supplied. Did you test it with those listed icons (Bookmarks, Podcasts, Audiobooks, Radio, inbox, Video, History, Upcoming Releases) removed from the skin? There's no error logged.

[edit] This will show the issue more clearly (Azure skin):

(http://i.imgur.com/dDmgf9M.png)

1. Current
2. When those 8 default icons are removed from the skin file
3. When only Podcasts icon is supplied among those 8 icons
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on April 25, 2016, 11:22:02 PM
Is there an element, or an icon overrule for setting the check ticks in the Configure Layout panel?
no its auto-generated. Please add to the 3.1 skinning requests if you need this
But there is already available
<element id="Controls.LargeTickBoxFill" bg="xxx,xxx,xxx" />
to change the background to a higher contrast colour
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 26, 2016, 07:55:05 AM
Thnx Bee-liever, but I really want to change the tick itself.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: sleepless on April 26, 2016, 02:24:50 PM
"Controls.SliderButton.Default" no longer works. Specifically, the button for the artwork size slider used to display the bg color, but no longer does. I don't know of other areas this element was used.
the artwork slider button now uses an auto-generated colours because its in a context menu
looking at the code its using:
Content[Artwork].HeaderControl.Default
not sure if i advertised that

Oh yeah, I actually had that figured earlier. I guess I moved its location though, and <element id="Content[Artwork]" was overriding it.
So are these elements still required? I can't find any issues after removing them:

<element id="Content[ArtistProfile]"
<element id="Content[Artwork]"
<element id="LyricsPanel"
<element id="TrackInfoPanel"
<element id="ArtworkPanel"

Sorry for the noob questions.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 28, 2016, 03:36:19 PM
The small popup window from tag inspector has unskinned border of 100,100,100 which looks awful with some skins.

http://i.imgur.com/D3Wa67r.png
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 28, 2016, 05:56:47 PM
that would be a non-trivial change and should go on the 3.1 requests if you want it implemented for the next MB version
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 30, 2016, 04:20:04 AM
Would it be possible the skin doesn't have to supply the same default icons for Bookmark, Podcast, Audiobooks, Radio, inbox, Video, History, Upcoming Release nodes?

Bump
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on April 30, 2016, 07:27:07 AM
forgot to reply on this. I confirm the behavior you describe but wont make any change for v3 at risk of messing something up elsewhere
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on April 30, 2016, 07:37:24 AM
OK. I'll add it to v3.1 wishlist.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Iasc on May 02, 2016, 10:38:38 AM
In the now playing panel, show player controls in right sidebar doesn't work well unless the sidebar panel is wide. I don't actually use it but i came across it when i was playing around with the settings so thought i would report it.

(http://i.imgur.com/vNMqXReh.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: sleepless on May 03, 2016, 07:17:18 PM
I realize this is likely not a v3 issue, and possibly intentional, but I've always found it odd that the wavebar isn't centered in the player (weighted to the bottom). To me, this just doesn't look right. Although admittedly I'm a bit OCD, which makes me a bit more sensitive to objects appearing off-balanced.

(http://i.imgur.com/qcL3RgI.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: psychoadept on May 08, 2016, 06:09:27 PM
I have this set, but I'm getting lowlight scrollbars even without narrow scrollbars.

<element id="ScrollBarLowlightNarrowOnly">true</element>
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on May 11, 2016, 03:13:27 PM
I've seen this bug a couple times (just now) but can't reproduce it intentionally. Have a look at the code if something is wrong.
When PlayerTopFlat elements are not supplied to the skin, switching progress bar from on top to in middle with main player on top sometimes draws the progress bar (from the middle) all the way to the right, overlapping with spectrum visualizer on the right.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on May 09, 2017, 06:17:40 PM
Not sure how you tested it but they currently look fine because they have all the default icons supplied. Did you test it with those listed icons (Bookmarks, Podcasts, Audiobooks, Radio, inbox, Video, History, Upcoming Releases) removed from the skin? There's no error logged.

[edit] This will show the issue more clearly (Azure skin):

(http://i.imgur.com/dDmgf9M.png)

1. Current
2. When those 8 default icons are removed from the skin file
3. When only Podcasts icon is supplied among those 8 icons
there is some code around the assumption that all icons are supplied. I have changed the behaviour so each icon is checked individually
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: redwing on May 09, 2017, 07:00:24 PM
there is some code around the assumption that all icons are supplied. I have changed the behaviour so each icon is checked individually

Working fine now without those default icons supplied. Thanks!
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: The Incredible Boom Boom on November 20, 2021, 08:22:53 PM
Two skin (exoskeleton? 🤔 bees don't have skin) mishaps

(https://i.imgur.com/gD047lv.png)
I'm pretty sure the .ItemSeparator element is extending too far?
Code
<element id="Content[AlbumAndTracks].ItemSeparatorLine" fg="highlighted" />

(https://i.imgur.com/ILOZJ4G.png)
This is the scroll bar for the Tag Explorer. It was fine until I modified the bgand bg2 attributes below.
*This persisted through restarts, but the panel just refreshed and now the ScrollBarThumb sits properly above the SectionHeader. I dunno if you want to put any effort towards this since it works now, but it may be replicable.
EDIT: The below bug just returned, so it is a persistent one
Code
<element id="Panel.SectionHeader.Default" bg="darkGreen" bg2="gradientBG" fg="mainText" />
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on March 04, 2022, 07:36:15 PM
Currently working on a skin and I'm going around checking just about every MusicBee setting there is. I've come across these which I think need addressing.
(https://i.imgur.com/bv0JMHj.png)  (https://i.imgur.com/Qlpg0Tf.png)

As for this one, it's more of a request than an oversight being pointed out.
When I double-click on my 1200x1200 album covers, an enlarged version pops up.
Only one thing bothers me, the bottom border is placed below the taskbar. Seeing as the window is not resizable...I cannot do anything about that on my part.
I was hoping the window size could be reduced a bit so that both (top & bottom) borders could appear.
(https://i.imgur.com/ANX4Vkf.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on March 06, 2022, 06:32:37 AM
these issues should be addressed now:
https://getmusicbee.com/patches/MusicBee35_Patched.zip
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on March 06, 2022, 07:49:49 AM
All good now. Thank you Steven.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on March 31, 2022, 05:44:17 PM
When the "narrow scrollbars" setting is enabled in preferences, the size of the scrollbar in the "Panels Configuration" is way different compared to the rest.
(https://i.imgur.com/J7c508D.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on April 09, 2022, 04:44:45 PM
When there is a 'normal' audio track listed in the Playing Tracks panel, but it is unavailable because it was e.g. deleted from the drive, there will be an exclamation mark beside it explaining the problem.

But when the same happens for a podcast episode, there is no exclamation mark but the text is displayed in a different (disabled) colour.
I think it would be better if the behaviour with podcasts was the same as for normal tracks.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: hiccup on July 21, 2022, 05:03:34 PM
The LastFmButton can be hidden these days, but there is no "replacementElement id" in the skin.xml for it.
I added it myself, but that doesn't seem to work.

So I am guessing the skincreator needs to be updated to recognise it?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Bee-liever on July 22, 2022, 12:08:33 AM
The LastFmButton can be hidden these days, but there is no "replacementElement id" in the skin.xml for it.
I added it myself, but that doesn't seem to work.

So I am guessing the skincreator needs to be updated to recognise it?

Refer here: https://getmusicbee.com/forum/index.php?topic=35473.msg193997 (https://getmusicbee.com/forum/index.php?topic=35473.msg193997)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on August 12, 2022, 01:04:38 PM
3.5.8246 P

In the virtual tag template editor, whenever I click on the composer tag under the field selector:
MusicBee displays the header menu of whatever tab I had accessed the editor from.

(https://i.imgur.com/qij9H3F.png)

Edit: Actually, it doesn't always happen. You have to be playing a song for this to occur - that's important to reproducing this.
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on August 13, 2022, 04:57:07 AM
bit of a strange one but fixed for the next update
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: T010 on August 27, 2022, 09:40:32 AM
I found the following unskinnable graphical elements (plus one visual error), for which I'd like to have the ability to use custom images for each:

(https://i.imgur.com/JspA7ps.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on August 27, 2022, 09:57:21 AM
the spacing is intentional to give the two nodes their own space but it doesnt make as much sense for that as when done originally and i will change it to even spacing with the other nodes
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: T010 on August 27, 2022, 03:21:30 PM
Visual bug: MB doesn't respect the PlayerInfoCentered=false setting when ProgressBar is set to Do Not Display
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on August 27, 2022, 09:56:57 PM
@T010

Regarding the 'playlist' image, you can override that using UnknownAlbumIcon.

For 'star ratings', you want to change the image of those stars...to what, if you don't mind my asking?
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: T010 on August 28, 2022, 07:53:49 AM
@T010

Regarding the 'playlist' image, you can override that using UnknownAlbumIcon.

For 'star ratings', you want to change the image of those stars...to what, if you don't mind my asking?

Thank you, UnknownAlbumIcon works fine.

The ability to change the star graphics is the least urgent/important for me, but would be nice regardless. I was thinking of having outlined stars for the Lowlight state
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: T010 on August 29, 2022, 07:49:40 AM
Small "Banned" icon in tracks list can not seem to be skinned by custom image: (the larger one in Player Controls panel can be skinned)

(https://i.imgur.com/HKJNkF1.jpg)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on January 27, 2024, 08:42:00 AM
If you have a long vertical list of options in a tool menu, you get these white-coloured scroll buttons pointed out in red below.
Not a biggie, but it would be great if we can get them skinned too.

The small black arrow can follow his green buddies marked in yellow.
The white piece can follow the green shade marked in purple.

(https://i.imgur.com/m8gBGra.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on January 27, 2024, 08:51:02 AM
This one is specific to skins that have the scroll button hidden.
In the preview section of the template editor, when a field column has been moved all the way to the far-right, a solid square pops out.
Not a biggie either, but it would also be nice if that square could follow the background colour of the scrollbar.

(https://i.imgur.com/hUWYUan.png)
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Steven on January 28, 2024, 07:09:14 AM
The small black arrow can follow his green buddies marked in yellow.
The white piece can follow the green shade marked in purple.
I have looked but cant find any way to override the colours for that bar
Title: Re: Skin- and visual errors related to, and skinning requests for MusicBee v3
Post by: Mayibongwe on January 28, 2024, 03:41:22 PM
No worries Steven. Thanks for checking it out.