its easy enough for that to be done and i will include it in the v2.3 changee but i wonder if it might be better as a skin setting (probably just used for dark skins) otherwise most people wont know about it
or maybe just a way to link a specific set of tool bar buttons to a specific skin so that when you change skin musicbee will automatically use those buttons.This way, you can really choose the colour you want and the icon design.
Well, skin-adaptive toolbar button coloring option is better than nothing but it's not the way to go imo.
This is better:or maybe just a way to link a specific set of tool bar buttons to a specific skin so that when you change skin musicbee will automatically use those buttons.This way, you can really choose the colour you want and the icon design.
A skinner should be able to force the choice of icons set and fonts: switching skins wouldn't result with inadequate icons and/or fonts.
Good idea! Then give me icon sets that I can choose from for each skin.
Good idea! Then give me icon sets that I can choose from for each skin.
No need to be sarcastic.
So, no, your suggestion don't have to be dismissed in favor of iasc & scampbll one.
<element id="DefaultIconName">Tron Bee</element><element id="DefaultToolbarSet">DarkRED</element>Do you mean some skins will come with not just an icon set from which users could choose for what to use but a specifically chosen button set?
If that's just an icon set that's designed to go along well with the skin, then users only need to set up a pairing between the skin and the icon set (icon subfolder). Wouldn't this be simpler?
Take DarkRED skin as an example since its skinner(endeavour1934) already provided its own icon set.Ahh. That's what I said back here
If the user wants to use that supplied icon set, she needs to store the icon set under \MusicBee\Icons\DarkRED\ folder. Yes, the name of the sub-folder should be the same as the skin name. Then you don't have to make a pairing between a skin and its icon sub-folder. MB would, if implemented, first look for a icons sub-folder with the same name as the skin
Maybe using:Codewould search for a DarkRED sub-folder in Icons, if not found the defaults loaded in Preferences>Layout (1)>toolbar buttons: would be used<element id="DefaultToolbarSet">DarkRED</element>
About the coloring of buttons:and also said that here:
Users can choose either "Original" or "Skin adaptive" colors with whatever icon set they're using.
If all options were implemented as suggested, you could make one greyscale set of icons for the entire series and recommend that users turn on "Adaptive" option at 80%, so that they changed colour when using original, red or green versions.
About the filenames of icons:I think using the standardised action name from the hotkeys panel would be better, programmatically speaking, e.g. General_ Activate Auto-Shutdown
I'd assume most people use the same kind of toolbar buttons whatever skin they're using
Finally why I think my idea is better than yours:
- Users don't have to edit skin files including those uneditable bitmap skins. nor in mine
- Users can use a specific icon set for their favorite skins even if there's no supplied icon set from the skinner. ditto
- Simple and easy to manage icon sets and its coloring option. same again
Ahh. That's what I said back here
i am willing to do something very simple with this eg. right click/ "Set Icon Colours to Skin" or something along that line and MB gets the colour from the relevant skin panel header element
Let me know if thats useful
Setting an alpha on the new colour would only change the overall colour but wouldnt make any difference otherwise
so even with the alpha I wouldn't be able to achieve a semi-transparent look like this?thats done for the next v2.3 update
Even without alpha value, some skins display icon background in a different way from the majority. Also some bitmap skins have a problem with this setting. A few examples:
you need to make sure the RGB components are the same colour as the panel header
i have made the algorithm more sophisticated and probably is now what you were expecting. You can tint using any colour now - as long as there is an alpha component it will use this approach and when there is no alpha component it uses the way redwing requestedyou need to make sure the RGB components are the same colour as the panel headerOh OK, will give that a go.
Even without alpha value, some skins display icon background in a different way from the majority. Also some bitmap skins have a problem with this setting. A few examples:these are the result of some unfortunate fg choices for the header control element where the colours are similar/same as that panel background.
this has the amended colouring algorithm
Even without alpha value, some skins display icon background in a different way from the majority. Also some bitmap skins have a problem with this setting. A few examples:these are the result of some unfortunate fg choices for the header control element where the colours are similar/same as that panel background.
The skin developer can easily correct that or use the new element if they want
this has the amended colouring algorithm: